All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
	Corentin Chary <corentincj@iksaif.net>,
	Len Brown <len.brown@intel.com>
Subject: [PATCH 06/19] eeepc-laptop: fix wlan rfkill state change during init
Date: Sat, 16 May 2009 02:02:03 -0400	[thread overview]
Message-ID: <fbc97e4c5c31ea198f912196b1379d7493362800.1242453625.git.len.brown@intel.com> (raw)
In-Reply-To: <1242453736-20763-1-git-send-email-lenb@kernel.org>
In-Reply-To: <45cb50e646d1560eff01c5ad0f0df3c7fd6148dd.1242453625.git.len.brown@intel.com>

From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>

When an rfkill device is registered, the rfkill core will change its
state to the system default. So we need to prepare for state changes
*before* we register it. That means installing the eeepc-specific ACPI
callback which handles the hotplug of the wireless network adaptor.

This problem doesn't occur during normal operation.  You have to

1) Boot with wireless enabled. eeepc-laptop should load automatically.
2) modprobe -r eeepc-laptop
3) modprobe eeepc-laptop

On boot, the default rfkill state will be set to enabled.
With the current core code, step 2) will disable the wireless.
Therefore in step 3), the wireless will change state during registration,
from disabled to enabled.  But without this fix, the PCI device for the
wireless adaptor will not appear.

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Acked-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/platform/x86/eeepc-laptop.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
index 6f54fd1..e21f7cd 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b/drivers/platform/x86/eeepc-laptop.c
@@ -649,6 +649,9 @@ static int eeepc_hotk_add(struct acpi_device *device)
 	if (ACPI_FAILURE(status))
 		printk(EEEPC_ERR "Error installing notify handler\n");
 
+	eeepc_register_rfkill_notifier("\\_SB.PCI0.P0P6");
+	eeepc_register_rfkill_notifier("\\_SB.PCI0.P0P7");
+
 	if (get_acpi(CM_ASL_WLAN) != -1) {
 		ehotk->eeepc_wlan_rfkill = rfkill_allocate(&device->dev,
 							   RFKILL_TYPE_WLAN);
@@ -704,9 +707,6 @@ static int eeepc_hotk_add(struct acpi_device *device)
 			goto bluetooth_fail;
 	}
 
-	eeepc_register_rfkill_notifier("\\_SB.PCI0.P0P6");
-	eeepc_register_rfkill_notifier("\\_SB.PCI0.P0P7");
-
 	return 0;
 
  bluetooth_fail:
-- 
1.6.0.6


  parent reply	other threads:[~2009-05-16  6:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-16  6:01 ACPI & driver patches for 2.6.30-rc5 Len Brown
2009-05-16  6:01 ` [PATCH 01/19] ACPI video: dmi check for broken _BQC on Acer Aspire 5720 Len Brown
2009-05-16  6:01   ` [PATCH 02/19] ACPICA: use acpi.* modparam namespace Len Brown
2009-05-16  6:02   ` [PATCH 03/19] ACPI: video: DMI workaround another broken Acer BIOS enabling display brightness Len Brown
2009-05-16  6:02   ` [PATCH 04/19] ACPI: power: update error message Len Brown
2009-05-16  6:02   ` [PATCH 05/19] ACPI: suspend: don't let device _PS3 failure prevent suspend Len Brown
2009-05-16  6:02   ` Len Brown [this message]
2009-05-16  6:02   ` [PATCH 07/19] eeepc-laptop: report brightness control events via the input layer Len Brown
2009-05-16  6:02   ` [PATCH 08/19] eeepc-laptop: Work around rfkill firmware bug Len Brown
2009-05-16  6:02   ` [PATCH 09/19] eeepc-laptop: support for super hybrid engine (SHE) Len Brown
2009-05-24  9:28     ` Alan Jenkins
2009-05-24 17:23       ` Corentin Chary
     [not found]         ` <4A198401.3040003@tuffmail.co.uk>
2009-05-25  8:12           ` Corentin Chary
2009-05-25  9:43             ` Alan Jenkins
2009-05-25  9:59               ` Corentin Chary
2009-05-25 10:07                 ` Alan Jenkins
2009-05-25 11:19                   ` Corentin Chary
2009-05-25 11:51                     ` Alan Jenkins
2009-05-26 10:12                       ` Corentin Chary
2009-05-26 10:15                         ` Alan Jenkins
2009-05-26 17:29                           ` Francesco Lattanzio
2009-05-26 17:43                             ` Alan Jenkins
2009-05-26 18:05                               ` Corentin Chary
2009-05-24 20:24       ` Corentin Chary
2009-05-16  6:02   ` [PATCH 10/19] asus-laptop: fix input keycode Len Brown
2009-05-16  6:02   ` [PATCH 11/19] eeepc-laptop: unregister_rfkill_notifier on failure Len Brown
2009-05-16  6:02   ` [PATCH 12/19] thermal: fix off-by-1 error in trip point trigger condition Len Brown
2009-05-16  6:02   ` [PATCH 13/19] ACPI: resume: re-enable SCI-enable workaround Len Brown
2009-05-16  6:02   ` [PATCH 14/19] ACPI: suspend: restore BM_RLD on resume Len Brown
2009-05-16  6:02   ` [PATCH 15/19] ACPI, i915: build fix Len Brown
2009-05-18  2:49     ` yakui_zhao
2009-05-16  6:02   ` [PATCH 16/19] ACPI processor: introduce module parameter processor.ignore_tpc Len Brown
2009-05-16  6:02   ` [PATCH 17/19] ACPI processor: reset the throttling state once it's invalid Len Brown
2009-05-16  6:02   ` [PATCH 18/19] ACPI: idle: fix init-time TSC check regression Len Brown
2009-05-16  6:02   ` [PATCH 19/19] ACPI: Idle C-states disabled by max_cstate should not disable the TSC Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbc97e4c5c31ea198f912196b1379d7493362800.1242453625.git.len.brown@intel.com \
    --to=lenb@kernel.org \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=corentincj@iksaif.net \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.