* [PATCH] media: imx-csi: fix burst size for 16 bit
@ 2018-05-03 16:32 Jan Luebbe
2018-05-03 16:40 ` Philipp Zabel
0 siblings, 1 reply; 3+ messages in thread
From: Jan Luebbe @ 2018-05-03 16:32 UTC (permalink / raw)
To: linux-media; +Cc: Jan Luebbe, slongerbeam, p.zabel
A burst_size of 4 does not work for the 16 bit passthrough formats, so
we use 8 instead.
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
drivers/staging/media/imx/imx-media-csi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 1112d8f67a18..08b636084286 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -410,7 +410,7 @@ static int csi_idmac_setup_channel(struct csi_priv *priv)
case V4L2_PIX_FMT_SGRBG16:
case V4L2_PIX_FMT_SRGGB16:
case V4L2_PIX_FMT_Y16:
- burst_size = 4;
+ burst_size = 8;
passthrough = true;
passthrough_bits = 16;
break;
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: imx-csi: fix burst size for 16 bit
2018-05-03 16:32 [PATCH] media: imx-csi: fix burst size for 16 bit Jan Luebbe
@ 2018-05-03 16:40 ` Philipp Zabel
2018-05-05 19:56 ` Steve Longerbeam
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Zabel @ 2018-05-03 16:40 UTC (permalink / raw)
To: Jan Luebbe, linux-media; +Cc: slongerbeam
On Thu, 2018-05-03 at 18:32 +0200, Jan Luebbe wrote:
> A burst_size of 4 does not work for the 16 bit passthrough formats, so
> we use 8 instead.
>
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> ---
> drivers/staging/media/imx/imx-media-csi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 1112d8f67a18..08b636084286 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -410,7 +410,7 @@ static int csi_idmac_setup_channel(struct csi_priv *priv)
> case V4L2_PIX_FMT_SGRBG16:
> case V4L2_PIX_FMT_SRGGB16:
> case V4L2_PIX_FMT_Y16:
> - burst_size = 4;
> + burst_size = 8;
This seems to be the equivalent to commit 37ea9830139b3 ("media: imx-
csi: fix burst size"), but for 16-bit formats.
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: imx-csi: fix burst size for 16 bit
2018-05-03 16:40 ` Philipp Zabel
@ 2018-05-05 19:56 ` Steve Longerbeam
0 siblings, 0 replies; 3+ messages in thread
From: Steve Longerbeam @ 2018-05-05 19:56 UTC (permalink / raw)
To: Philipp Zabel, Jan Luebbe, linux-media
Acked-by: Steve Longerbeam <steve_longerbeam@mentor.com>
On 05/03/2018 09:40 AM, Philipp Zabel wrote:
> On Thu, 2018-05-03 at 18:32 +0200, Jan Luebbe wrote:
>> A burst_size of 4 does not work for the 16 bit passthrough formats, so
>> we use 8 instead.
>>
>> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
>> ---
>> drivers/staging/media/imx/imx-media-csi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
>> index 1112d8f67a18..08b636084286 100644
>> --- a/drivers/staging/media/imx/imx-media-csi.c
>> +++ b/drivers/staging/media/imx/imx-media-csi.c
>> @@ -410,7 +410,7 @@ static int csi_idmac_setup_channel(struct csi_priv *priv)
>> case V4L2_PIX_FMT_SGRBG16:
>> case V4L2_PIX_FMT_SRGGB16:
>> case V4L2_PIX_FMT_Y16:
>> - burst_size = 4;
>> + burst_size = 8;
> This seems to be the equivalent to commit 37ea9830139b3 ("media: imx-
> csi: fix burst size"), but for 16-bit formats.
>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> regards
> Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-05 19:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-03 16:32 [PATCH] media: imx-csi: fix burst size for 16 bit Jan Luebbe
2018-05-03 16:40 ` Philipp Zabel
2018-05-05 19:56 ` Steve Longerbeam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.