All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Loic Poulain
	<loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Johan Hedberg
	<johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ray Jui <rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Scott Branden <sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Florian Fainelli
	<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"open list:BLUETOOTH DRIVERS"
	<linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 2/3] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 as serial slave
Date: Thu, 10 Aug 2017 18:15:04 +0200	[thread overview]
Message-ID: <8186E2A3-D0AC-498F-8229-78862D363F78@holtmann.org> (raw)
In-Reply-To: <CAL_JsqKxA2pgtjmG-cxy5XPWuRWUiia-weRZDSh4++Vn=QZmqA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Rob,

>> Add BCM43438 as a slave device of uart0 (pl011/ttyAMA0).
>> This allows to automatically insert the bcm43438 to the bluetooth
>> subsystem instead of relying on userspace helpers (hciattach).
>> 
>> Overwrite bootargs to use 8250 aux uart (ttyS0) as console instead
>> of pl011/ttyAMA0.
>> 
>> Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>> v2: dt-bindings as separate patch
>>     rebase on upcoming pi3 dts changes
>> v3: changes in bcm serdev drivers:
>>     name refactoring and additional comments
>>     Add generic host_set_baudrate method
>>     Use agnostic device_property_read
>> 
>> arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> index 20725ca..5abc1df 100644
>> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> @@ -8,6 +8,11 @@
>>        compatible = "raspberrypi,3-model-b", "brcm,bcm2837";
>>        model = "Raspberry Pi 3 Model B";
>> 
>> +       chosen {
>> +               /* 8250 auxiliar UART instead of pl011 */
>> +               bootargs = "earlyprintk console=ttyS0,115200";
> 
> This is an unrelated change. "earlyprintk" is arm32 specific and only
> works with a kernel built with a specific uart type and address. Also,
> stdout-path property is preferred to set the default over "console”.

the whole fun with the serial console on the rPI3 and the bt-miniuart overlay is something we should solve now. What is the upstream story on this since the config.txt and everything around it is confusing and also misleading since it relies on a Raspbian userspace.

Do we need to the kernel and init to stay away from the ttyAMA0 to avoid confusing the BT chip? As I mentioned earlier, I can not even get a Fedora 26 with hciattach or btattach to work.

Regards

Marcel

WARNING: multiple messages have this Message-ID (diff)
From: Marcel Holtmann <marcel@holtmann.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Loic Poulain <loic.poulain@gmail.com>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 as serial slave
Date: Thu, 10 Aug 2017 18:15:04 +0200	[thread overview]
Message-ID: <8186E2A3-D0AC-498F-8229-78862D363F78@holtmann.org> (raw)
In-Reply-To: <CAL_JsqKxA2pgtjmG-cxy5XPWuRWUiia-weRZDSh4++Vn=QZmqA@mail.gmail.com>

Hi Rob,

>> Add BCM43438 as a slave device of uart0 (pl011/ttyAMA0).
>> This allows to automatically insert the bcm43438 to the bluetooth
>> subsystem instead of relying on userspace helpers (hciattach).
>> 
>> Overwrite bootargs to use 8250 aux uart (ttyS0) as console instead
>> of pl011/ttyAMA0.
>> 
>> Signed-off-by: Loic Poulain <loic.poulain@gmail.com>
>> ---
>> v2: dt-bindings as separate patch
>>     rebase on upcoming pi3 dts changes
>> v3: changes in bcm serdev drivers:
>>     name refactoring and additional comments
>>     Add generic host_set_baudrate method
>>     Use agnostic device_property_read
>> 
>> arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> index 20725ca..5abc1df 100644
>> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> @@ -8,6 +8,11 @@
>>        compatible = "raspberrypi,3-model-b", "brcm,bcm2837";
>>        model = "Raspberry Pi 3 Model B";
>> 
>> +       chosen {
>> +               /* 8250 auxiliar UART instead of pl011 */
>> +               bootargs = "earlyprintk console=ttyS0,115200";
> 
> This is an unrelated change. "earlyprintk" is arm32 specific and only
> works with a kernel built with a specific uart type and address. Also,
> stdout-path property is preferred to set the default over "console”.

the whole fun with the serial console on the rPI3 and the bt-miniuart overlay is something we should solve now. What is the upstream story on this since the config.txt and everything around it is confusing and also misleading since it relies on a Raspbian userspace.

Do we need to the kernel and init to stay away from the ttyAMA0 to avoid confusing the BT chip? As I mentioned earlier, I can not even get a Fedora 26 with hciattach or btattach to work.

Regards

Marcel


  parent reply	other threads:[~2017-08-10 16:15 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07 10:39 [PATCH v3 1/3] dt-bindings: net: bluetooth: Add broadcom-bluetooth Loic Poulain
2017-08-07 10:39 ` Loic Poulain
     [not found] ` <1502102366-2760-1-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-07 10:39   ` [PATCH v3 2/3] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 as serial slave Loic Poulain
2017-08-07 10:39     ` Loic Poulain
     [not found]     ` <1502102366-2760-2-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-09 23:10       ` Rob Herring
2017-08-09 23:10         ` Rob Herring
     [not found]         ` <CAL_JsqKxA2pgtjmG-cxy5XPWuRWUiia-weRZDSh4++Vn=QZmqA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-10 16:15           ` Marcel Holtmann [this message]
2017-08-10 16:15             ` Marcel Holtmann
     [not found]             ` <8186E2A3-D0AC-498F-8229-78862D363F78-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-14 13:56               ` Loic Poulain
2017-08-14 13:56                 ` Loic Poulain
     [not found]                 ` <392e6d51-33d6-1585-6582-1397a0c64852-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-14 16:02                   ` Marcel Holtmann
2017-08-14 16:02                     ` Marcel Holtmann
     [not found]                     ` <161632C7-EBBF-47F5-86DC-453E10395B54-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-14 17:32                       ` Loic Poulain
2017-08-14 17:32                         ` Loic Poulain
     [not found]                         ` <e001e055-10a5-facd-a8e1-57c1bdb78172-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-14 17:39                           ` Stefan Wahren
2017-08-14 17:39                             ` Stefan Wahren
2017-08-14 18:36                           ` Marcel Holtmann
2017-08-14 18:36                             ` Marcel Holtmann
2017-08-14 22:16                           ` Marcel Holtmann
2017-08-14 22:16                             ` Marcel Holtmann
     [not found]                             ` <FCD47ED6-F01F-4921-97A3-BBC1D0263747-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-15  4:39                               ` Marcel Holtmann
2017-08-15  4:39                                 ` Marcel Holtmann
2017-08-16 12:37                               ` Peter Robinson
2017-08-16 12:37                                 ` Peter Robinson
     [not found]                                 ` <CALeDE9MeMHtCD8esCcznHjS+z6o7Ezh9dP1OZq=77DuYNS2=2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-16 14:52                                   ` Marcel Holtmann
2017-08-16 14:52                                     ` Marcel Holtmann
     [not found]                                     ` <0C198B33-8CB6-4D6A-B89F-35D3CD771135-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-17 10:07                                       ` Loic Poulain
2017-08-17 10:07                                         ` Loic Poulain
     [not found]                                         ` <92579650-5eb0-cdf2-405a-7c5be9c54770-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-17 10:35                                           ` Marcel Holtmann
2017-08-17 10:35                                             ` Marcel Holtmann
     [not found]                                             ` <8CF7E37E-BF1C-4E32-AF3A-E44BA2E5A2B9-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-17 10:47                                               ` Marcel Holtmann
2017-08-17 10:47                                                 ` Marcel Holtmann
2017-08-17 16:21                                               ` Eric Anholt
2017-08-17 16:21                                                 ` Eric Anholt
     [not found]                                                 ` <87shgqgo7b.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2017-08-17 17:34                                                   ` Marcel Holtmann
2017-08-17 17:34                                                     ` Marcel Holtmann
     [not found]                                                     ` <E1FFE8C1-97C9-4640-A12A-3AE37F9B655F-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-17 19:38                                                       ` Eric Anholt
2017-08-17 19:38                                                         ` Eric Anholt
2017-08-17 20:08                                                   ` Phil Elwell
2017-08-17 20:08                                                     ` Phil Elwell
2017-08-15 13:06       ` Marcel Holtmann
2017-08-15 13:06         ` Marcel Holtmann
     [not found]         ` <43820E05-9D40-4470-AE6C-B7B6C705E0A5-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-08-15 19:12           ` Rob Herring
2017-08-15 19:12             ` Rob Herring
2017-08-07 10:39   ` [PATCH v3 3/3] Bluetooth: hci_bcm: Add serdev support Loic Poulain
2017-08-07 10:39     ` Loic Poulain
2017-08-09 23:16   ` [PATCH v3 1/3] dt-bindings: net: bluetooth: Add broadcom-bluetooth Rob Herring
2017-08-09 23:16     ` Rob Herring
     [not found]     ` <CAL_Jsq+akZpqXMPnSh8KRVchWJpFTrzFi6LpOpJ9FYDCrY1hPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-15 17:42       ` Eric Anholt
2017-08-15 17:42         ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8186E2A3-D0AC-498F-8229-78862D363F78@holtmann.org \
    --to=marcel-kz+m5ild9qbg9huczpvpmw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.