Hard coded register address in "drm: rcar-du: Add DPLL support"?

Hard coded register address in "drm: rcar-du: Add DPLL support"?

[Dirk Behme]

Hi,

I'm not sure on which mailing list this

https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git/commit/drivers/gpu/drm/rcar-du/rcar_du_crtc.c?h=topic/gen3-latest&id=e297be92f09a9e8f9a63e72b8d69440dbf5bbabe
drm: rcar-du: Add DPLL support

is discussed.

But it's the same like with the hard coded MODEMR register: We don't 
want the hard coded

#define PRODUCT_REG 0xfff00044

here.

Are there already patches or plans to convert this to a device tree 
based interface?

Best regards

Dirk

Re: Hard coded register address in "drm: rcar-du: Add DPLL support"?

[Dirk Behme]

On 18.05.2016 16:29, Dirk Behme wrote:
> Hi,
>
> I'm not sure on which mailing list this
>
> https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git/commit/drivers/gpu/drm/rcar-du/rcar_du_crtc.c?h=topic/gen3-latest&id=e297be92f09a9e8f9a63e72b8d69440dbf5bbabe
>
> drm: rcar-du: Add DPLL support
>
> is discussed.
>
> But it's the same like with the hard coded MODEMR register: We don't
> want the hard coded
>
> #define PRODUCT_REG 0xfff00044
>
> here.
>
> Are there already patches or plans to convert this to a device tree
> based interface?


Looking into the HW documentation for the product register, this seems 
to be not associated with any hardware block (IP block), but 'just' a 
register somewhere in the address space. Documented in the appendix.

So a device tree based access function for this could be simple. E.g. 
like below [1].

What do you think about this? Where would we put code like this? 
drivers/misc?

Best regards

Dirk

[1]

static struct of_device_id rcar_gen3_prr_ids[] __initdata = {
         { .compatible = "renesas,rcar-gen3-prr" },
         {}
};

int __init rcar_gen3_read_product(u32 *prr)
{
         void __iomem *product;
         struct device_node *np;

         np = of_find_matching_node(NULL, rcar_gen3_prr_ids);
         if (!np) {
                 pr_err("can't find Renesas rcar-gen3-prr device node");
		return -ENOMEM;
         }

         product = of_iomap(np, 0);
         prr = ioread32(product);
         iounmap(product);
         of_node_put(np);

	return 0;
}