From: Joe Perches <joe@perches.com>
To: Masami Hiramatsu <mhiramat@kernel.org>,
Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Jonathan Corbet <corbet@lwn.net>, Marc Koderer <marc@koderer.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
Jisheng Zhang <jszhang@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Randy Dunlap <randy.dunlap@oracle.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH v3] samples/kprobes: Fix typo in handler_{post,fault}()
Date: Sun, 16 May 2021 06:14:58 -0700 [thread overview]
Message-ID: <81d398b86b1c7214e64a0dd25a9ef090f86bc16c.camel@perches.com> (raw)
In-Reply-To: <20210516190201.790f4f2085e2691bbb96c58c@kernel.org>
On Sun, 2021-05-16 at 19:02 +0900, Masami Hiramatsu wrote:
> On Sat, 15 May 2021 10:39:06 +0800
> Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> > It should use post_handler instead of pre_handler in handler_post().
> >
> > As Joe Perches suggested, it would be better to use pr_fmt and remove
> > all the embedded pre/post strings. This would change the style of the
> > output through.
> >
>
> NAK, this also shows which handler cought the event.
> If you wanna change it. Please replace it with __func__ instead.
[]
> > diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
[]
> > @@ -10,6 +10,8 @@
> > * whenever kernel_clone() is invoked to create a new process.
> > */
> >
> > +#define pr_fmt(fmt) "%s: " fmt, __func__
It does that already via the pr_fmt which uses __func__.
next prev parent reply other threads:[~2021-05-16 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 2:39 [PATCH v3] samples/kprobes: Fix typo in handler_{post,fault}() Tiezhu Yang
2021-05-16 10:02 ` Masami Hiramatsu
2021-05-16 13:14 ` Joe Perches [this message]
2021-05-16 13:20 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81d398b86b1c7214e64a0dd25a9ef090f86bc16c.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=christian.brauner@ubuntu.com \
--cc=corbet@lwn.net \
--cc=hca@linux.ibm.com \
--cc=jszhang@kernel.org \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=marc@koderer.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mchehab+huawei@kernel.org \
--cc=mhiramat@kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=schwidefsky@de.ibm.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.