From: Heiko Stuebner <heiko@sntech.de>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@lists.collabora.co.uk,
Jianqun Xu <jay.xu@rock-chips.com>,
kernel@collabora.com
Subject: Re: [PATCHv1 13/19] pinctrl/rockchip: add rk3588 support
Date: Sat, 30 Apr 2022 16:12:46 +0200 [thread overview]
Message-ID: <8226003.NyiUUSuA9g@phil> (raw)
In-Reply-To: <CACRpkdZXuLPpgKcM_OU+Xewuuq6zGJek0QXAT1Xxn5fcZofJvA@mail.gmail.com>
Hi,
Am Freitag, 29. April 2022, 00:55:52 CEST schrieb Linus Walleij:
> On Fri, Apr 22, 2022 at 7:09 PM Sebastian Reichel
> <sebastian.reichel@collabora.com> wrote:
>
> > From: Jianqun Xu <jay.xu@rock-chips.com>
> >
> > Add pinctrl support for RK3588.
> >
> > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> > [merged in downstream fixes, simplified register lookup logic for better
> > maintanence at the cost of a bit more static const memory and fixed some
> > incorrect registers]
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Patch applied, unless Heiko does some loud protesting it stays
> in the tree.
I'm never loud ;-)
Patch looked ok overall as well. I guess at some future point someone
will need to refactor the small "if rk3588" but that can be done when
another slightly different user appears and we have a feeling what the
common approach could look like.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@lists.collabora.co.uk,
Jianqun Xu <jay.xu@rock-chips.com>,
kernel@collabora.com
Subject: Re: [PATCHv1 13/19] pinctrl/rockchip: add rk3588 support
Date: Sat, 30 Apr 2022 16:12:46 +0200 [thread overview]
Message-ID: <8226003.NyiUUSuA9g@phil> (raw)
In-Reply-To: <CACRpkdZXuLPpgKcM_OU+Xewuuq6zGJek0QXAT1Xxn5fcZofJvA@mail.gmail.com>
Hi,
Am Freitag, 29. April 2022, 00:55:52 CEST schrieb Linus Walleij:
> On Fri, Apr 22, 2022 at 7:09 PM Sebastian Reichel
> <sebastian.reichel@collabora.com> wrote:
>
> > From: Jianqun Xu <jay.xu@rock-chips.com>
> >
> > Add pinctrl support for RK3588.
> >
> > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> > [merged in downstream fixes, simplified register lookup logic for better
> > maintanence at the cost of a bit more static const memory and fixed some
> > incorrect registers]
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Patch applied, unless Heiko does some loud protesting it stays
> in the tree.
I'm never loud ;-)
Patch looked ok overall as well. I guess at some future point someone
will need to refactor the small "if rk3588" but that can be done when
another slightly different user appears and we have a feeling what the
common approach could look like.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@lists.collabora.co.uk,
Jianqun Xu <jay.xu@rock-chips.com>,
kernel@collabora.com
Subject: Re: [PATCHv1 13/19] pinctrl/rockchip: add rk3588 support
Date: Sat, 30 Apr 2022 16:12:46 +0200 [thread overview]
Message-ID: <8226003.NyiUUSuA9g@phil> (raw)
In-Reply-To: <CACRpkdZXuLPpgKcM_OU+Xewuuq6zGJek0QXAT1Xxn5fcZofJvA@mail.gmail.com>
Hi,
Am Freitag, 29. April 2022, 00:55:52 CEST schrieb Linus Walleij:
> On Fri, Apr 22, 2022 at 7:09 PM Sebastian Reichel
> <sebastian.reichel@collabora.com> wrote:
>
> > From: Jianqun Xu <jay.xu@rock-chips.com>
> >
> > Add pinctrl support for RK3588.
> >
> > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> > [merged in downstream fixes, simplified register lookup logic for better
> > maintanence at the cost of a bit more static const memory and fixed some
> > incorrect registers]
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Patch applied, unless Heiko does some loud protesting it stays
> in the tree.
I'm never loud ;-)
Patch looked ok overall as well. I guess at some future point someone
will need to refactor the small "if rk3588" but that can be done when
another slightly different user appears and we have a feeling what the
common approach could look like.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-30 14:13 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 17:09 [PATCHv1 00/19] Basic RK3588 Support Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` [PATCHv1 01/19] dt-binding: clock: Document rockchip,rk3588-cru bindings Sebastian Reichel
2022-04-22 17:09 ` [PATCHv1 01/19] dt-binding: clock: Document rockchip, rk3588-cru bindings Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-23 10:01 ` [PATCHv1 01/19] dt-binding: clock: Document rockchip,rk3588-cru bindings Krzysztof Kozlowski
2022-04-23 10:01 ` Krzysztof Kozlowski
2022-04-23 10:01 ` Krzysztof Kozlowski
2022-04-22 17:09 ` [PATCHv1 02/19] clk: rockchip: add register offset of the cores select parent Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` [PATCHv1 03/19] clk: rockchip: add pll type for RK3588 Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-27 13:36 ` Nicolas Dufresne
2022-04-27 13:36 ` Nicolas Dufresne
2022-04-27 13:36 ` Nicolas Dufresne
2022-04-30 0:02 ` Heiko Stübner
2022-04-30 0:02 ` Heiko Stübner
2022-04-30 0:02 ` Heiko Stübner
2022-04-29 1:56 ` kernel test robot
2022-04-29 1:56 ` kernel test robot
2022-04-29 1:56 ` kernel test robot
2022-04-22 17:09 ` [PATCHv1 04/19] clk: rockchip: clk-cpu: add mux setting for cpu change frequency Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` [PATCHv1 05/19] clk: rockchip: add dt-binding header for rk3588 Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-05-02 22:15 ` Rob Herring
2022-05-02 22:15 ` Rob Herring
2022-05-02 22:15 ` Rob Herring
2022-04-22 17:09 ` [PATCHv1 06/19] clk: rockchip: Add clock controller for the RK3588 Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-29 19:31 ` kernel test robot
2022-04-29 19:31 ` kernel test robot
2022-04-29 19:31 ` kernel test robot
2022-04-22 17:09 ` [PATCHv1 07/19] dt-bindings: mmc: sdhci-of-dwcmhsc: Add rk3588 Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-23 10:01 ` Krzysztof Kozlowski
2022-04-23 10:01 ` Krzysztof Kozlowski
2022-04-23 10:01 ` Krzysztof Kozlowski
2022-05-04 10:37 ` Ulf Hansson
2022-05-04 10:37 ` Ulf Hansson
2022-05-04 10:37 ` Ulf Hansson
2022-04-22 17:09 ` [PATCHv1 08/19] mmc: sdhci-of-dwcmshc: add reset call back for rockchip Socs Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-23 10:32 ` Dmitry Osipenko
2022-04-23 10:32 ` Dmitry Osipenko
2022-04-23 10:32 ` Dmitry Osipenko
2022-04-27 7:50 ` Adrian Hunter
2022-04-27 7:50 ` Adrian Hunter
2022-04-27 7:50 ` Adrian Hunter
2022-04-22 17:09 ` [PATCHv1 09/19] mmc: sdhci-of-dwcmshc: rename rk3568 to rk35xx Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-27 7:51 ` Adrian Hunter
2022-04-27 7:51 ` Adrian Hunter
2022-04-27 7:51 ` Adrian Hunter
2022-04-22 17:09 ` [PATCHv1 10/19] mmc: sdhci-of-dwcmshc: add support for rk3588 Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-27 7:51 ` Adrian Hunter
2022-04-27 7:51 ` Adrian Hunter
2022-04-27 7:51 ` Adrian Hunter
2022-04-22 17:09 ` [PATCHv1 11/19] dt-bindings: pinctrl: rockchip: add rk3588 Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-23 10:02 ` Krzysztof Kozlowski
2022-04-23 10:02 ` Krzysztof Kozlowski
2022-04-23 10:02 ` Krzysztof Kozlowski
2022-04-22 17:09 ` [PATCHv1 12/19] pinctrl/rockchip: add error handling for pull/drive register getters Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 20:50 ` Heiko Stuebner
2022-04-22 20:50 ` Heiko Stuebner
2022-04-22 20:50 ` Heiko Stuebner
2022-04-28 22:54 ` Linus Walleij
2022-04-28 22:54 ` Linus Walleij
2022-04-28 22:54 ` Linus Walleij
2022-04-22 17:09 ` [PATCHv1 13/19] pinctrl/rockchip: add rk3588 support Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-28 22:55 ` Linus Walleij
2022-04-28 22:55 ` Linus Walleij
2022-04-28 22:55 ` Linus Walleij
2022-04-30 14:12 ` Heiko Stuebner [this message]
2022-04-30 14:12 ` Heiko Stuebner
2022-04-30 14:12 ` Heiko Stuebner
2022-04-22 17:09 ` [PATCHv1 14/19] gpio: rockchip: add support for rk3588 Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 20:35 ` Linus Walleij
2022-04-22 20:35 ` Linus Walleij
2022-04-22 20:35 ` Linus Walleij
2022-04-22 17:09 ` [PATCHv1 15/19] dt-bindings: serial: snps-dw-apb-uart: Add Rockchip RK3588 Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-23 10:02 ` Krzysztof Kozlowski
2022-04-23 10:02 ` Krzysztof Kozlowski
2022-04-23 10:02 ` Krzysztof Kozlowski
2022-04-22 17:09 ` [PATCHv1 16/19] dt-bindings: soc: rockchip: add initial rk3588 syscon compatibles Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-23 10:03 ` Krzysztof Kozlowski
2022-04-23 10:03 ` Krzysztof Kozlowski
2022-04-23 10:03 ` Krzysztof Kozlowski
2022-04-22 17:09 ` [PATCHv1 17/19] arm64: dts: rockchip: Add rk3588s pinctrl data Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 20:45 ` Linus Walleij
2022-04-22 20:45 ` Linus Walleij
2022-04-22 20:45 ` Linus Walleij
2022-04-22 17:09 ` [PATCHv1 18/19] arm64: dts: rockchip: Add base DT for rk3588 SoC Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 18:16 ` Robin Murphy
2022-04-22 18:16 ` Robin Murphy
2022-04-22 18:16 ` Robin Murphy
2022-04-25 18:14 ` Sebastian Reichel
2022-04-25 18:14 ` Sebastian Reichel
2022-04-25 18:14 ` Sebastian Reichel
2022-04-25 19:37 ` Peter Geis
2022-04-25 19:37 ` Peter Geis
2022-04-25 19:37 ` Peter Geis
2022-04-23 10:07 ` Krzysztof Kozlowski
2022-04-23 10:07 ` Krzysztof Kozlowski
2022-04-23 10:07 ` Krzysztof Kozlowski
2022-05-02 22:20 ` Rob Herring
2022-05-02 22:20 ` Rob Herring
2022-05-02 22:20 ` Rob Herring
2022-04-22 17:09 ` [PATCHv1 19/19] arm64: dts: rockchip: Add rk3588-evb1 board Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-22 17:09 ` Sebastian Reichel
2022-04-23 10:09 ` Krzysztof Kozlowski
2022-04-23 10:09 ` Krzysztof Kozlowski
2022-04-23 10:09 ` Krzysztof Kozlowski
2022-04-25 19:44 ` Rob Herring
2022-04-25 19:44 ` Rob Herring
2022-04-25 19:44 ` Rob Herring
2022-04-22 20:44 ` [PATCHv1 00/19] Basic RK3588 Support Linus Walleij
2022-04-22 20:44 ` Linus Walleij
2022-04-22 20:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8226003.NyiUUSuA9g@phil \
--to=heiko@sntech.de \
--cc=adrian.hunter@intel.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=jay.xu@rock-chips.com \
--cc=kernel@collabora.com \
--cc=kernel@lists.collabora.co.uk \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.