All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: checking for NULL instead of IS_ERR()
@ 2017-11-06 11:43 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-11-06 11:43 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Tom St Denis, Andrey Grodzovsky, David Airlie, Harry Wentland,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Leo (Sunpeng) Li,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Tony Cheng,
	Christian König

backlight_device_register() never returns NULL, it returns error
pointers on error so the check here is wrong.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 33a15a1d818c..75f9383f5b9b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1296,7 +1296,7 @@ amdgpu_dm_register_backlight_device(struct amdgpu_display_manager *dm)
 			&amdgpu_dm_backlight_ops,
 			&props);
 
-	if (NULL = dm->backlight_dev)
+	if (IS_ERR(dm->backlight_dev))
 		DRM_ERROR("DM: Backlight registration failed!\n");
 	else
 		DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n", bl_name);

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/amd/display: checking for NULL instead of IS_ERR()
@ 2017-11-06 11:43 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-11-06 11:43 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Tom St Denis, Andrey Grodzovsky, David Airlie, Harry Wentland,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Leo (Sunpeng) Li,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Tony Cheng,
	Christian König

backlight_device_register() never returns NULL, it returns error
pointers on error so the check here is wrong.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 33a15a1d818c..75f9383f5b9b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1296,7 +1296,7 @@ amdgpu_dm_register_backlight_device(struct amdgpu_display_manager *dm)
 			&amdgpu_dm_backlight_ops,
 			&props);
 
-	if (NULL == dm->backlight_dev)
+	if (IS_ERR(dm->backlight_dev))
 		DRM_ERROR("DM: Backlight registration failed!\n");
 	else
 		DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n", bl_name);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: checking for NULL instead of IS_ERR()
  2017-11-06 11:43 ` Dan Carpenter
@ 2017-11-06 11:51   ` Christian König
  -1 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2017-11-06 11:51 UTC (permalink / raw)
  To: Dan Carpenter, Alex Deucher
  Cc: David Airlie, Harry Wentland, Andrey Grodzovsky, Tony Cheng,
	Leo (Sunpeng) Li, Tom St Denis, amd-gfx, dri-devel,
	kernel-janitors

Am 06.11.2017 um 12:43 schrieb Dan Carpenter:
> backlight_device_register() never returns NULL, it returns error
> pointers on error so the check here is wrong.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Christian König <christian.koenig@amd.com>

>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 33a15a1d818c..75f9383f5b9b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1296,7 +1296,7 @@ amdgpu_dm_register_backlight_device(struct amdgpu_display_manager *dm)
>   			&amdgpu_dm_backlight_ops,
>   			&props);
>   
> -	if (NULL = dm->backlight_dev)
> +	if (IS_ERR(dm->backlight_dev))
>   		DRM_ERROR("DM: Backlight registration failed!\n");
>   	else
>   		DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n", bl_name);


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: checking for NULL instead of IS_ERR()
@ 2017-11-06 11:51   ` Christian König
  0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2017-11-06 11:51 UTC (permalink / raw)
  To: Dan Carpenter, Alex Deucher
  Cc: David Airlie, Harry Wentland, Andrey Grodzovsky, Tony Cheng,
	Leo (Sunpeng) Li, Tom St Denis, amd-gfx, dri-devel,
	kernel-janitors

Am 06.11.2017 um 12:43 schrieb Dan Carpenter:
> backlight_device_register() never returns NULL, it returns error
> pointers on error so the check here is wrong.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Christian König <christian.koenig@amd.com>

>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 33a15a1d818c..75f9383f5b9b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1296,7 +1296,7 @@ amdgpu_dm_register_backlight_device(struct amdgpu_display_manager *dm)
>   			&amdgpu_dm_backlight_ops,
>   			&props);
>   
> -	if (NULL == dm->backlight_dev)
> +	if (IS_ERR(dm->backlight_dev))
>   		DRM_ERROR("DM: Backlight registration failed!\n");
>   	else
>   		DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n", bl_name);



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: checking for NULL instead of IS_ERR()
       [not found]   ` <823814f1-4133-bffa-fe34-c676a2466d1d-5C7GfCeVMHo@public.gmane.org>
@ 2017-11-06 21:30       ` Alex Deucher
  0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2017-11-06 21:30 UTC (permalink / raw)
  To: Christian König
  Cc: Tom St Denis, Andrey Grodzovsky, David Airlie, Tony Cheng,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA, amd-gfx list,
	Leo (Sunpeng) Li, Maling list - DRI developers, Alex Deucher,
	Harry Wentland, Dan Carpenter

On Mon, Nov 6, 2017 at 6:51 AM, Christian König
<christian.koenig@amd.com> wrote:
> Am 06.11.2017 um 12:43 schrieb Dan Carpenter:
>>
>> backlight_device_register() never returns NULL, it returns error
>> pointers on error so the check here is wrong.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
>
> Acked-by: Christian König <christian.koenig@amd.com>

Applied.  thanks!

Alex

>
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 33a15a1d818c..75f9383f5b9b 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -1296,7 +1296,7 @@ amdgpu_dm_register_backlight_device(struct
>> amdgpu_display_manager *dm)
>>                         &amdgpu_dm_backlight_ops,
>>                         &props);
>>   -     if (NULL == dm->backlight_dev)
>> +       if (IS_ERR(dm->backlight_dev))
>>                 DRM_ERROR("DM: Backlight registration failed!\n");
>>         else
>>                 DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n",
>> bl_name);
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: checking for NULL instead of IS_ERR()
@ 2017-11-06 21:30       ` Alex Deucher
  0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2017-11-06 21:30 UTC (permalink / raw)
  To: Christian König
  Cc: Tom St Denis, Andrey Grodzovsky, David Airlie, Tony Cheng,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA, amd-gfx list,
	Leo (Sunpeng) Li, Maling list - DRI developers, Alex Deucher,
	Harry Wentland, Dan Carpenter

On Mon, Nov 6, 2017 at 6:51 AM, Christian König
<christian.koenig@amd.com> wrote:
> Am 06.11.2017 um 12:43 schrieb Dan Carpenter:
>>
>> backlight_device_register() never returns NULL, it returns error
>> pointers on error so the check here is wrong.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
>
> Acked-by: Christian König <christian.koenig@amd.com>

Applied.  thanks!

Alex

>
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 33a15a1d818c..75f9383f5b9b 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -1296,7 +1296,7 @@ amdgpu_dm_register_backlight_device(struct
>> amdgpu_display_manager *dm)
>>                         &amdgpu_dm_backlight_ops,
>>                         &props);
>>   -     if (NULL == dm->backlight_dev)
>> +       if (IS_ERR(dm->backlight_dev))
>>                 DRM_ERROR("DM: Backlight registration failed!\n");
>>         else
>>                 DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n",
>> bl_name);
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-06 21:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 11:43 [PATCH] drm/amd/display: checking for NULL instead of IS_ERR() Dan Carpenter
2017-11-06 11:43 ` Dan Carpenter
2017-11-06 11:51 ` Christian König
2017-11-06 11:51   ` Christian König
     [not found]   ` <823814f1-4133-bffa-fe34-c676a2466d1d-5C7GfCeVMHo@public.gmane.org>
2017-11-06 21:30     ` Alex Deucher
2017-11-06 21:30       ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.