* [PATCH] xen/pvcalls-front: mark expected switch fall-through
@ 2017-11-02 18:51 Gustavo A. R. Silva
2017-11-03 8:04 ` Juergen Gross
2017-11-03 8:04 ` Juergen Gross
0 siblings, 2 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-02 18:51 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross
Cc: xen-devel, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I placed the "fall through" comment
on its own line, which is what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/xen/pvcalls-front.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 0c1ec68..ed94ea0 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -1250,7 +1250,8 @@ static void pvcalls_front_changed(struct xenbus_device *dev,
case XenbusStateClosed:
if (dev->state == XenbusStateClosed)
break;
- /* Missed the backend's CLOSING state -- fallthrough */
+ /* Missed the backend's CLOSING state */
+ /* fall through */
case XenbusStateClosing:
xenbus_frontend_closed(dev);
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/pvcalls-front: mark expected switch fall-through
2017-11-02 18:51 [PATCH] xen/pvcalls-front: mark expected switch fall-through Gustavo A. R. Silva
@ 2017-11-03 8:04 ` Juergen Gross
2017-11-08 21:19 ` Boris Ostrovsky
2017-11-03 8:04 ` Juergen Gross
1 sibling, 1 reply; 6+ messages in thread
From: Juergen Gross @ 2017-11-03 8:04 UTC (permalink / raw)
To: Gustavo A. R. Silva, Boris Ostrovsky; +Cc: xen-devel, linux-kernel
On 02/11/17 19:51, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case I placed the "fall through" comment
> on its own line, which is what GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/pvcalls-front: mark expected switch fall-through
2017-11-02 18:51 [PATCH] xen/pvcalls-front: mark expected switch fall-through Gustavo A. R. Silva
2017-11-03 8:04 ` Juergen Gross
@ 2017-11-03 8:04 ` Juergen Gross
1 sibling, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2017-11-03 8:04 UTC (permalink / raw)
To: Gustavo A. R. Silva, Boris Ostrovsky; +Cc: xen-devel, linux-kernel
On 02/11/17 19:51, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case I placed the "fall through" comment
> on its own line, which is what GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/pvcalls-front: mark expected switch fall-through
2017-11-03 8:04 ` Juergen Gross
@ 2017-11-08 21:19 ` Boris Ostrovsky
0 siblings, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2017-11-08 21:19 UTC (permalink / raw)
To: Juergen Gross, Gustavo A. R. Silva; +Cc: xen-devel, linux-kernel
On 11/03/2017 04:04 AM, Juergen Gross wrote:
> On 02/11/17 19:51, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Notice that in this particular case I placed the "fall through" comment
>> on its own line, which is what GCC is expecting to find.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Applied to for-linus-4.15.
-boris
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/pvcalls-front: mark expected switch fall-through
@ 2017-11-08 21:19 ` Boris Ostrovsky
0 siblings, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2017-11-08 21:19 UTC (permalink / raw)
To: Juergen Gross, Gustavo A. R. Silva; +Cc: xen-devel, linux-kernel
On 11/03/2017 04:04 AM, Juergen Gross wrote:
> On 02/11/17 19:51, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Notice that in this particular case I placed the "fall through" comment
>> on its own line, which is what GCC is expecting to find.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Applied to for-linus-4.15.
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xen/pvcalls-front: mark expected switch fall-through
@ 2017-11-02 18:51 Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-02 18:51 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross
Cc: xen-devel, Gustavo A. R. Silva, linux-kernel
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I placed the "fall through" comment
on its own line, which is what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/xen/pvcalls-front.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 0c1ec68..ed94ea0 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -1250,7 +1250,8 @@ static void pvcalls_front_changed(struct xenbus_device *dev,
case XenbusStateClosed:
if (dev->state == XenbusStateClosed)
break;
- /* Missed the backend's CLOSING state -- fallthrough */
+ /* Missed the backend's CLOSING state */
+ /* fall through */
case XenbusStateClosing:
xenbus_frontend_closed(dev);
break;
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-08 21:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 18:51 [PATCH] xen/pvcalls-front: mark expected switch fall-through Gustavo A. R. Silva
2017-11-03 8:04 ` Juergen Gross
2017-11-08 21:19 ` Boris Ostrovsky
2017-11-08 21:19 ` Boris Ostrovsky
2017-11-03 8:04 ` Juergen Gross
2017-11-02 18:51 Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.