All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Dinghao Liu <dinghao.liu@zju.edu.cn>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hartmut Knaack <knaack.h@gmx.de>, Kangjie Lu <kjlu@umn.edu>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error in ak8974_probe()
Date: Sat, 27 Jun 2020 17:52:42 +0200	[thread overview]
Message-ID: <8249fead-3a2c-f11e-eaef-e74c4c755f53@web.de> (raw)
In-Reply-To: <20200627155304.54ade781@archlinux>

>> How were the chances that my patch review comments would be taken
>> better into account?
>> https://lore.kernel.org/linux-iio/dd84c12f-277d-27e7-3727-4592e530e4ed@web.de/
>> https://lkml.org/lkml/2020/5/31/152
>
> I'm not sure why, but your reply did not have a reply-to field in the header
> as such my email client did not present it alongside the patch.

There are some factors involved for this undesirable effect.

Example:
My software selection contains open issues in the handling of mailto links
according to the communication interface “public inbox”.


> Hence I missed it when applying.

Can my approach for a patch review reminder get more attention?


> Agreed it would have been nicer to have fixed those typos.

Thanks for this positive feedback.


> However, they don't affect comprehensibility of the message
> so I'm not that worried about having them in the log.

Can you get other concerns around the quality of commit messages?


Will it become more interesting to take another look at jump targets
for the exception handling?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Dinghao Liu <dinghao.liu@zju.edu.cn>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hartmut Knaack <knaack.h@gmx.de>, Kangjie Lu <kjlu@umn.edu>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error in ak8974_probe()
Date: Sat, 27 Jun 2020 15:52:42 +0000	[thread overview]
Message-ID: <8249fead-3a2c-f11e-eaef-e74c4c755f53@web.de> (raw)
In-Reply-To: <20200627155304.54ade781@archlinux>

>> How were the chances that my patch review comments would be taken
>> better into account?
>> https://lore.kernel.org/linux-iio/dd84c12f-277d-27e7-3727-4592e530e4ed@web.de/
>> https://lkml.org/lkml/2020/5/31/152
>
> I'm not sure why, but your reply did not have a reply-to field in the header
> as such my email client did not present it alongside the patch.

There are some factors involved for this undesirable effect.

Example:
My software selection contains open issues in the handling of mailto links
according to the communication interface “public inbox”.


> Hence I missed it when applying.

Can my approach for a patch review reminder get more attention?


> Agreed it would have been nicer to have fixed those typos.

Thanks for this positive feedback.


> However, they don't affect comprehensibility of the message
> so I'm not that worried about having them in the log.

Can you get other concerns around the quality of commit messages?


Will it become more interesting to take another look at jump targets
for the exception handling?

Regards,
Markus

  reply	other threads:[~2020-06-27 15:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31 14:06 [PATCH v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error in ak8974_probe() Markus Elfring
2020-05-31 14:06 ` Markus Elfring
2020-06-25 12:34 ` Markus Elfring
2020-06-25 12:34   ` Markus Elfring
2020-06-27 14:53   ` Jonathan Cameron
2020-06-27 14:53     ` Jonathan Cameron
2020-06-27 15:52     ` Markus Elfring [this message]
2020-06-27 15:52       ` [v2] " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8249fead-3a2c-f11e-eaef-e74c4c755f53@web.de \
    --to=markus.elfring@web.de \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=dinghao.liu@zju.edu.cn \
    --cc=jic23@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlu@umn.edu \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.