All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: ipv4: Fixed some styling issues.
@ 2021-03-17 15:07 Anish Udupa
  2021-03-17 15:50 ` David Ahern
  0 siblings, 1 reply; 2+ messages in thread
From: Anish Udupa @ 2021-03-17 15:07 UTC (permalink / raw)
  To: davem, yoshfuji, dsahern, kuba, netdev, linux-kernel

Ran checkpatch and found these warnings. Fixed some of them in this patch.
a) Added a space before '='.
b) Removed the space before the tab.

Signed-off-by: Anish Udupa H <udupa.anish@gmail.com>
---
 net/ipv4/route.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 02d81d79deeb..0b9024584fde 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -2236,7 +2236,7 @@ out: return err;
  if (!rth)
  goto e_nobufs;

- rth->dst.output= ip_rt_bug;
+ rth->dst.output = ip_rt_bug;
 #ifdef CONFIG_IP_ROUTE_CLASSID
  rth->dst.tclassid = itag;
 #endif
@@ -2244,9 +2244,9 @@ out: return err;

  RT_CACHE_STAT_INC(in_slow_tot);
  if (res->type == RTN_UNREACHABLE) {
- rth->dst.input= ip_error;
- rth->dst.error= -err;
- rth->rt_flags &= ~RTCF_LOCAL;
+ rth->dst.input = ip_error;
+ rth->dst.error = -err;
+ rth->rt_flags &= ~RTCF_LOCAL;
  }

  if (do_cache) {
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: ipv4: Fixed some styling issues.
  2021-03-17 15:07 [PATCH] net: ipv4: Fixed some styling issues Anish Udupa
@ 2021-03-17 15:50 ` David Ahern
  0 siblings, 0 replies; 2+ messages in thread
From: David Ahern @ 2021-03-17 15:50 UTC (permalink / raw)
  To: Anish Udupa, davem, yoshfuji, dsahern, kuba, netdev, linux-kernel

On 3/17/21 9:07 AM, Anish Udupa wrote:
> Ran checkpatch and found these warnings. Fixed some of them in this patch.
> a) Added a space before '='.
> b) Removed the space before the tab.
> 
> Signed-off-by: Anish Udupa H <udupa.anish@gmail.com>
> ---
>  net/ipv4/route.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 02d81d79deeb..0b9024584fde 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -2236,7 +2236,7 @@ out: return err;
>   if (!rth)
>   goto e_nobufs;
> 
> - rth->dst.output= ip_rt_bug;
> + rth->dst.output = ip_rt_bug;
>  #ifdef CONFIG_IP_ROUTE_CLASSID
>   rth->dst.tclassid = itag;
>  #endif
> @@ -2244,9 +2244,9 @@ out: return err;
> 
>   RT_CACHE_STAT_INC(in_slow_tot);
>   if (res->type == RTN_UNREACHABLE) {
> - rth->dst.input= ip_error;
> - rth->dst.error= -err;
> - rth->rt_flags &= ~RTCF_LOCAL;
> + rth->dst.input = ip_error;
> + rth->dst.error = -err;
> + rth->rt_flags &= ~RTCF_LOCAL;
>   }
> 
>   if (do_cache) {
> 

your patch seems to have lost one or more tabs at the beginning of each
line.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-17 16:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 15:07 [PATCH] net: ipv4: Fixed some styling issues Anish Udupa
2021-03-17 15:50 ` David Ahern

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.