* [PATCH] Clean up serial console support on Sibyte 1250 duart
@ 2007-02-19 23:48 Andrew Sharp
2007-02-20 0:06 ` Ralf Baechle
2007-02-20 10:55 ` Ralf Baechle
0 siblings, 2 replies; 8+ messages in thread
From: Andrew Sharp @ 2007-02-19 23:48 UTC (permalink / raw)
To: linux-mips
[-- Attachment #1: Type: text/plain, Size: 74 bytes --]
Clean up the serial console support on the Sibyte 1250's built in duart.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Clean up serial console support on Sibyte 1250 duart
2007-02-19 23:48 [PATCH] Clean up serial console support on Sibyte 1250 duart Andrew Sharp
@ 2007-02-20 0:06 ` Ralf Baechle
2007-02-20 0:19 ` Woodrow Tree
2007-02-20 10:55 ` Ralf Baechle
1 sibling, 1 reply; 8+ messages in thread
From: Ralf Baechle @ 2007-02-20 0:06 UTC (permalink / raw)
To: Andrew Sharp; +Cc: linux-mips
On Mon, Feb 19, 2007 at 03:48:24PM -0800, Andrew Sharp wrote:
Patch looks reasonable at a quick glance. I'll review it for real
later, just wanted to mention that the drivers/char/ Sibyte serial
driver is really a dead end of the evolution. The driver should
be replaced with a new driver based on the the new drivers/serial/
infrastructure.
Ralf
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Clean up serial console support on Sibyte 1250 duart
2007-02-20 0:06 ` Ralf Baechle
@ 2007-02-20 0:19 ` Woodrow Tree
0 siblings, 0 replies; 8+ messages in thread
From: Woodrow Tree @ 2007-02-20 0:19 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On 2/19/07, Ralf Baechle <ralf@linux-mips.org> wrote:
>
> On Mon, Feb 19, 2007 at 03:48:24PM -0800, Andrew Sharp wrote:
>
> Patch looks reasonable at a quick glance. I'll review it for real
> later, just wanted to mention that the drivers/char/ Sibyte serial
> driver is really a dead end of the evolution. The driver should
> be replaced with a new driver based on the the new drivers/serial/
> infrastructure.
>
> Ralf
>
That explains the "shouldn't there be a general frame work for all this?"
itch in the back of my neck the whole time I was hacking on it.
a
[-- Attachment #2: Type: text/html, Size: 916 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Clean up serial console support on Sibyte 1250 duart
2007-02-19 23:48 [PATCH] Clean up serial console support on Sibyte 1250 duart Andrew Sharp
2007-02-20 0:06 ` Ralf Baechle
@ 2007-02-20 10:55 ` Ralf Baechle
1 sibling, 0 replies; 8+ messages in thread
From: Ralf Baechle @ 2007-02-20 10:55 UTC (permalink / raw)
To: Andrew Sharp; +Cc: linux-mips
On Mon, Feb 19, 2007 at 03:48:24PM -0800, Andrew Sharp wrote:
> Clean up the serial console support on the Sibyte 1250's built in duart.
Thanks, applied with some additional formatting fixes.
Ralf
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Clean up serial console support on Sibyte 1250 duart
2007-02-20 18:13 ` Ralf Baechle
@ 2007-02-21 12:56 ` Maciej W. Rozycki
0 siblings, 0 replies; 8+ messages in thread
From: Maciej W. Rozycki @ 2007-02-21 12:56 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Kaz Kylheku, Andrew Sharp, linux-mips
On Tue, 20 Feb 2007, Ralf Baechle wrote:
> While that's strongly prefered I wasn't picky in this case because this
> driver only has a single job left to do - as a stop gap until there is
> a new driver for the drivers/serial subsystem.
Which will be a funny exercise because of that AC97 codec hanging off one
of the lines. I guess it gives me enough incentive to put it on my to-do
list for not such a distant future. ;-)
It's a pity they did not wire the clock lines (TxC, RxC) to the serial
port connectors (I guess PCB space was more important) -- it would have
given me yet more incentive...
Maciej
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Clean up serial console support on Sibyte 1250 duart
2007-02-20 17:03 ` Kaz Kylheku
(?)
@ 2007-02-20 18:13 ` Ralf Baechle
2007-02-21 12:56 ` Maciej W. Rozycki
-1 siblings, 1 reply; 8+ messages in thread
From: Ralf Baechle @ 2007-02-20 18:13 UTC (permalink / raw)
To: Kaz Kylheku; +Cc: Andrew Sharp, linux-mips
On Tue, Feb 20, 2007 at 09:03:56AM -0800, Kaz Kylheku wrote:
> Andrew Sharp wrote:
> > Clean up the serial console support on the Sibyte 1250's
> > built in duart.
>
> Hi Andrew,
>
> Would it be too much trouble to split the patch into two: the whitespace
> changes, and the actual bugfix?
While that's strongly prefered I wasn't picky in this case because this
driver only has a single job left to do - as a stop gap until there is
a new driver for the drivers/serial subsystem.
Ralf
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] Clean up serial console support on Sibyte 1250 duart
@ 2007-02-20 17:03 ` Kaz Kylheku
0 siblings, 0 replies; 8+ messages in thread
From: Kaz Kylheku @ 2007-02-20 17:03 UTC (permalink / raw)
To: Andrew Sharp, linux-mips
Andrew Sharp wrote:
> Clean up the serial console support on the Sibyte 1250's
> built in duart.
Hi Andrew,
Would it be too much trouble to split the patch into two: the whitespace
changes, and the actual bugfix?
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] Clean up serial console support on Sibyte 1250 duart
@ 2007-02-20 17:03 ` Kaz Kylheku
0 siblings, 0 replies; 8+ messages in thread
From: Kaz Kylheku @ 2007-02-20 17:03 UTC (permalink / raw)
To: Andrew Sharp, linux-mips
Andrew Sharp wrote:
> Clean up the serial console support on the Sibyte 1250's
> built in duart.
Hi Andrew,
Would it be too much trouble to split the patch into two: the whitespace
changes, and the actual bugfix?
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2007-02-21 12:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-19 23:48 [PATCH] Clean up serial console support on Sibyte 1250 duart Andrew Sharp
2007-02-20 0:06 ` Ralf Baechle
2007-02-20 0:19 ` Woodrow Tree
2007-02-20 10:55 ` Ralf Baechle
2007-02-20 17:03 Kaz Kylheku
2007-02-20 17:03 ` Kaz Kylheku
2007-02-20 18:13 ` Ralf Baechle
2007-02-21 12:56 ` Maciej W. Rozycki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.