* [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
@ 2022-05-25 21:01 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-05-25 21:01 UTC (permalink / raw)
To: Kunihiko Hayashi, Bjorn Helgaas, Krzysztof Kozlowski, Masami Hiramatsu
Cc: linux-pci, devicetree, linux-arm-kernel, linux-kernel
The Socionext interrupt controller internal to the the PCI block isn't
documented which causes warnings when unevaluatedProperties check is
also fixed. Add the 'interrupt-controller' child node and properties and
fixup the example so that interrupt properties can be parsed.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/pci/socionext,uniphier-pcie.yaml | 23 ++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
index f5926d0fb085..638b99db0433 100644
--- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
@@ -51,6 +51,19 @@ properties:
phy-names:
const: pcie-phy
+ interrupt-controller:
+ type: object
+ additionalProperties: false
+
+ properties:
+ interrupt-controller: true
+
+ '#interrupt-cells':
+ const: 1
+
+ interrupts:
+ maxItems: 1
+
required:
- compatible
- reg
@@ -62,6 +75,13 @@ unevaluatedProperties: false
examples:
- |
+ bus {
+ gic: interrupt-controller {
+ interrupt-controller;
+ #interrupt-cells = <3>;
+ };
+ };
+
pcie: pcie@66000000 {
compatible = "socionext,uniphier-pcie";
reg-names = "dbi", "link", "config";
@@ -80,6 +100,7 @@ examples:
phys = <&pcie_phy>;
#interrupt-cells = <1>;
interrupt-names = "dma", "msi";
+ interrupt-parent = <&gic>;
interrupts = <0 224 4>, <0 225 4>;
interrupt-map-mask = <0 0 0 7>;
interrupt-map = <0 0 0 1 &pcie_intc 0>,
@@ -87,7 +108,7 @@ examples:
<0 0 0 3 &pcie_intc 2>,
<0 0 0 4 &pcie_intc 3>;
- pcie_intc: legacy-interrupt-controller {
+ pcie_intc: interrupt-controller {
interrupt-controller;
#interrupt-cells = <1>;
interrupt-parent = <&gic>;
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
@ 2022-05-25 21:01 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-05-25 21:01 UTC (permalink / raw)
To: Kunihiko Hayashi, Bjorn Helgaas, Krzysztof Kozlowski, Masami Hiramatsu
Cc: linux-pci, devicetree, linux-arm-kernel, linux-kernel
The Socionext interrupt controller internal to the the PCI block isn't
documented which causes warnings when unevaluatedProperties check is
also fixed. Add the 'interrupt-controller' child node and properties and
fixup the example so that interrupt properties can be parsed.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/pci/socionext,uniphier-pcie.yaml | 23 ++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
index f5926d0fb085..638b99db0433 100644
--- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
@@ -51,6 +51,19 @@ properties:
phy-names:
const: pcie-phy
+ interrupt-controller:
+ type: object
+ additionalProperties: false
+
+ properties:
+ interrupt-controller: true
+
+ '#interrupt-cells':
+ const: 1
+
+ interrupts:
+ maxItems: 1
+
required:
- compatible
- reg
@@ -62,6 +75,13 @@ unevaluatedProperties: false
examples:
- |
+ bus {
+ gic: interrupt-controller {
+ interrupt-controller;
+ #interrupt-cells = <3>;
+ };
+ };
+
pcie: pcie@66000000 {
compatible = "socionext,uniphier-pcie";
reg-names = "dbi", "link", "config";
@@ -80,6 +100,7 @@ examples:
phys = <&pcie_phy>;
#interrupt-cells = <1>;
interrupt-names = "dma", "msi";
+ interrupt-parent = <&gic>;
interrupts = <0 224 4>, <0 225 4>;
interrupt-map-mask = <0 0 0 7>;
interrupt-map = <0 0 0 1 &pcie_intc 0>,
@@ -87,7 +108,7 @@ examples:
<0 0 0 3 &pcie_intc 2>,
<0 0 0 4 &pcie_intc 3>;
- pcie_intc: legacy-interrupt-controller {
+ pcie_intc: interrupt-controller {
interrupt-controller;
#interrupt-cells = <1>;
interrupt-parent = <&gic>;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
2022-05-25 21:01 ` Rob Herring
@ 2022-05-26 9:01 ` Kunihiko Hayashi
-1 siblings, 0 replies; 10+ messages in thread
From: Kunihiko Hayashi @ 2022-05-26 9:01 UTC (permalink / raw)
To: Rob Herring, Bjorn Helgaas, Krzysztof Kozlowski, Masami Hiramatsu
Cc: linux-pci, devicetree, linux-arm-kernel, linux-kernel
Hi Rob,
On 2022/05/26 6:01, Rob Herring wrote:
> The Socionext interrupt controller internal to the the PCI block isn't
> documented which causes warnings when unevaluatedProperties check is
> also fixed. Add the 'interrupt-controller' child node and properties and
> fixup the example so that interrupt properties can be parsed.
Surely internal interrupt controller isn't described, and should be documented.
And the child node name "legacy-interrupt-controller" also should be fixed.
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
BTW I can't reproduce such warnings with my environment.
Can you show the command line to reproduce the warnings?
Thank you,
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/pci/socionext,uniphier-pcie.yaml | 23 ++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> index f5926d0fb085..638b99db0433 100644
> --- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> @@ -51,6 +51,19 @@ properties:
> phy-names:
> const: pcie-phy
>
> + interrupt-controller:
> + type: object
> + additionalProperties: false
> +
> + properties:
> + interrupt-controller: true
> +
> + '#interrupt-cells':
> + const: 1
> +
> + interrupts:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -62,6 +75,13 @@ unevaluatedProperties: false
>
> examples:
> - |
> + bus {
> + gic: interrupt-controller {
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + };
> + };
> +
> pcie: pcie@66000000 {
> compatible = "socionext,uniphier-pcie";
> reg-names = "dbi", "link", "config";
> @@ -80,6 +100,7 @@ examples:
> phys = <&pcie_phy>;
> #interrupt-cells = <1>;
> interrupt-names = "dma", "msi";
> + interrupt-parent = <&gic>;
> interrupts = <0 224 4>, <0 225 4>;
> interrupt-map-mask = <0 0 0 7>;
> interrupt-map = <0 0 0 1 &pcie_intc 0>,
> @@ -87,7 +108,7 @@ examples:
> <0 0 0 3 &pcie_intc 2>,
> <0 0 0 4 &pcie_intc 3>;
>
> - pcie_intc: legacy-interrupt-controller {
> + pcie_intc: interrupt-controller {
> interrupt-controller;
> #interrupt-cells = <1>;
> interrupt-parent = <&gic>;
>
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
@ 2022-05-26 9:01 ` Kunihiko Hayashi
0 siblings, 0 replies; 10+ messages in thread
From: Kunihiko Hayashi @ 2022-05-26 9:01 UTC (permalink / raw)
To: Rob Herring, Bjorn Helgaas, Krzysztof Kozlowski, Masami Hiramatsu
Cc: linux-pci, devicetree, linux-arm-kernel, linux-kernel
Hi Rob,
On 2022/05/26 6:01, Rob Herring wrote:
> The Socionext interrupt controller internal to the the PCI block isn't
> documented which causes warnings when unevaluatedProperties check is
> also fixed. Add the 'interrupt-controller' child node and properties and
> fixup the example so that interrupt properties can be parsed.
Surely internal interrupt controller isn't described, and should be documented.
And the child node name "legacy-interrupt-controller" also should be fixed.
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
BTW I can't reproduce such warnings with my environment.
Can you show the command line to reproduce the warnings?
Thank you,
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/pci/socionext,uniphier-pcie.yaml | 23 ++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> index f5926d0fb085..638b99db0433 100644
> --- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> @@ -51,6 +51,19 @@ properties:
> phy-names:
> const: pcie-phy
>
> + interrupt-controller:
> + type: object
> + additionalProperties: false
> +
> + properties:
> + interrupt-controller: true
> +
> + '#interrupt-cells':
> + const: 1
> +
> + interrupts:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -62,6 +75,13 @@ unevaluatedProperties: false
>
> examples:
> - |
> + bus {
> + gic: interrupt-controller {
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + };
> + };
> +
> pcie: pcie@66000000 {
> compatible = "socionext,uniphier-pcie";
> reg-names = "dbi", "link", "config";
> @@ -80,6 +100,7 @@ examples:
> phys = <&pcie_phy>;
> #interrupt-cells = <1>;
> interrupt-names = "dma", "msi";
> + interrupt-parent = <&gic>;
> interrupts = <0 224 4>, <0 225 4>;
> interrupt-map-mask = <0 0 0 7>;
> interrupt-map = <0 0 0 1 &pcie_intc 0>,
> @@ -87,7 +108,7 @@ examples:
> <0 0 0 3 &pcie_intc 2>,
> <0 0 0 4 &pcie_intc 3>;
>
> - pcie_intc: legacy-interrupt-controller {
> + pcie_intc: interrupt-controller {
> interrupt-controller;
> #interrupt-cells = <1>;
> interrupt-parent = <&gic>;
>
---
Best Regards
Kunihiko Hayashi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
2022-05-26 9:01 ` Kunihiko Hayashi
@ 2022-05-26 12:46 ` Rob Herring
-1 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-05-26 12:46 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: Bjorn Helgaas, Krzysztof Kozlowski, Masami Hiramatsu, PCI,
devicetree, linux-arm-kernel, linux-kernel
On Thu, May 26, 2022 at 4:02 AM Kunihiko Hayashi
<hayashi.kunihiko@socionext.com> wrote:
>
> Hi Rob,
>
> On 2022/05/26 6:01, Rob Herring wrote:
> > The Socionext interrupt controller internal to the the PCI block isn't
> > documented which causes warnings when unevaluatedProperties check is
> > also fixed. Add the 'interrupt-controller' child node and properties and
> > fixup the example so that interrupt properties can be parsed.
>
> Surely internal interrupt controller isn't described, and should be documented.
> And the child node name "legacy-interrupt-controller" also should be fixed.
>
> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Thanks.
>
> BTW I can't reproduce such warnings with my environment.
> Can you show the command line to reproduce the warnings?
"causes warnings when unevaluatedProperties check is also fixed"
You won't. I have a fix in dtschema pending, but first all the
warnings that appear need to be fixed.
Rob
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
@ 2022-05-26 12:46 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-05-26 12:46 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: Bjorn Helgaas, Krzysztof Kozlowski, Masami Hiramatsu, PCI,
devicetree, linux-arm-kernel, linux-kernel
On Thu, May 26, 2022 at 4:02 AM Kunihiko Hayashi
<hayashi.kunihiko@socionext.com> wrote:
>
> Hi Rob,
>
> On 2022/05/26 6:01, Rob Herring wrote:
> > The Socionext interrupt controller internal to the the PCI block isn't
> > documented which causes warnings when unevaluatedProperties check is
> > also fixed. Add the 'interrupt-controller' child node and properties and
> > fixup the example so that interrupt properties can be parsed.
>
> Surely internal interrupt controller isn't described, and should be documented.
> And the child node name "legacy-interrupt-controller" also should be fixed.
>
> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Thanks.
>
> BTW I can't reproduce such warnings with my environment.
> Can you show the command line to reproduce the warnings?
"causes warnings when unevaluatedProperties check is also fixed"
You won't. I have a fix in dtschema pending, but first all the
warnings that appear need to be fixed.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
2022-05-26 12:46 ` Rob Herring
@ 2022-05-27 9:27 ` Kunihiko Hayashi
-1 siblings, 0 replies; 10+ messages in thread
From: Kunihiko Hayashi @ 2022-05-27 9:27 UTC (permalink / raw)
To: Rob Herring
Cc: Bjorn Helgaas, Krzysztof Kozlowski, Masami Hiramatsu, PCI,
devicetree, linux-arm-kernel, linux-kernel
On 2022/05/26 21:46, Rob Herring wrote:
> On Thu, May 26, 2022 at 4:02 AM Kunihiko Hayashi
> <hayashi.kunihiko@socionext.com> wrote:
>>
>> Hi Rob,
>>
>> On 2022/05/26 6:01, Rob Herring wrote:
>>> The Socionext interrupt controller internal to the the PCI block isn't
>>> documented which causes warnings when unevaluatedProperties check is
>>> also fixed. Add the 'interrupt-controller' child node and properties and
>>> fixup the example so that interrupt properties can be parsed.
>>
>> Surely internal interrupt controller isn't described, and should be
>> documented.
>> And the child node name "legacy-interrupt-controller" also should be
>> fixed.
>>
>> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>
> Thanks.
>
>>
>> BTW I can't reproduce such warnings with my environment.
>> Can you show the command line to reproduce the warnings?
>
> "causes warnings when unevaluatedProperties check is also fixed"
>
> You won't. I have a fix in dtschema pending, but first all the
> warnings that appear need to be fixed.
I understand. I don't care abort the warning on the way to fix.
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
@ 2022-05-27 9:27 ` Kunihiko Hayashi
0 siblings, 0 replies; 10+ messages in thread
From: Kunihiko Hayashi @ 2022-05-27 9:27 UTC (permalink / raw)
To: Rob Herring
Cc: Bjorn Helgaas, Krzysztof Kozlowski, Masami Hiramatsu, PCI,
devicetree, linux-arm-kernel, linux-kernel
On 2022/05/26 21:46, Rob Herring wrote:
> On Thu, May 26, 2022 at 4:02 AM Kunihiko Hayashi
> <hayashi.kunihiko@socionext.com> wrote:
>>
>> Hi Rob,
>>
>> On 2022/05/26 6:01, Rob Herring wrote:
>>> The Socionext interrupt controller internal to the the PCI block isn't
>>> documented which causes warnings when unevaluatedProperties check is
>>> also fixed. Add the 'interrupt-controller' child node and properties and
>>> fixup the example so that interrupt properties can be parsed.
>>
>> Surely internal interrupt controller isn't described, and should be
>> documented.
>> And the child node name "legacy-interrupt-controller" also should be
>> fixed.
>>
>> Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>
> Thanks.
>
>>
>> BTW I can't reproduce such warnings with my environment.
>> Can you show the command line to reproduce the warnings?
>
> "causes warnings when unevaluatedProperties check is also fixed"
>
> You won't. I have a fix in dtschema pending, but first all the
> warnings that appear need to be fixed.
I understand. I don't care abort the warning on the way to fix.
Thank you,
---
Best Regards
Kunihiko Hayashi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
2022-05-25 21:01 ` Rob Herring
@ 2022-05-31 15:19 ` Rob Herring
-1 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-05-31 15:19 UTC (permalink / raw)
To: Kunihiko Hayashi, Bjorn Helgaas, Krzysztof Kozlowski, Masami Hiramatsu
Cc: linux-pci, devicetree, linux-arm-kernel, linux-kernel
On Wed, May 25, 2022 at 04:01:16PM -0500, Rob Herring wrote:
> The Socionext interrupt controller internal to the the PCI block isn't
> documented which causes warnings when unevaluatedProperties check is
> also fixed. Add the 'interrupt-controller' child node and properties and
> fixup the example so that interrupt properties can be parsed.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/pci/socionext,uniphier-pcie.yaml | 23 ++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller
@ 2022-05-31 15:19 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-05-31 15:19 UTC (permalink / raw)
To: Kunihiko Hayashi, Bjorn Helgaas, Krzysztof Kozlowski, Masami Hiramatsu
Cc: linux-pci, devicetree, linux-arm-kernel, linux-kernel
On Wed, May 25, 2022 at 04:01:16PM -0500, Rob Herring wrote:
> The Socionext interrupt controller internal to the the PCI block isn't
> documented which causes warnings when unevaluatedProperties check is
> also fixed. Add the 'interrupt-controller' child node and properties and
> fixup the example so that interrupt properties can be parsed.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/pci/socionext,uniphier-pcie.yaml | 23 ++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-05-31 15:20 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-25 21:01 [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller Rob Herring
2022-05-25 21:01 ` Rob Herring
2022-05-26 9:01 ` Kunihiko Hayashi
2022-05-26 9:01 ` Kunihiko Hayashi
2022-05-26 12:46 ` Rob Herring
2022-05-26 12:46 ` Rob Herring
2022-05-27 9:27 ` Kunihiko Hayashi
2022-05-27 9:27 ` Kunihiko Hayashi
2022-05-31 15:19 ` Rob Herring
2022-05-31 15:19 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.