[Buildroot] [PATCH 1/2] package/expat: disable examples, tests and xmlwf

[Buildroot] [PATCH 1/2] package/expat: disable examples, tests and xmlwf

[Fabrice Fontaine]

Disable examples and tests (enabled by default) through
--without-{examples,tests} which are available since version 2.2.7 and
https://github.com/libexpat/libexpat/commit/1fdfd8a1b490f8ac9e7e11896298e41cc210d87d

Also disable xmlwf (a binary that determines if an XML document is
well-formed) through --without-xmlwf which is available since version
2.2.4 and
https://github.com/libexpat/libexpat/commit/9d950527a07783c104aada685384edf3f8f23f8a

This will fix the following build failure on riscv64:

ERROR: reloc type R_RISCV_SET6 unsupported in this context

Fixes:
 - http://autobuild.buildroot.org/results/99890c9c7ebe3266dd533c81352a3cbcf4d3d738

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/expat/expat.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/expat/expat.mk b/package/expat/expat.mk
index b29b0e1d26..92a3bfda8e 100644
--- a/package/expat/expat.mk
+++ b/package/expat/expat.mk
@@ -15,8 +15,9 @@ EXPAT_LICENSE_FILES = COPYING
 EXPAT_CPE_ID_VENDOR = libexpat_project
 EXPAT_CPE_ID_PRODUCT = libexpat
 
-EXPAT_CONF_OPTS = --without-docbook
-HOST_EXPAT_CONF_OPTS = --without-docbook
+EXPAT_CONF_OPTS = \
+	--without-docbook --without-examples --without-tests --without-xmlwf
+HOST_EXPAT_CONF_OPTS = --without-docbook --without-examples --without-tests
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/expat: drop host-pkgconf dependency

[Fabrice Fontaine]

Drop host-pkgconf dependency which has been wrongly added by commit
732d94d25fd10fff65a378b03c3fca9bde403e95. Indeed, expat doesn't use
pkgconf to retrieve dependencies

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/expat/expat.mk | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/expat/expat.mk b/package/expat/expat.mk
index 92a3bfda8e..a42c77e0fb 100644
--- a/package/expat/expat.mk
+++ b/package/expat/expat.mk
@@ -8,8 +8,6 @@ EXPAT_VERSION = 2.4.7
 EXPAT_SITE = http://downloads.sourceforge.net/project/expat/expat/$(EXPAT_VERSION)
 EXPAT_SOURCE = expat-$(EXPAT_VERSION).tar.xz
 EXPAT_INSTALL_STAGING = YES
-EXPAT_DEPENDENCIES = host-pkgconf
-HOST_EXPAT_DEPENDENCIES = host-pkgconf
 EXPAT_LICENSE = MIT
 EXPAT_LICENSE_FILES = COPYING
 EXPAT_CPE_ID_VENDOR = libexpat_project
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/expat: disable examples, tests and xmlwf

[Arnout Vandecappelle]

On 19/04/2022 11:03, Fabrice Fontaine wrote:
> Disable examples and tests (enabled by default) through
> --without-{examples,tests} which are available since version 2.2.7 and
> https://github.com/libexpat/libexpat/commit/1fdfd8a1b490f8ac9e7e11896298e41cc210d87d
> 
> Also disable xmlwf (a binary that determines if an XML document is
> well-formed) through --without-xmlwf which is available since version
> 2.2.4 and
> https://github.com/libexpat/libexpat/commit/9d950527a07783c104aada685384edf3f8f23f8a
> 
> This will fix the following build failure on riscv64:
> 
> ERROR: reloc type R_RISCV_SET6 unsupported in this context
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/99890c9c7ebe3266dd533c81352a3cbcf4d3d738
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied both to master, thanks.

  Someone may actually need xmlwf for something, but then they can send a patch 
to enable it (probably with a Config.in option which depends on !riscv64).

  Regards,
  Arnout

> ---
>   package/expat/expat.mk | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/expat/expat.mk b/package/expat/expat.mk
> index b29b0e1d26..92a3bfda8e 100644
> --- a/package/expat/expat.mk
> +++ b/package/expat/expat.mk
> @@ -15,8 +15,9 @@ EXPAT_LICENSE_FILES = COPYING
>   EXPAT_CPE_ID_VENDOR = libexpat_project
>   EXPAT_CPE_ID_PRODUCT = libexpat
>   
> -EXPAT_CONF_OPTS = --without-docbook
> -HOST_EXPAT_CONF_OPTS = --without-docbook
> +EXPAT_CONF_OPTS = \
> +	--without-docbook --without-examples --without-tests --without-xmlwf
> +HOST_EXPAT_CONF_OPTS = --without-docbook --without-examples --without-tests
>   
>   $(eval $(autotools-package))
>   $(eval $(host-autotools-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/expat: disable examples, tests and xmlwf

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Disable examples and tests (enabled by default) through
 > --without-{examples,tests} which are available since version 2.2.7 and
 > https://github.com/libexpat/libexpat/commit/1fdfd8a1b490f8ac9e7e11896298e41cc210d87d

 > Also disable xmlwf (a binary that determines if an XML document is
 > well-formed) through --without-xmlwf which is available since version
 > 2.2.4 and
 > https://github.com/libexpat/libexpat/commit/9d950527a07783c104aada685384edf3f8f23f8a

 > This will fix the following build failure on riscv64:

 > ERROR: reloc type R_RISCV_SET6 unsupported in this context

 > Fixes:
 >  - http://autobuild.buildroot.org/results/99890c9c7ebe3266dd533c81352a3cbcf4d3d738

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/expat: drop host-pkgconf dependency

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Drop host-pkgconf dependency which has been wrongly added by commit
 > 732d94d25fd10fff65a378b03c3fca9bde403e95. Indeed, expat doesn't use
 > pkgconf to retrieve dependencies

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot