All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>
Cc: "David S . Miller" <davem@davemloft.net>,
	Shuah Khan <shuah@kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout
Date: Mon, 21 May 2018 10:13:02 -0700	[thread overview]
Message-ID: <828b3f2e-5062-01ef-2e7f-a94615c62aa3@gmail.com> (raw)
In-Reply-To: <615c089e-47a6-e36c-9ad4-2c86a8edeaa1@lab.ntt.co.jp>

On 05/20/2018 10:15 PM, Prashant Bhole wrote:
> 
> 
> On 5/19/2018 1:47 AM, John Fastabend wrote:
>> On 05/18/2018 12:17 AM, Prashant Bhole wrote:
>>> In order to reduce runtime of tests, recently timout for select() call
>>> was reduced from 1sec to 10usec. This was causing many tests failures.
>>> It was caught with failure handling commits in this series.
>>>
>>> Restoring the timeout from 10usec to 1sec
>>>
>>> Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_sockmap tests")
>>> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
>>> ---
>>
>> Whats the runtime for the entire test suite after this? I agree
>> I was probably to aggressive in setting this but on the other
>> hand I was trying to avoid letting the test run for minutes.
>>
> 
> Currently any failure stops further tests.
> So I made local change to force cork=0. With this change, it takes
> around 60 seconds for all 648 tests. It will change after fixing cork
> tests.
> 
> -Prashant
> 


OK, lets see how long it takes with the cork tests fixed. Maybe if
the cork flag is set we should lower the timeout to 100us.

.John

  reply	other threads:[~2018-05-21 17:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  7:17 [PATCH bpf-next 0/5] fix test_sockmap Prashant Bhole
2018-05-18  7:17 ` [PATCH bpf-next 1/5] selftests/bpf: test_sockmap, check test failure Prashant Bhole
2018-05-18  7:17 ` [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Prashant Bhole
2018-05-18 16:45   ` John Fastabend
2018-05-21  5:15     ` Prashant Bhole
2018-05-21 17:10       ` John Fastabend
2018-05-18  7:17 ` [PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout Prashant Bhole
2018-05-18 16:47   ` John Fastabend
2018-05-21  5:15     ` Prashant Bhole
2018-05-21 17:13       ` John Fastabend [this message]
2018-05-18  7:17 ` [PATCH bpf-next 4/5] selftests/bpf: test_sockmap, fix data verification Prashant Bhole
2018-05-18 16:49   ` John Fastabend
2018-05-18  7:17 ` [PATCH bpf-next 5/5] selftests/bpf: test_sockmap, print additional test options Prashant Bhole
2018-05-18 16:51   ` John Fastabend
2018-05-18 16:42 ` [PATCH bpf-next 0/5] fix test_sockmap John Fastabend
2018-05-21  5:13   ` Prashant Bhole
2018-05-21 17:08     ` John Fastabend
2018-05-23  9:44       ` Prashant Bhole
2018-05-24  4:47         ` Prashant Bhole
2018-05-24  4:58           ` John Fastabend
2018-05-25  8:28             ` Prashant Bhole
2018-05-25 14:01               ` John Fastabend
2018-05-28  4:16                 ` Prashant Bhole
2018-05-18 16:54 ` Shuah Khan
2018-05-18 16:54   ` Shuah Khan
2018-05-18 16:54   ` shuah
2018-05-18 17:23   ` Daniel Borkmann
2018-05-18 17:23     ` Daniel Borkmann
2018-05-18 17:23     ` daniel
2018-05-21  5:16   ` Prashant Bhole
2018-05-21  5:16     ` Prashant Bhole
2018-05-21  5:16     ` bhole_prashant_q7

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=828b3f2e-5062-01ef-2e7f-a94615c62aa3@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=ast@kernel.org \
    --cc=bhole_prashant_q7@lab.ntt.co.jp \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.