From: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
To: John Fastabend <john.fastabend@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: "David S . Miller" <davem@davemloft.net>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode
Date: Mon, 21 May 2018 14:15:16 +0900 [thread overview]
Message-ID: <f8320fed-076d-9a93-ef93-ea7f3cdbf88f@lab.ntt.co.jp> (raw)
In-Reply-To: <4c7e3657-902e-016b-0604-eef3448ae3d5@gmail.com>
On 5/19/2018 1:45 AM, John Fastabend wrote:
> On 05/18/2018 12:17 AM, Prashant Bhole wrote:
>> In case of selftest mode, temporary cgroup environment is created but
>> cgroup is not joined. It causes test failures. Fixed by joining the
>> cgroup
>>
>> Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
>> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
>> --
>
> Thanks, LGTM. Should this be the first patch in the series though?
> I wonder if after patch 1 if you would get failures without this
> patch.
Patch 1 fixes selftest mode as well as manual mode. This patch 2 is
specifically for selftest mode, hence the sequence.
- Prashant
next prev parent reply other threads:[~2018-05-21 5:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 7:17 [PATCH bpf-next 0/5] fix test_sockmap Prashant Bhole
2018-05-18 7:17 ` [PATCH bpf-next 1/5] selftests/bpf: test_sockmap, check test failure Prashant Bhole
2018-05-18 7:17 ` [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Prashant Bhole
2018-05-18 16:45 ` John Fastabend
2018-05-21 5:15 ` Prashant Bhole [this message]
2018-05-21 17:10 ` John Fastabend
2018-05-18 7:17 ` [PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout Prashant Bhole
2018-05-18 16:47 ` John Fastabend
2018-05-21 5:15 ` Prashant Bhole
2018-05-21 17:13 ` John Fastabend
2018-05-18 7:17 ` [PATCH bpf-next 4/5] selftests/bpf: test_sockmap, fix data verification Prashant Bhole
2018-05-18 16:49 ` John Fastabend
2018-05-18 7:17 ` [PATCH bpf-next 5/5] selftests/bpf: test_sockmap, print additional test options Prashant Bhole
2018-05-18 16:51 ` John Fastabend
2018-05-18 16:42 ` [PATCH bpf-next 0/5] fix test_sockmap John Fastabend
2018-05-21 5:13 ` Prashant Bhole
2018-05-21 17:08 ` John Fastabend
2018-05-23 9:44 ` Prashant Bhole
2018-05-24 4:47 ` Prashant Bhole
2018-05-24 4:58 ` John Fastabend
2018-05-25 8:28 ` Prashant Bhole
2018-05-25 14:01 ` John Fastabend
2018-05-28 4:16 ` Prashant Bhole
2018-05-18 16:54 ` Shuah Khan
2018-05-18 16:54 ` Shuah Khan
2018-05-18 16:54 ` shuah
2018-05-18 17:23 ` Daniel Borkmann
2018-05-18 17:23 ` Daniel Borkmann
2018-05-18 17:23 ` daniel
2018-05-21 5:16 ` Prashant Bhole
2018-05-21 5:16 ` Prashant Bhole
2018-05-21 5:16 ` bhole_prashant_q7
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8320fed-076d-9a93-ef93-ea7f3cdbf88f@lab.ntt.co.jp \
--to=bhole_prashant_q7@lab.ntt.co.jp \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.