[SPDK] question on using bdevio w/wait for RPC & tests.py

[SPDK] question on using bdevio w/wait for RPC & tests.py

[Luse, Paul E]

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

Hi Tomasz,

I was looking to use this feature that you added not too long ago in the compression tests in CI however I'm not sure how to invoke tests.py correctly I guess unless I copy it over to the /scripts directory so it can import rpc.  If I copy it over it works great however I'm guessing that wasn't the intention :)

Below is the error I get running from its location in the source tree. Can you shed some light on this for me, I really need to get compression running in CI and I need to use an RPC to configure a compression operation before running bdevio (well and bdevperf too).

Thanks!
Paul

Traceback (most recent call last):
  File "./tests.py", line 3, in <module>
    from rpc.client import print_dict, JSONRPCException
ModuleNotFoundError: No module named 'rpc'

Re: [SPDK] question on using bdevio w/wait for RPC & tests.py

[Luse, Paul E]

[-- Attachment #1: Type: text/plain, Size: 2070 bytes --]

Great, thanks!!

From: Zawadzki, Tomasz
Sent: Tuesday, July 9, 2019 1:11 AM
To: Luse, Paul E <paul.e.luse(a)intel.com>
Cc: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: RE: question on using bdevio w/wait for RPC & tests.py

Hi Paul,

Great to see someone using it ! :)

You are right, copying the script is not the intention. It relies on other imports from ./spdk/scripts/. tests.py --help should inform user about it... but of course it does not get to print part of code when imports are missing.

A user needs to execute command below in order to use tests.py directly:
export PYTHONPATH=$PYTHONPATH:./spdk/scripts/
This is already being done as part of CI tests in autotest_common.sh, so it is available in any test script sourcing it.

Thank you for rising this issue, please see following patch that adds more info when the script does not find the imports:
https://review.gerrithub.io/c/spdk/spdk/+/460908

Thanks,
Tomek

From: Luse, Paul E
Sent: Monday, July 8, 2019 9:03 PM
To: Zawadzki, Tomasz <tomasz.zawadzki(a)intel.com<mailto:tomasz.zawadzki(a)intel.com>>
Cc: Storage Performance Development Kit <spdk(a)lists.01.org<mailto:spdk(a)lists.01.org>>
Subject: question on using bdevio w/wait for RPC & tests.py

Hi Tomasz,

I was looking to use this feature that you added not too long ago in the compression tests in CI however I'm not sure how to invoke tests.py correctly I guess unless I copy it over to the /scripts directory so it can import rpc.  If I copy it over it works great however I'm guessing that wasn't the intention :)

Below is the error I get running from its location in the source tree. Can you shed some light on this for me, I really need to get compression running in CI and I need to use an RPC to configure a compression operation before running bdevio (well and bdevperf too).

Thanks!
Paul

Traceback (most recent call last):
  File "./tests.py", line 3, in <module>
    from rpc.client import print_dict, JSONRPCException
ModuleNotFoundError: No module named 'rpc'

Re: [SPDK] question on using bdevio w/wait for RPC & tests.py

[Zawadzki, Tomasz]

[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]

Hi Paul,

Great to see someone using it ! :)

You are right, copying the script is not the intention. It relies on other imports from ./spdk/scripts/. tests.py --help should inform user about it... but of course it does not get to print part of code when imports are missing.

A user needs to execute command below in order to use tests.py directly:
export PYTHONPATH=$PYTHONPATH:./spdk/scripts/
This is already being done as part of CI tests in autotest_common.sh, so it is available in any test script sourcing it.

Thank you for rising this issue, please see following patch that adds more info when the script does not find the imports:
https://review.gerrithub.io/c/spdk/spdk/+/460908

Thanks,
Tomek

From: Luse, Paul E
Sent: Monday, July 8, 2019 9:03 PM
To: Zawadzki, Tomasz <tomasz.zawadzki(a)intel.com>
Cc: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: question on using bdevio w/wait for RPC & tests.py

Hi Tomasz,

I was looking to use this feature that you added not too long ago in the compression tests in CI however I'm not sure how to invoke tests.py correctly I guess unless I copy it over to the /scripts directory so it can import rpc.  If I copy it over it works great however I'm guessing that wasn't the intention :)

Below is the error I get running from its location in the source tree. Can you shed some light on this for me, I really need to get compression running in CI and I need to use an RPC to configure a compression operation before running bdevio (well and bdevperf too).

Thanks!
Paul

Traceback (most recent call last):
  File "./tests.py", line 3, in <module>
    from rpc.client import print_dict, JSONRPCException
ModuleNotFoundError: No module named 'rpc'