Re: [SPDK] SPDK Directory Structure Change (Proposition)

Re: [SPDK] SPDK Directory Structure Change (Proposition)

[Luse, Paul E]

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

That's a lot of changes that could really surprise people Seth, thanks for calling attention to these patches.  Will review for sure

Thx
Paul

-----Original Message-----
From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Howell, Seth
Sent: Tuesday, August 20, 2019 8:23 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: [SPDK] SPDK Directory Structure Change (Proposition)

Hi All,

I have a patch series out right now which makes a couple of significant changes to the directory structure of SPDK. Some of the biggest changes are linked below.

https://review.gerrithub.io/c/spdk/spdk/+/465454/6
https://review.gerrithub.io/c/spdk/spdk/+/465455/6

The main reason for these changes is to enable creating link time dependencies between the individual SPDK shared libraries. The previous directory structure had the bdev modules and event subsystems nested inside of the event and bdev library directories. This had the unfortunate effect of creating cyclical dependencies between library directories. The changes above serve to flatten the library directory by creating a logical distinction between top level libraries and sub-modules that rely on those top level libraries.

Since these changes make significant changes to the directory structure, I wanted to put them out on the mailing list to see if there were any objections to the directory change.

Thanks,

Seth Howell





_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org
https://lists.01.org/mailman/listinfo/spdk

Re: [SPDK] SPDK Directory Structure Change (Proposition)

[Harris, James R]

[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]

Hi Seth,

This patch series all looks good to me.  I've added my +2s.  This is really going to help with the inter-library dependencies.

-Jim


On 8/20/19, 8:23 AM, "SPDK on behalf of Howell, Seth" <spdk-bounces(a)lists.01.org on behalf of seth.howell(a)intel.com> wrote:

    Hi All,
    
    I have a patch series out right now which makes a couple of significant changes to the directory structure of SPDK. Some of the biggest changes are linked below.
    
    https://review.gerrithub.io/c/spdk/spdk/+/465454/6
    https://review.gerrithub.io/c/spdk/spdk/+/465455/6
    
    The main reason for these changes is to enable creating link time dependencies between the individual SPDK shared libraries. The previous directory structure had the bdev modules and event subsystems nested inside of the event and bdev library directories. This had the unfortunate effect of creating cyclical dependencies between library directories. The changes above serve to flatten the library directory by creating a logical distinction between top level libraries and sub-modules that rely on those top level libraries.
    
    Since these changes make significant changes to the directory structure, I wanted to put them out on the mailing list to see if there were any objections to the directory change.
    
    Thanks,
    
    Seth Howell
    
    
    
    
    
    _______________________________________________
    SPDK mailing list
    SPDK(a)lists.01.org
    https://lists.01.org/mailman/listinfo/spdk
    

[SPDK] SPDK Directory Structure Change (Proposition)

[Howell, Seth]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

Hi All,

I have a patch series out right now which makes a couple of significant changes to the directory structure of SPDK. Some of the biggest changes are linked below.

https://review.gerrithub.io/c/spdk/spdk/+/465454/6
https://review.gerrithub.io/c/spdk/spdk/+/465455/6

The main reason for these changes is to enable creating link time dependencies between the individual SPDK shared libraries. The previous directory structure had the bdev modules and event subsystems nested inside of the event and bdev library directories. This had the unfortunate effect of creating cyclical dependencies between library directories. The changes above serve to flatten the library directory by creating a logical distinction between top level libraries and sub-modules that rely on those top level libraries.

Since these changes make significant changes to the directory structure, I wanted to put them out on the mailing list to see if there were any objections to the directory change.

Thanks,

Seth Howell