From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: arnd@linaro.org, heiko@sntech.de, ulf.hansson@linaro.org,
rjw@rjwysocki.net, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
lukasz.luba@arm.com, Robin Murphy <robin.murphy@arm.com>,
Johan Jonker <jbx6244@gmail.com>,
Helen Koike <helen.koike@collabora.com>,
Brian Norris <briannorris@chromium.org>,
Shunqian Zheng <zhengsq@rock-chips.com>,
Elaine Zhang <zhangqing@rock-chips.com>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v2 2/5] arm64: dts: rockchip: Add powerzones definition for rock960
Date: Wed, 8 Dec 2021 17:16:18 +0100 [thread overview]
Message-ID: <82ac88d2-5419-4c1f-e81a-154c65b39c1b@linaro.org> (raw)
In-Reply-To: <CAL_JsqK1tsOqUYrLkZCo95BC=AXwZxai947x41zYpeHbodvwFg@mail.gmail.com>
Hi Rob,
On 07/12/2021 19:41, Rob Herring wrote:
[ ... ]
>> thermal_zones: thermal-zones {
>> cpu_thermal: cpu-thermal {
>> polling-delay-passive = <100>;
>> @@ -2027,6 +2050,8 @@ gpu: gpu@ff9a0000 {
>> clocks = <&cru ACLK_GPU>;
>> #cooling-cells = <2>;
>> power-domains = <&power RK3399_PD_GPU>;
>> + #powerzone-cells = <0>;
>> + powerzone = <&PKG_PZ>;
>
> Every CPU and the GPU are in the same powerzone. What is the point? Do
> you really have to be told that CPUs and GPU are a source of heat and
> might need to be limited?
A powerzone ==> can read power && set power limit
Every CPU is a powerzone as well as the GPU.
They are all grouped under PKG_PZ.
That means we have:
pkg
|-- cpu0-3
|
|-- cpu4-7
|
`-- gpu
We can read the power consumption of cpu0-3, cpu4-7 or gpu and set their
power limit.
We can read the power consumption of pkg (which is the sum of the power
consumption of cpu0-3, cpu4-7 and gpu) and I can set the power limit
which will ensure powerof(cpu0-3 + cpu4-7 + gpu) <= powerof(pkg).
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: arnd@linaro.org, heiko@sntech.de, ulf.hansson@linaro.org,
rjw@rjwysocki.net, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
lukasz.luba@arm.com, Robin Murphy <robin.murphy@arm.com>,
Johan Jonker <jbx6244@gmail.com>,
Helen Koike <helen.koike@collabora.com>,
Brian Norris <briannorris@chromium.org>,
Shunqian Zheng <zhengsq@rock-chips.com>,
Elaine Zhang <zhangqing@rock-chips.com>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v2 2/5] arm64: dts: rockchip: Add powerzones definition for rock960
Date: Wed, 8 Dec 2021 17:16:18 +0100 [thread overview]
Message-ID: <82ac88d2-5419-4c1f-e81a-154c65b39c1b@linaro.org> (raw)
In-Reply-To: <CAL_JsqK1tsOqUYrLkZCo95BC=AXwZxai947x41zYpeHbodvwFg@mail.gmail.com>
Hi Rob,
On 07/12/2021 19:41, Rob Herring wrote:
[ ... ]
>> thermal_zones: thermal-zones {
>> cpu_thermal: cpu-thermal {
>> polling-delay-passive = <100>;
>> @@ -2027,6 +2050,8 @@ gpu: gpu@ff9a0000 {
>> clocks = <&cru ACLK_GPU>;
>> #cooling-cells = <2>;
>> power-domains = <&power RK3399_PD_GPU>;
>> + #powerzone-cells = <0>;
>> + powerzone = <&PKG_PZ>;
>
> Every CPU and the GPU are in the same powerzone. What is the point? Do
> you really have to be told that CPUs and GPU are a source of heat and
> might need to be limited?
A powerzone ==> can read power && set power limit
Every CPU is a powerzone as well as the GPU.
They are all grouped under PKG_PZ.
That means we have:
pkg
|-- cpu0-3
|
|-- cpu4-7
|
`-- gpu
We can read the power consumption of cpu0-3, cpu4-7 or gpu and set their
power limit.
We can read the power consumption of pkg (which is the sum of the power
consumption of cpu0-3, cpu4-7 and gpu) and I can set the power limit
which will ensure powerof(cpu0-3 + cpu4-7 + gpu) <= powerof(pkg).
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: arnd@linaro.org, heiko@sntech.de, ulf.hansson@linaro.org,
rjw@rjwysocki.net, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
lukasz.luba@arm.com, Robin Murphy <robin.murphy@arm.com>,
Johan Jonker <jbx6244@gmail.com>,
Helen Koike <helen.koike@collabora.com>,
Brian Norris <briannorris@chromium.org>,
Shunqian Zheng <zhengsq@rock-chips.com>,
Elaine Zhang <zhangqing@rock-chips.com>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v2 2/5] arm64: dts: rockchip: Add powerzones definition for rock960
Date: Wed, 8 Dec 2021 17:16:18 +0100 [thread overview]
Message-ID: <82ac88d2-5419-4c1f-e81a-154c65b39c1b@linaro.org> (raw)
In-Reply-To: <CAL_JsqK1tsOqUYrLkZCo95BC=AXwZxai947x41zYpeHbodvwFg@mail.gmail.com>
Hi Rob,
On 07/12/2021 19:41, Rob Herring wrote:
[ ... ]
>> thermal_zones: thermal-zones {
>> cpu_thermal: cpu-thermal {
>> polling-delay-passive = <100>;
>> @@ -2027,6 +2050,8 @@ gpu: gpu@ff9a0000 {
>> clocks = <&cru ACLK_GPU>;
>> #cooling-cells = <2>;
>> power-domains = <&power RK3399_PD_GPU>;
>> + #powerzone-cells = <0>;
>> + powerzone = <&PKG_PZ>;
>
> Every CPU and the GPU are in the same powerzone. What is the point? Do
> you really have to be told that CPUs and GPU are a source of heat and
> might need to be limited?
A powerzone ==> can read power && set power limit
Every CPU is a powerzone as well as the GPU.
They are all grouped under PKG_PZ.
That means we have:
pkg
|-- cpu0-3
|
|-- cpu4-7
|
`-- gpu
We can read the power consumption of cpu0-3, cpu4-7 or gpu and set their
power limit.
We can read the power consumption of pkg (which is the sum of the power
consumption of cpu0-3, cpu4-7 and gpu) and I can set the power limit
which will ensure powerof(cpu0-3 + cpu4-7 + gpu) <= powerof(pkg).
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-08 16:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 18:14 [PATCH v2 1/5] dt-bindings: Powerzone new bindings Daniel Lezcano
2021-11-26 18:14 ` [PATCH v2 2/5] arm64: dts: rockchip: Add powerzones definition for rock960 Daniel Lezcano
2021-11-26 18:14 ` Daniel Lezcano
2021-11-26 18:14 ` Daniel Lezcano
2021-12-07 18:41 ` Rob Herring
2021-12-07 18:41 ` Rob Herring
2021-12-07 18:41 ` Rob Herring
2021-12-08 16:16 ` Daniel Lezcano [this message]
2021-12-08 16:16 ` Daniel Lezcano
2021-12-08 16:16 ` Daniel Lezcano
2021-11-26 18:14 ` [PATCH v2 3/5] powercap/drivers/dtpm: Add DT initialization support Daniel Lezcano
2021-11-26 18:14 ` [PATCH v2 4/5] powercap/drivers/dtpm: Add CPU " Daniel Lezcano
2021-11-26 18:14 ` [PATCH v2 5/5] powercap/drivers/dtpm: Add dtpm devfreq with energy model support Daniel Lezcano
2021-11-30 16:48 ` [PATCH v2 1/5] dt-bindings: Powerzone new bindings Daniel Lezcano
2021-12-01 9:23 ` Ulf Hansson
2021-12-01 14:43 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82ac88d2-5419-4c1f-e81a-154c65b39c1b@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=arnd@linaro.org \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lukasz.luba@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=ulf.hansson@linaro.org \
--cc=zhangqing@rock-chips.com \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.