[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[Bin Meng]

QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host.
Enable the driver for it.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 board/emulation/qemu-riscv/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
index 20ea6dc..2a03e43 100644
--- a/board/emulation/qemu-riscv/Kconfig
+++ b/board/emulation/qemu-riscv/Kconfig
@@ -36,5 +36,9 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	imply OF_BOARD_SETUP
 	imply SIFIVE_SERIAL
 	imply SMP
+	imply PCI
+	imply DM_PCI
+	imply PCIE_ECAM_GENERIC
+	imply CMD_PCI
 
 endif
-- 
2.7.4

[U-Boot] [PATCH 2/2] riscv: qemu: Enable e1000 and nvme support

[Bin Meng]

Since we have added the PCI support to the 'virt' target, enable
e1000 and NVME as alternate network and storage devices for these
virtio based devices.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 board/emulation/qemu-riscv/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
index 2a03e43..7f9a74d 100644
--- a/board/emulation/qemu-riscv/Kconfig
+++ b/board/emulation/qemu-riscv/Kconfig
@@ -40,5 +40,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	imply DM_PCI
 	imply PCIE_ECAM_GENERIC
 	imply CMD_PCI
+	imply E1000
+	imply NVME
 
 endif
-- 
2.7.4

[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[Auer, Lukas]

On Wed, 2019-05-15 at 08:42 -0700, Bin Meng wrote:
> QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host.
> Enable the driver for it.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> 
>  board/emulation/qemu-riscv/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
Tested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>

[U-Boot] [PATCH 2/2] riscv: qemu: Enable e1000 and nvme support

[Auer, Lukas]

On Wed, 2019-05-15 at 08:42 -0700, Bin Meng wrote:
> Since we have added the PCI support to the 'virt' target, enable
> e1000 and NVME as alternate network and storage devices for these
> virtio based devices.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> 
>  board/emulation/qemu-riscv/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig
> index 2a03e43..7f9a74d 100644
> --- a/board/emulation/qemu-riscv/Kconfig
> +++ b/board/emulation/qemu-riscv/Kconfig
> @@ -40,5 +40,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>  	imply DM_PCI
>  	imply PCIE_ECAM_GENERIC
>  	imply CMD_PCI
> +	imply E1000
> +	imply NVME
>  
>  endif

Tested the series in QEMU master with an e1000 and a NVMe device,
accessing them from U-Boot.

Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
Tested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>

[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[Bin Meng]

Hi Rick,

On Mon, May 27, 2019 at 4:40 PM Auer, Lukas
<lukas.auer@aisec.fraunhofer.de> wrote:
>
> On Wed, 2019-05-15 at 08:42 -0700, Bin Meng wrote:
> > QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host.
> > Enable the driver for it.
> >
> > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > ---
> >
> >  board/emulation/qemu-riscv/Kconfig | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
>
> Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> Tested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>

Could you please apply this series for v2019.07?

Regards,
Bin

[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[Rick Chen]

Hi BIn

> Hi Rick,
>
> On Mon, May 27, 2019 at 4:40 PM Auer, Lukas
> <lukas.auer@aisec.fraunhofer.de> wrote:
> >
> > On Wed, 2019-05-15 at 08:42 -0700, Bin Meng wrote:
> > > QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host.
> > > Enable the driver for it.
> > >
> > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > > ---
> > >
> > >  board/emulation/qemu-riscv/Kconfig | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> >
> > Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > Tested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
>
> Could you please apply this series for v2019.07?
>

OK
I will apply it today.

Thanks
Rick

> Regards,
> Bin

[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[Rick Chen]

>
> Hi BIn
>
> > Hi Rick,
> >
> > On Mon, May 27, 2019 at 4:40 PM Auer, Lukas
> > <lukas.auer@aisec.fraunhofer.de> wrote:
> > >
> > > On Wed, 2019-05-15 at 08:42 -0700, Bin Meng wrote:
> > > > QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host.
> > > > Enable the driver for it.
> > > >
> > > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > > > ---
> > > >
> > > >  board/emulation/qemu-riscv/Kconfig | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >
> > >
> > > Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > Tested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> >
> > Could you please apply this series for v2019.07?
> >

Applied to u-boot-riscv/master, thanks!

>
> OK
> I will apply it today.
>
> Thanks
> Rick
>
> > Regards,
> > Bin

[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[Bin Meng]

Hi Rick,

On Tue, Jun 4, 2019 at 1:35 PM Rick Chen <rickchen36@gmail.com> wrote:
>
> >
> > Hi BIn
> >
> > > Hi Rick,
> > >
> > > On Mon, May 27, 2019 at 4:40 PM Auer, Lukas
> > > <lukas.auer@aisec.fraunhofer.de> wrote:
> > > >
> > > > On Wed, 2019-05-15 at 08:42 -0700, Bin Meng wrote:
> > > > > QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host.
> > > > > Enable the driver for it.
> > > > >
> > > > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > > > > ---
> > > > >
> > > > >  board/emulation/qemu-riscv/Kconfig | 4 ++++
> > > > >  1 file changed, 4 insertions(+)
> > > > >
> > > >
> > > > Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > > Tested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > >
> > > Could you please apply this series for v2019.07?
> > >
>
> Applied to u-boot-riscv/master, thanks!

Thanks for applying.

By searching riscv patches from patchwork, it seems there are some old
patches that are not cleaned up. I am not sure about their status.
Maybe they are already applied.

http://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=riscv&archive=&delegate=

Could you please do some house keeping?

Regards,
Bin

[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[Rick Chen]

Hi Bin

Bin Meng <bmeng.cn@gmail.com> 於 2019年6月4日 週二 下午2:27寫道：
>
> Hi Rick,
>
> On Tue, Jun 4, 2019 at 1:35 PM Rick Chen <rickchen36@gmail.com> wrote:
> >
> > >
> > > Hi BIn
> > >
> > > > Hi Rick,
> > > >
> > > > On Mon, May 27, 2019 at 4:40 PM Auer, Lukas
> > > > <lukas.auer@aisec.fraunhofer.de> wrote:
> > > > >
> > > > > On Wed, 2019-05-15 at 08:42 -0700, Bin Meng wrote:
> > > > > > QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host.
> > > > > > Enable the driver for it.
> > > > > >
> > > > > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > > > > > ---
> > > > > >
> > > > > >  board/emulation/qemu-riscv/Kconfig | 4 ++++
> > > > > >  1 file changed, 4 insertions(+)
> > > > > >
> > > > >
> > > > > Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > > > Tested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > >
> > > > Could you please apply this series for v2019.07?
> > > >
> >
> > Applied to u-boot-riscv/master, thanks!
>
> Thanks for applying.
>
> By searching riscv patches from patchwork, it seems there are some old
> patches that are not cleaned up. I am not sure about their status.
> Maybe they are already applied.

I will rebase to u-boot/master before applying the patchs.
If they are already applied, there will have conflictions, right ?

>
> http://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=riscv&archive=&delegate=
>
> Could you please do some house keeping?

I am not sure what do you mean about house keeping ?

>
> Regards,
> Bin

[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[Bin Meng]

Hi Rick,

On Wed, Jun 5, 2019 at 1:55 PM Rick Chen <rickchen36@gmail.com> wrote:
>
> Hi Bin
>
> Bin Meng <bmeng.cn@gmail.com> 於 2019年6月4日 週二 下午2:27寫道：
> >
> > Hi Rick,
> >
> > On Tue, Jun 4, 2019 at 1:35 PM Rick Chen <rickchen36@gmail.com> wrote:
> > >
> > > >
> > > > Hi BIn
> > > >
> > > > > Hi Rick,
> > > > >
> > > > > On Mon, May 27, 2019 at 4:40 PM Auer, Lukas
> > > > > <lukas.auer@aisec.fraunhofer.de> wrote:
> > > > > >
> > > > > > On Wed, 2019-05-15 at 08:42 -0700, Bin Meng wrote:
> > > > > > > QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host.
> > > > > > > Enable the driver for it.
> > > > > > >
> > > > > > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > > > > > > ---
> > > > > > >
> > > > > > >  board/emulation/qemu-riscv/Kconfig | 4 ++++
> > > > > > >  1 file changed, 4 insertions(+)
> > > > > > >
> > > > > >
> > > > > > Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > > > > Tested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > > >
> > > > > Could you please apply this series for v2019.07?
> > > > >
> > >
> > > Applied to u-boot-riscv/master, thanks!
> >
> > Thanks for applying.
> >
> > By searching riscv patches from patchwork, it seems there are some old
> > patches that are not cleaned up. I am not sure about their status.
> > Maybe they are already applied.
>
> I will rebase to u-boot/master before applying the patchs.
> If they are already applied, there will have conflictions, right ?
>

Not sure if there will be conflicts, so simply not applied (skipped).
You can try.

> >
> > http://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=riscv&archive=&delegate=
> >
> > Could you please do some house keeping?
>
> I am not sure what do you mean about house keeping ?

I meant that you should clean up all these patches in your queue.
Either mark them as accepted, or superseded, etc.

Regards,
Bin

[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[Rick Chen]

Hi Bin

Bin Meng <bmeng.cn@gmail.com> 於 2019年6月5日 週三 下午5:29寫道：
>
> Hi Rick,
>
> On Wed, Jun 5, 2019 at 1:55 PM Rick Chen <rickchen36@gmail.com> wrote:
> >
> > Hi Bin
> >
> > Bin Meng <bmeng.cn@gmail.com> 於 2019年6月4日 週二 下午2:27寫道：
> > >
> > > Hi Rick,
> > >
> > > On Tue, Jun 4, 2019 at 1:35 PM Rick Chen <rickchen36@gmail.com> wrote:
> > > >
> > > > >
> > > > > Hi BIn
> > > > >
> > > > > > Hi Rick,
> > > > > >
> > > > > > On Mon, May 27, 2019 at 4:40 PM Auer, Lukas
> > > > > > <lukas.auer@aisec.fraunhofer.de> wrote:
> > > > > > >
> > > > > > > On Wed, 2019-05-15 at 08:42 -0700, Bin Meng wrote:
> > > > > > > > QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host.
> > > > > > > > Enable the driver for it.
> > > > > > > >
> > > > > > > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > > > > > > > ---
> > > > > > > >
> > > > > > > >  board/emulation/qemu-riscv/Kconfig | 4 ++++
> > > > > > > >  1 file changed, 4 insertions(+)
> > > > > > > >
> > > > > > >
> > > > > > > Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > > > > > Tested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > > > >
> > > > > > Could you please apply this series for v2019.07?
> > > > > >
> > > >
> > > > Applied to u-boot-riscv/master, thanks!
> > >
> > > Thanks for applying.
> > >
> > > By searching riscv patches from patchwork, it seems there are some old
> > > patches that are not cleaned up. I am not sure about their status.
> > > Maybe they are already applied.
> >
> > I will rebase to u-boot/master before applying the patchs.
> > If they are already applied, there will have conflictions, right ?
> >
>
> Not sure if there will be conflicts, so simply not applied (skipped).
> You can try.
>
> > >
> > > http://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=riscv&archive=&delegate=
> > >
> > > Could you please do some house keeping?
> >
> > I am not sure what do you mean about house keeping ?
>
> I meant that you should clean up all these patches in your queue.
> Either mark them as accepted, or superseded, etc.
>

I just applied your patchs yesterday. And its state became Accepted.
https://patchwork.ozlabs.org/project/uboot/list/?order=delegate&state=*

I thought it will change by my actions automatically.
How can I change state from New to Accepted ?

Thanks
Rick

> Regards,
> Bin

[U-Boot] [PATCH 1/2] riscv: qemu: Enable PCI host ECAM generic driver

[Bin Meng]

Hi Rick,

On Wed, Jun 5, 2019 at 6:04 PM Rick Chen <rickchen36@gmail.com> wrote:
>
> Hi Bin
>
> Bin Meng <bmeng.cn@gmail.com> 於 2019年6月5日 週三 下午5:29寫道：
> >
> > Hi Rick,
> >
> > On Wed, Jun 5, 2019 at 1:55 PM Rick Chen <rickchen36@gmail.com> wrote:
> > >
> > > Hi Bin
> > >
> > > Bin Meng <bmeng.cn@gmail.com> 於 2019年6月4日 週二 下午2:27寫道：
> > > >
> > > > Hi Rick,
> > > >
> > > > On Tue, Jun 4, 2019 at 1:35 PM Rick Chen <rickchen36@gmail.com> wrote:
> > > > >
> > > > > >
> > > > > > Hi BIn
> > > > > >
> > > > > > > Hi Rick,
> > > > > > >
> > > > > > > On Mon, May 27, 2019 at 4:40 PM Auer, Lukas
> > > > > > > <lukas.auer@aisec.fraunhofer.de> wrote:
> > > > > > > >
> > > > > > > > On Wed, 2019-05-15 at 08:42 -0700, Bin Meng wrote:
> > > > > > > > > QEMU 4.0.0 'virt' target integrates a generic ECAM PCI host.
> > > > > > > > > Enable the driver for it.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > > > > > > > > ---
> > > > > > > > >
> > > > > > > > >  board/emulation/qemu-riscv/Kconfig | 4 ++++
> > > > > > > > >  1 file changed, 4 insertions(+)
> > > > > > > > >
> > > > > > > >
> > > > > > > > Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > > > > > > Tested-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de>
> > > > > > >
> > > > > > > Could you please apply this series for v2019.07?
> > > > > > >
> > > > >
> > > > > Applied to u-boot-riscv/master, thanks!
> > > >
> > > > Thanks for applying.
> > > >
> > > > By searching riscv patches from patchwork, it seems there are some old
> > > > patches that are not cleaned up. I am not sure about their status.
> > > > Maybe they are already applied.
> > >
> > > I will rebase to u-boot/master before applying the patchs.
> > > If they are already applied, there will have conflictions, right ?
> > >
> >
> > Not sure if there will be conflicts, so simply not applied (skipped).
> > You can try.
> >
> > > >
> > > > http://patchwork.ozlabs.org/project/uboot/list/?series=&submitter=&state=&q=riscv&archive=&delegate=
> > > >
> > > > Could you please do some house keeping?
> > >
> > > I am not sure what do you mean about house keeping ?
> >
> > I meant that you should clean up all these patches in your queue.
> > Either mark them as accepted, or superseded, etc.
> >
>
> I just applied your patchs yesterday. And its state became Accepted.

I cleaned up my patches because I have the privilege to change patch status.

> https://patchwork.ozlabs.org/project/uboot/list/?order=delegate&state=*
>
> I thought it will change by my actions automatically.

No, it won't.

> How can I change state from New to Accepted ?
>

You need change the state manually. I don't know other patches'
status, so I left them to you. In the end, you are the RISC-V
custodian.

Regards,
Bin