* [PATCH] arc: Add "include chroot" for DT bindings
@ 2017-05-30 13:22 ` Alexey Brodkin
0 siblings, 0 replies; 8+ messages in thread
From: Alexey Brodkin @ 2017-05-30 13:22 UTC (permalink / raw)
To: linux-snps-arc
Cc: linux-kernel, Vineet Gupta, Alexey Brodkin, Stephen Warren, Rob Herring
Basically this extends
c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
ARC where we extensively use Device Tree and there're good reasons
to use DT bindings, especially if those are required.
Otherwise on attempt to compile .dts with something like:
-------------------->8---------------------
#include <dt-bindings/net/ti-dp83867.h>
-------------------->8---------------------
we inevitably see this compilation failure:
-------------------->8---------------------
arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
#include <dt-bindings/net/ti-dp83867.h>
^
compilation terminated.
-------------------->8---------------------
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Rob Herring <robh+dt@kernel.org>
---
arch/arc/boot/dts/include/dt-bindings | 1 +
1 file changed, 1 insertion(+)
create mode 120000 arch/arc/boot/dts/include/dt-bindings
diff --git a/arch/arc/boot/dts/include/dt-bindings b/arch/arc/boot/dts/include/dt-bindings
new file mode 120000
index 000000000000..08c00e4972fa
--- /dev/null
+++ b/arch/arc/boot/dts/include/dt-bindings
@@ -0,0 +1 @@
+../../../../../include/dt-bindings
\ No newline at end of file
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] arc: Add "include chroot" for DT bindings
@ 2017-05-30 13:22 ` Alexey Brodkin
0 siblings, 0 replies; 8+ messages in thread
From: Alexey Brodkin @ 2017-05-30 13:22 UTC (permalink / raw)
To: linux-snps-arc
Basically this extends
c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
ARC where we extensively use Device Tree and there're good reasons
to use DT bindings, especially if those are required.
Otherwise on attempt to compile .dts with something like:
-------------------->8---------------------
#include <dt-bindings/net/ti-dp83867.h>
-------------------->8---------------------
we inevitably see this compilation failure:
-------------------->8---------------------
arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
#include <dt-bindings/net/ti-dp83867.h>
^
compilation terminated.
-------------------->8---------------------
Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
Cc: Stephen Warren <swarren at wwwdotorg.org>
Cc: Rob Herring <robh+dt at kernel.org>
---
arch/arc/boot/dts/include/dt-bindings | 1 +
1 file changed, 1 insertion(+)
create mode 120000 arch/arc/boot/dts/include/dt-bindings
diff --git a/arch/arc/boot/dts/include/dt-bindings b/arch/arc/boot/dts/include/dt-bindings
new file mode 120000
index 000000000000..08c00e4972fa
--- /dev/null
+++ b/arch/arc/boot/dts/include/dt-bindings
@@ -0,0 +1 @@
+../../../../../include/dt-bindings
\ No newline at end of file
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] arc: Add "include chroot" for DT bindings
2017-05-30 13:22 ` Alexey Brodkin
@ 2017-05-30 16:30 ` Vineet Gupta
-1 siblings, 0 replies; 8+ messages in thread
From: Vineet Gupta @ 2017-05-30 16:30 UTC (permalink / raw)
To: Alexey Brodkin, linux-snps-arc; +Cc: linux-kernel, Stephen Warren, Rob Herring
On 05/30/2017 06:22 AM, Alexey Brodkin wrote:
> Basically this extends
> c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> ARC where we extensively use Device Tree and there're good reasons
> to use DT bindings, especially if those are required.
>
> Otherwise on attempt to compile .dts with something like:
> -------------------->8---------------------
> #include <dt-bindings/net/ti-dp83867.h>
> -------------------->8---------------------
>
> we inevitably see this compilation failure:
> -------------------->8---------------------
> arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
> #include <dt-bindings/net/ti-dp83867.h>
> ^
> compilation terminated.
> -------------------->8---------------------
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
> arch/arc/boot/dts/include/dt-bindings | 1 +
> 1 file changed, 1 insertion(+)
> create mode 120000 arch/arc/boot/dts/include/dt-bindings
>
> diff --git a/arch/arc/boot/dts/include/dt-bindings b/arch/arc/boot/dts/include/dt-bindings
> new file mode 120000
> index 000000000000..08c00e4972fa
> --- /dev/null
> +++ b/arch/arc/boot/dts/include/dt-bindings
> @@ -0,0 +1 @@
> +../../../../../include/dt-bindings
> \ No newline at end of file
I'm OK with adding this to ARC, but won't it be nicer to have a generic include
helper instead to avoid boilerplate addition in multiple places ?
-Vineet
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] arc: Add "include chroot" for DT bindings
@ 2017-05-30 16:30 ` Vineet Gupta
0 siblings, 0 replies; 8+ messages in thread
From: Vineet Gupta @ 2017-05-30 16:30 UTC (permalink / raw)
To: linux-snps-arc
On 05/30/2017 06:22 AM, Alexey Brodkin wrote:
> Basically this extends
> c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> ARC where we extensively use Device Tree and there're good reasons
> to use DT bindings, especially if those are required.
>
> Otherwise on attempt to compile .dts with something like:
> -------------------->8---------------------
> #include <dt-bindings/net/ti-dp83867.h>
> -------------------->8---------------------
>
> we inevitably see this compilation failure:
> -------------------->8---------------------
> arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
> #include <dt-bindings/net/ti-dp83867.h>
> ^
> compilation terminated.
> -------------------->8---------------------
>
> Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Stephen Warren <swarren at wwwdotorg.org>
> Cc: Rob Herring <robh+dt at kernel.org>
> ---
> arch/arc/boot/dts/include/dt-bindings | 1 +
> 1 file changed, 1 insertion(+)
> create mode 120000 arch/arc/boot/dts/include/dt-bindings
>
> diff --git a/arch/arc/boot/dts/include/dt-bindings b/arch/arc/boot/dts/include/dt-bindings
> new file mode 120000
> index 000000000000..08c00e4972fa
> --- /dev/null
> +++ b/arch/arc/boot/dts/include/dt-bindings
> @@ -0,0 +1 @@
> +../../../../../include/dt-bindings
> \ No newline at end of file
I'm OK with adding this to ARC, but won't it be nicer to have a generic include
helper instead to avoid boilerplate addition in multiple places ?
-Vineet
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arc: Add "include chroot" for DT bindings
2017-05-30 13:22 ` Alexey Brodkin
@ 2017-05-30 16:56 ` Rob Herring
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2017-05-30 16:56 UTC (permalink / raw)
To: Alexey Brodkin; +Cc: arcml, linux-kernel, Vineet Gupta, Stephen Warren
On Tue, May 30, 2017 at 8:22 AM, Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
> Basically this extends
> c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> ARC where we extensively use Device Tree and there're good reasons
> to use DT bindings, especially if those are required.
>
> Otherwise on attempt to compile .dts with something like:
> -------------------->8---------------------
> #include <dt-bindings/net/ti-dp83867.h>
> -------------------->8---------------------
>
> we inevitably see this compilation failure:
> -------------------->8---------------------
> arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
> #include <dt-bindings/net/ti-dp83867.h>
> ^
> compilation terminated.
> -------------------->8---------------------
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
> arch/arc/boot/dts/include/dt-bindings | 1 +
> 1 file changed, 1 insertion(+)
> create mode 120000 arch/arc/boot/dts/include/dt-bindings
I believe commit d5d332d3f7e8 ("devicetree: Move include prefixes from
arch to separate directory") does what you want.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] arc: Add "include chroot" for DT bindings
@ 2017-05-30 16:56 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2017-05-30 16:56 UTC (permalink / raw)
To: linux-snps-arc
On Tue, May 30, 2017 at 8:22 AM, Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
> Basically this extends
> c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> ARC where we extensively use Device Tree and there're good reasons
> to use DT bindings, especially if those are required.
>
> Otherwise on attempt to compile .dts with something like:
> -------------------->8---------------------
> #include <dt-bindings/net/ti-dp83867.h>
> -------------------->8---------------------
>
> we inevitably see this compilation failure:
> -------------------->8---------------------
> arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
> #include <dt-bindings/net/ti-dp83867.h>
> ^
> compilation terminated.
> -------------------->8---------------------
>
> Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Stephen Warren <swarren at wwwdotorg.org>
> Cc: Rob Herring <robh+dt at kernel.org>
> ---
> arch/arc/boot/dts/include/dt-bindings | 1 +
> 1 file changed, 1 insertion(+)
> create mode 120000 arch/arc/boot/dts/include/dt-bindings
I believe commit d5d332d3f7e8 ("devicetree: Move include prefixes from
arch to separate directory") does what you want.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arc: Add "include chroot" for DT bindings
2017-05-30 16:56 ` Rob Herring
@ 2017-05-30 17:04 ` Alexey Brodkin
-1 siblings, 0 replies; 8+ messages in thread
From: Alexey Brodkin @ 2017-05-30 17:04 UTC (permalink / raw)
To: robh+dt; +Cc: linux-kernel, Vineet.Gupta1, swarren, linux-snps-arc
Hi Rob,
On Tue, 2017-05-30 at 11:56 -0500, Rob Herring wrote:
> On Tue, May 30, 2017 at 8:22 AM, Alexey Brodkin
> <Alexey.Brodkin@synopsys.com> wrote:
> >
> > Basically this extends
> > c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> > ARC where we extensively use Device Tree and there're good reasons
> > to use DT bindings, especially if those are required.
> >
> > Otherwise on attempt to compile .dts with something like:
> > -------------------->8---------------------
> > #include <dt-bindings/net/ti-dp83867.h>
> > -------------------->8---------------------
> >
> > we inevitably see this compilation failure:
> > -------------------->8---------------------
> > arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
> > #include <dt-bindings/net/ti-dp83867.h>
> > ^
> > compilation terminated.
> > -------------------->8---------------------
> >
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > ---
> > arch/arc/boot/dts/include/dt-bindings | 1 +
> > 1 file changed, 1 insertion(+)
> > create mode 120000 arch/arc/boot/dts/include/dt-bindings
>
> I believe commit d5d332d3f7e8 ("devicetree: Move include prefixes from
> arch to separate directory") does what you want.
Indeed that helps!
Thanks a lot for the pointer!
-Alexey
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] arc: Add "include chroot" for DT bindings
@ 2017-05-30 17:04 ` Alexey Brodkin
0 siblings, 0 replies; 8+ messages in thread
From: Alexey Brodkin @ 2017-05-30 17:04 UTC (permalink / raw)
To: linux-snps-arc
Hi Rob,
On Tue, 2017-05-30@11:56 -0500, Rob Herring wrote:
> On Tue, May 30, 2017 at 8:22 AM, Alexey Brodkin
> <Alexey.Brodkin@synopsys.com> wrote:
> >
> > Basically this extends
> > c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> > ARC where we extensively use Device Tree and there're good reasons
> > to use DT bindings, especially if those are required.
> >
> > Otherwise on attempt to compile .dts with something like:
> > -------------------->8---------------------
> > ?#include <dt-bindings/net/ti-dp83867.h>
> > -------------------->8---------------------
> >
> > we inevitably see this compilation failure:
> > -------------------->8---------------------
> > arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
> > ?#include <dt-bindings/net/ti-dp83867.h>
> > ????????????????????????????????????????^
> > compilation terminated.
> > -------------------->8---------------------
> >
> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> > Cc: Stephen Warren <swarren at wwwdotorg.org>
> > Cc: Rob Herring <robh+dt at kernel.org>
> > ---
> > ?arch/arc/boot/dts/include/dt-bindings | 1 +
> > ?1 file changed, 1 insertion(+)
> > ?create mode 120000 arch/arc/boot/dts/include/dt-bindings
>
> I believe commit d5d332d3f7e8 ("devicetree: Move include prefixes from
> arch to separate directory") does what you want.
Indeed that helps!
Thanks a lot for the pointer!
-Alexey
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-05-30 17:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-30 13:22 [PATCH] arc: Add "include chroot" for DT bindings Alexey Brodkin
2017-05-30 13:22 ` Alexey Brodkin
2017-05-30 16:30 ` Vineet Gupta
2017-05-30 16:30 ` Vineet Gupta
2017-05-30 16:56 ` Rob Herring
2017-05-30 16:56 ` Rob Herring
2017-05-30 17:04 ` Alexey Brodkin
2017-05-30 17:04 ` Alexey Brodkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.