* [PATCH i-g-t] tests/i915: Restore some BAT coverage
@ 2019-05-22 16:31 ` Tvrtko Ursulin
0 siblings, 0 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2019-05-22 16:31 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Engine enumerated test names have changed so fast-feedback.testlist needs
to be updated. However listing all engines there won't scale. So instead
add new tests cases which iterate all engines internally.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/i915/gem_busy.c | 17 +++++++++++---
tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
tests/intel-ci/fast-feedback.testlist | 33 ++++-----------------------
3 files changed, 51 insertions(+), 32 deletions(-)
diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index 2872e7b7be62..1f2a89991b9b 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -460,6 +460,14 @@ static void basic(int fd, const struct intel_execution_engine2 *e, unsigned flag
igt_spin_free(fd, spin);
}
+static void all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ basic(i915, e, false);
+}
+
igt_main
{
const struct intel_execution_engine2 *e;
@@ -477,11 +485,14 @@ igt_main
igt_fork_hang_detector(fd);
}
+ igt_subtest("busy-all") {
+ gem_quiescent_gpu(fd);
+ all(fd);
+ }
+
__for_each_physical_engine(fd, e) {
igt_subtest_group {
- igt_subtest_f("%sbusy-%s",
- e->class == I915_ENGINE_CLASS_RENDER
- ? "basic-" : "", e->name) {
+ igt_subtest_f("busy-%s", e->name) {
gem_quiescent_gpu(fd);
basic(fd, e, false);
}
diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
index 140cbdbc66a5..24e1cb5bdaa9 100644
--- a/tests/i915/gem_exec_basic.c
+++ b/tests/i915/gem_exec_basic.c
@@ -114,6 +114,30 @@ static void gtt(int fd, uint64_t flags)
munmap(execbuf, 4096);
}
+static void all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ noop(i915, e->flags);
+}
+
+static void readonly_all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ readonly(i915, e->flags);
+}
+
+static void gtt_all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ gtt(i915, e->flags);
+}
+
igt_main
{
const struct intel_execution_engine2 *e;
@@ -126,6 +150,15 @@ igt_main
igt_fork_hang_detector(fd);
}
+ igt_subtest("all")
+ all(fd);
+
+ igt_subtest("readonly-all")
+ readonly_all(fd);
+
+ igt_subtest("gtt-all")
+ gtt_all(fd);
+
__for_each_physical_engine(fd, e) {
igt_subtest_f("basic-%s", e->name)
noop(fd, e->flags);
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 40475b1ab361..03ac6dd1eee8 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -5,7 +5,7 @@ igt@debugfs_test@read_all_entries
igt@gem_basic@bad-close
igt@gem_basic@create-close
igt@gem_basic@create-fd-close
-igt@gem_busy@basic-busy-default
+igt@gem_busy@busy-all
igt@gem_close_race@basic-process
igt@gem_close_race@basic-threads
igt@gem_cpu_reloc@basic
@@ -15,27 +15,9 @@ igt@gem_ctx_exec@basic
igt@gem_ctx_param@basic
igt@gem_ctx_param@basic-default
igt@gem_ctx_switch@basic-default
-igt@gem_exec_basic@basic-blt
-igt@gem_exec_basic@basic-bsd
-igt@gem_exec_basic@basic-bsd1
-igt@gem_exec_basic@basic-bsd2
-igt@gem_exec_basic@basic-default
-igt@gem_exec_basic@basic-render
-igt@gem_exec_basic@basic-vebox
-igt@gem_exec_basic@gtt-blt
-igt@gem_exec_basic@gtt-bsd
-igt@gem_exec_basic@gtt-bsd1
-igt@gem_exec_basic@gtt-bsd2
-igt@gem_exec_basic@gtt-default
-igt@gem_exec_basic@gtt-render
-igt@gem_exec_basic@gtt-vebox
-igt@gem_exec_basic@readonly-blt
-igt@gem_exec_basic@readonly-bsd
-igt@gem_exec_basic@readonly-bsd1
-igt@gem_exec_basic@readonly-bsd2
-igt@gem_exec_basic@readonly-default
-igt@gem_exec_basic@readonly-render
-igt@gem_exec_basic@readonly-vebox
+igt@gem_exec_basic@basic-all
+igt@gem_exec_basic@gtt-all
+igt@gem_exec_basic@readonly-all
igt@gem_exec_create@basic
igt@gem_exec_fence@basic-busy-default
igt@gem_exec_fence@basic-wait-default
@@ -74,13 +56,6 @@ igt@gem_exec_reloc@basic-write-gtt-active
igt@gem_exec_reloc@basic-write-read-active
igt@gem_exec_reloc@basic-softpin
igt@gem_exec_store@basic-all
-igt@gem_exec_store@basic-blt
-igt@gem_exec_store@basic-bsd
-igt@gem_exec_store@basic-bsd1
-igt@gem_exec_store@basic-bsd2
-igt@gem_exec_store@basic-default
-igt@gem_exec_store@basic-render
-igt@gem_exec_store@basic-vebox
igt@gem_exec_suspend@basic
igt@gem_exec_suspend@basic-s3
igt@gem_exec_suspend@basic-s4-devices
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/i915: Restore some BAT coverage
@ 2019-05-22 16:31 ` Tvrtko Ursulin
0 siblings, 0 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2019-05-22 16:31 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Engine enumerated test names have changed so fast-feedback.testlist needs
to be updated. However listing all engines there won't scale. So instead
add new tests cases which iterate all engines internally.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/i915/gem_busy.c | 17 +++++++++++---
tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
tests/intel-ci/fast-feedback.testlist | 33 ++++-----------------------
3 files changed, 51 insertions(+), 32 deletions(-)
diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index 2872e7b7be62..1f2a89991b9b 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -460,6 +460,14 @@ static void basic(int fd, const struct intel_execution_engine2 *e, unsigned flag
igt_spin_free(fd, spin);
}
+static void all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ basic(i915, e, false);
+}
+
igt_main
{
const struct intel_execution_engine2 *e;
@@ -477,11 +485,14 @@ igt_main
igt_fork_hang_detector(fd);
}
+ igt_subtest("busy-all") {
+ gem_quiescent_gpu(fd);
+ all(fd);
+ }
+
__for_each_physical_engine(fd, e) {
igt_subtest_group {
- igt_subtest_f("%sbusy-%s",
- e->class == I915_ENGINE_CLASS_RENDER
- ? "basic-" : "", e->name) {
+ igt_subtest_f("busy-%s", e->name) {
gem_quiescent_gpu(fd);
basic(fd, e, false);
}
diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
index 140cbdbc66a5..24e1cb5bdaa9 100644
--- a/tests/i915/gem_exec_basic.c
+++ b/tests/i915/gem_exec_basic.c
@@ -114,6 +114,30 @@ static void gtt(int fd, uint64_t flags)
munmap(execbuf, 4096);
}
+static void all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ noop(i915, e->flags);
+}
+
+static void readonly_all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ readonly(i915, e->flags);
+}
+
+static void gtt_all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ gtt(i915, e->flags);
+}
+
igt_main
{
const struct intel_execution_engine2 *e;
@@ -126,6 +150,15 @@ igt_main
igt_fork_hang_detector(fd);
}
+ igt_subtest("all")
+ all(fd);
+
+ igt_subtest("readonly-all")
+ readonly_all(fd);
+
+ igt_subtest("gtt-all")
+ gtt_all(fd);
+
__for_each_physical_engine(fd, e) {
igt_subtest_f("basic-%s", e->name)
noop(fd, e->flags);
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 40475b1ab361..03ac6dd1eee8 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -5,7 +5,7 @@ igt@debugfs_test@read_all_entries
igt@gem_basic@bad-close
igt@gem_basic@create-close
igt@gem_basic@create-fd-close
-igt@gem_busy@basic-busy-default
+igt@gem_busy@busy-all
igt@gem_close_race@basic-process
igt@gem_close_race@basic-threads
igt@gem_cpu_reloc@basic
@@ -15,27 +15,9 @@ igt@gem_ctx_exec@basic
igt@gem_ctx_param@basic
igt@gem_ctx_param@basic-default
igt@gem_ctx_switch@basic-default
-igt@gem_exec_basic@basic-blt
-igt@gem_exec_basic@basic-bsd
-igt@gem_exec_basic@basic-bsd1
-igt@gem_exec_basic@basic-bsd2
-igt@gem_exec_basic@basic-default
-igt@gem_exec_basic@basic-render
-igt@gem_exec_basic@basic-vebox
-igt@gem_exec_basic@gtt-blt
-igt@gem_exec_basic@gtt-bsd
-igt@gem_exec_basic@gtt-bsd1
-igt@gem_exec_basic@gtt-bsd2
-igt@gem_exec_basic@gtt-default
-igt@gem_exec_basic@gtt-render
-igt@gem_exec_basic@gtt-vebox
-igt@gem_exec_basic@readonly-blt
-igt@gem_exec_basic@readonly-bsd
-igt@gem_exec_basic@readonly-bsd1
-igt@gem_exec_basic@readonly-bsd2
-igt@gem_exec_basic@readonly-default
-igt@gem_exec_basic@readonly-render
-igt@gem_exec_basic@readonly-vebox
+igt@gem_exec_basic@basic-all
+igt@gem_exec_basic@gtt-all
+igt@gem_exec_basic@readonly-all
igt@gem_exec_create@basic
igt@gem_exec_fence@basic-busy-default
igt@gem_exec_fence@basic-wait-default
@@ -74,13 +56,6 @@ igt@gem_exec_reloc@basic-write-gtt-active
igt@gem_exec_reloc@basic-write-read-active
igt@gem_exec_reloc@basic-softpin
igt@gem_exec_store@basic-all
-igt@gem_exec_store@basic-blt
-igt@gem_exec_store@basic-bsd
-igt@gem_exec_store@basic-bsd1
-igt@gem_exec_store@basic-bsd2
-igt@gem_exec_store@basic-default
-igt@gem_exec_store@basic-render
-igt@gem_exec_store@basic-vebox
igt@gem_exec_suspend@basic
igt@gem_exec_suspend@basic-s3
igt@gem_exec_suspend@basic-s4-devices
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915: Restore some BAT coverage
2019-05-22 16:31 ` [igt-dev] " Tvrtko Ursulin
@ 2019-05-22 16:45 ` Chris Wilson
-1 siblings, 0 replies; 23+ messages in thread
From: Chris Wilson @ 2019-05-22 16:45 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
Quoting Tvrtko Ursulin (2019-05-22 17:31:41)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Engine enumerated test names have changed so fast-feedback.testlist needs
> to be updated. However listing all engines there won't scale. So instead
> add new tests cases which iterate all engines internally.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tests/i915/gem_busy.c | 17 +++++++++++---
> tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> tests/intel-ci/fast-feedback.testlist | 33 ++++-----------------------
> 3 files changed, 51 insertions(+), 32 deletions(-)
>
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index 2872e7b7be62..1f2a89991b9b 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -460,6 +460,14 @@ static void basic(int fd, const struct intel_execution_engine2 *e, unsigned flag
> igt_spin_free(fd, spin);
> }
>
> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + basic(i915, e, false);
> +}
> +
> igt_main
> {
> const struct intel_execution_engine2 *e;
> @@ -477,11 +485,14 @@ igt_main
> igt_fork_hang_detector(fd);
> }
>
> + igt_subtest("busy-all") {
> + gem_quiescent_gpu(fd);
> + all(fd);
> + }
Lgtm.
> +
> __for_each_physical_engine(fd, e) {
> igt_subtest_group {
> - igt_subtest_f("%sbusy-%s",
> - e->class == I915_ENGINE_CLASS_RENDER
> - ? "basic-" : "", e->name) {
> + igt_subtest_f("busy-%s", e->name) {
> gem_quiescent_gpu(fd);
> basic(fd, e, false);
> }
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index 140cbdbc66a5..24e1cb5bdaa9 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -114,6 +114,30 @@ static void gtt(int fd, uint64_t flags)
> munmap(execbuf, 4096);
> }
>
> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + noop(i915, e->flags);
> +}
> +
> +static void readonly_all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + readonly(i915, e->flags);
> +}
> +
> +static void gtt_all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + gtt(i915, e->flags);
> +}
> +
> igt_main
> {
> const struct intel_execution_engine2 *e;
> @@ -126,6 +150,15 @@ igt_main
> igt_fork_hang_detector(fd);
> }
>
> + igt_subtest("all")
> + all(fd);
> +
> + igt_subtest("readonly-all")
> + readonly_all(fd);
> +
> + igt_subtest("gtt-all")
> + gtt_all(fd);
Ok. I'd say we only need all itself in BAT. Using readonly or gtt
pointers for params only needs irregular testing and doesn't do much for
verifying driver sanity.
> +
> __for_each_physical_engine(fd, e) {
> igt_subtest_f("basic-%s", e->name)
> noop(fd, e->flags);
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 40475b1ab361..03ac6dd1eee8 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -5,7 +5,7 @@ igt@debugfs_test@read_all_entries
> igt@gem_basic@bad-close
> igt@gem_basic@create-close
> igt@gem_basic@create-fd-close
> -igt@gem_busy@basic-busy-default
> +igt@gem_busy@busy-all
> igt@gem_close_race@basic-process
> igt@gem_close_race@basic-threads
> igt@gem_cpu_reloc@basic
> @@ -15,27 +15,9 @@ igt@gem_ctx_exec@basic
> igt@gem_ctx_param@basic
> igt@gem_ctx_param@basic-default
> igt@gem_ctx_switch@basic-default
> -igt@gem_exec_basic@basic-blt
> -igt@gem_exec_basic@basic-bsd
> -igt@gem_exec_basic@basic-bsd1
> -igt@gem_exec_basic@basic-bsd2
> -igt@gem_exec_basic@basic-default
> -igt@gem_exec_basic@basic-render
> -igt@gem_exec_basic@basic-vebox
> -igt@gem_exec_basic@gtt-blt
> -igt@gem_exec_basic@gtt-bsd
> -igt@gem_exec_basic@gtt-bsd1
> -igt@gem_exec_basic@gtt-bsd2
> -igt@gem_exec_basic@gtt-default
> -igt@gem_exec_basic@gtt-render
> -igt@gem_exec_basic@gtt-vebox
> -igt@gem_exec_basic@readonly-blt
> -igt@gem_exec_basic@readonly-bsd
> -igt@gem_exec_basic@readonly-bsd1
> -igt@gem_exec_basic@readonly-bsd2
> -igt@gem_exec_basic@readonly-default
> -igt@gem_exec_basic@readonly-render
> -igt@gem_exec_basic@readonly-vebox
> +igt@gem_exec_basic@basic-all
> +igt@gem_exec_basic@gtt-all
> +igt@gem_exec_basic@readonly-all
I'd vote for only basic-all
> igt@gem_exec_create@basic
> igt@gem_exec_fence@basic-busy-default
> igt@gem_exec_fence@basic-wait-default
> @@ -74,13 +56,6 @@ igt@gem_exec_reloc@basic-write-gtt-active
> igt@gem_exec_reloc@basic-write-read-active
> igt@gem_exec_reloc@basic-softpin
> igt@gem_exec_store@basic-all
> -igt@gem_exec_store@basic-blt
> -igt@gem_exec_store@basic-bsd
> -igt@gem_exec_store@basic-bsd1
> -igt@gem_exec_store@basic-bsd2
> -igt@gem_exec_store@basic-default
> -igt@gem_exec_store@basic-render
> -igt@gem_exec_store@basic-vebox
> igt@gem_exec_suspend@basic
> igt@gem_exec_suspend@basic-s3
> igt@gem_exec_suspend@basic-s4-devices
Nevertheless,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915: Restore some BAT coverage
@ 2019-05-22 16:45 ` Chris Wilson
0 siblings, 0 replies; 23+ messages in thread
From: Chris Wilson @ 2019-05-22 16:45 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
Quoting Tvrtko Ursulin (2019-05-22 17:31:41)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Engine enumerated test names have changed so fast-feedback.testlist needs
> to be updated. However listing all engines there won't scale. So instead
> add new tests cases which iterate all engines internally.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tests/i915/gem_busy.c | 17 +++++++++++---
> tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> tests/intel-ci/fast-feedback.testlist | 33 ++++-----------------------
> 3 files changed, 51 insertions(+), 32 deletions(-)
>
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index 2872e7b7be62..1f2a89991b9b 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -460,6 +460,14 @@ static void basic(int fd, const struct intel_execution_engine2 *e, unsigned flag
> igt_spin_free(fd, spin);
> }
>
> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + basic(i915, e, false);
> +}
> +
> igt_main
> {
> const struct intel_execution_engine2 *e;
> @@ -477,11 +485,14 @@ igt_main
> igt_fork_hang_detector(fd);
> }
>
> + igt_subtest("busy-all") {
> + gem_quiescent_gpu(fd);
> + all(fd);
> + }
Lgtm.
> +
> __for_each_physical_engine(fd, e) {
> igt_subtest_group {
> - igt_subtest_f("%sbusy-%s",
> - e->class == I915_ENGINE_CLASS_RENDER
> - ? "basic-" : "", e->name) {
> + igt_subtest_f("busy-%s", e->name) {
> gem_quiescent_gpu(fd);
> basic(fd, e, false);
> }
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index 140cbdbc66a5..24e1cb5bdaa9 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -114,6 +114,30 @@ static void gtt(int fd, uint64_t flags)
> munmap(execbuf, 4096);
> }
>
> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + noop(i915, e->flags);
> +}
> +
> +static void readonly_all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + readonly(i915, e->flags);
> +}
> +
> +static void gtt_all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + gtt(i915, e->flags);
> +}
> +
> igt_main
> {
> const struct intel_execution_engine2 *e;
> @@ -126,6 +150,15 @@ igt_main
> igt_fork_hang_detector(fd);
> }
>
> + igt_subtest("all")
> + all(fd);
> +
> + igt_subtest("readonly-all")
> + readonly_all(fd);
> +
> + igt_subtest("gtt-all")
> + gtt_all(fd);
Ok. I'd say we only need all itself in BAT. Using readonly or gtt
pointers for params only needs irregular testing and doesn't do much for
verifying driver sanity.
> +
> __for_each_physical_engine(fd, e) {
> igt_subtest_f("basic-%s", e->name)
> noop(fd, e->flags);
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 40475b1ab361..03ac6dd1eee8 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -5,7 +5,7 @@ igt@debugfs_test@read_all_entries
> igt@gem_basic@bad-close
> igt@gem_basic@create-close
> igt@gem_basic@create-fd-close
> -igt@gem_busy@basic-busy-default
> +igt@gem_busy@busy-all
> igt@gem_close_race@basic-process
> igt@gem_close_race@basic-threads
> igt@gem_cpu_reloc@basic
> @@ -15,27 +15,9 @@ igt@gem_ctx_exec@basic
> igt@gem_ctx_param@basic
> igt@gem_ctx_param@basic-default
> igt@gem_ctx_switch@basic-default
> -igt@gem_exec_basic@basic-blt
> -igt@gem_exec_basic@basic-bsd
> -igt@gem_exec_basic@basic-bsd1
> -igt@gem_exec_basic@basic-bsd2
> -igt@gem_exec_basic@basic-default
> -igt@gem_exec_basic@basic-render
> -igt@gem_exec_basic@basic-vebox
> -igt@gem_exec_basic@gtt-blt
> -igt@gem_exec_basic@gtt-bsd
> -igt@gem_exec_basic@gtt-bsd1
> -igt@gem_exec_basic@gtt-bsd2
> -igt@gem_exec_basic@gtt-default
> -igt@gem_exec_basic@gtt-render
> -igt@gem_exec_basic@gtt-vebox
> -igt@gem_exec_basic@readonly-blt
> -igt@gem_exec_basic@readonly-bsd
> -igt@gem_exec_basic@readonly-bsd1
> -igt@gem_exec_basic@readonly-bsd2
> -igt@gem_exec_basic@readonly-default
> -igt@gem_exec_basic@readonly-render
> -igt@gem_exec_basic@readonly-vebox
> +igt@gem_exec_basic@basic-all
> +igt@gem_exec_basic@gtt-all
> +igt@gem_exec_basic@readonly-all
I'd vote for only basic-all
> igt@gem_exec_create@basic
> igt@gem_exec_fence@basic-busy-default
> igt@gem_exec_fence@basic-wait-default
> @@ -74,13 +56,6 @@ igt@gem_exec_reloc@basic-write-gtt-active
> igt@gem_exec_reloc@basic-write-read-active
> igt@gem_exec_reloc@basic-softpin
> igt@gem_exec_store@basic-all
> -igt@gem_exec_store@basic-blt
> -igt@gem_exec_store@basic-bsd
> -igt@gem_exec_store@basic-bsd1
> -igt@gem_exec_store@basic-bsd2
> -igt@gem_exec_store@basic-default
> -igt@gem_exec_store@basic-render
> -igt@gem_exec_store@basic-vebox
> igt@gem_exec_suspend@basic
> igt@gem_exec_suspend@basic-s3
> igt@gem_exec_suspend@basic-s4-devices
Nevertheless,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915: Restore some BAT coverage
2019-05-22 16:31 ` [igt-dev] " Tvrtko Ursulin
(?)
(?)
@ 2019-05-22 18:48 ` Patchwork
-1 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2019-05-22 18:48 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
== Series Details ==
Series: tests/i915: Restore some BAT coverage
URL : https://patchwork.freedesktop.org/series/60996/
State : success
== Summary ==
CI Bug Log - changes from IGT_5005 -> IGTPW_3033
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60996/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3033:
### IGT changes ###
#### Possible regressions ####
* {igt@gem_busy@busy-all} (NEW):
- fi-pnv-d510: NOTRUN -> [WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/fi-pnv-d510/igt@gem_busy@busy-all.html
- fi-blb-e6850: NOTRUN -> [WARN][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/fi-blb-e6850/igt@gem_busy@busy-all.html
New tests
---------
New tests have been introduced between IGT_5005 and IGTPW_3033:
### New IGT tests (4) ###
* igt@gem_busy@busy-all:
- Statuses : 42 pass(s) 2 skip(s) 2 warn(s)
- Exec time: [0.0, 0.02] s
* igt@gem_exec_basic@basic-all:
- Statuses :
- Exec time: [None] s
* igt@gem_exec_basic@gtt-all:
- Statuses : 46 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_exec_basic@readonly-all:
- Statuses : 46 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_3033 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][3] -> [FAIL][4] ([fdo#108511])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-7567u: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/fi-kbl-7567u/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/fi-kbl-7567u/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
- fi-blb-e6850: [PASS][7] -> [INCOMPLETE][8] ([fdo#107718])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
#### Possible fixes ####
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: [INCOMPLETE][9] ([fdo#108602] / [fdo#108744]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
- {fi-icl-y}: [INCOMPLETE][11] ([fdo#107713] / [fdo#108569]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/fi-icl-y/igt@i915_selftest@live_hangcheck.html
- {fi-icl-dsi}: [INCOMPLETE][13] ([fdo#107713] / [fdo#108569]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
* igt@kms_frontbuffer_tracking@basic:
- {fi-icl-u2}: [FAIL][15] ([fdo#103167]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
Participating hosts (53 -> 46)
------------------------------
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5005 -> IGTPW_3033
CI_DRM_6121: 0a029524f22ca287ec7e515edc1258e7f806750c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3033: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/
IGT_5005: adf9f435a795d692e30cd6eafe26eddf4993c8ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@gem_busy@busy-all
+igt@gem_busy@busy-rcs0
+igt@gem_exec_basic@all
+igt@gem_exec_basic@gtt-all
+igt@gem_exec_basic@readonly-all
-igt@gem_busy@basic-busy-rcs0
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915: Restore some BAT coverage
2019-05-22 16:31 ` [igt-dev] " Tvrtko Ursulin
@ 2019-05-22 21:28 ` Andi Shyti
-1 siblings, 0 replies; 23+ messages in thread
From: Andi Shyti @ 2019-05-22 21:28 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx
Hi Tvrtko,
> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + basic(i915, e, false);
ops... there is an error in my previous patch.
I restored the meaining of flags because you and Chris didn't
like the boolean true/false meaning, indeed here I still check
with:
if ((flags & HANG) == 0) {
but then I forgot to update the test cases.
This means that this line needs to be
basic(i915, e, 0);
as the rest.
I'm sorry about the confusion! In any case,
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915: Restore some BAT coverage
@ 2019-05-22 21:28 ` Andi Shyti
0 siblings, 0 replies; 23+ messages in thread
From: Andi Shyti @ 2019-05-22 21:28 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx, Tvrtko Ursulin
Hi Tvrtko,
> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + basic(i915, e, false);
ops... there is an error in my previous patch.
I restored the meaining of flags because you and Chris didn't
like the boolean true/false meaning, indeed here I still check
with:
if ((flags & HANG) == 0) {
but then I forgot to update the test cases.
This means that this line needs to be
basic(i915, e, 0);
as the rest.
I'm sorry about the confusion! In any case,
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Thanks,
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
2019-05-22 16:31 ` [igt-dev] " Tvrtko Ursulin
@ 2019-05-23 6:37 ` Tvrtko Ursulin
-1 siblings, 0 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2019-05-23 6:37 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Engine enumerated test names have changed so fast-feedback.testlist needs
to be updated. However listing all engines there won't scale. So instead
add new tests cases which iterate all engines internally.
v2:
* Fix basic-all test name.
* Fix params to basic (bool false to zero).
* Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
contexts for now.
* Have only basic-all in BAT. (Chris)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
---
tests/i915/gem_busy.c | 19 +++++++++++----
tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
3 files changed, 50 insertions(+), 33 deletions(-)
diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index 781a3bfab1d1..f3ebb37a33b4 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
static bool has_extended_busy_ioctl(int fd)
{
- igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
+ igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
uint32_t read, write;
__gem_busy(fd, spin->handle, &read, &write);
@@ -460,6 +460,14 @@ static void basic(int fd, const struct intel_execution_engine2 *e, unsigned flag
igt_spin_free(fd, spin);
}
+static void all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ basic(i915, e, 0);
+}
+
igt_main
{
const struct intel_execution_engine2 *e;
@@ -477,11 +485,14 @@ igt_main
igt_fork_hang_detector(fd);
}
+ igt_subtest("busy-all") {
+ gem_quiescent_gpu(fd);
+ all(fd);
+ }
+
__for_each_physical_engine(fd, e) {
igt_subtest_group {
- igt_subtest_f("%sbusy-%s",
- e->class == I915_ENGINE_CLASS_RENDER
- ? "basic-" : "", e->name) {
+ igt_subtest_f("busy-%s", e->name) {
gem_quiescent_gpu(fd);
basic(fd, e, 0);
}
diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
index 140cbdbc66a5..1287860be3b1 100644
--- a/tests/i915/gem_exec_basic.c
+++ b/tests/i915/gem_exec_basic.c
@@ -114,6 +114,30 @@ static void gtt(int fd, uint64_t flags)
munmap(execbuf, 4096);
}
+static void all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ noop(i915, e->flags);
+}
+
+static void readonly_all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ readonly(i915, e->flags);
+}
+
+static void gtt_all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ gtt(i915, e->flags);
+}
+
igt_main
{
const struct intel_execution_engine2 *e;
@@ -126,6 +150,15 @@ igt_main
igt_fork_hang_detector(fd);
}
+ igt_subtest("basic-all")
+ all(fd);
+
+ igt_subtest("readonly-all")
+ readonly_all(fd);
+
+ igt_subtest("gtt-all")
+ gtt_all(fd);
+
__for_each_physical_engine(fd, e) {
igt_subtest_f("basic-%s", e->name)
noop(fd, e->flags);
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 40475b1ab361..58e6b5c5f882 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -5,7 +5,7 @@ igt@debugfs_test@read_all_entries
igt@gem_basic@bad-close
igt@gem_basic@create-close
igt@gem_basic@create-fd-close
-igt@gem_busy@basic-busy-default
+igt@gem_busy@busy-all
igt@gem_close_race@basic-process
igt@gem_close_race@basic-threads
igt@gem_cpu_reloc@basic
@@ -15,27 +15,7 @@ igt@gem_ctx_exec@basic
igt@gem_ctx_param@basic
igt@gem_ctx_param@basic-default
igt@gem_ctx_switch@basic-default
-igt@gem_exec_basic@basic-blt
-igt@gem_exec_basic@basic-bsd
-igt@gem_exec_basic@basic-bsd1
-igt@gem_exec_basic@basic-bsd2
-igt@gem_exec_basic@basic-default
-igt@gem_exec_basic@basic-render
-igt@gem_exec_basic@basic-vebox
-igt@gem_exec_basic@gtt-blt
-igt@gem_exec_basic@gtt-bsd
-igt@gem_exec_basic@gtt-bsd1
-igt@gem_exec_basic@gtt-bsd2
-igt@gem_exec_basic@gtt-default
-igt@gem_exec_basic@gtt-render
-igt@gem_exec_basic@gtt-vebox
-igt@gem_exec_basic@readonly-blt
-igt@gem_exec_basic@readonly-bsd
-igt@gem_exec_basic@readonly-bsd1
-igt@gem_exec_basic@readonly-bsd2
-igt@gem_exec_basic@readonly-default
-igt@gem_exec_basic@readonly-render
-igt@gem_exec_basic@readonly-vebox
+igt@gem_exec_basic@basic-all
igt@gem_exec_create@basic
igt@gem_exec_fence@basic-busy-default
igt@gem_exec_fence@basic-wait-default
@@ -74,13 +54,6 @@ igt@gem_exec_reloc@basic-write-gtt-active
igt@gem_exec_reloc@basic-write-read-active
igt@gem_exec_reloc@basic-softpin
igt@gem_exec_store@basic-all
-igt@gem_exec_store@basic-blt
-igt@gem_exec_store@basic-bsd
-igt@gem_exec_store@basic-bsd1
-igt@gem_exec_store@basic-bsd2
-igt@gem_exec_store@basic-default
-igt@gem_exec_store@basic-render
-igt@gem_exec_store@basic-vebox
igt@gem_exec_suspend@basic
igt@gem_exec_suspend@basic-s3
igt@gem_exec_suspend@basic-s4-devices
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
@ 2019-05-23 6:37 ` Tvrtko Ursulin
0 siblings, 0 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2019-05-23 6:37 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Engine enumerated test names have changed so fast-feedback.testlist needs
to be updated. However listing all engines there won't scale. So instead
add new tests cases which iterate all engines internally.
v2:
* Fix basic-all test name.
* Fix params to basic (bool false to zero).
* Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
contexts for now.
* Have only basic-all in BAT. (Chris)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
---
tests/i915/gem_busy.c | 19 +++++++++++----
tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
3 files changed, 50 insertions(+), 33 deletions(-)
diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index 781a3bfab1d1..f3ebb37a33b4 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
static bool has_extended_busy_ioctl(int fd)
{
- igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
+ igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
uint32_t read, write;
__gem_busy(fd, spin->handle, &read, &write);
@@ -460,6 +460,14 @@ static void basic(int fd, const struct intel_execution_engine2 *e, unsigned flag
igt_spin_free(fd, spin);
}
+static void all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ basic(i915, e, 0);
+}
+
igt_main
{
const struct intel_execution_engine2 *e;
@@ -477,11 +485,14 @@ igt_main
igt_fork_hang_detector(fd);
}
+ igt_subtest("busy-all") {
+ gem_quiescent_gpu(fd);
+ all(fd);
+ }
+
__for_each_physical_engine(fd, e) {
igt_subtest_group {
- igt_subtest_f("%sbusy-%s",
- e->class == I915_ENGINE_CLASS_RENDER
- ? "basic-" : "", e->name) {
+ igt_subtest_f("busy-%s", e->name) {
gem_quiescent_gpu(fd);
basic(fd, e, 0);
}
diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
index 140cbdbc66a5..1287860be3b1 100644
--- a/tests/i915/gem_exec_basic.c
+++ b/tests/i915/gem_exec_basic.c
@@ -114,6 +114,30 @@ static void gtt(int fd, uint64_t flags)
munmap(execbuf, 4096);
}
+static void all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ noop(i915, e->flags);
+}
+
+static void readonly_all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ readonly(i915, e->flags);
+}
+
+static void gtt_all(int i915)
+{
+ const struct intel_execution_engine2 *e;
+
+ __for_each_physical_engine(i915, e)
+ gtt(i915, e->flags);
+}
+
igt_main
{
const struct intel_execution_engine2 *e;
@@ -126,6 +150,15 @@ igt_main
igt_fork_hang_detector(fd);
}
+ igt_subtest("basic-all")
+ all(fd);
+
+ igt_subtest("readonly-all")
+ readonly_all(fd);
+
+ igt_subtest("gtt-all")
+ gtt_all(fd);
+
__for_each_physical_engine(fd, e) {
igt_subtest_f("basic-%s", e->name)
noop(fd, e->flags);
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 40475b1ab361..58e6b5c5f882 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -5,7 +5,7 @@ igt@debugfs_test@read_all_entries
igt@gem_basic@bad-close
igt@gem_basic@create-close
igt@gem_basic@create-fd-close
-igt@gem_busy@basic-busy-default
+igt@gem_busy@busy-all
igt@gem_close_race@basic-process
igt@gem_close_race@basic-threads
igt@gem_cpu_reloc@basic
@@ -15,27 +15,7 @@ igt@gem_ctx_exec@basic
igt@gem_ctx_param@basic
igt@gem_ctx_param@basic-default
igt@gem_ctx_switch@basic-default
-igt@gem_exec_basic@basic-blt
-igt@gem_exec_basic@basic-bsd
-igt@gem_exec_basic@basic-bsd1
-igt@gem_exec_basic@basic-bsd2
-igt@gem_exec_basic@basic-default
-igt@gem_exec_basic@basic-render
-igt@gem_exec_basic@basic-vebox
-igt@gem_exec_basic@gtt-blt
-igt@gem_exec_basic@gtt-bsd
-igt@gem_exec_basic@gtt-bsd1
-igt@gem_exec_basic@gtt-bsd2
-igt@gem_exec_basic@gtt-default
-igt@gem_exec_basic@gtt-render
-igt@gem_exec_basic@gtt-vebox
-igt@gem_exec_basic@readonly-blt
-igt@gem_exec_basic@readonly-bsd
-igt@gem_exec_basic@readonly-bsd1
-igt@gem_exec_basic@readonly-bsd2
-igt@gem_exec_basic@readonly-default
-igt@gem_exec_basic@readonly-render
-igt@gem_exec_basic@readonly-vebox
+igt@gem_exec_basic@basic-all
igt@gem_exec_create@basic
igt@gem_exec_fence@basic-busy-default
igt@gem_exec_fence@basic-wait-default
@@ -74,13 +54,6 @@ igt@gem_exec_reloc@basic-write-gtt-active
igt@gem_exec_reloc@basic-write-read-active
igt@gem_exec_reloc@basic-softpin
igt@gem_exec_store@basic-all
-igt@gem_exec_store@basic-blt
-igt@gem_exec_store@basic-bsd
-igt@gem_exec_store@basic-bsd1
-igt@gem_exec_store@basic-bsd2
-igt@gem_exec_store@basic-default
-igt@gem_exec_store@basic-render
-igt@gem_exec_store@basic-vebox
igt@gem_exec_suspend@basic
igt@gem_exec_suspend@basic-s3
igt@gem_exec_suspend@basic-s4-devices
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
2019-05-23 6:37 ` [igt-dev] " Tvrtko Ursulin
@ 2019-05-23 6:43 ` Tvrtko Ursulin
-1 siblings, 0 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2019-05-23 6:43 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
On 23/05/2019 07:37, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Engine enumerated test names have changed so fast-feedback.testlist needs
> to be updated. However listing all engines there won't scale. So instead
> add new tests cases which iterate all engines internally.
>
> v2:
> * Fix basic-all test name.
> * Fix params to basic (bool false to zero).
> * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
> contexts for now.
> * Have only basic-all in BAT. (Chris)
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
> Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
> ---
> tests/i915/gem_busy.c | 19 +++++++++++----
> tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
> 3 files changed, 50 insertions(+), 33 deletions(-)
>
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index 781a3bfab1d1..f3ebb37a33b4 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
>
> static bool has_extended_busy_ioctl(int fd)
> {
> - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
> + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
(This fails on platforms with only rcs0 (no other engines) due context
has a map now, and I915_EXEC_RENDER == 1 == -EINVAL.)
We need to come up with a robust and easy to remember solution for
dealing with the fact contexts are stateful now and
__for_each_physical_engine iterator configures the default one.
Could end game for test conversion be to stop passing in eb.flags to
igt_spin_new and do class:instance instead? That would enable dummyload
to unambiguously know what to use, depending on get_engines query. Until
then it is fiddling and guess work.
But are there more tests which could be affected? Must be..
Or we drop the aspiration to support
non-engine-discovery-and-no-context-map kernels?
Regards,
Tvrtko
> uint32_t read, write;
>
> __gem_busy(fd, spin->handle, &read, &write);
> @@ -460,6 +460,14 @@ static void basic(int fd, const struct intel_execution_engine2 *e, unsigned flag
> igt_spin_free(fd, spin);
> }
>
> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + basic(i915, e, 0);
> +}
> +
> igt_main
> {
> const struct intel_execution_engine2 *e;
> @@ -477,11 +485,14 @@ igt_main
> igt_fork_hang_detector(fd);
> }
>
> + igt_subtest("busy-all") {
> + gem_quiescent_gpu(fd);
> + all(fd);
> + }
> +
> __for_each_physical_engine(fd, e) {
> igt_subtest_group {
> - igt_subtest_f("%sbusy-%s",
> - e->class == I915_ENGINE_CLASS_RENDER
> - ? "basic-" : "", e->name) {
> + igt_subtest_f("busy-%s", e->name) {
> gem_quiescent_gpu(fd);
> basic(fd, e, 0);
> }
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index 140cbdbc66a5..1287860be3b1 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -114,6 +114,30 @@ static void gtt(int fd, uint64_t flags)
> munmap(execbuf, 4096);
> }
>
> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + noop(i915, e->flags);
> +}
> +
> +static void readonly_all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + readonly(i915, e->flags);
> +}
> +
> +static void gtt_all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + gtt(i915, e->flags);
> +}
> +
> igt_main
> {
> const struct intel_execution_engine2 *e;
> @@ -126,6 +150,15 @@ igt_main
> igt_fork_hang_detector(fd);
> }
>
> + igt_subtest("basic-all")
> + all(fd);
> +
> + igt_subtest("readonly-all")
> + readonly_all(fd);
> +
> + igt_subtest("gtt-all")
> + gtt_all(fd);
> +
> __for_each_physical_engine(fd, e) {
> igt_subtest_f("basic-%s", e->name)
> noop(fd, e->flags);
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 40475b1ab361..58e6b5c5f882 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -5,7 +5,7 @@ igt@debugfs_test@read_all_entries
> igt@gem_basic@bad-close
> igt@gem_basic@create-close
> igt@gem_basic@create-fd-close
> -igt@gem_busy@basic-busy-default
> +igt@gem_busy@busy-all
> igt@gem_close_race@basic-process
> igt@gem_close_race@basic-threads
> igt@gem_cpu_reloc@basic
> @@ -15,27 +15,7 @@ igt@gem_ctx_exec@basic
> igt@gem_ctx_param@basic
> igt@gem_ctx_param@basic-default
> igt@gem_ctx_switch@basic-default
> -igt@gem_exec_basic@basic-blt
> -igt@gem_exec_basic@basic-bsd
> -igt@gem_exec_basic@basic-bsd1
> -igt@gem_exec_basic@basic-bsd2
> -igt@gem_exec_basic@basic-default
> -igt@gem_exec_basic@basic-render
> -igt@gem_exec_basic@basic-vebox
> -igt@gem_exec_basic@gtt-blt
> -igt@gem_exec_basic@gtt-bsd
> -igt@gem_exec_basic@gtt-bsd1
> -igt@gem_exec_basic@gtt-bsd2
> -igt@gem_exec_basic@gtt-default
> -igt@gem_exec_basic@gtt-render
> -igt@gem_exec_basic@gtt-vebox
> -igt@gem_exec_basic@readonly-blt
> -igt@gem_exec_basic@readonly-bsd
> -igt@gem_exec_basic@readonly-bsd1
> -igt@gem_exec_basic@readonly-bsd2
> -igt@gem_exec_basic@readonly-default
> -igt@gem_exec_basic@readonly-render
> -igt@gem_exec_basic@readonly-vebox
> +igt@gem_exec_basic@basic-all
> igt@gem_exec_create@basic
> igt@gem_exec_fence@basic-busy-default
> igt@gem_exec_fence@basic-wait-default
> @@ -74,13 +54,6 @@ igt@gem_exec_reloc@basic-write-gtt-active
> igt@gem_exec_reloc@basic-write-read-active
> igt@gem_exec_reloc@basic-softpin
> igt@gem_exec_store@basic-all
> -igt@gem_exec_store@basic-blt
> -igt@gem_exec_store@basic-bsd
> -igt@gem_exec_store@basic-bsd1
> -igt@gem_exec_store@basic-bsd2
> -igt@gem_exec_store@basic-default
> -igt@gem_exec_store@basic-render
> -igt@gem_exec_store@basic-vebox
> igt@gem_exec_suspend@basic
> igt@gem_exec_suspend@basic-s3
> igt@gem_exec_suspend@basic-s4-devices
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
@ 2019-05-23 6:43 ` Tvrtko Ursulin
0 siblings, 0 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2019-05-23 6:43 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
On 23/05/2019 07:37, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Engine enumerated test names have changed so fast-feedback.testlist needs
> to be updated. However listing all engines there won't scale. So instead
> add new tests cases which iterate all engines internally.
>
> v2:
> * Fix basic-all test name.
> * Fix params to basic (bool false to zero).
> * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
> contexts for now.
> * Have only basic-all in BAT. (Chris)
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
> Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
> ---
> tests/i915/gem_busy.c | 19 +++++++++++----
> tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
> 3 files changed, 50 insertions(+), 33 deletions(-)
>
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index 781a3bfab1d1..f3ebb37a33b4 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
>
> static bool has_extended_busy_ioctl(int fd)
> {
> - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
> + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
(This fails on platforms with only rcs0 (no other engines) due context
has a map now, and I915_EXEC_RENDER == 1 == -EINVAL.)
We need to come up with a robust and easy to remember solution for
dealing with the fact contexts are stateful now and
__for_each_physical_engine iterator configures the default one.
Could end game for test conversion be to stop passing in eb.flags to
igt_spin_new and do class:instance instead? That would enable dummyload
to unambiguously know what to use, depending on get_engines query. Until
then it is fiddling and guess work.
But are there more tests which could be affected? Must be..
Or we drop the aspiration to support
non-engine-discovery-and-no-context-map kernels?
Regards,
Tvrtko
> uint32_t read, write;
>
> __gem_busy(fd, spin->handle, &read, &write);
> @@ -460,6 +460,14 @@ static void basic(int fd, const struct intel_execution_engine2 *e, unsigned flag
> igt_spin_free(fd, spin);
> }
>
> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + basic(i915, e, 0);
> +}
> +
> igt_main
> {
> const struct intel_execution_engine2 *e;
> @@ -477,11 +485,14 @@ igt_main
> igt_fork_hang_detector(fd);
> }
>
> + igt_subtest("busy-all") {
> + gem_quiescent_gpu(fd);
> + all(fd);
> + }
> +
> __for_each_physical_engine(fd, e) {
> igt_subtest_group {
> - igt_subtest_f("%sbusy-%s",
> - e->class == I915_ENGINE_CLASS_RENDER
> - ? "basic-" : "", e->name) {
> + igt_subtest_f("busy-%s", e->name) {
> gem_quiescent_gpu(fd);
> basic(fd, e, 0);
> }
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index 140cbdbc66a5..1287860be3b1 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -114,6 +114,30 @@ static void gtt(int fd, uint64_t flags)
> munmap(execbuf, 4096);
> }
>
> +static void all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + noop(i915, e->flags);
> +}
> +
> +static void readonly_all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + readonly(i915, e->flags);
> +}
> +
> +static void gtt_all(int i915)
> +{
> + const struct intel_execution_engine2 *e;
> +
> + __for_each_physical_engine(i915, e)
> + gtt(i915, e->flags);
> +}
> +
> igt_main
> {
> const struct intel_execution_engine2 *e;
> @@ -126,6 +150,15 @@ igt_main
> igt_fork_hang_detector(fd);
> }
>
> + igt_subtest("basic-all")
> + all(fd);
> +
> + igt_subtest("readonly-all")
> + readonly_all(fd);
> +
> + igt_subtest("gtt-all")
> + gtt_all(fd);
> +
> __for_each_physical_engine(fd, e) {
> igt_subtest_f("basic-%s", e->name)
> noop(fd, e->flags);
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 40475b1ab361..58e6b5c5f882 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -5,7 +5,7 @@ igt@debugfs_test@read_all_entries
> igt@gem_basic@bad-close
> igt@gem_basic@create-close
> igt@gem_basic@create-fd-close
> -igt@gem_busy@basic-busy-default
> +igt@gem_busy@busy-all
> igt@gem_close_race@basic-process
> igt@gem_close_race@basic-threads
> igt@gem_cpu_reloc@basic
> @@ -15,27 +15,7 @@ igt@gem_ctx_exec@basic
> igt@gem_ctx_param@basic
> igt@gem_ctx_param@basic-default
> igt@gem_ctx_switch@basic-default
> -igt@gem_exec_basic@basic-blt
> -igt@gem_exec_basic@basic-bsd
> -igt@gem_exec_basic@basic-bsd1
> -igt@gem_exec_basic@basic-bsd2
> -igt@gem_exec_basic@basic-default
> -igt@gem_exec_basic@basic-render
> -igt@gem_exec_basic@basic-vebox
> -igt@gem_exec_basic@gtt-blt
> -igt@gem_exec_basic@gtt-bsd
> -igt@gem_exec_basic@gtt-bsd1
> -igt@gem_exec_basic@gtt-bsd2
> -igt@gem_exec_basic@gtt-default
> -igt@gem_exec_basic@gtt-render
> -igt@gem_exec_basic@gtt-vebox
> -igt@gem_exec_basic@readonly-blt
> -igt@gem_exec_basic@readonly-bsd
> -igt@gem_exec_basic@readonly-bsd1
> -igt@gem_exec_basic@readonly-bsd2
> -igt@gem_exec_basic@readonly-default
> -igt@gem_exec_basic@readonly-render
> -igt@gem_exec_basic@readonly-vebox
> +igt@gem_exec_basic@basic-all
> igt@gem_exec_create@basic
> igt@gem_exec_fence@basic-busy-default
> igt@gem_exec_fence@basic-wait-default
> @@ -74,13 +54,6 @@ igt@gem_exec_reloc@basic-write-gtt-active
> igt@gem_exec_reloc@basic-write-read-active
> igt@gem_exec_reloc@basic-softpin
> igt@gem_exec_store@basic-all
> -igt@gem_exec_store@basic-blt
> -igt@gem_exec_store@basic-bsd
> -igt@gem_exec_store@basic-bsd1
> -igt@gem_exec_store@basic-bsd2
> -igt@gem_exec_store@basic-default
> -igt@gem_exec_store@basic-render
> -igt@gem_exec_store@basic-vebox
> igt@gem_exec_suspend@basic
> igt@gem_exec_suspend@basic-s3
> igt@gem_exec_suspend@basic-s4-devices
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
2019-05-23 6:43 ` Tvrtko Ursulin
@ 2019-05-23 6:58 ` Chris Wilson
-1 siblings, 0 replies; 23+ messages in thread
From: Chris Wilson @ 2019-05-23 6:58 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
Quoting Tvrtko Ursulin (2019-05-23 07:43:12)
>
> On 23/05/2019 07:37, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >
> > Engine enumerated test names have changed so fast-feedback.testlist needs
> > to be updated. However listing all engines there won't scale. So instead
> > add new tests cases which iterate all engines internally.
> >
> > v2:
> > * Fix basic-all test name.
> > * Fix params to basic (bool false to zero).
> > * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
> > contexts for now.
> > * Have only basic-all in BAT. (Chris)
> >
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
> > Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
> > ---
> > tests/i915/gem_busy.c | 19 +++++++++++----
> > tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> > tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
> > 3 files changed, 50 insertions(+), 33 deletions(-)
> >
> > diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> > index 781a3bfab1d1..f3ebb37a33b4 100644
> > --- a/tests/i915/gem_busy.c
> > +++ b/tests/i915/gem_busy.c
> > @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
> >
> > static bool has_extended_busy_ioctl(int fd)
> > {
> > - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
> > + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
>
> (This fails on platforms with only rcs0 (no other engines) due context
> has a map now, and I915_EXEC_RENDER == 1 == -EINVAL.)
In which case, it probably should be a plain 0 as it no longer has the
old EXEC_RING semantics but is just an index, i.e. igt_spin_new(fd);
> We need to come up with a robust and easy to remember solution for
> dealing with the fact contexts are stateful now and
> __for_each_physical_engine iterator configures the default one.
>
> Could end game for test conversion be to stop passing in eb.flags to
> igt_spin_new and do class:instance instead? That would enable dummyload
> to unambiguously know what to use, depending on get_engines query.
Speak to Mika, we abuse igt_spin_t much more by resubmitting the same
dummyload to multiple engines and contexts.
> Until
> then it is fiddling and guess work.
Hmm, but it shouldn't be. We pass both context and engine to
igt_spin_new(). It is fully under the caller's control. What has
happened is that we've changed the caller's context...
> But are there more tests which could be affected? Must be..
>
> Or we drop the aspiration to support
> non-engine-discovery-and-no-context-map kernels?
igt must be able to run on linus and drm-tip, at the very least.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
@ 2019-05-23 6:58 ` Chris Wilson
0 siblings, 0 replies; 23+ messages in thread
From: Chris Wilson @ 2019-05-23 6:58 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
Quoting Tvrtko Ursulin (2019-05-23 07:43:12)
>
> On 23/05/2019 07:37, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >
> > Engine enumerated test names have changed so fast-feedback.testlist needs
> > to be updated. However listing all engines there won't scale. So instead
> > add new tests cases which iterate all engines internally.
> >
> > v2:
> > * Fix basic-all test name.
> > * Fix params to basic (bool false to zero).
> > * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
> > contexts for now.
> > * Have only basic-all in BAT. (Chris)
> >
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
> > Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
> > ---
> > tests/i915/gem_busy.c | 19 +++++++++++----
> > tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> > tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
> > 3 files changed, 50 insertions(+), 33 deletions(-)
> >
> > diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> > index 781a3bfab1d1..f3ebb37a33b4 100644
> > --- a/tests/i915/gem_busy.c
> > +++ b/tests/i915/gem_busy.c
> > @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
> >
> > static bool has_extended_busy_ioctl(int fd)
> > {
> > - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
> > + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
>
> (This fails on platforms with only rcs0 (no other engines) due context
> has a map now, and I915_EXEC_RENDER == 1 == -EINVAL.)
In which case, it probably should be a plain 0 as it no longer has the
old EXEC_RING semantics but is just an index, i.e. igt_spin_new(fd);
> We need to come up with a robust and easy to remember solution for
> dealing with the fact contexts are stateful now and
> __for_each_physical_engine iterator configures the default one.
>
> Could end game for test conversion be to stop passing in eb.flags to
> igt_spin_new and do class:instance instead? That would enable dummyload
> to unambiguously know what to use, depending on get_engines query.
Speak to Mika, we abuse igt_spin_t much more by resubmitting the same
dummyload to multiple engines and contexts.
> Until
> then it is fiddling and guess work.
Hmm, but it shouldn't be. We pass both context and engine to
igt_spin_new(). It is fully under the caller's control. What has
happened is that we've changed the caller's context...
> But are there more tests which could be affected? Must be..
>
> Or we drop the aspiration to support
> non-engine-discovery-and-no-context-map kernels?
igt must be able to run on linus and drm-tip, at the very least.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/i915: Restore some BAT coverage (rev2)
2019-05-22 16:31 ` [igt-dev] " Tvrtko Ursulin
` (4 preceding siblings ...)
(?)
@ 2019-05-23 7:30 ` Patchwork
-1 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2019-05-23 7:30 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
== Series Details ==
Series: tests/i915: Restore some BAT coverage (rev2)
URL : https://patchwork.freedesktop.org/series/60996/
State : failure
== Summary ==
CI Bug Log - changes from IGT_5006 -> IGTPW_3036
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3036 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3036, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60996/revisions/2/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3036:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- fi-snb-2600: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3036/fi-snb-2600/igt@runner@aborted.html
New tests
---------
New tests have been introduced between IGT_5006 and IGTPW_3036:
### New IGT tests (2) ###
* igt@gem_busy@busy-all:
- Statuses : 43 pass(s) 2 skip(s)
- Exec time: [0.0, 0.01] s
* igt@gem_exec_basic@basic-all:
- Statuses : 45 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_3036 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- {fi-icl-u3}: [DMESG-WARN][2] ([fdo#107724]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5006/fi-icl-u3/igt@i915_module_load@reload-no-display.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3036/fi-icl-u3/igt@i915_module_load@reload-no-display.html
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: [DMESG-WARN][4] ([fdo#107709]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5006/fi-bsw-kefka/igt@i915_selftest@live_evict.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3036/fi-bsw-kefka/igt@i915_selftest@live_evict.html
* igt@kms_frontbuffer_tracking@basic:
- {fi-icl-u2}: [FAIL][6] ([fdo#103167]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5006/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3036/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
#### Warnings ####
* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: [DMESG-FAIL][8] ([fdo#110620]) -> [FAIL][9] ([fdo#110623])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5006/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3036/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#110620]: https://bugs.freedesktop.org/show_bug.cgi?id=110620
[fdo#110623]: https://bugs.freedesktop.org/show_bug.cgi?id=110623
Participating hosts (51 -> 45)
------------------------------
Additional (1): fi-blb-e6850
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5006 -> IGTPW_3036
CI_DRM_6126: 307cedb7b907ee533bf9e746d0e06bea04f2722b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3036: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3036/
IGT_5006: 95d22d5fece7af1448e3b533228c9298080d26e7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@gem_busy@busy-all
+igt@gem_busy@busy-rcs0
+igt@gem_exec_basic@basic-all
+igt@gem_exec_basic@gtt-all
+igt@gem_exec_basic@readonly-all
-igt@gem_busy@basic-busy-rcs0
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3036/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915: Restore some BAT coverage (rev3)
2019-05-22 16:31 ` [igt-dev] " Tvrtko Ursulin
` (5 preceding siblings ...)
(?)
@ 2019-05-23 11:00 ` Patchwork
-1 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2019-05-23 11:00 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
== Series Details ==
Series: tests/i915: Restore some BAT coverage (rev3)
URL : https://patchwork.freedesktop.org/series/60996/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6128 -> IGTPW_3042
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60996/revisions/3/mbox/
New tests
---------
New tests have been introduced between CI_DRM_6128 and IGTPW_3042:
### New IGT tests (2) ###
* igt@gem_busy@busy-all:
- Statuses : 41 pass(s) 2 skip(s)
- Exec time: [0.0, 0.02] s
* igt@gem_exec_basic@basic-all:
- Statuses : 43 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_3042 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][1] -> [DMESG-FAIL][2] ([fdo#110235])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [INCOMPLETE][3] ([fdo#107718]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [DMESG-WARN][5] ([fdo#105541]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_hangcheck:
- {fi-icl-u3}: [INCOMPLETE][7] ([fdo#107713] / [fdo#108569]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[fdo#110718]: https://bugs.freedesktop.org/show_bug.cgi?id=110718
Participating hosts (52 -> 43)
------------------------------
Additional (1): fi-hsw-peppy
Missing (10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-pnv-d510 fi-byt-clapper fi-bdw-samus fi-cml-u
Build changes
-------------
* IGT: IGT_5007 -> IGTPW_3042
CI_DRM_6128: 6af092dc0755f4c49722d6d074625abdfd05777f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3042: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/
IGT_5007: ed4a5515109ee83556f505a9519e33acd9518279 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@gem_busy@busy-all
+igt@gem_busy@busy-rcs0
+igt@gem_exec_basic@basic-all
+igt@gem_exec_basic@gtt-all
+igt@gem_exec_basic@readonly-all
-igt@gem_busy@basic-busy-rcs0
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
2019-05-23 6:37 ` [igt-dev] " Tvrtko Ursulin
@ 2019-05-23 11:43 ` Chris Wilson
-1 siblings, 0 replies; 23+ messages in thread
From: Chris Wilson @ 2019-05-23 11:43 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
Quoting Tvrtko Ursulin (2019-05-23 07:37:01)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Engine enumerated test names have changed so fast-feedback.testlist needs
> to be updated. However listing all engines there won't scale. So instead
> add new tests cases which iterate all engines internally.
>
> v2:
> * Fix basic-all test name.
> * Fix params to basic (bool false to zero).
> * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
> contexts for now.
> * Have only basic-all in BAT. (Chris)
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
> Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
> ---
> tests/i915/gem_busy.c | 19 +++++++++++----
> tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
> 3 files changed, 50 insertions(+), 33 deletions(-)
>
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index 781a3bfab1d1..f3ebb37a33b4 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
>
> static bool has_extended_busy_ioctl(int fd)
> {
> - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
> + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
I vote for igt_spin_t *spin = igt_spin_new(fd); for ultra-funkiness.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
@ 2019-05-23 11:43 ` Chris Wilson
0 siblings, 0 replies; 23+ messages in thread
From: Chris Wilson @ 2019-05-23 11:43 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
Quoting Tvrtko Ursulin (2019-05-23 07:37:01)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Engine enumerated test names have changed so fast-feedback.testlist needs
> to be updated. However listing all engines there won't scale. So instead
> add new tests cases which iterate all engines internally.
>
> v2:
> * Fix basic-all test name.
> * Fix params to basic (bool false to zero).
> * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
> contexts for now.
> * Have only basic-all in BAT. (Chris)
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
> Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
> ---
> tests/i915/gem_busy.c | 19 +++++++++++----
> tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
> 3 files changed, 50 insertions(+), 33 deletions(-)
>
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index 781a3bfab1d1..f3ebb37a33b4 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
>
> static bool has_extended_busy_ioctl(int fd)
> {
> - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
> + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
I vote for igt_spin_t *spin = igt_spin_new(fd); for ultra-funkiness.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
2019-05-23 6:58 ` Chris Wilson
@ 2019-05-23 12:02 ` Mika Kuoppala
-1 siblings, 0 replies; 23+ messages in thread
From: Mika Kuoppala @ 2019-05-23 12:02 UTC (permalink / raw)
To: Chris Wilson, Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Tvrtko Ursulin (2019-05-23 07:43:12)
>>
>> On 23/05/2019 07:37, Tvrtko Ursulin wrote:
>> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> >
>> > Engine enumerated test names have changed so fast-feedback.testlist needs
>> > to be updated. However listing all engines there won't scale. So instead
>> > add new tests cases which iterate all engines internally.
>> >
>> > v2:
>> > * Fix basic-all test name.
>> > * Fix params to basic (bool false to zero).
>> > * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
>> > contexts for now.
>> > * Have only basic-all in BAT. (Chris)
>> >
>> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
>> > Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
>> > ---
>> > tests/i915/gem_busy.c | 19 +++++++++++----
>> > tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
>> > tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
>> > 3 files changed, 50 insertions(+), 33 deletions(-)
>> >
>> > diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
>> > index 781a3bfab1d1..f3ebb37a33b4 100644
>> > --- a/tests/i915/gem_busy.c
>> > +++ b/tests/i915/gem_busy.c
>> > @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
>> >
>> > static bool has_extended_busy_ioctl(int fd)
>> > {
>> > - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
>> > + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
>>
>> (This fails on platforms with only rcs0 (no other engines) due context
>> has a map now, and I915_EXEC_RENDER == 1 == -EINVAL.)
>
> In which case, it probably should be a plain 0 as it no longer has the
> old EXEC_RING semantics but is just an index, i.e. igt_spin_new(fd);
>
>> We need to come up with a robust and easy to remember solution for
>> dealing with the fact contexts are stateful now and
>> __for_each_physical_engine iterator configures the default one.
>>
>> Could end game for test conversion be to stop passing in eb.flags to
>> igt_spin_new and do class:instance instead? That would enable dummyload
>> to unambiguously know what to use, depending on get_engines query.
>
> Speak to Mika, we abuse igt_spin_t much more by resubmitting the same
> dummyload to multiple engines and contexts.
I have wandered there yes. The reason for this abuse is still unclear.
We could do a clearer interface for creating spinners but is the
reusage due to latency concerns?
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
@ 2019-05-23 12:02 ` Mika Kuoppala
0 siblings, 0 replies; 23+ messages in thread
From: Mika Kuoppala @ 2019-05-23 12:02 UTC (permalink / raw)
To: Chris Wilson, Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Tvrtko Ursulin (2019-05-23 07:43:12)
>>
>> On 23/05/2019 07:37, Tvrtko Ursulin wrote:
>> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> >
>> > Engine enumerated test names have changed so fast-feedback.testlist needs
>> > to be updated. However listing all engines there won't scale. So instead
>> > add new tests cases which iterate all engines internally.
>> >
>> > v2:
>> > * Fix basic-all test name.
>> > * Fix params to basic (bool false to zero).
>> > * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
>> > contexts for now.
>> > * Have only basic-all in BAT. (Chris)
>> >
>> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
>> > Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
>> > ---
>> > tests/i915/gem_busy.c | 19 +++++++++++----
>> > tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
>> > tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
>> > 3 files changed, 50 insertions(+), 33 deletions(-)
>> >
>> > diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
>> > index 781a3bfab1d1..f3ebb37a33b4 100644
>> > --- a/tests/i915/gem_busy.c
>> > +++ b/tests/i915/gem_busy.c
>> > @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
>> >
>> > static bool has_extended_busy_ioctl(int fd)
>> > {
>> > - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
>> > + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
>>
>> (This fails on platforms with only rcs0 (no other engines) due context
>> has a map now, and I915_EXEC_RENDER == 1 == -EINVAL.)
>
> In which case, it probably should be a plain 0 as it no longer has the
> old EXEC_RING semantics but is just an index, i.e. igt_spin_new(fd);
>
>> We need to come up with a robust and easy to remember solution for
>> dealing with the fact contexts are stateful now and
>> __for_each_physical_engine iterator configures the default one.
>>
>> Could end game for test conversion be to stop passing in eb.flags to
>> igt_spin_new and do class:instance instead? That would enable dummyload
>> to unambiguously know what to use, depending on get_engines query.
>
> Speak to Mika, we abuse igt_spin_t much more by resubmitting the same
> dummyload to multiple engines and contexts.
I have wandered there yes. The reason for this abuse is still unclear.
We could do a clearer interface for creating spinners but is the
reusage due to latency concerns?
-Mika
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
2019-05-23 12:02 ` Mika Kuoppala
@ 2019-05-23 12:08 ` Chris Wilson
-1 siblings, 0 replies; 23+ messages in thread
From: Chris Wilson @ 2019-05-23 12:08 UTC (permalink / raw)
To: Mika Kuoppala, Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
Quoting Mika Kuoppala (2019-05-23 13:02:30)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Quoting Tvrtko Ursulin (2019-05-23 07:43:12)
> >>
> >> On 23/05/2019 07:37, Tvrtko Ursulin wrote:
> >> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >> >
> >> > Engine enumerated test names have changed so fast-feedback.testlist needs
> >> > to be updated. However listing all engines there won't scale. So instead
> >> > add new tests cases which iterate all engines internally.
> >> >
> >> > v2:
> >> > * Fix basic-all test name.
> >> > * Fix params to basic (bool false to zero).
> >> > * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
> >> > contexts for now.
> >> > * Have only basic-all in BAT. (Chris)
> >> >
> >> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
> >> > Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
> >> > ---
> >> > tests/i915/gem_busy.c | 19 +++++++++++----
> >> > tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> >> > tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
> >> > 3 files changed, 50 insertions(+), 33 deletions(-)
> >> >
> >> > diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> >> > index 781a3bfab1d1..f3ebb37a33b4 100644
> >> > --- a/tests/i915/gem_busy.c
> >> > +++ b/tests/i915/gem_busy.c
> >> > @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
> >> >
> >> > static bool has_extended_busy_ioctl(int fd)
> >> > {
> >> > - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
> >> > + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
> >>
> >> (This fails on platforms with only rcs0 (no other engines) due context
> >> has a map now, and I915_EXEC_RENDER == 1 == -EINVAL.)
> >
> > In which case, it probably should be a plain 0 as it no longer has the
> > old EXEC_RING semantics but is just an index, i.e. igt_spin_new(fd);
> >
> >> We need to come up with a robust and easy to remember solution for
> >> dealing with the fact contexts are stateful now and
> >> __for_each_physical_engine iterator configures the default one.
> >>
> >> Could end game for test conversion be to stop passing in eb.flags to
> >> igt_spin_new and do class:instance instead? That would enable dummyload
> >> to unambiguously know what to use, depending on get_engines query.
> >
> > Speak to Mika, we abuse igt_spin_t much more by resubmitting the same
> > dummyload to multiple engines and contexts.
>
> I have wandered there yes. The reason for this abuse is still unclear.
> We could do a clearer interface for creating spinners but is the
> reusage due to latency concerns?
No, just because we are lazy and creating a clean, clear interface takes
time and lots of effort. So we excuse ourselves to get something that
does the job and once we know what we want, we tell the next fool to
come along to fix it neatly. :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/i915: Restore some BAT coverage
@ 2019-05-23 12:08 ` Chris Wilson
0 siblings, 0 replies; 23+ messages in thread
From: Chris Wilson @ 2019-05-23 12:08 UTC (permalink / raw)
To: Mika Kuoppala, Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
Quoting Mika Kuoppala (2019-05-23 13:02:30)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Quoting Tvrtko Ursulin (2019-05-23 07:43:12)
> >>
> >> On 23/05/2019 07:37, Tvrtko Ursulin wrote:
> >> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >> >
> >> > Engine enumerated test names have changed so fast-feedback.testlist needs
> >> > to be updated. However listing all engines there won't scale. So instead
> >> > add new tests cases which iterate all engines internally.
> >> >
> >> > v2:
> >> > * Fix basic-all test name.
> >> > * Fix params to basic (bool false to zero).
> >> > * Use I915_EXEC_DEFAULT in has_extended_busy_ioctl to workaround stateful
> >> > contexts for now.
> >> > * Have only basic-all in BAT. (Chris)
> >> >
> >> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
> >> > Reviewed-by: Andi Shyti <andi.shyti@intel.com> # v1
> >> > ---
> >> > tests/i915/gem_busy.c | 19 +++++++++++----
> >> > tests/i915/gem_exec_basic.c | 33 +++++++++++++++++++++++++++
> >> > tests/intel-ci/fast-feedback.testlist | 31 ++-----------------------
> >> > 3 files changed, 50 insertions(+), 33 deletions(-)
> >> >
> >> > diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> >> > index 781a3bfab1d1..f3ebb37a33b4 100644
> >> > --- a/tests/i915/gem_busy.c
> >> > +++ b/tests/i915/gem_busy.c
> >> > @@ -417,7 +417,7 @@ static bool has_semaphores(int fd)
> >> >
> >> > static bool has_extended_busy_ioctl(int fd)
> >> > {
> >> > - igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_RENDER);
> >> > + igt_spin_t *spin = igt_spin_new(fd, .engine = I915_EXEC_DEFAULT);
> >>
> >> (This fails on platforms with only rcs0 (no other engines) due context
> >> has a map now, and I915_EXEC_RENDER == 1 == -EINVAL.)
> >
> > In which case, it probably should be a plain 0 as it no longer has the
> > old EXEC_RING semantics but is just an index, i.e. igt_spin_new(fd);
> >
> >> We need to come up with a robust and easy to remember solution for
> >> dealing with the fact contexts are stateful now and
> >> __for_each_physical_engine iterator configures the default one.
> >>
> >> Could end game for test conversion be to stop passing in eb.flags to
> >> igt_spin_new and do class:instance instead? That would enable dummyload
> >> to unambiguously know what to use, depending on get_engines query.
> >
> > Speak to Mika, we abuse igt_spin_t much more by resubmitting the same
> > dummyload to multiple engines and contexts.
>
> I have wandered there yes. The reason for this abuse is still unclear.
> We could do a clearer interface for creating spinners but is the
> reusage due to latency concerns?
No, just because we are lazy and creating a clean, clear interface takes
time and lots of effort. So we excuse ourselves to get something that
does the job and once we know what we want, we tell the next fool to
come along to fix it neatly. :)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/i915: Restore some BAT coverage
2019-05-22 16:31 ` [igt-dev] " Tvrtko Ursulin
` (6 preceding siblings ...)
(?)
@ 2019-05-23 14:27 ` Patchwork
-1 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2019-05-23 14:27 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
== Series Details ==
Series: tests/i915: Restore some BAT coverage
URL : https://patchwork.freedesktop.org/series/60996/
State : success
== Summary ==
CI Bug Log - changes from IGT_5005_full -> IGTPW_3033_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60996/revisions/1/mbox/
New tests
---------
New tests have been introduced between IGT_5005_full and IGTPW_3033_full:
### New IGT tests (4) ###
* igt@gem_busy@busy-rcs0:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@gem_exec_basic@all:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_exec_basic@gtt-all:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@gem_exec_basic@readonly-all:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
Known issues
------------
Here are the changes found in IGTPW_3033_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [PASS][1] -> [FAIL][2] ([fdo#108686])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-glk8/igt@gem_tiled_swapping@non-threaded.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-glk8/igt@gem_tiled_swapping@non-threaded.html
- shard-hsw: [PASS][3] -> [FAIL][4] ([fdo#108686])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-hsw6/igt@gem_tiled_swapping@non-threaded.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-hsw7/igt@gem_tiled_swapping@non-threaded.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-apl4/igt@gem_workarounds@suspend-resume.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-apl4/igt@gem_workarounds@suspend-resume.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-blt:
- shard-glk: [PASS][7] -> [INCOMPLETE][8] ([fdo#103359] / [k.org#198133])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_plane_scaling@pipe-c-plane-scaling:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([fdo#103313] / [fdo#105345])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-kbl4/igt@kms_plane_scaling@pipe-c-plane-scaling.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-kbl2/igt@kms_plane_scaling@pipe-c-plane-scaling.html
#### Possible fixes ####
* igt@i915_suspend@debugfs-reader:
- shard-apl: [DMESG-WARN][11] ([fdo#108566]) -> [PASS][12] +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-apl3/igt@i915_suspend@debugfs-reader.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-apl7/igt@i915_suspend@debugfs-reader.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-kbl: [FAIL][13] ([fdo#102670]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-kbl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-kbl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
- shard-hsw: [FAIL][15] ([fdo#102670]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-hsw6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-hsw2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-snb: [INCOMPLETE][17] ([fdo#105411]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-snb1/igt@kms_flip@flip-vs-suspend-interruptible.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-snb4/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-glk: [FAIL][19] ([fdo#103060]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-glk8/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-glk5/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs0-s3:
- shard-apl: [DMESG-WARN][21] ([fdo#108566]) -> [WARN][22] ([fdo#110738])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-apl3/igt@gem_ctx_isolation@vcs0-s3.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-apl2/igt@gem_ctx_isolation@vcs0-s3.html
* igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name:
- shard-hsw: [SKIP][23] ([fdo#109271]) -> [INCOMPLETE][24] ([fdo#103540])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5005/shard-hsw2/igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/shard-hsw7/igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#105345]: https://bugs.freedesktop.org/show_bug.cgi?id=105345
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#110738]: https://bugs.freedesktop.org/show_bug.cgi?id=110738
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_5005 -> IGTPW_3033
CI_DRM_6121: 0a029524f22ca287ec7e515edc1258e7f806750c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3033: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/
IGT_5005: adf9f435a795d692e30cd6eafe26eddf4993c8ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3033/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/i915: Restore some BAT coverage (rev3)
2019-05-22 16:31 ` [igt-dev] " Tvrtko Ursulin
` (7 preceding siblings ...)
(?)
@ 2019-05-24 9:11 ` Patchwork
-1 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2019-05-24 9:11 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
== Series Details ==
Series: tests/i915: Restore some BAT coverage (rev3)
URL : https://patchwork.freedesktop.org/series/60996/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6128_full -> IGTPW_3042_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60996/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_3042_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@forked-medium-copy-xy:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#109100])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-iclb6/igt@gem_mmap_gtt@forked-medium-copy-xy.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-iclb7/igt@gem_mmap_gtt@forked-medium-copy-xy.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-apl4/igt@gem_workarounds@suspend-resume.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-apl6/igt@gem_workarounds@suspend-resume.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-msflip-blt:
- shard-hsw: [PASS][5] -> [SKIP][6] ([fdo#109271]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-hsw8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-msflip-blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-hsw5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-iclb: [PASS][7] -> [FAIL][8] ([fdo#103167]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-badstride.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109642])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-iclb2/igt@kms_psr2_su@page_flip.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-iclb5/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109441]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-iclb2/igt@kms_psr@psr2_dpms.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-iclb6/igt@kms_psr@psr2_dpms.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][13] -> [FAIL][14] ([fdo#99912])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-apl4/igt@kms_setmode@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-apl4/igt@kms_setmode@basic.html
- shard-kbl: [PASS][15] -> [FAIL][16] ([fdo#99912])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-kbl3/igt@kms_setmode@basic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-kbl4/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@gem_exec_whisper@normal:
- shard-glk: [INCOMPLETE][17] ([fdo#103359] / [k.org#198133]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-glk9/igt@gem_exec_whisper@normal.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-glk3/igt@gem_exec_whisper@normal.html
- shard-hsw: [INCOMPLETE][19] ([fdo#103540]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-hsw8/igt@gem_exec_whisper@normal.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-hsw8/igt@gem_exec_whisper@normal.html
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: [FAIL][21] ([fdo#108686]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-hsw8/igt@gem_tiled_swapping@non-threaded.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-hsw5/igt@gem_tiled_swapping@non-threaded.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][23] ([fdo#108566]) -> [PASS][24] +4 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-apl2/igt@gem_workarounds@suspend-resume-context.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
* {igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding}:
- shard-apl: [INCOMPLETE][25] ([fdo#103927]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-apl7/igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding.html
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [FAIL][27] ([fdo#106509] / [fdo#107409]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-glk1/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-glk7/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
- shard-hsw: [SKIP][29] ([fdo#109271]) -> [PASS][30] +31 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-hsw5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-hsw7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-msflip-blt:
- shard-glk: [FAIL][31] ([fdo#103167]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-msflip-blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-tilingchange:
- shard-apl: [FAIL][33] ([fdo#103167]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-apl2/igt@kms_frontbuffer_tracking@fbc-tilingchange.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-apl2/igt@kms_frontbuffer_tracking@fbc-tilingchange.html
- shard-kbl: [FAIL][35] ([fdo#103167]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-tilingchange.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-tilingchange.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: [FAIL][37] ([fdo#103167]) -> [PASS][38] +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
* igt@perf_pmu@rc6-runtime-pm:
- shard-hsw: [FAIL][39] ([fdo#105010]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-hsw5/igt@perf_pmu@rc6-runtime-pm.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-hsw8/igt@perf_pmu@rc6-runtime-pm.html
* igt@tools_test@tools_test:
- shard-iclb: [SKIP][41] ([fdo#109352]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-iclb3/igt@tools_test@tools_test.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-iclb7/igt@tools_test@tools_test.html
#### Warnings ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [DMESG-WARN][43] ([fdo#108566]) -> [WARN][44] ([fdo#110738]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-apl7/igt@gem_ctx_isolation@bcs0-s3.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-apl7/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [WARN][45] ([fdo#110738]) -> [DMESG-WARN][46] ([fdo#108566])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-apl7/igt@gem_ctx_isolation@rcs0-s3.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-apl6/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_mmap_gtt@forked-big-copy-xy:
- shard-iclb: [TIMEOUT][47] ([fdo#109673]) -> [INCOMPLETE][48] ([fdo#107713] / [fdo#109100])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6128/shard-iclb5/igt@gem_mmap_gtt@forked-big-copy-xy.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/shard-iclb2/igt@gem_mmap_gtt@forked-big-copy-xy.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109352]: https://bugs.freedesktop.org/show_bug.cgi?id=109352
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#110738]: https://bugs.freedesktop.org/show_bug.cgi?id=110738
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_5007 -> IGTPW_3042
* Piglit: piglit_4509 -> None
CI_DRM_6128: 6af092dc0755f4c49722d6d074625abdfd05777f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3042: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/
IGT_5007: ed4a5515109ee83556f505a9519e33acd9518279 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3042/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2019-05-24 9:11 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-22 16:31 [PATCH i-g-t] tests/i915: Restore some BAT coverage Tvrtko Ursulin
2019-05-22 16:31 ` [igt-dev] " Tvrtko Ursulin
2019-05-22 16:45 ` Chris Wilson
2019-05-22 16:45 ` Chris Wilson
2019-05-22 18:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-22 21:28 ` [igt-dev] [PATCH i-g-t] " Andi Shyti
2019-05-22 21:28 ` Andi Shyti
2019-05-23 6:37 ` [PATCH i-g-t v2] " Tvrtko Ursulin
2019-05-23 6:37 ` [igt-dev] " Tvrtko Ursulin
2019-05-23 6:43 ` Tvrtko Ursulin
2019-05-23 6:43 ` Tvrtko Ursulin
2019-05-23 6:58 ` Chris Wilson
2019-05-23 6:58 ` Chris Wilson
2019-05-23 12:02 ` Mika Kuoppala
2019-05-23 12:02 ` Mika Kuoppala
2019-05-23 12:08 ` Chris Wilson
2019-05-23 12:08 ` Chris Wilson
2019-05-23 11:43 ` Chris Wilson
2019-05-23 11:43 ` [Intel-gfx] " Chris Wilson
2019-05-23 7:30 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/i915: Restore some BAT coverage (rev2) Patchwork
2019-05-23 11:00 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915: Restore some BAT coverage (rev3) Patchwork
2019-05-23 14:27 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/i915: Restore some BAT coverage Patchwork
2019-05-24 9:11 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/i915: Restore some BAT coverage (rev3) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.