From: Randy Dunlap <rdunlap@infradead.org>
To: Daniel Gutson <daniel.gutson@eclypsium.com>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel@vger.kernel.org,
Richard Hughes <hughsient@gmail.com>,
Alex Bazhaniuk <alex@eclypsium.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] Platform integrity information in sysfs (version 9)
Date: Sat, 3 Oct 2020 21:01:27 -0700 [thread overview]
Message-ID: <82bb95bd-988f-3cc2-40f7-8ebfd20b09d9@infradead.org> (raw)
In-Reply-To: <20200930163714.12879-3-daniel.gutson@eclypsium.com>
On 9/30/20 9:37 AM, Daniel Gutson wrote:
> diff --git a/drivers/mtd/spi-nor/controllers/Kconfig b/drivers/mtd/spi-nor/controllers/Kconfig
> index 5c0e0ec2e6d1..e7eaef506fc2 100644
> --- a/drivers/mtd/spi-nor/controllers/Kconfig
> +++ b/drivers/mtd/spi-nor/controllers/Kconfig
> @@ -29,6 +29,7 @@ config SPI_NXP_SPIFI
>
> config SPI_INTEL_SPI
> tristate
> + depends on PLATFORM_INTEGRITY_DATA
So SPI_INTEL_SPI_PCI selects SPI_INTEL_SPI:
config SPI_INTEL_SPI_PCI
tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)"
depends on X86 && PCI
select SPI_INTEL_SPI
without checking that PLATFORM_INTEGRITY_DATA is set/enabled.
"select" does not follow any kconfig dependency chains, so when
PLATFORM_INTEGRITY_DATA is not enabled, this should be causing
a kconfig warning, which is not OK.
--
~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Daniel Gutson <daniel.gutson@eclypsium.com>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel@vger.kernel.org,
Richard Hughes <hughsient@gmail.com>,
Alex Bazhaniuk <alex@eclypsium.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] Platform integrity information in sysfs (version 9)
Date: Sat, 3 Oct 2020 21:01:27 -0700 [thread overview]
Message-ID: <82bb95bd-988f-3cc2-40f7-8ebfd20b09d9@infradead.org> (raw)
In-Reply-To: <20200930163714.12879-3-daniel.gutson@eclypsium.com>
On 9/30/20 9:37 AM, Daniel Gutson wrote:
> diff --git a/drivers/mtd/spi-nor/controllers/Kconfig b/drivers/mtd/spi-nor/controllers/Kconfig
> index 5c0e0ec2e6d1..e7eaef506fc2 100644
> --- a/drivers/mtd/spi-nor/controllers/Kconfig
> +++ b/drivers/mtd/spi-nor/controllers/Kconfig
> @@ -29,6 +29,7 @@ config SPI_NXP_SPIFI
>
> config SPI_INTEL_SPI
> tristate
> + depends on PLATFORM_INTEGRITY_DATA
So SPI_INTEL_SPI_PCI selects SPI_INTEL_SPI:
config SPI_INTEL_SPI_PCI
tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)"
depends on X86 && PCI
select SPI_INTEL_SPI
without checking that PLATFORM_INTEGRITY_DATA is set/enabled.
"select" does not follow any kconfig dependency chains, so when
PLATFORM_INTEGRITY_DATA is not enabled, this should be causing
a kconfig warning, which is not OK.
--
~Randy
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-10-04 4:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 16:37 [PATCH 0/2] Platform integrity information in sysfs (version 9) Daniel Gutson
2020-09-30 16:37 ` Daniel Gutson
2020-09-30 16:37 ` [PATCH 1/2] " Daniel Gutson
2020-09-30 16:37 ` Daniel Gutson
2020-09-30 16:37 ` [PATCH 2/2] " Daniel Gutson
2020-09-30 16:37 ` Daniel Gutson
2020-10-02 13:43 ` Greg Kroah-Hartman
2020-10-02 13:43 ` Greg Kroah-Hartman
2020-10-21 19:55 ` Daniel Gutson
2020-10-21 19:55 ` Daniel Gutson
2020-11-10 14:07 ` Daniel Gutson
2020-11-10 14:07 ` Daniel Gutson
2020-10-04 4:01 ` Randy Dunlap [this message]
2020-10-04 4:01 ` Randy Dunlap
2020-10-22 12:08 ` Daniel Gutson
2020-10-22 12:08 ` Daniel Gutson
2020-09-30 16:42 ` [PATCH 0/2] " Daniel Gutson
2020-09-30 16:42 ` Daniel Gutson
-- strict thread matches above, loose matches on Subject: below --
2020-09-30 13:51 [PATCH 2/2] " Daniel Gutson
2020-09-30 13:51 ` Daniel Gutson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82bb95bd-988f-3cc2-40f7-8ebfd20b09d9@infradead.org \
--to=rdunlap@infradead.org \
--cc=alex@eclypsium.com \
--cc=arnd@arndb.de \
--cc=daniel.gutson@eclypsium.com \
--cc=derek.kiernan@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=hughsient@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mchehab+huawei@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.