All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:40 ` Javier Martinez Canillas
  0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:40 UTC (permalink / raw)
  To: linux-kernel
  Cc: Javier Martinez Canillas, Jarkko Sakkinen, Marcel Selhorst,
	Peter Huewe, Kevin Hilman, Neil Armstrong, tpmdd-devel,
	PrasannaKumar Muralidharan, Carlo Caione, Jason Gunthorpe,
	Herbert Xu, linux-amlogic, Matt Mackall, linux-arm-kernel,
	linux-crypto

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias:          platform:meson-rng

After this patch:

$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias:          platform:meson-rng
alias:          of:N*T*Camlogic,meson-rngC*
alias:          of:N*T*Camlogic,meson-rng

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/char/hw_random/meson-rng.c | 1 +
 drivers/char/tpm/Kconfig           | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
index 58bef39f7286..51864a509be7 100644
--- a/drivers/char/hw_random/meson-rng.c
+++ b/drivers/char/hw_random/meson-rng.c
@@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = {
 	{ .compatible = "amlogic,meson-rng", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, meson_rng_of_match);
 
 static struct platform_driver meson_rng_driver = {
 	.probe	= meson_rng_probe,
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 9faa0b1e7766..982ed2fe927c 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -32,7 +32,7 @@ config TCG_TIS_CORE
 
 config TCG_TIS
 	tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
-	depends on X86
+	depends on X86 || COMPILE_TEST
 	select TCG_TIS_CORE
 	---help---
 	  If you have a TPM security chip that is compliant with the
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:40 ` Javier Martinez Canillas
  0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:40 UTC (permalink / raw)
  To: linux-arm-kernel

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias:          platform:meson-rng

After this patch:

$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias:          platform:meson-rng
alias:          of:N*T*Camlogic,meson-rngC*
alias:          of:N*T*Camlogic,meson-rng

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/char/hw_random/meson-rng.c | 1 +
 drivers/char/tpm/Kconfig           | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
index 58bef39f7286..51864a509be7 100644
--- a/drivers/char/hw_random/meson-rng.c
+++ b/drivers/char/hw_random/meson-rng.c
@@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = {
 	{ .compatible = "amlogic,meson-rng", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, meson_rng_of_match);
 
 static struct platform_driver meson_rng_driver = {
 	.probe	= meson_rng_probe,
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 9faa0b1e7766..982ed2fe927c 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -32,7 +32,7 @@ config TCG_TIS_CORE
 
 config TCG_TIS
 	tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
-	depends on X86
+	depends on X86 || COMPILE_TEST
 	select TCG_TIS_CORE
 	---help---
 	  If you have a TPM security chip that is compliant with the
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:40 ` Javier Martinez Canillas
  0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:40 UTC (permalink / raw)
  To: linus-amlogic

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias:          platform:meson-rng

After this patch:

$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias:          platform:meson-rng
alias:          of:N*T*Camlogic,meson-rngC*
alias:          of:N*T*Camlogic,meson-rng

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/char/hw_random/meson-rng.c | 1 +
 drivers/char/tpm/Kconfig           | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
index 58bef39f7286..51864a509be7 100644
--- a/drivers/char/hw_random/meson-rng.c
+++ b/drivers/char/hw_random/meson-rng.c
@@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = {
 	{ .compatible = "amlogic,meson-rng", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, meson_rng_of_match);
 
 static struct platform_driver meson_rng_driver = {
 	.probe	= meson_rng_probe,
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 9faa0b1e7766..982ed2fe927c 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -32,7 +32,7 @@ config TCG_TIS_CORE
 
 config TCG_TIS
 	tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
-	depends on X86
+	depends on X86 || COMPILE_TEST
 	select TCG_TIS_CORE
 	---help---
 	  If you have a TPM security chip that is compliant with the
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 18+ messages in thread
* Re: [PATCH] hwrng: meson: Fix module autoload for OF registration
  2016-10-17 19:40 ` Javier Martinez Canillas
  (?)
  (?)
@ 2016-10-17 19:45     ` Jason Gunthorpe
  -1 siblings, 0 replies; 18+ messages in thread
From: Jason Gunthorpe @ 2016-10-17 19:45 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: Herbert Xu, Neil Armstrong, Kevin Hilman, Matt Mackall,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	linux-crypto-u79uwXL29TY76Z2rM5mHXA, PrasannaKumar Muralidharan,
	Carlo Caione, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

On Mon, Oct 17, 2016 at 04:40:14PM -0300, Javier Martinez Canillas wrote:

> Signed-off-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
> 
>  drivers/char/hw_random/meson-rng.c | 1 +
>  drivers/char/tpm/Kconfig           | 2 +-

Looks like this patch should not have tpm in it.

Jason

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 18+ messages in thread
* Re: [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:45     ` Jason Gunthorpe
  0 siblings, 0 replies; 18+ messages in thread
From: Jason Gunthorpe @ 2016-10-17 19:45 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: linux-kernel, Jarkko Sakkinen, Marcel Selhorst, Peter Huewe,
	Kevin Hilman, Neil Armstrong, tpmdd-devel,
	PrasannaKumar Muralidharan, Carlo Caione, Herbert Xu,
	linux-amlogic, Matt Mackall, linux-arm-kernel, linux-crypto

On Mon, Oct 17, 2016 at 04:40:14PM -0300, Javier Martinez Canillas wrote:

> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
>  drivers/char/hw_random/meson-rng.c | 1 +
>  drivers/char/tpm/Kconfig           | 2 +-

Looks like this patch should not have tpm in it.

Jason

^ permalink raw reply	[flat|nested] 18+ messages in thread
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:45     ` Jason Gunthorpe
  0 siblings, 0 replies; 18+ messages in thread
From: Jason Gunthorpe @ 2016-10-17 19:45 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Oct 17, 2016 at 04:40:14PM -0300, Javier Martinez Canillas wrote:

> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
>  drivers/char/hw_random/meson-rng.c | 1 +
>  drivers/char/tpm/Kconfig           | 2 +-

Looks like this patch should not have tpm in it.

Jason

^ permalink raw reply	[flat|nested] 18+ messages in thread
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:45     ` Jason Gunthorpe
  0 siblings, 0 replies; 18+ messages in thread
From: Jason Gunthorpe @ 2016-10-17 19:45 UTC (permalink / raw)
  To: linus-amlogic

On Mon, Oct 17, 2016 at 04:40:14PM -0300, Javier Martinez Canillas wrote:

> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
>  drivers/char/hw_random/meson-rng.c | 1 +
>  drivers/char/tpm/Kconfig           | 2 +-

Looks like this patch should not have tpm in it.

Jason

^ permalink raw reply	[flat|nested] 18+ messages in thread
* Re: [PATCH] hwrng: meson: Fix module autoload for OF registration
  2016-10-17 19:40 ` Javier Martinez Canillas
  (?)
  (?)
@ 2016-10-17 19:45   ` Fabio Estevam
  -1 siblings, 0 replies; 18+ messages in thread
From: Fabio Estevam @ 2016-10-17 19:45 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: linux-kernel, Herbert Xu, Neil Armstrong, Kevin Hilman,
	Matt Mackall, Marcel Selhorst, Jarkko Sakkinen, Jason Gunthorpe,
	tpmdd-devel, linux-crypto, PrasannaKumar Muralidharan,
	Carlo Caione, linux-amlogic, Peter Huewe, linux-arm-kernel

On Mon, Oct 17, 2016 at 5:40 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:

> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -32,7 +32,7 @@ config TCG_TIS_CORE
>
>  config TCG_TIS
>         tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
> -       depends on X86
> +       depends on X86 || COMPILE_TEST

This is a separate change.

^ permalink raw reply	[flat|nested] 18+ messages in thread
* Re: [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:45   ` Fabio Estevam
  0 siblings, 0 replies; 18+ messages in thread
From: Fabio Estevam @ 2016-10-17 19:45 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: linux-kernel, Herbert Xu, Neil Armstrong, Kevin Hilman,
	Matt Mackall, Marcel Selhorst, Jarkko Sakkinen, Jason Gunthorpe,
	tpmdd-devel, linux-crypto, PrasannaKumar Muralidharan,
	Carlo Caione, linux-amlogic, Peter Huewe, linux-arm-kernel

On Mon, Oct 17, 2016 at 5:40 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:

> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -32,7 +32,7 @@ config TCG_TIS_CORE
>
>  config TCG_TIS
>         tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
> -       depends on X86
> +       depends on X86 || COMPILE_TEST

This is a separate change.

^ permalink raw reply	[flat|nested] 18+ messages in thread
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:45   ` Fabio Estevam
  0 siblings, 0 replies; 18+ messages in thread
From: Fabio Estevam @ 2016-10-17 19:45 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Oct 17, 2016 at 5:40 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:

> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -32,7 +32,7 @@ config TCG_TIS_CORE
>
>  config TCG_TIS
>         tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
> -       depends on X86
> +       depends on X86 || COMPILE_TEST

This is a separate change.

^ permalink raw reply	[flat|nested] 18+ messages in thread
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:45   ` Fabio Estevam
  0 siblings, 0 replies; 18+ messages in thread
From: Fabio Estevam @ 2016-10-17 19:45 UTC (permalink / raw)
  To: linus-amlogic

On Mon, Oct 17, 2016 at 5:40 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:

> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -32,7 +32,7 @@ config TCG_TIS_CORE
>
>  config TCG_TIS
>         tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
> -       depends on X86
> +       depends on X86 || COMPILE_TEST

This is a separate change.

^ permalink raw reply	[flat|nested] 18+ messages in thread
* Re: [PATCH] hwrng: meson: Fix module autoload for OF registration
  2016-10-17 19:45     ` Jason Gunthorpe
  (?)
@ 2016-10-17 19:47       ` Javier Martinez Canillas
  -1 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:47 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: linux-kernel, Jarkko Sakkinen, Marcel Selhorst, Peter Huewe,
	Kevin Hilman, Neil Armstrong, tpmdd-devel,
	PrasannaKumar Muralidharan, Carlo Caione, Herbert Xu,
	linux-amlogic, Matt Mackall, linux-arm-kernel, linux-crypto

Hello Jason,

On 10/17/2016 04:45 PM, Jason Gunthorpe wrote:
> On Mon, Oct 17, 2016 at 04:40:14PM -0300, Javier Martinez Canillas wrote:
> 
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>>  drivers/char/hw_random/meson-rng.c | 1 +
>>  drivers/char/tpm/Kconfig           | 2 +-
> 
> Looks like this patch should not have tpm in it.
>

Argh, yes. I had some unrelated changes in my staging area and did a
commit by mistake. Thanks a lot for pointing out and sorry for that.

I'll post a v2 without this.

> Jason
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

^ permalink raw reply	[flat|nested] 18+ messages in thread
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:47       ` Javier Martinez Canillas
  0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:47 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Jason,

On 10/17/2016 04:45 PM, Jason Gunthorpe wrote:
> On Mon, Oct 17, 2016 at 04:40:14PM -0300, Javier Martinez Canillas wrote:
> 
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>>  drivers/char/hw_random/meson-rng.c | 1 +
>>  drivers/char/tpm/Kconfig           | 2 +-
> 
> Looks like this patch should not have tpm in it.
>

Argh, yes. I had some unrelated changes in my staging area and did a
commit by mistake. Thanks a lot for pointing out and sorry for that.

I'll post a v2 without this.

> Jason
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

^ permalink raw reply	[flat|nested] 18+ messages in thread
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:47       ` Javier Martinez Canillas
  0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:47 UTC (permalink / raw)
  To: linus-amlogic

Hello Jason,

On 10/17/2016 04:45 PM, Jason Gunthorpe wrote:
> On Mon, Oct 17, 2016 at 04:40:14PM -0300, Javier Martinez Canillas wrote:
> 
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>>  drivers/char/hw_random/meson-rng.c | 1 +
>>  drivers/char/tpm/Kconfig           | 2 +-
> 
> Looks like this patch should not have tpm in it.
>

Argh, yes. I had some unrelated changes in my staging area and did a
commit by mistake. Thanks a lot for pointing out and sorry for that.

I'll post a v2 without this.

> Jason
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

^ permalink raw reply	[flat|nested] 18+ messages in thread
* Re: [PATCH] hwrng: meson: Fix module autoload for OF registration
  2016-10-17 19:45   ` Fabio Estevam
  (?)
  (?)
@ 2016-10-17 19:53     ` Javier Martinez Canillas
  -1 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:53 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Herbert Xu, Neil Armstrong, Kevin Hilman,
	PrasannaKumar Muralidharan, Marcel Selhorst, linux-kernel,
	Jarkko Sakkinen, Jason Gunthorpe, tpmdd-devel, linux-crypto,
	Matt Mackall, Carlo Caione, linux-amlogic, Peter Huewe,
	linux-arm-kernel

Hello Fabio,

On 10/17/2016 04:45 PM, Fabio Estevam wrote:
> On Mon, Oct 17, 2016 at 5:40 PM, Javier Martinez Canillas
> <javier@osg.samsung.com> wrote:
> 
>> --- a/drivers/char/tpm/Kconfig
>> +++ b/drivers/char/tpm/Kconfig
>> @@ -32,7 +32,7 @@ config TCG_TIS_CORE
>>
>>  config TCG_TIS
>>         tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
>> -       depends on X86
>> +       depends on X86 || COMPILE_TEST
> 
> This is a separate change.
> 

Yes, I did a commit by mistake. Sorry about that.

Jason already pointed out and I posted a v2.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

^ permalink raw reply	[flat|nested] 18+ messages in thread
* Re: [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:53     ` Javier Martinez Canillas
  0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:53 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: linux-kernel, Herbert Xu, Neil Armstrong, Kevin Hilman,
	Matt Mackall, Marcel Selhorst, Jarkko Sakkinen, Jason Gunthorpe,
	tpmdd-devel, linux-crypto, PrasannaKumar Muralidharan,
	Carlo Caione, linux-amlogic, Peter Huewe, linux-arm-kernel

Hello Fabio,

On 10/17/2016 04:45 PM, Fabio Estevam wrote:
> On Mon, Oct 17, 2016 at 5:40 PM, Javier Martinez Canillas
> <javier@osg.samsung.com> wrote:
> 
>> --- a/drivers/char/tpm/Kconfig
>> +++ b/drivers/char/tpm/Kconfig
>> @@ -32,7 +32,7 @@ config TCG_TIS_CORE
>>
>>  config TCG_TIS
>>         tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
>> -       depends on X86
>> +       depends on X86 || COMPILE_TEST
> 
> This is a separate change.
> 

Yes, I did a commit by mistake. Sorry about that.

Jason already pointed out and I posted a v2.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

^ permalink raw reply	[flat|nested] 18+ messages in thread
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:53     ` Javier Martinez Canillas
  0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:53 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Fabio,

On 10/17/2016 04:45 PM, Fabio Estevam wrote:
> On Mon, Oct 17, 2016 at 5:40 PM, Javier Martinez Canillas
> <javier@osg.samsung.com> wrote:
> 
>> --- a/drivers/char/tpm/Kconfig
>> +++ b/drivers/char/tpm/Kconfig
>> @@ -32,7 +32,7 @@ config TCG_TIS_CORE
>>
>>  config TCG_TIS
>>         tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
>> -       depends on X86
>> +       depends on X86 || COMPILE_TEST
> 
> This is a separate change.
> 

Yes, I did a commit by mistake. Sorry about that.

Jason already pointed out and I posted a v2.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

^ permalink raw reply	[flat|nested] 18+ messages in thread
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:53     ` Javier Martinez Canillas
  0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:53 UTC (permalink / raw)
  To: linus-amlogic

Hello Fabio,

On 10/17/2016 04:45 PM, Fabio Estevam wrote:
> On Mon, Oct 17, 2016 at 5:40 PM, Javier Martinez Canillas
> <javier@osg.samsung.com> wrote:
> 
>> --- a/drivers/char/tpm/Kconfig
>> +++ b/drivers/char/tpm/Kconfig
>> @@ -32,7 +32,7 @@ config TCG_TIS_CORE
>>
>>  config TCG_TIS
>>         tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
>> -       depends on X86
>> +       depends on X86 || COMPILE_TEST
> 
> This is a separate change.
> 

Yes, I did a commit by mistake. Sorry about that.

Jason already pointed out and I posted a v2.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

^ permalink raw reply	[flat|nested] 18+ messages in thread
end of thread, other threads:[~2016-10-17 19:53 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-17 19:40 [PATCH] hwrng: meson: Fix module autoload for OF registration Javier Martinez Canillas
2016-10-17 19:40 ` Javier Martinez Canillas
2016-10-17 19:40 ` Javier Martinez Canillas
     [not found] ` <1476733214-19044-1-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-10-17 19:45   ` Jason Gunthorpe
2016-10-17 19:45     ` Jason Gunthorpe
2016-10-17 19:45     ` Jason Gunthorpe
2016-10-17 19:45     ` Jason Gunthorpe
2016-10-17 19:47     ` Javier Martinez Canillas
2016-10-17 19:47       ` Javier Martinez Canillas
2016-10-17 19:47       ` Javier Martinez Canillas
2016-10-17 19:45 ` Fabio Estevam
2016-10-17 19:45   ` Fabio Estevam
2016-10-17 19:45   ` Fabio Estevam
2016-10-17 19:45   ` Fabio Estevam
2016-10-17 19:53   ` Javier Martinez Canillas
2016-10-17 19:53     ` Javier Martinez Canillas
2016-10-17 19:53     ` Javier Martinez Canillas
2016-10-17 19:53     ` Javier Martinez Canillas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.