* Smatch indenting warnings?
@ 2020-03-02 12:49 Dan Carpenter
2020-03-02 15:06 ` Li, Philip
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2020-03-02 12:49 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Smatch prints a lot of warnings about inconsistent indenting.
sound/soc/codecs/max98088.c:1746 max98088_i2c_probe() warn: inconsistent indenting
sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn: inconsistent indenting
sound/core/rawmidi.c:1882 alsa_rawmidi_init() warn: inconsistent indenting
$ grep "inconsistent indenting" smatch_warns.txt | wc -l
321
These are generally not bugs, but the check has a low false positive
ratio and it's all stuff which really should be fixed. I seldom report
them but it would be nice if kbuild reported them automatically.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Smatch indenting warnings?
2020-03-02 12:49 Smatch indenting warnings? Dan Carpenter
@ 2020-03-02 15:06 ` Li, Philip
2020-03-02 15:12 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Li, Philip @ 2020-03-02 15:06 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
> Subject: [kbuild] Smatch indenting warnings?
>
> Smatch prints a lot of warnings about inconsistent indenting.
>
> sound/soc/codecs/max98088.c:1746 max98088_i2c_probe() warn: inconsistent
> indenting
> sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn: inconsistent
> indenting
> sound/core/rawmidi.c:1882 alsa_rawmidi_init() warn: inconsistent indenting
>
>
> $ grep "inconsistent indenting" smatch_warns.txt | wc -l
> 321
>
> These are generally not bugs, but the check has a low false positive
> ratio and it's all stuff which really should be fixed. I seldom report
> them but it would be nice if kbuild reported them automatically.
Thanks Dan, we will handle this in this week to automatically send
"inconsistent indenting" warn.
>
> regards,
> dan carpenter
> _______________________________________________
> kbuild mailing list -- kbuild(a)lists.01.org
> To unsubscribe send an email to kbuild-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Smatch indenting warnings?
2020-03-02 15:06 ` Li, Philip
@ 2020-03-02 15:12 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-03-02 15:12 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On Mon, Mar 02, 2020 at 03:06:21PM +0000, Li, Philip wrote:
> > Subject: [kbuild] Smatch indenting warnings?
> >
> > Smatch prints a lot of warnings about inconsistent indenting.
> >
> > sound/soc/codecs/max98088.c:1746 max98088_i2c_probe() warn: inconsistent
> > indenting
> > sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn: inconsistent
> > indenting
> > sound/core/rawmidi.c:1882 alsa_rawmidi_init() warn: inconsistent indenting
> >
> >
> > $ grep "inconsistent indenting" smatch_warns.txt | wc -l
> > 321
> >
> > These are generally not bugs, but the check has a low false positive
> > ratio and it's all stuff which really should be fixed. I seldom report
> > them but it would be nice if kbuild reported them automatically.
> Thanks Dan, we will handle this in this week to automatically send
> "inconsistent indenting" warn.
Awesome! Thanks so much.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-02 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-02 12:49 Smatch indenting warnings? Dan Carpenter
2020-03-02 15:06 ` Li, Philip
2020-03-02 15:12 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.