All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Raghavendra Rao Ananta <rananta@codeaurora.org>,
	linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org,
	Andrew Melnychenko <andrew@daynix.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open
Date: Tue, 28 Apr 2020 14:48:38 +0200	[thread overview]
Message-ID: <831bf548-a461-6160-f878-ee0f4c5c311b@web.de> (raw)

> Hence, serialize hvc_open and check if tty->private_data is NULL before
> proceeding ahead.

How do you think about to add the tag “Fixes” because of adjustments
for the data synchronisation?


…
> +++ b/drivers/tty/hvc/hvc_console.c
…
@@ -384,6 +394,8 @@ static int hvc_open(struct tty_struct *tty, struct file * filp)
…
> +out:
> +	mutex_unlock(&hvc_open_mutex);
>  	return rc;
>  }

I suggest to use the label “unlock” instead.

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Raghavendra Rao Ananta <rananta@codeaurora.org>,
	linuxppc-dev@lists.ozlabs.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Melnychenko <andrew@daynix.com>,
	linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open
Date: Tue, 28 Apr 2020 14:48:38 +0200	[thread overview]
Message-ID: <831bf548-a461-6160-f878-ee0f4c5c311b@web.de> (raw)

> Hence, serialize hvc_open and check if tty->private_data is NULL before
> proceeding ahead.

How do you think about to add the tag “Fixes” because of adjustments
for the data synchronisation?


…
> +++ b/drivers/tty/hvc/hvc_console.c
…
@@ -384,6 +394,8 @@ static int hvc_open(struct tty_struct *tty, struct file * filp)
…
> +out:
> +	mutex_unlock(&hvc_open_mutex);
>  	return rc;
>  }

I suggest to use the label “unlock” instead.

Regards,
Markus

             reply	other threads:[~2020-04-28 12:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 12:48 Markus Elfring [this message]
2020-04-28 12:48 ` [PATCH] tty: hvc: Fix data abort due to race in hvc_open Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-04-28  3:26 Raghavendra Rao Ananta
2020-05-06  9:48 ` Greg KH
2020-05-06  9:48   ` Greg KH
2020-05-10  1:30   ` rananta
2020-05-10  1:30     ` rananta
2020-05-10  6:48     ` Greg KH
2020-05-10  6:48       ` Greg KH
2020-05-11  7:23       ` rananta
2020-05-11  7:23         ` rananta
2020-05-11  7:34         ` rananta
2020-05-11  7:34           ` rananta
2020-05-11  7:41           ` Greg KH
2020-05-11  7:41             ` Greg KH
2020-05-11  7:39         ` Greg KH
2020-05-11  7:39           ` Greg KH
2020-05-12  7:22           ` Jiri Slaby
2020-05-12  8:25             ` Greg KH
2020-05-12 21:39               ` rananta
2020-05-12 21:39                 ` rananta
2020-05-13  7:04                 ` Greg KH
2020-05-13  7:04                   ` Greg KH
2020-05-14 23:22                   ` rananta
2020-05-14 23:22                     ` rananta
2020-05-15  7:30                     ` Greg KH
2020-05-15  7:30                       ` Greg KH
2020-05-15 19:21                       ` rananta
2020-05-15 19:21                         ` rananta
2020-05-20  9:38                     ` Jiri Slaby
2020-05-20 13:49                       ` rananta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831bf548-a461-6160-f878-ee0f4c5c311b@web.de \
    --to=markus.elfring@web.de \
    --cc=andrew@daynix.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=rananta@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.