[MPTCP] Re: [PATCH 0/2] Correctly handle port field in ADD_ADDR option

[MPTCP] Re: [PATCH 0/2] Correctly handle port field in ADD_ADDR option

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

Hi Peter, Mat,

On 20/03/2020 20:17, Mat Martineau wrote:
> 
> On Fri, 20 Mar 2020, Peter Krystad wrote:
> 
>> Existing code allows ADD_ADDR option lengths that include the port field,
>> so we should correctly parse options with those lengths.
>>
>>
>> Peter Krystad (2):
>>  mptcp: Parse optional port field of ADD_ADDR
>>  mptcp: Include ADD_ADDR port value for path manager
>>
>> include/linux/tcp.h |  1 +
>> net/mptcp/options.c | 11 +++++++++++
>> 2 files changed, 12 insertions(+)
>>
> 
> Both patches look good to me - and they apply cleanly to the current 
> export branch.

Thank you for the patches and the reviews!

- 6b71141d6040: "squashed" patch 1/2 in "mptcp: Add ADD_ADDR handling"
- 49bd5a76f678..212bed34defa: result

- 3dc91a03e4e8: "squashed" patch 2/2 in "mptcp: Add path manager interface"
- 212bed34defa..19b9d67eec8a: result

Tests + export are in progress!

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH 0/2] Correctly handle port field in ADD_ADDR option

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]


On Fri, 20 Mar 2020, Peter Krystad wrote:

> Existing code allows ADD_ADDR option lengths that include the port field,
> so we should correctly parse options with those lengths.
>
>
> Peter Krystad (2):
>  mptcp: Parse optional port field of ADD_ADDR
>  mptcp: Include ADD_ADDR port value for path manager
>
> include/linux/tcp.h |  1 +
> net/mptcp/options.c | 11 +++++++++++
> 2 files changed, 12 insertions(+)
>

Both patches look good to me - and they apply cleanly to the current 
export branch.

--
Mat Martineau
Intel