From: William Kucharski <william.kucharski@oracle.com>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
rppt@linux.ibm.com, Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
vbabka@suse.cz, Rik van Riel <riel@surriel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
rppt@linux.vnet.ibm.com, Peter Zijlstra <peterz@infradead.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
robin.murphy@arm.com, iamjoonsoo.kim@lge.com, treding@nvidia.com,
Kees Cook <keescook@chromium.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
stefanr@s5r6.in-berlin.de, hjc@rock-chips.com,
Heiko Stuebner <heiko@sntech.de>,
airlied@linux.ie, oleksandr_andrushchenko@epam.com,
joro@8bytes.org, pawel@osciak.com,
Kyungmin Park <kyungmin.park@samsung.com>,
mchehab@kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org, Linux-MM <linux-mm@kvack.org>,
linux-arm-kernel@lists.infradead.org,
linux1394-devel@lists.sourceforge.net,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, xen-devel@lists.xen.org,
iommu@lists.linux-foundation.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/9] mm: Introduce new vm_insert_range API
Date: Wed, 21 Nov 2018 04:19:11 -0700 [thread overview]
Message-ID: <833B5050-DEF6-44A0-9832-276F86671212@oracle.com> (raw)
In-Reply-To: <CAFqt6zbOWX5LUTWwoGDJsGdf+pTR6N1yTPVxyr1W3-6Fte39ww@mail.gmail.com>
Could you add a line to the description explicitly stating that a failure
to insert any page in the range will fail the entire routine, something
like:
> * This allows drivers to insert range of kernel pages they've allocated
> * into a user vma. This is a generic function which drivers can use
> * rather than using their own way of mapping range of kernel pages into
> * user vma.
> *
> * A failure to insert any page in the range will fail the call as a whole.
It's obvious when reading the code, but it would be self-documenting to
state it outright.
Thanks!
-- Bill
WARNING: multiple messages have this Message-ID (diff)
From: William Kucharski <william.kucharski-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Souptick Joarder <jrdr.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux-MM <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
linux1394-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Marek Szyprowski
<m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
oleksandr_andrushchenko-uRwfk40T5oI@public.gmane.org,
joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
Russell King - ARM Linux
<linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
rppt-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org,
airlied-cv59FeDIM0c@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
pawel-FA/gS7QP4orQT0dZR+AlfA@public.gmane.org,
Rik van Riel <riel-ebMLmSuQjDVBDgjK7y7TUQ@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
rppt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
Boris Ostrovsky
<boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org,
vbabka-AlSwsSmVLrQ@public.gmane.org, Juergen
Subject: Re: [PATCH 1/9] mm: Introduce new vm_insert_range API
Date: Wed, 21 Nov 2018 04:19:11 -0700 [thread overview]
Message-ID: <833B5050-DEF6-44A0-9832-276F86671212@oracle.com> (raw)
In-Reply-To: <CAFqt6zbOWX5LUTWwoGDJsGdf+pTR6N1yTPVxyr1W3-6Fte39ww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Could you add a line to the description explicitly stating that a failure
to insert any page in the range will fail the entire routine, something
like:
> * This allows drivers to insert range of kernel pages they've allocated
> * into a user vma. This is a generic function which drivers can use
> * rather than using their own way of mapping range of kernel pages into
> * user vma.
> *
> * A failure to insert any page in the range will fail the call as a whole.
It's obvious when reading the code, but it would be self-documenting to
state it outright.
Thanks!
-- Bill
WARNING: multiple messages have this Message-ID (diff)
From: william.kucharski@oracle.com (William Kucharski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] mm: Introduce new vm_insert_range API
Date: Wed, 21 Nov 2018 04:19:11 -0700 [thread overview]
Message-ID: <833B5050-DEF6-44A0-9832-276F86671212@oracle.com> (raw)
In-Reply-To: <CAFqt6zbOWX5LUTWwoGDJsGdf+pTR6N1yTPVxyr1W3-6Fte39ww@mail.gmail.com>
Could you add a line to the description explicitly stating that a failure
to insert any page in the range will fail the entire routine, something
like:
> * This allows drivers to insert range of kernel pages they've allocated
> * into a user vma. This is a generic function which drivers can use
> * rather than using their own way of mapping range of kernel pages into
> * user vma.
> *
> * A failure to insert any page in the range will fail the call as a whole.
It's obvious when reading the code, but it would be self-documenting to
state it outright.
Thanks!
-- Bill
next prev parent reply other threads:[~2018-11-21 11:21 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 15:45 [PATCH 1/9] mm: Introduce new vm_insert_range API Souptick Joarder
2018-11-15 15:45 ` Souptick Joarder
2018-11-15 15:45 ` Souptick Joarder
2018-11-15 18:13 ` Randy Dunlap
2018-11-15 18:13 ` Randy Dunlap
2018-11-15 18:13 ` Randy Dunlap
2018-11-16 5:30 ` Souptick Joarder
2018-11-16 5:30 ` Souptick Joarder
2018-11-16 5:30 ` Souptick Joarder
2018-11-16 5:30 ` Souptick Joarder
2018-11-16 6:40 ` Matthew Wilcox
2018-11-16 6:40 ` Matthew Wilcox
2018-11-16 6:40 ` Matthew Wilcox
2018-11-16 8:15 ` Souptick Joarder
2018-11-16 8:15 ` Souptick Joarder
2018-11-16 8:15 ` Souptick Joarder
2018-11-16 8:15 ` Souptick Joarder
2018-11-16 16:59 ` Randy Dunlap
2018-11-16 16:59 ` Randy Dunlap
2018-11-16 16:59 ` Randy Dunlap
2018-11-16 16:59 ` Randy Dunlap
2018-11-16 6:40 ` Matthew Wilcox
2018-11-15 18:13 ` Randy Dunlap
2018-11-16 17:48 ` Slavomir Kaslev
2018-11-16 17:55 ` Slavomir Kaslev
2018-11-16 17:48 ` Slavomir Kaslev
2018-11-16 17:48 ` Slavomir Kaslev
2018-11-16 18:28 ` Mike Rapoport
2018-11-16 18:28 ` Mike Rapoport
2018-11-16 18:28 ` Mike Rapoport
2018-11-16 18:28 ` Mike Rapoport
2018-11-17 6:56 ` Souptick Joarder
2018-11-17 6:56 ` Souptick Joarder
2018-11-17 6:56 ` Souptick Joarder
2018-11-17 6:56 ` Souptick Joarder
2018-11-17 14:37 ` Matthew Wilcox
2018-11-17 14:37 ` Matthew Wilcox
2018-11-17 14:37 ` Matthew Wilcox
2018-11-17 14:37 ` Matthew Wilcox
2018-11-19 15:13 ` Souptick Joarder
2018-11-19 15:13 ` Souptick Joarder
2018-11-19 15:13 ` Souptick Joarder
2018-11-19 15:13 ` Souptick Joarder
2018-11-19 16:26 ` Mike Rapoport
2018-11-19 16:26 ` Mike Rapoport
2018-11-19 16:26 ` Mike Rapoport
2018-11-19 17:45 ` Souptick Joarder
2018-11-19 17:45 ` Souptick Joarder
2018-11-19 17:45 ` Souptick Joarder
2018-11-19 17:45 ` Souptick Joarder
2018-11-23 7:19 ` Mike Rapoport
2018-11-23 7:19 ` Mike Rapoport
2018-11-23 7:19 ` Mike Rapoport
2018-11-23 7:19 ` Mike Rapoport
2018-11-19 16:26 ` Mike Rapoport
2018-11-21 11:19 ` William Kucharski
2018-11-21 11:19 ` William Kucharski [this message]
2018-11-21 11:19 ` William Kucharski
2018-11-21 11:19 ` William Kucharski
2018-11-21 12:35 ` Matthew Wilcox
2018-11-21 12:35 ` Matthew Wilcox
2018-11-21 12:35 ` Matthew Wilcox
2018-11-21 14:29 ` William Kucharski
2018-11-21 14:29 ` William Kucharski
2018-11-21 14:29 ` William Kucharski
2018-11-21 14:29 ` William Kucharski
2018-11-21 14:29 ` William Kucharski
2018-11-21 12:35 ` Matthew Wilcox
2018-11-28 15:21 ` Heiko Stübner
2018-11-28 15:21 ` Heiko Stübner
2018-11-28 15:21 ` Heiko Stübner
2018-11-28 15:21 ` Heiko Stübner
-- strict thread matches above, loose matches on Subject: below --
2018-11-15 15:45 Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=833B5050-DEF6-44A0-9832-276F86671212@oracle.com \
--to=william.kucharski@oracle.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=jrdr.linux@gmail.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=mhocko@suse.com \
--cc=oleksandr_andrushchenko@epam.com \
--cc=pawel@osciak.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.ibm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=stefanr@s5r6.in-berlin.de \
--cc=treding@nvidia.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.