All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: Rob Herring <robh+dt@kernel.org>, Jason Liu <jason.hui.liu@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 1/1] of: of_reserved_mem: Ensure cma reserved region not cross the low/high memory
Date: Wed, 14 Dec 2016 14:21:26 -0800	[thread overview]
Message-ID: <833f99b1-d10b-27ba-e0f9-a7c6398fb63d@redhat.com> (raw)
In-Reply-To: <CAL_JsqLHh96D0VULuYfYC1P5K_Bbz6iRjizuYP3Mb6bdERbDnA@mail.gmail.com>

On 12/14/2016 12:45 PM, Rob Herring wrote:
> On Wed, Nov 23, 2016 at 5:37 AM, Jason Liu <jason.hui.liu@nxp.com> wrote:
>> Need ensure the cma reserved region not cross the low/high memory boundary
>> when using the dynamic allocation methond through device-tree, otherwise,
>> kernel will fail to boot up when cma reserved region cross how/high mem.
> 
> The kernel command line code setting CMA already deals with this. Why
> don't we just call the CMA code (cma_declare_contiguous) to deal with
> this?
> 
> Rob
> 

That was proposed in the first version[1] but I think this is a generic
problem not specific to CMA. Even non-CMA reservations trying to span
zones could cause problems so the devicetree allocation code should
restrict reservations to a single zone.

Thanks,
Laura


[1] https://marc.info/?l=linux-kernel&m=147928325113103&w=2

WARNING: multiple messages have this Message-ID (diff)
From: Laura Abbott <labbott-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Jason Liu <jason.hui.liu-3arQi8VN3Tc@public.gmane.org>
Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Frank Rowand
	<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/1] of: of_reserved_mem: Ensure cma reserved region not cross the low/high memory
Date: Wed, 14 Dec 2016 14:21:26 -0800	[thread overview]
Message-ID: <833f99b1-d10b-27ba-e0f9-a7c6398fb63d@redhat.com> (raw)
In-Reply-To: <CAL_JsqLHh96D0VULuYfYC1P5K_Bbz6iRjizuYP3Mb6bdERbDnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 12/14/2016 12:45 PM, Rob Herring wrote:
> On Wed, Nov 23, 2016 at 5:37 AM, Jason Liu <jason.hui.liu-3arQi8VN3Tc@public.gmane.org> wrote:
>> Need ensure the cma reserved region not cross the low/high memory boundary
>> when using the dynamic allocation methond through device-tree, otherwise,
>> kernel will fail to boot up when cma reserved region cross how/high mem.
> 
> The kernel command line code setting CMA already deals with this. Why
> don't we just call the CMA code (cma_declare_contiguous) to deal with
> this?
> 
> Rob
> 

That was proposed in the first version[1] but I think this is a generic
problem not specific to CMA. Even non-CMA reservations trying to span
zones could cause problems so the devicetree allocation code should
restrict reservations to a single zone.

Thanks,
Laura


[1] https://marc.info/?l=linux-kernel&m=147928325113103&w=2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-12-14 22:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 11:37 [PATCH 1/1] of: of_reserved_mem: Ensure cma reserved region not cross the low/high memory Jason Liu
2016-11-23 11:37 ` Jason Liu
2016-12-10  4:29 ` Jason Liu
2016-12-10  4:29   ` Jason Liu
2016-12-14 20:45 ` Rob Herring
2016-12-14 20:45   ` Rob Herring
2016-12-14 22:21   ` Laura Abbott [this message]
2016-12-14 22:21     ` Laura Abbott
2016-12-15 13:54     ` Rob Herring
2016-12-15 13:54       ` Rob Herring
2016-12-15 15:10       ` Jason Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=833f99b1-d10b-27ba-e0f9-a7c6398fb63d@redhat.com \
    --to=labbott@redhat.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=jason.hui.liu@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.