[PATCH] clk: Fix memory leak in devm_clk_notifier_register()

* [PATCH] clk: Fix memory leak in devm_clk_notifier_register()
@ 2023-06-17  8:09 Fei Shao
  2023-06-17 20:00 ` [cocci] " Markus Elfring
  0 siblings, 1 reply; 9+ messages in thread
From: Fei Shao @ 2023-06-17  8:09 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Fei Shao, Jerome Brunet, Michael Turquette, linux-clk, linux-kernel

devm_clk_notifier_register() allocates a devres resource for clk
notifier but didn't register that to the device, so the notifier didn't
get unregistered on device detach and the allocated resource was leaked.

This fixes the issue.

Fixes: 6d30d50d037d ("clk: add devm variant of clk_notifier_register")
Signed-off-by: Fei Shao <fshao@chromium.org>
---

 drivers/clk/clk.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 7ac9f7a8cb84..c249f9791ae8 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -4741,6 +4741,7 @@ int devm_clk_notifier_register(struct device *dev, struct clk *clk,
 	if (!ret) {
 		devres->clk = clk;
 		devres->nb = nb;
+		devres_add(dev, devres);
 	} else {
 		devres_free(devres);
 	}
-- 
2.41.0.162.gfafddb0af9-goog


^ permalink raw reply related	[flat|nested] 9+ messages in thread