[PATCH 0/6] vmw_balloon: 64-bit limit support, compaction, shrinker

[PATCH 0/6] vmw_balloon: 64-bit limit support, compaction, shrinker

[Nadav Amit]

Various enhancements for VMware balloon, some of which are remainder
from a previous patch-set.

Patch 1: Aumps the version number, following recent changes
Patch 2: Adds support for 64-bit memory limit
Patches 3-4: Support for compaction
Patch 5: Support for memory shrinker - disabled by default
Patch 6: Split refused pages to improve performance

Since the 3rd patch requires Michael Tsirkin ack, which has not arrived
in the last couple of times the patch was sent, please consider applying
patches 1-2 for 5.1.

Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: linux-mm@kvack.org
Cc: virtualization@lists.linux-foundation.org

Nadav Amit (5):
  vmw_balloon: bump version number
  mm/balloon_compaction: list interfaces
  vmw_balloon: compaction support
  vmw_balloon: add memory shrinker
  vmw_balloon: split refused pages

Xavier Deguillard (1):
  vmw_balloon: support 64-bit memory limit

 drivers/misc/Kconfig               |   1 +
 drivers/misc/vmw_balloon.c         | 511 ++++++++++++++++++++++++++---
 include/linux/balloon_compaction.h |   4 +
 mm/balloon_compaction.c            | 139 +++++---
 4 files changed, 566 insertions(+), 89 deletions(-)

-- 
2.17.1

[PATCH 1/6] vmw_balloon: bump version number

[Nadav Amit]

Following recent changes.

Signed-off-by: Nadav Amit <namit@vmware.com>
---
 drivers/misc/vmw_balloon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
index f8240b87df22..7294f305753f 100644
--- a/drivers/misc/vmw_balloon.c
+++ b/drivers/misc/vmw_balloon.c
@@ -34,7 +34,7 @@
 
 MODULE_AUTHOR("VMware, Inc.");
 MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
-MODULE_VERSION("1.5.0.0-k");
+MODULE_VERSION("1.6.0.0-k");
 MODULE_ALIAS("dmi:*:svnVMware*:*");
 MODULE_ALIAS("vmware_vmmemctl");
 MODULE_LICENSE("GPL");
-- 
2.17.1

Re: [PATCH 1/6] vmw_balloon: bump version number

[Greg Kroah-Hartman]

On Tue, Feb 05, 2019 at 09:13:31PM -0800, Nadav Amit wrote:
> Following recent changes.
> 
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
>  drivers/misc/vmw_balloon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> index f8240b87df22..7294f305753f 100644
> --- a/drivers/misc/vmw_balloon.c
> +++ b/drivers/misc/vmw_balloon.c
> @@ -34,7 +34,7 @@
>  
>  MODULE_AUTHOR("VMware, Inc.");
>  MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
> -MODULE_VERSION("1.5.0.0-k");
> +MODULE_VERSION("1.6.0.0-k");

Please just drop this pointless line, it means nothing and is always out
of date.  It's been removed from many other drivers, and I really don't
want to see it come back.

Your driver "version" is the kernel version, full stop.  That's all you
need to ever worry about.

thanks,

greg k-h

Re: [PATCH 1/6] vmw_balloon: bump version number

[Nadav Amit]

> On Feb 6, 2019, at 8:42 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Feb 05, 2019 at 09:13:31PM -0800, Nadav Amit wrote:
>> Following recent changes.
>> 
>> Signed-off-by: Nadav Amit <namit@vmware.com>
>> ---
>> drivers/misc/vmw_balloon.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
>> index f8240b87df22..7294f305753f 100644
>> --- a/drivers/misc/vmw_balloon.c
>> +++ b/drivers/misc/vmw_balloon.c
>> @@ -34,7 +34,7 @@
>> 
>> MODULE_AUTHOR("VMware, Inc.");
>> MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
>> -MODULE_VERSION("1.5.0.0-k");
>> +MODULE_VERSION("1.6.0.0-k");
> 
> Please just drop this pointless line, it means nothing and is always out
> of date.  It's been removed from many other drivers, and I really don't
> want to see it come back.
> 
> Your driver "version" is the kernel version, full stop.  That's all you
> need to ever worry about.

I understand, and I will inform those who asked for the version bump.

Having said that, I do not see a reference for this policy. I understand
that you removed the MODULE_VERSION from in-kernel drivers, but I also see
that you accepted several drivers last year that used MODULE_VERSION.

Re: [PATCH 1/6] vmw_balloon: bump version number

[Greg Kroah-Hartman]

On Wed, Feb 06, 2019 at 08:39:52PM +0000, Nadav Amit wrote:
> > On Feb 6, 2019, at 8:42 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 
> > On Tue, Feb 05, 2019 at 09:13:31PM -0800, Nadav Amit wrote:
> >> Following recent changes.
> >> 
> >> Signed-off-by: Nadav Amit <namit@vmware.com>
> >> ---
> >> drivers/misc/vmw_balloon.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> >> index f8240b87df22..7294f305753f 100644
> >> --- a/drivers/misc/vmw_balloon.c
> >> +++ b/drivers/misc/vmw_balloon.c
> >> @@ -34,7 +34,7 @@
> >> 
> >> MODULE_AUTHOR("VMware, Inc.");
> >> MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
> >> -MODULE_VERSION("1.5.0.0-k");
> >> +MODULE_VERSION("1.6.0.0-k");
> > 
> > Please just drop this pointless line, it means nothing and is always out
> > of date.  It's been removed from many other drivers, and I really don't
> > want to see it come back.
> > 
> > Your driver "version" is the kernel version, full stop.  That's all you
> > need to ever worry about.
> 
> I understand, and I will inform those who asked for the version bump.
> 
> Having said that, I do not see a reference for this policy. I understand
> that you removed the MODULE_VERSION from in-kernel drivers, but I also see
> that you accepted several drivers last year that used MODULE_VERSION.

I messed up, and will be glad to take patches to remove them.  Usually
that's the last thing I remember to check when reviewing patches, I
can always use the help :)

Also, I only received 1 patch in this series, did something go wrong
with the sending of it?

thanks,

greg k-h

Re: [PATCH 1/6] vmw_balloon: bump version number

[Nadav Amit]

> On Feb 6, 2019, at 1:06 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Wed, Feb 06, 2019 at 08:39:52PM +0000, Nadav Amit wrote:
>>> On Feb 6, 2019, at 8:42 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>>> 
>>> On Tue, Feb 05, 2019 at 09:13:31PM -0800, Nadav Amit wrote:
>>>> Following recent changes.
>>>> 
>>>> Signed-off-by: Nadav Amit <namit@vmware.com>
>>>> ---
>>>> drivers/misc/vmw_balloon.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>> 
>>>> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
>>>> index f8240b87df22..7294f305753f 100644
>>>> --- a/drivers/misc/vmw_balloon.c
>>>> +++ b/drivers/misc/vmw_balloon.c
>>>> @@ -34,7 +34,7 @@
>>>> 
>>>> MODULE_AUTHOR("VMware, Inc.");
>>>> MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
>>>> -MODULE_VERSION("1.5.0.0-k");
>>>> +MODULE_VERSION("1.6.0.0-k");
>>> 
>>> Please just drop this pointless line, it means nothing and is always out
>>> of date.  It's been removed from many other drivers, and I really don't
>>> want to see it come back.
>>> 
>>> Your driver "version" is the kernel version, full stop.  That's all you
>>> need to ever worry about.
>> 
>> I understand, and I will inform those who asked for the version bump.
>> 
>> Having said that, I do not see a reference for this policy. I understand
>> that you removed the MODULE_VERSION from in-kernel drivers, but I also see
>> that you accepted several drivers last year that used MODULE_VERSION.
> 
> I messed up, and will be glad to take patches to remove them.  Usually
> that's the last thing I remember to check when reviewing patches, I
> can always use the help :)
> 
> Also, I only received 1 patch in this series, did something go wrong
> with the sending of it?

Err. Thanks for letting me know. I guess that that I messed up the git-send
trying to avoid cc’ing patch author who got his email address deactivated.

I will resend.

Re: [PATCH 0/6] vmw_balloon: 64-bit limit support, compaction, shrinker

[Michael S. Tsirkin]

On Tue, Feb 05, 2019 at 09:13:30PM -0800, Nadav Amit wrote:
> Various enhancements for VMware balloon, some of which are remainder
> from a previous patch-set.
> 
> Patch 1: Aumps the version number, following recent changes
> Patch 2: Adds support for 64-bit memory limit
> Patches 3-4: Support for compaction
> Patch 5: Support for memory shrinker - disabled by default
> Patch 6: Split refused pages to improve performance
> 
> Since the 3rd patch requires Michael Tsirkin ack, which has not arrived
> in the last couple of times the patch was sent, please consider applying
> patches 1-2 for 5.1.
> 
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: linux-mm@kvack.org
> Cc: virtualization@lists.linux-foundation.org


I don't seem to have got anything except patch 0 either directly
or through virtualization@lists.linux-foundation.org
Could you bounce the relevant patches there?

Thanks!

> Nadav Amit (5):
>   vmw_balloon: bump version number
>   mm/balloon_compaction: list interfaces
>   vmw_balloon: compaction support
>   vmw_balloon: add memory shrinker
>   vmw_balloon: split refused pages
> 
> Xavier Deguillard (1):
>   vmw_balloon: support 64-bit memory limit
> 
>  drivers/misc/Kconfig               |   1 +
>  drivers/misc/vmw_balloon.c         | 511 ++++++++++++++++++++++++++---
>  include/linux/balloon_compaction.h |   4 +
>  mm/balloon_compaction.c            | 139 +++++---
>  4 files changed, 566 insertions(+), 89 deletions(-)
> 
> -- 
> 2.17.1

Re: [PATCH 0/6] vmw_balloon: 64-bit limit support, compaction, shrinker

[Nadav Amit]

> On Feb 6, 2019, at 9:52 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> 
> On Tue, Feb 05, 2019 at 09:13:30PM -0800, Nadav Amit wrote:
>> Various enhancements for VMware balloon, some of which are remainder
>> from a previous patch-set.
>> 
>> Patch 1: Aumps the version number, following recent changes
>> Patch 2: Adds support for 64-bit memory limit
>> Patches 3-4: Support for compaction
>> Patch 5: Support for memory shrinker - disabled by default
>> Patch 6: Split refused pages to improve performance
>> 
>> Since the 3rd patch requires Michael Tsirkin ack, which has not arrived
>> in the last couple of times the patch was sent, please consider applying
>> patches 1-2 for 5.1.
>> 
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Cc: Jason Wang <jasowang@redhat.com>
>> Cc: linux-mm@kvack.org
>> Cc: virtualization@lists.linux-foundation.org
> 
> 
> I don't seem to have got anything except patch 0 either directly
> or through virtualization@lists.linux-foundation.org
> Could you bounce the relevant patches there?

Sorry for that. I will resend.

Re: [PATCH 0/6] vmw_balloon: 64-bit limit support, compaction, shrinker

[Nadav Amit]

> On Feb 6, 2019, at 9:52 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> 
> On Tue, Feb 05, 2019 at 09:13:30PM -0800, Nadav Amit wrote:
>> Various enhancements for VMware balloon, some of which are remainder
>> from a previous patch-set.
>> 
>> Patch 1: Aumps the version number, following recent changes
>> Patch 2: Adds support for 64-bit memory limit
>> Patches 3-4: Support for compaction
>> Patch 5: Support for memory shrinker - disabled by default
>> Patch 6: Split refused pages to improve performance
>> 
>> Since the 3rd patch requires Michael Tsirkin ack, which has not arrived
>> in the last couple of times the patch was sent, please consider applying
>> patches 1-2 for 5.1.
>> 
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Cc: Jason Wang <jasowang@redhat.com>
>> Cc: linux-mm@kvack.org
>> Cc: virtualization@lists.linux-foundation.org
> 
> 
> I don't seem to have got anything except patch 0 either directly
> or through virtualization@lists.linux-foundation.org
> Could you bounce the relevant patches there?

Sorry for that. I will resend.

Re: [PATCH 0/6] vmw_balloon: 64-bit limit support, compaction, shrinker

[Michael S. Tsirkin]

On Tue, Feb 05, 2019 at 09:13:30PM -0800, Nadav Amit wrote:
> Various enhancements for VMware balloon, some of which are remainder
> from a previous patch-set.
> 
> Patch 1: Aumps the version number, following recent changes
> Patch 2: Adds support for 64-bit memory limit
> Patches 3-4: Support for compaction
> Patch 5: Support for memory shrinker - disabled by default
> Patch 6: Split refused pages to improve performance
> 
> Since the 3rd patch requires Michael Tsirkin ack, which has not arrived
> in the last couple of times the patch was sent, please consider applying
> patches 1-2 for 5.1.
> 
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: linux-mm@kvack.org
> Cc: virtualization@lists.linux-foundation.org


I don't seem to have got anything except patch 0 either directly
or through virtualization@lists.linux-foundation.org
Could you bounce the relevant patches there?

Thanks!

> Nadav Amit (5):
>   vmw_balloon: bump version number
>   mm/balloon_compaction: list interfaces
>   vmw_balloon: compaction support
>   vmw_balloon: add memory shrinker
>   vmw_balloon: split refused pages
> 
> Xavier Deguillard (1):
>   vmw_balloon: support 64-bit memory limit
> 
>  drivers/misc/Kconfig               |   1 +
>  drivers/misc/vmw_balloon.c         | 511 ++++++++++++++++++++++++++---
>  include/linux/balloon_compaction.h |   4 +
>  mm/balloon_compaction.c            | 139 +++++---
>  4 files changed, 566 insertions(+), 89 deletions(-)
> 
> -- 
> 2.17.1