[PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Anusha Srivatsa]

There is a new version of DMC available for KBL.

The release notes mentions:
1. Fix for the issue where DC_STATE was getting enabled even
when disabled by driver causing data corruption.

Adding the pull request here as an experiment-
The following changes since commit bf04291309d3169c0ad3b8db52564235bbd08e30:

  WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100)

are available in the git repository at:

  https://github.com/anushasr/linux-firmware.git KBL_DMC

for you to fetch changes up to 2f2b42764455856c2ba63d2154b3b2fbb7424236:

  linux-firmware: DMC firmware for kabylake v1.04 (2017-11-01 19:22:21 -0700)

----------------------------------------------------------------
Anusha Srivatsa (1):
      linux-firmware: DMC firmware for kabylake v1.04

 WHENCE                   |   4 ++++
 i915/kbl_dmc_ver1_04.bin | Bin 0 -> 8840 bytes
 2 files changed, 4 insertions(+)
 create mode 100644 i915/kbl_dmc_ver1_04.bin

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 3e1f86d..5842777 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -40,9 +40,9 @@
 #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
 #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
 
-#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
+#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
 MODULE_FIRMWARE(I915_CSR_KBL);
-#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
+#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
 #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
 MODULE_FIRMWARE(I915_CSR_SKL);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for drm/i915/dmc: DMC 1.04 for Kabylake

[Patchwork]

== Series Details ==

Series: drm/i915/dmc: DMC 1.04 for Kabylake
URL   : https://patchwork.freedesktop.org/series/33022/
State : failure

== Summary ==

Series 33022v1 drm/i915/dmc: DMC 1.04 for Kabylake
https://patchwork.freedesktop.org/api/1.0/series/33022/revisions/1/mbox/

Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-wb:
                pass       -> INCOMPLETE (fi-cnl-y)
Test gem_exec_reloc:
        Subgroup basic-cpu-active:
                fail       -> PASS       (fi-gdg-551) fdo#102582 +1
Test kms_frontbuffer_tracking:
        Subgroup basic:
                dmesg-warn -> PASS       (fi-bdw-5557u) fdo#102473
Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-c:
                pass       -> SKIP       (fi-hsw-4770r)

fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
fdo#102473 https://bugs.freedesktop.org/show_bug.cgi?id=102473

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:442s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:451s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:380s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:540s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:275s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:509s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:512s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:509s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:487s
fi-cfl-s         total:289  pass:253  dwarn:4   dfail:0   fail:0   skip:32  time:556s
fi-cnl-y         total:62   pass:45   dwarn:0   dfail:0   fail:0   skip:16 
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:425s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:265s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:580s
fi-glk-dsi       total:289  pass:258  dwarn:0   dfail:0   fail:1   skip:30  time:492s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:428s
fi-hsw-4770r     total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:433s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:428s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:495s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:463s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:498s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:574s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:479s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:584s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:571s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:459s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:598s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:650s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:518s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:498s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:461s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:573s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:419s

dcf7d008f606b543fef53609a6e336097e6b5694 drm-tip: 2017y-11m-02d-08h-43m-13s UTC integration manifest
903b3ef9653e drm/i915/dmc: DMC 1.04 for Kabylake

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6918/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Jani Nikula]

On Wed, 01 Nov 2017, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> There is a new version of DMC available for KBL.

Nobody's going to pull this to linux-firmware if you don't send it to
the linux-firmware folks...

> The release notes mentions:
> 1. Fix for the issue where DC_STATE was getting enabled even
> when disabled by driver causing data corruption.
>
> Adding the pull request here as an experiment-
> The following changes since commit bf04291309d3169c0ad3b8db52564235bbd08e30:
>
>   WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100)
>
> are available in the git repository at:
>
>   https://github.com/anushasr/linux-firmware.git KBL_DMC

We should have a shared repo for this at freedesktop.org instead of your
private repo at github. And we should use signed tags for pull requests.

BR,
Jani.

>
> for you to fetch changes up to 2f2b42764455856c2ba63d2154b3b2fbb7424236:
>
>   linux-firmware: DMC firmware for kabylake v1.04 (2017-11-01 19:22:21 -0700)
>
> ----------------------------------------------------------------
> Anusha Srivatsa (1):
>       linux-firmware: DMC firmware for kabylake v1.04
>
>  WHENCE                   |   4 ++++
>  i915/kbl_dmc_ver1_04.bin | Bin 0 -> 8840 bytes
>  2 files changed, 4 insertions(+)
>  create mode 100644 i915/kbl_dmc_ver1_04.bin
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 3e1f86d..5842777 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -40,9 +40,9 @@
>  #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
>  #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
>  
> -#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
> +#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
>  MODULE_FIRMWARE(I915_CSR_KBL);
> -#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
> +#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
>  
>  #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
>  MODULE_FIRMWARE(I915_CSR_SKL);

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/dmc: DMC 1.04 for Kabylake

[Patchwork]

== Series Details ==

Series: drm/i915/dmc: DMC 1.04 for Kabylake
URL   : https://patchwork.freedesktop.org/series/33022/
State : success

== Summary ==

Series 33022v1 drm/i915/dmc: DMC 1.04 for Kabylake
https://patchwork.freedesktop.org/api/1.0/series/33022/revisions/1/mbox/

Test kms_cursor_legacy:
        Subgroup basic-flip-before-cursor-varying-size:
                skip       -> PASS       (fi-hsw-4770r)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a-frame-sequence:
                dmesg-warn -> PASS       (fi-skl-6700k)
        Subgroup nonblocking-crc-pipe-b:
                incomplete -> PASS       (fi-skl-6700k)

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:449s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:461s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:384s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:534s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:276s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:509s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:513s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:508s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:492s
fi-cnl-y         total:92   pass:88   dwarn:0   dfail:0   fail:0   skip:4  
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:431s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:268s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:594s
fi-glk-dsi       total:289  pass:258  dwarn:0   dfail:0   fail:1   skip:30  time:494s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:433s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:431s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:436s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:498s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:465s
fi-kbl-7500u     total:289  pass:263  dwarn:1   dfail:0   fail:1   skip:24  time:486s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:578s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:478s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:588s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:568s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:453s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:601s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:650s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:523s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:521s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:458s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:580s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:422s
fi-cnl-y failed to connect after reboot

fca2506bc5d492609e3f1b6e59d667e376a1eb3f drm-tip: 2017y-11m-02d-13h-10m-58s UTC integration manifest
79e0033a464c drm/i915/dmc: DMC 1.04 for Kabylake

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6927/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Rodrigo Vivi]

On Thu, Nov 02, 2017 at 10:34:37AM +0000, Jani Nikula wrote:
> On Wed, 01 Nov 2017, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> > There is a new version of DMC available for KBL.
> 
> Nobody's going to pull this to linux-firmware if you don't send it to
> the linux-firmware folks...

That's intentional. The idea is to send to linux-firmware only after it
passes our CI. So, prepare already in a way that it is easy to just forward when
that happens.

But what I believe we can change is to send that in the cover-letter of
the series.
So cover-letter with pull-request that CI would get automatically,
all related patches on the series, so right now it could be:
patch 0: pull-request
patch 1: kbl dmc 1.04
patch 2: skl dmc 1.27

> 
> > The release notes mentions:
> > 1. Fix for the issue where DC_STATE was getting enabled even
> > when disabled by driver causing data corruption.
> >
> > Adding the pull request here as an experiment-
> > The following changes since commit bf04291309d3169c0ad3b8db52564235bbd08e30:
> >
> >   WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100)
> >
> > are available in the git repository at:
> >
> >   https://github.com/anushasr/linux-firmware.git KBL_DMC
> 
> We should have a shared repo for this at freedesktop.org instead of your
> private repo at github.

I had never seen a particularly need for that before, but with
this new process in place I believe it makes tons of sense.
Who could help to setup a repo and right permissions?
Daniel Stone?

> And we should use signed tags for pull requests.

Yes, tags are essencial here. Specially with this process
of sending here first for CI and only after passing CI fwding
that to linux-firmware.git we need to have tags.

Thanks,
Rodrigo.

> 
> BR,
> Jani.
> 
> >
> > for you to fetch changes up to 2f2b42764455856c2ba63d2154b3b2fbb7424236:
> >
> >   linux-firmware: DMC firmware for kabylake v1.04 (2017-11-01 19:22:21 -0700)
> >
> > ----------------------------------------------------------------
> > Anusha Srivatsa (1):
> >       linux-firmware: DMC firmware for kabylake v1.04
> >
> >  WHENCE                   |   4 ++++
> >  i915/kbl_dmc_ver1_04.bin | Bin 0 -> 8840 bytes
> >  2 files changed, 4 insertions(+)
> >  create mode 100644 i915/kbl_dmc_ver1_04.bin
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> > index 3e1f86d..5842777 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -40,9 +40,9 @@
> >  #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
> >  #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
> >  
> > -#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
> > +#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
> >  MODULE_FIRMWARE(I915_CSR_KBL);
> > -#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
> > +#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
> >  
> >  #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
> >  MODULE_FIRMWARE(I915_CSR_SKL);
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: warning for drm/i915/dmc: DMC 1.04 for Kabylake

[Patchwork]

== Series Details ==

Series: drm/i915/dmc: DMC 1.04 for Kabylake
URL   : https://patchwork.freedesktop.org/series/33022/
State : warning

== Summary ==

Test kms_busy:
        Subgroup extended-modeset-hang-newfb-with-reset-render-B:
                pass       -> DMESG-WARN (shard-hsw)
        Subgroup extended-modeset-hang-oldfb-with-reset-render-A:
                dmesg-warn -> PASS       (shard-hsw)
Test kms_flip:
        Subgroup plain-flip-fb-recreate-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#100368

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368

shard-hsw        total:2539 pass:1431 dwarn:2   dfail:0   fail:9   skip:1097 time:9313s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6927/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Srivatsa, Anusha]

>-----Original Message-----
>From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
>Sent: Thursday, November 2, 2017 3:35 AM
>To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
>gfx@lists.freedesktop.org
>Cc: Vivi, Rodrigo <rodrigo.vivi@intel.com>
>Subject: Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake
>
>On Wed, 01 Nov 2017, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
>> There is a new version of DMC available for KBL.
>
>Nobody's going to pull this to linux-firmware if you don't send it to the linux-
>firmware folks...
>
>> The release notes mentions:
>> 1. Fix for the issue where DC_STATE was getting enabled even when
>> disabled by driver causing data corruption.
>>
>> Adding the pull request here as an experiment- The following changes
>> since commit bf04291309d3169c0ad3b8db52564235bbd08e30:
>>
>>   WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100)
>>
>> are available in the git repository at:
>>
>>   https://github.com/anushasr/linux-firmware.git KBL_DMC
>
>We should have a shared repo for this at freedesktop.org instead of your private
>repo at github. And we should use signed tags for pull requests.
Hi Jani,

I will see to it that a freedesktop repo is created for this purpose moving forward. I will use signed tags too.

Thanks,
Anusha

>BR,
>Jani.
>
>>
>> for you to fetch changes up to 2f2b42764455856c2ba63d2154b3b2fbb7424236:
>>
>>   linux-firmware: DMC firmware for kabylake v1.04 (2017-11-01 19:22:21
>> -0700)
>>
>> ----------------------------------------------------------------
>> Anusha Srivatsa (1):
>>       linux-firmware: DMC firmware for kabylake v1.04
>>
>>  WHENCE                   |   4 ++++
>>  i915/kbl_dmc_ver1_04.bin | Bin 0 -> 8840 bytes
>>  2 files changed, 4 insertions(+)
>>  create mode 100644 i915/kbl_dmc_ver1_04.bin
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_csr.c
>> b/drivers/gpu/drm/i915/intel_csr.c
>> index 3e1f86d..5842777 100644
>> --- a/drivers/gpu/drm/i915/intel_csr.c
>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>> @@ -40,9 +40,9 @@
>>  #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
>>  #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
>>
>> -#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
>> +#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
>>  MODULE_FIRMWARE(I915_CSR_KBL);
>> -#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
>> +#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
>>
>>  #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
>>  MODULE_FIRMWARE(I915_CSR_SKL);
>
>--
>Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Pandiyan, Dhinakaran]

On Thu, 2017-11-02 at 07:27 -0700, Rodrigo Vivi wrote:
> On Thu, Nov 02, 2017 at 10:34:37AM +0000, Jani Nikula wrote:
> > On Wed, 01 Nov 2017, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> > > There is a new version of DMC available for KBL.
> > 
> > Nobody's going to pull this to linux-firmware if you don't send it to
> > the linux-firmware folks...
> 
> That's intentional. The idea is to send to linux-firmware only after it
> passes our CI. So, prepare already in a way that it is easy to just forward when
> that happens.
> 
> But what I believe we can change is to send that in the cover-letter of
> the series.
> So cover-letter with pull-request that CI would get automatically,
> all related patches on the series, so right now it could be:
> patch 0: pull-request
> patch 1: kbl dmc 1.04
> patch 2: skl dmc 1.27
This patch updates only KBL firmware. Is there an upcoming 1.27 release
for SKL?
> 
> > 
> > > The release notes mentions:
> > > 1. Fix for the issue where DC_STATE was getting enabled even
> > > when disabled by driver causing data corruption.
> > >
> > > Adding the pull request here as an experiment-
> > > The following changes since commit bf04291309d3169c0ad3b8db52564235bbd08e30:
> > >
> > >   WHENCE: Add new qed firmware (2017-10-09 18:03:26 +0100)
> > >
> > > are available in the git repository at:
> > >
> > >   https://github.com/anushasr/linux-firmware.git KBL_DMC
> > 
> > We should have a shared repo for this at freedesktop.org instead of your
> > private repo at github.
> 
> I had never seen a particularly need for that before, but with
> this new process in place I believe it makes tons of sense.
> Who could help to setup a repo and right permissions?
> Daniel Stone?
> 
> > And we should use signed tags for pull requests.
> 
> Yes, tags are essencial here. Specially with this process
> of sending here first for CI and only after passing CI fwding
> that to linux-firmware.git we need to have tags.
> 
> Thanks,
> Rodrigo.
> 
> > 
> > BR,
> > Jani.
> > 
> > >
> > > for you to fetch changes up to 2f2b42764455856c2ba63d2154b3b2fbb7424236:
> > >
> > >   linux-firmware: DMC firmware for kabylake v1.04 (2017-11-01 19:22:21 -0700)
> > >
> > > ----------------------------------------------------------------
> > > Anusha Srivatsa (1):
> > >       linux-firmware: DMC firmware for kabylake v1.04
> > >
> > >  WHENCE                   |   4 ++++
> > >  i915/kbl_dmc_ver1_04.bin | Bin 0 -> 8840 bytes
> > >  2 files changed, 4 insertions(+)
> > >  create mode 100644 i915/kbl_dmc_ver1_04.bin
> > >
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> > > index 3e1f86d..5842777 100644
> > > --- a/drivers/gpu/drm/i915/intel_csr.c
> > > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > > @@ -40,9 +40,9 @@
> > >  #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
> > >  #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
> > >  
> > > -#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
> > > +#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
> > >  MODULE_FIRMWARE(I915_CSR_KBL);
> > > -#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
> > > +#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
> > >  
> > >  #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
> > >  MODULE_FIRMWARE(I915_CSR_SKL);
> > 
> > -- 
> > Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Daniel Stone]

Hi,

On 2 November 2017 at 18:04, Pandiyan, Dhinakaran
<dhinakaran.pandiyan@intel.com> wrote:
> On Thu, 2017-11-02 at 07:27 -0700, Rodrigo Vivi wrote:
>> That's intentional. The idea is to send to linux-firmware only after it
>> passes our CI. So, prepare already in a way that it is easy to just forward when
>> that happens.
>>
>> But what I believe we can change is to send that in the cover-letter of
>> the series.
>> So cover-letter with pull-request that CI would get automatically,
>> all related patches on the series, so right now it could be:
>> patch 0: pull-request
>> patch 1: kbl dmc 1.04
>> patch 2: skl dmc 1.27
> This patch updates only KBL firmware. Is there an upcoming 1.27 release
> for SKL?

If there is, it hasn't yet made it to 01.org either.

Cheers,
Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Srivatsa, Anusha]

>-----Original Message-----
>From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
>Daniel Stone
>Sent: Friday, November 3, 2017 6:40 AM
>To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>
>Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>
>Subject: Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake
>
>Hi,
>
>On 2 November 2017 at 18:04, Pandiyan, Dhinakaran
><dhinakaran.pandiyan@intel.com> wrote:
>> On Thu, 2017-11-02 at 07:27 -0700, Rodrigo Vivi wrote:
>>> That's intentional. The idea is to send to linux-firmware only after
>>> it passes our CI. So, prepare already in a way that it is easy to
>>> just forward when that happens.
>>>
>>> But what I believe we can change is to send that in the cover-letter
>>> of the series.
>>> So cover-letter with pull-request that CI would get automatically,
>>> all related patches on the series, so right now it could be:
>>> patch 0: pull-request
>>> patch 1: kbl dmc 1.04
>>> patch 2: skl dmc 1.27
>> This patch updates only KBL firmware. Is there an upcoming 1.27
>> release for SKL?

1.27 to be sent out to public soon.

Anusha 
>If there is, it hasn't yet made it to 01.org either.
>
>Cheers,
>Daniel
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Srivatsa, Anusha]

>-----Original Message-----
>From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
>Daniel Stone
>Sent: Friday, November 3, 2017 6:40 AM
>To: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>
>Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi@intel.com>
>Subject: Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake
>
>Hi,
>
>On 2 November 2017 at 18:04, Pandiyan, Dhinakaran
><dhinakaran.pandiyan@intel.com> wrote:
>> On Thu, 2017-11-02 at 07:27 -0700, Rodrigo Vivi wrote:
>>> That's intentional. The idea is to send to linux-firmware only after
>>> it passes our CI. So, prepare already in a way that it is easy to
>>> just forward when that happens.
>>>
>>> But what I believe we can change is to send that in the cover-letter
>>> of the series.
>>> So cover-letter with pull-request that CI would get automatically,
>>> all related patches on the series, so right now it could be:
>>> patch 0: pull-request
>>> patch 1: kbl dmc 1.04
>>> patch 2: skl dmc 1.27
>> This patch updates only KBL firmware. Is there an upcoming 1.27
>> release for SKL?
>
>If there is, it hasn't yet made it to 01.org either.

Daniel,
The plan is to release the firmware to 01.org once we get ack from CI. Once we get ack, I will also send pull request to linux-firmware.

I actually need your help in setting up a shared repo on freedesktop from where I can send pull requests.... I am currently doing that through my private github account. 

Regards,
Anusha
>Cheers,
>Daniel
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Jani Nikula]

On Thu, 09 Nov 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Thu, Nov 09, 2017 at 06:51:43PM +0000, Anusha Srivatsa wrote:
>> There is a new version of DMC available for KBL.
>> 
>> The release notes mentions:
>> 1. Fix for the issue where DC_STATE was getting enabled even
>> when disabled by driver causing data corruption.
>
> v2: Remove pull request from commit message (Rodrigo).
>
>> 
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Since this got tested by CI already I'm going to merge as soon as
> I see the pull request flowing to linux-firmware.git.

Pushed, thanks for the patch and review.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=cb12249bf495460abf9945c8a8bf2a13a07c235a

BR,
Jani.

>
> But I also hope linux-firmware.git gets faster in accepting
> our pull requests...
>
> Thanks,
> Rodrigo.
>
>> ---
>>  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
>> index 77d8b3d..07e4f7b 100644
>> --- a/drivers/gpu/drm/i915/intel_csr.c
>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>> @@ -40,9 +40,9 @@
>>  #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
>>  #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
>>  
>> -#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
>> +#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
>>  MODULE_FIRMWARE(I915_CSR_KBL);
>> -#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
>> +#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
>>  
>>  #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
>>  MODULE_FIRMWARE(I915_CSR_SKL);
>> -- 
>> 2.7.4
>> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Rodrigo Vivi]

On Thu, Nov 09, 2017 at 06:51:43PM +0000, Anusha Srivatsa wrote:
> There is a new version of DMC available for KBL.
> 
> The release notes mentions:
> 1. Fix for the issue where DC_STATE was getting enabled even
> when disabled by driver causing data corruption.

v2: Remove pull request from commit message (Rodrigo).

> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Since this got tested by CI already I'm going to merge as soon as
I see the pull request flowing to linux-firmware.git.

But I also hope linux-firmware.git gets faster in accepting
our pull requests...

Thanks,
Rodrigo.

> ---
>  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 77d8b3d..07e4f7b 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -40,9 +40,9 @@
>  #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
>  #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
>  
> -#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
> +#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
>  MODULE_FIRMWARE(I915_CSR_KBL);
> -#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
> +#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
>  
>  #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
>  MODULE_FIRMWARE(I915_CSR_SKL);
> -- 
> 2.7.4
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

[Anusha Srivatsa]

There is a new version of DMC available for KBL.

The release notes mentions:
1. Fix for the issue where DC_STATE was getting enabled even
when disabled by driver causing data corruption.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 77d8b3d..07e4f7b 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -40,9 +40,9 @@
 #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
 #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
 
-#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
+#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
 MODULE_FIRMWARE(I915_CSR_KBL);
-#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
+#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
 #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
 MODULE_FIRMWARE(I915_CSR_SKL);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx