All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Nathan Chancellor <natechancellor@gmail.com>
Cc: Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v3] arm64: mm: Fix unused variable warning in zone_sizes_init
Date: Wed, 16 Oct 2019 17:09:30 +0200	[thread overview]
Message-ID: <83c223c14c55aff1c8c9b30b0760c7e13c928209.camel@suse.de> (raw)
In-Reply-To: <20191016150846.GO49619@arrakis.emea.arm.com>

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

On Wed, 2019-10-16 at 16:08 +0100, Catalin Marinas wrote:
> On Wed, Oct 16, 2019 at 07:47:14AM -0700, Nathan Chancellor wrote:
> > When building arm64 allnoconfig, CONFIG_ZONE_DMA and CONFIG_ZONE_DMA32
> > get disabled so there is a warning about max_dma being unused.
> > 
> > ../arch/arm64/mm/init.c:215:16: warning: unused variable 'max_dma'
> > [-Wunused-variable]
> >         unsigned long max_dma = min;
> >                       ^
> > 1 warning generated.
> > 
> > Add __maybe_unused to make this clear to the compiler.
> > 
> > Fixes: 1a8e1cef7603 ("arm64: use both ZONE_DMA and ZONE_DMA32")
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> 
> Thanks. Queued on top of Nicolas' patches for 5.5. I also added Nicolas'
> reviewed-by from v2 as I suspect it still stands.

Yes, thanks!


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Nathan Chancellor <natechancellor@gmail.com>
Cc: Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next v3] arm64: mm: Fix unused variable warning in zone_sizes_init
Date: Wed, 16 Oct 2019 17:09:30 +0200	[thread overview]
Message-ID: <83c223c14c55aff1c8c9b30b0760c7e13c928209.camel@suse.de> (raw)
In-Reply-To: <20191016150846.GO49619@arrakis.emea.arm.com>


[-- Attachment #1.1: Type: text/plain, Size: 830 bytes --]

On Wed, 2019-10-16 at 16:08 +0100, Catalin Marinas wrote:
> On Wed, Oct 16, 2019 at 07:47:14AM -0700, Nathan Chancellor wrote:
> > When building arm64 allnoconfig, CONFIG_ZONE_DMA and CONFIG_ZONE_DMA32
> > get disabled so there is a warning about max_dma being unused.
> > 
> > ../arch/arm64/mm/init.c:215:16: warning: unused variable 'max_dma'
> > [-Wunused-variable]
> >         unsigned long max_dma = min;
> >                       ^
> > 1 warning generated.
> > 
> > Add __maybe_unused to make this clear to the compiler.
> > 
> > Fixes: 1a8e1cef7603 ("arm64: use both ZONE_DMA and ZONE_DMA32")
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> 
> Thanks. Queued on top of Nicolas' patches for 5.5. I also added Nicolas'
> reviewed-by from v2 as I suspect it still stands.

Yes, thanks!


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-16 15:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 22:43 [PATCH -next] arm64: mm: Fix unused variable warning in zone_sizes_init Nathan Chancellor
2019-10-15 22:43 ` Nathan Chancellor
2019-10-16  3:00 ` Will Deacon
2019-10-16  3:00   ` Will Deacon
2019-10-16  3:08   ` Nathan Chancellor
2019-10-16  3:08     ` Nathan Chancellor
2019-10-16  3:11 ` [PATCH -next v2] " Nathan Chancellor
2019-10-16  3:11   ` Nathan Chancellor
2019-10-16  8:54   ` Nicolas Saenz Julienne
2019-10-16  8:54     ` Nicolas Saenz Julienne
2019-10-16 14:40   ` Catalin Marinas
2019-10-16 14:40     ` Catalin Marinas
2019-10-16 14:47   ` [PATCH -next v3] " Nathan Chancellor
2019-10-16 14:47     ` Nathan Chancellor
2019-10-16 15:08     ` Catalin Marinas
2019-10-16 15:08       ` Catalin Marinas
2019-10-16 15:09       ` Nicolas Saenz Julienne [this message]
2019-10-16 15:09         ` Nicolas Saenz Julienne
2019-10-16 15:51         ` Nathan Chancellor
2019-10-16 15:51           ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83c223c14c55aff1c8c9b30b0760c7e13c928209.camel@suse.de \
    --to=nsaenzjulienne@suse.de \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.