* [PATCH] pxa168fb: fix release function mismatch in probe failure
@ 2019-12-05 16:06 ` Chuhong Yuan
0 siblings, 0 replies; 6+ messages in thread
From: Chuhong Yuan @ 2019-12-05 16:06 UTC (permalink / raw)
Cc: Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-kernel,
Chuhong Yuan
The driver uses kfree() to release the resource allocated by
framebuffer_alloc(), which does not match.
Use framebuffer_release() instead to fix it.
Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 (base layer)")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/video/fbdev/pxa168fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index 1410f476e135..b9435133b6f3 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -769,7 +769,7 @@ static int pxa168fb_probe(struct platform_device *pdev)
dma_free_coherent(fbi->dev, info->fix.smem_len,
info->screen_base, fbi->fb_start_dma);
failed_free_info:
- kfree(info);
+ framebuffer_release(info);
dev_err(&pdev->dev, "frame buffer device init failed with %d\n", ret);
return ret;
--
2.24.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] pxa168fb: fix release function mismatch in probe failure
@ 2019-12-05 16:06 ` Chuhong Yuan
0 siblings, 0 replies; 6+ messages in thread
From: Chuhong Yuan @ 2019-12-05 16:06 UTC (permalink / raw)
Cc: linux-fbdev, Chuhong Yuan, linux-kernel, dri-devel,
Bartlomiej Zolnierkiewicz
The driver uses kfree() to release the resource allocated by
framebuffer_alloc(), which does not match.
Use framebuffer_release() instead to fix it.
Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 (base layer)")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/video/fbdev/pxa168fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index 1410f476e135..b9435133b6f3 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -769,7 +769,7 @@ static int pxa168fb_probe(struct platform_device *pdev)
dma_free_coherent(fbi->dev, info->fix.smem_len,
info->screen_base, fbi->fb_start_dma);
failed_free_info:
- kfree(info);
+ framebuffer_release(info);
dev_err(&pdev->dev, "frame buffer device init failed with %d\n", ret);
return ret;
--
2.24.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] pxa168fb: fix release function mismatch in probe failure
@ 2019-12-05 16:06 ` Chuhong Yuan
0 siblings, 0 replies; 6+ messages in thread
From: Chuhong Yuan @ 2019-12-05 16:06 UTC (permalink / raw)
Cc: linux-fbdev, Chuhong Yuan, linux-kernel, dri-devel,
Bartlomiej Zolnierkiewicz
The driver uses kfree() to release the resource allocated by
framebuffer_alloc(), which does not match.
Use framebuffer_release() instead to fix it.
Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 (base layer)")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/video/fbdev/pxa168fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index 1410f476e135..b9435133b6f3 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -769,7 +769,7 @@ static int pxa168fb_probe(struct platform_device *pdev)
dma_free_coherent(fbi->dev, info->fix.smem_len,
info->screen_base, fbi->fb_start_dma);
failed_free_info:
- kfree(info);
+ framebuffer_release(info);
dev_err(&pdev->dev, "frame buffer device init failed with %d\n", ret);
return ret;
--
2.24.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] pxa168fb: fix release function mismatch in probe failure
2019-12-05 16:06 ` Chuhong Yuan
(?)
@ 2020-01-15 15:51 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-15 15:51 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: dri-devel, linux-fbdev, linux-kernel
On 12/5/19 5:06 PM, Chuhong Yuan wrote:
> The driver uses kfree() to release the resource allocated by
> framebuffer_alloc(), which does not match.
> Use framebuffer_release() instead to fix it.
For pxa168fb driver framebuffer_release() does only kfree() so
there is no real breakage currently. Lets fix it anyway so it
won't break in the future.
> Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 (base layer)")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Patch queued for v5.6, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/pxa168fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
> index 1410f476e135..b9435133b6f3 100644
> --- a/drivers/video/fbdev/pxa168fb.c
> +++ b/drivers/video/fbdev/pxa168fb.c
> @@ -769,7 +769,7 @@ static int pxa168fb_probe(struct platform_device *pdev)
> dma_free_coherent(fbi->dev, info->fix.smem_len,
> info->screen_base, fbi->fb_start_dma);
> failed_free_info:
> - kfree(info);
> + framebuffer_release(info);
>
> dev_err(&pdev->dev, "frame buffer device init failed with %d\n", ret);
> return ret;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pxa168fb: fix release function mismatch in probe failure
@ 2020-01-15 15:51 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-15 15:51 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: linux-fbdev, linux-kernel, dri-devel
On 12/5/19 5:06 PM, Chuhong Yuan wrote:
> The driver uses kfree() to release the resource allocated by
> framebuffer_alloc(), which does not match.
> Use framebuffer_release() instead to fix it.
For pxa168fb driver framebuffer_release() does only kfree() so
there is no real breakage currently. Lets fix it anyway so it
won't break in the future.
> Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 (base layer)")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Patch queued for v5.6, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/pxa168fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
> index 1410f476e135..b9435133b6f3 100644
> --- a/drivers/video/fbdev/pxa168fb.c
> +++ b/drivers/video/fbdev/pxa168fb.c
> @@ -769,7 +769,7 @@ static int pxa168fb_probe(struct platform_device *pdev)
> dma_free_coherent(fbi->dev, info->fix.smem_len,
> info->screen_base, fbi->fb_start_dma);
> failed_free_info:
> - kfree(info);
> + framebuffer_release(info);
>
> dev_err(&pdev->dev, "frame buffer device init failed with %d\n", ret);
> return ret;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pxa168fb: fix release function mismatch in probe failure
@ 2020-01-15 15:51 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-15 15:51 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: linux-fbdev, linux-kernel, dri-devel
On 12/5/19 5:06 PM, Chuhong Yuan wrote:
> The driver uses kfree() to release the resource allocated by
> framebuffer_alloc(), which does not match.
> Use framebuffer_release() instead to fix it.
For pxa168fb driver framebuffer_release() does only kfree() so
there is no real breakage currently. Lets fix it anyway so it
won't break in the future.
> Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 (base layer)")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Patch queued for v5.6, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/pxa168fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
> index 1410f476e135..b9435133b6f3 100644
> --- a/drivers/video/fbdev/pxa168fb.c
> +++ b/drivers/video/fbdev/pxa168fb.c
> @@ -769,7 +769,7 @@ static int pxa168fb_probe(struct platform_device *pdev)
> dma_free_coherent(fbi->dev, info->fix.smem_len,
> info->screen_base, fbi->fb_start_dma);
> failed_free_info:
> - kfree(info);
> + framebuffer_release(info);
>
> dev_err(&pdev->dev, "frame buffer device init failed with %d\n", ret);
> return ret;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-15 15:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20191205160628epcas4p38c1843647699dcbd209c5381d65ab869@epcas4p3.samsung.com>
2019-12-05 16:06 ` [PATCH] pxa168fb: fix release function mismatch in probe failure Chuhong Yuan
2019-12-05 16:06 ` Chuhong Yuan
2019-12-05 16:06 ` Chuhong Yuan
2020-01-15 15:51 ` Bartlomiej Zolnierkiewicz
2020-01-15 15:51 ` Bartlomiej Zolnierkiewicz
2020-01-15 15:51 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.