From: "Cédric Le Goater" <clg@kaod.org> To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org> Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>, <linux-pci@vger.kernel.org>, <xen-devel@lists.xenproject.org>, Juergen Gross <jgross@suse.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Niklas Schnelle <schnelle@linux.ibm.com>, <linux-s390@vger.kernel.org>, Heiko Carstens <hca@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Logan Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>, <linux-ntb@googlegroups.com> Subject: Re: [patch] genirq/msi: Populate sysfs entry only once Date: Tue, 11 Jan 2022 10:02:01 +0100 [thread overview] Message-ID: <83cac5d2-b5f2-836c-1f4f-bfe054a8bedb@kaod.org> (raw) In-Reply-To: <87leznqx2a.ffs@tglx> On 1/10/22 19:12, Thomas Gleixner wrote: > The MSI entries for multi-MSI are populated en bloc for the MSI descriptor, > but the current code invokes the population inside the per interrupt loop > which triggers a warning in the sysfs code and causes the interrupt > allocation to fail. > > Move it outside of the loop so it works correctly for single and multi-MSI. > > Fixes: bf5e758f02fc ("genirq/msi: Simplify sysfs handling") > Reported-by: Borislav Petkov <bp@alien8.de> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > kernel/irq/msi.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > --- a/kernel/irq/msi.c > +++ b/kernel/irq/msi.c > @@ -887,12 +887,11 @@ int __msi_domain_alloc_irqs(struct irq_d > ret = msi_init_virq(domain, virq + i, vflags); > if (ret) > return ret; > - > - if (info->flags & MSI_FLAG_DEV_SYSFS) { > - ret = msi_sysfs_populate_desc(dev, desc); > - if (ret) > - return ret; > - } > + } > + if (info->flags & MSI_FLAG_DEV_SYSFS) { > + ret = msi_sysfs_populate_desc(dev, desc); > + if (ret) > + return ret; > } > allocated++; > } >
WARNING: multiple messages have this Message-ID (diff)
From: "Cédric Le Goater" <clg@kaod.org> To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org> Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Niklas Schnelle <schnelle@linux.ibm.com>, linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Logan Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>, linux-ntb@googlegroups.com Subject: Re: [patch] genirq/msi: Populate sysfs entry only once Date: Tue, 11 Jan 2022 10:02:01 +0100 [thread overview] Message-ID: <83cac5d2-b5f2-836c-1f4f-bfe054a8bedb@kaod.org> (raw) In-Reply-To: <87leznqx2a.ffs@tglx> On 1/10/22 19:12, Thomas Gleixner wrote: > The MSI entries for multi-MSI are populated en bloc for the MSI descriptor, > but the current code invokes the population inside the per interrupt loop > which triggers a warning in the sysfs code and causes the interrupt > allocation to fail. > > Move it outside of the loop so it works correctly for single and multi-MSI. > > Fixes: bf5e758f02fc ("genirq/msi: Simplify sysfs handling") > Reported-by: Borislav Petkov <bp@alien8.de> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > kernel/irq/msi.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > --- a/kernel/irq/msi.c > +++ b/kernel/irq/msi.c > @@ -887,12 +887,11 @@ int __msi_domain_alloc_irqs(struct irq_d > ret = msi_init_virq(domain, virq + i, vflags); > if (ret) > return ret; > - > - if (info->flags & MSI_FLAG_DEV_SYSFS) { > - ret = msi_sysfs_populate_desc(dev, desc); > - if (ret) > - return ret; > - } > + } > + if (info->flags & MSI_FLAG_DEV_SYSFS) { > + ret = msi_sysfs_populate_desc(dev, desc); > + if (ret) > + return ret; > } > allocated++; > } >
next prev parent reply other threads:[~2022-01-11 9:02 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-06 22:51 [patch V2 00/31] genirq/msi, PCI/MSI: Spring cleaning - Part 3 Thomas Gleixner 2021-12-06 22:51 ` [patch V2 01/31] genirq/msi: Move descriptor list to struct msi_device_data Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 02/31] genirq/msi: Add mutex for MSI list protection Thomas Gleixner 2021-12-09 0:47 ` Jason Gunthorpe 2021-12-09 20:07 ` Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 03/31] genirq/msi: Provide msi_domain_alloc/free_irqs_descs_locked() Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 04/31] genirq/msi: Provide a set of advanced MSI accessors and iterators Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 05/31] genirq/msi: Provide msi_alloc_msi_desc() and a simple allocator Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 06/31] genirq/msi: Provide domain flags to allocate/free MSI descriptors automatically Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 07/31] PCI/MSI: Protect MSI operations Thomas Gleixner 2021-12-07 21:06 ` Bjorn Helgaas 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 08/31] PCI/MSI: Use msi_add_msi_desc() Thomas Gleixner 2021-12-07 21:07 ` Bjorn Helgaas 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 09/31] PCI/MSI: Let core code free MSI descriptors Thomas Gleixner 2021-12-07 21:07 ` Bjorn Helgaas 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 10/31] PCI/MSI: Use msi_on_each_desc() Thomas Gleixner 2021-12-07 21:07 ` Bjorn Helgaas 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 11/31] x86/pci/xen: Use msi_for_each_desc() Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 12/31] xen/pcifront: Rework MSI handling Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 13/31] s390/pci: Rework MSI descriptor walk Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 14/31] powerpc/4xx/hsta: Rework MSI handling Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 15/31] powerpc/cell/axon_msi: Convert to msi_on_each_desc() Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 16/31] powerpc/pasemi/msi: Convert to msi_on_each_dec() Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 17/31] powerpc/fsl_msi: Use msi_for_each_desc() Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 18/31] powerpc/mpic_u3msi: Use msi_for_each-desc() Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 19/31] PCI: hv: Rework MSI handling Thomas Gleixner 2021-12-07 21:08 ` Bjorn Helgaas 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 20/31] NTB/msi: Convert to msi_on_each_desc() Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 21/31] soc: ti: ti_sci_inta_msi: Rework MSI descriptor allocation Thomas Gleixner 2021-12-15 20:50 ` Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 22/31] soc: ti: ti_sci_inta_msi: Remove ti_sci_inta_msi_domain_free_irqs() Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 23/31] bus: fsl-mc-msi: Simplify MSI descriptor handling Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 24/31] platform-msi: Let core code handle MSI descriptors Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 25/31] platform-msi: Simplify platform device MSI code Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 26/31] genirq/msi: Make interrupt allocation less convoluted Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 27/31] genirq/msi: Convert to new functions Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 28/31] genirq/msi: Mop up old interfaces Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 29/31] genirq/msi: Add abuse prevention comment to msi header Thomas Gleixner 2021-12-07 8:21 ` Greg Kroah-Hartman 2021-12-07 12:46 ` Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-06 22:51 ` [patch V2 30/31] genirq/msi: Simplify sysfs handling Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2022-01-10 18:12 ` [patch] genirq/msi: Populate sysfs entry only once Thomas Gleixner 2022-01-10 18:15 ` Borislav Petkov 2022-01-10 18:28 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2022-01-11 8:57 ` [patch] " Greg Kroah-Hartman 2022-01-11 9:02 ` Cédric Le Goater [this message] 2022-01-11 9:02 ` Cédric Le Goater 2022-01-12 0:05 ` Kunihiko Hayashi 2022-01-18 23:59 ` Thomas Gleixner 2022-01-19 8:45 ` Kunihiko Hayashi 2021-12-06 22:51 ` [patch V2 31/31] genirq/msi: Convert storage to xarray Thomas Gleixner 2021-12-16 21:40 ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner 2021-12-09 1:01 ` [patch V2 00/31] genirq/msi, PCI/MSI: Spring cleaning - Part 3 Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=83cac5d2-b5f2-836c-1f4f-bfe054a8bedb@kaod.org \ --to=clg@kaod.org \ --cc=alex.williamson@redhat.com \ --cc=allenbh@gmail.com \ --cc=ashok.raj@intel.com \ --cc=borntraeger@de.ibm.com \ --cc=dave.jiang@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=hca@linux.ibm.com \ --cc=helgaas@kernel.org \ --cc=jdmason@kudzu.us \ --cc=jgg@nvidia.com \ --cc=jgross@suse.com \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-ntb@googlegroups.com \ --cc=linux-pci@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=logang@deltatee.com \ --cc=maz@kernel.org \ --cc=megha.dey@intel.com \ --cc=schnelle@linux.ibm.com \ --cc=tglx@linutronix.de \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.