All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Wright Feng <wright.feng@cypress.com>, linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	chi-hsien.lin@cypress.com
Subject: Re: [PATCH 2/2] brcmfmac: Set pacing shift before transmitting skb to bus
Date: Mon, 22 Jun 2020 10:57:25 +0200	[thread overview]
Message-ID: <83f89386-f5ae-91ef-d135-a1a0c9a55acb@broadcom.com> (raw)
In-Reply-To: <20200622020721.498-3-wright.feng@cypress.com>

On 6/22/2020 4:07 AM, Wright Feng wrote:
> Linux 3.6 introduces TSQ which has a per socket threshold for TCP Tx
> packet to reduce latency. In flow control mode, host driver enqueues skb
> in hanger and TCP doesn't push new skb frees until host frees the skb when
> receiving fwstatus event. So set pacing shift 8 to send them as a single
> large aggregate frame to the bus layer.
> 
> 43455 TX TCP throughput in FC mode 2 on Linux 5.4.18
> sk_pacing_shift : Throughput
> 10: 190 Mbps
>   9: 216 Mbps
>   8: 233 Mbps (Max throughput)
>   7: 233 Mpbs

In this patch the pacing shift update is done irrespective of the FC 
mode so I would like to see similar measurements for the other FC mode 
configurations.

Regards,
Arend

  reply	other threads:[~2020-06-22  8:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22  2:07 [PATCH 0/2] brcmfmac: Stability and throughput changes Wright Feng
2020-06-22  2:07 ` [PATCH 1/2] brcmfmac: set state of hanger slot to FREE when flushing PSQ Wright Feng
2020-06-22  8:58   ` Arend Van Spriel
2020-06-22  2:07 ` [PATCH 2/2] brcmfmac: Set pacing shift before transmitting skb to bus Wright Feng
2020-06-22  8:57   ` Arend Van Spriel [this message]
2020-06-24  5:45     ` Wright Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83f89386-f5ae-91ef-d135-a1a0c9a55acb@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=chi-hsien.lin@cypress.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wright.feng@cypress.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.