From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Wright Feng <wright.feng@cypress.com>, linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Kalle Valo <kvalo@codeaurora.org>,
chi-hsien.lin@cypress.com
Subject: Re: [PATCH 1/2] brcmfmac: set state of hanger slot to FREE when flushing PSQ
Date: Mon, 22 Jun 2020 10:58:21 +0200 [thread overview]
Message-ID: <8402643f-7b1f-f6dc-a6f7-c572b95836de@broadcom.com> (raw)
In-Reply-To: <20200622020721.498-2-wright.feng@cypress.com>
On 6/22/2020 4:07 AM, Wright Feng wrote:
> When USB or SDIO device got abnormal bus disconnection, host driver
> tried to clean up the skbs in PSQ and TXQ (The skb's pointer in hanger
> slot linked to PSQ and TSQ), so we should set the state of skb hanger slot
> to BRCMF_FWS_HANGER_ITEM_STATE_FREE before freeing skb.
> In brcmf_fws_bus_txq_cleanup it already sets
> BRCMF_FWS_HANGER_ITEM_STATE_FREE before freeing skb, therefore we add the
> same thing in brcmf_fws_psq_flush to avoid following warning message.
[...]
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Wright Feng <wright.feng@cypress.com>
> Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 4 ++++
> 1 file changed, 4 insertions(+)
next prev parent reply other threads:[~2020-06-22 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 2:07 [PATCH 0/2] brcmfmac: Stability and throughput changes Wright Feng
2020-06-22 2:07 ` [PATCH 1/2] brcmfmac: set state of hanger slot to FREE when flushing PSQ Wright Feng
2020-06-22 8:58 ` Arend Van Spriel [this message]
2020-06-22 2:07 ` [PATCH 2/2] brcmfmac: Set pacing shift before transmitting skb to bus Wright Feng
2020-06-22 8:57 ` Arend Van Spriel
2020-06-24 5:45 ` Wright Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8402643f-7b1f-f6dc-a6f7-c572b95836de@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.