All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] board/pine64/pinecube: new board
@ 2022-08-21 11:04 Jan Havran
  2022-08-21 17:53 ` Giulio Benetti
  2023-08-26 21:05 ` Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 9+ messages in thread
From: Jan Havran @ 2022-08-21 11:04 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Jan Havran, Jagan Teki

Add support for PineCube with:
- U-Boot 2022.04
- Linux 5.15.61

PineCube is a low-powered, open source IP camera
with the following specs:
 - Allwinner S3 Cortex-A7
 - 128 MiB DDR3
 - 16 MiB SPI flash
 - 5 MPx OV5640 camera
 - MicroSD slot
 - 10/100M Ethernet with passive PoE
 - 802.11 b/g/n WiFi
 - Bluetooth 4.1
 - USB 2.0
 - 26 pins GPIO header
 - Microphone
 - IR LEDs for night vision

Board homepage: https://www.pine64.org/cube/
Board wiki:     https://wiki.pine64.org/wiki/PineCube

Signed-off-by: Jan Havran <havran.jan@email.cz>
---
Changes v1 -> v2 (review by Giulio Benetti):
  - Updated commit message
  - Replaced boot.cmd by extlinux.conf
  - Renamed pinecube_defconfig to pine64_pinecube_defconfig
  - Changed welcome message (generic issue)
  - Updated U-Boot 2022.01 to 2022.04
  - Updated Linux kernel from 5.15 to 5.15.61
  - Removed NEON from FPU (but kept VFPV4)
---
 DEVELOPERS                          |  4 +++
 board/pine64/pinecube/extlinux.conf |  4 +++
 board/pine64/pinecube/genimage.cfg  | 34 ++++++++++++++++++++++
 board/pine64/pinecube/post-build.sh |  5 ++++
 board/pine64/pinecube/readme.txt    | 31 ++++++++++++++++++++
 configs/pine64_pinecube_defconfig   | 45 +++++++++++++++++++++++++++++
 6 files changed, 123 insertions(+)
 create mode 100644 board/pine64/pinecube/extlinux.conf
 create mode 100644 board/pine64/pinecube/genimage.cfg
 create mode 100755 board/pine64/pinecube/post-build.sh
 create mode 100644 board/pine64/pinecube/readme.txt
 create mode 100644 configs/pine64_pinecube_defconfig

diff --git a/DEVELOPERS b/DEVELOPERS
index 4287fd9cf7..74f57af6fa 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1410,6 +1410,10 @@ F:	package/pangomm/
 F:	package/rpm/
 F:	package/yad/
 
+N:	Jan Havran <havran.jan@email.cz>
+F:	board/pine64/pinecube/
+F:	configs/pine64_pinecube_defconfig
+
 N:	Jan Heylen <jan.heylen@nokia.com>
 F:	package/opentracing-cpp/
 
diff --git a/board/pine64/pinecube/extlinux.conf b/board/pine64/pinecube/extlinux.conf
new file mode 100644
index 0000000000..6a18d9a2cb
--- /dev/null
+++ b/board/pine64/pinecube/extlinux.conf
@@ -0,0 +1,4 @@
+label buildroot
+  kernel /zImage
+  devicetree /sun8i-s3-pinecube.dtb
+  append console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rootwait rw
diff --git a/board/pine64/pinecube/genimage.cfg b/board/pine64/pinecube/genimage.cfg
new file mode 100644
index 0000000000..398d45e2f7
--- /dev/null
+++ b/board/pine64/pinecube/genimage.cfg
@@ -0,0 +1,34 @@
+image boot.vfat {
+	vfat {
+		files = {
+			"zImage",
+			"sun8i-s3-pinecube.dtb",
+			"extlinux"
+		}
+	}
+
+	size = 8M
+}
+
+image sdcard.img {
+	hdimage {
+	}
+
+	partition u-boot {
+		in-partition-table = "no"
+		image = "u-boot-sunxi-with-spl.bin"
+		offset = 8K
+		size = 504K # 512KB - 8KB
+	}
+
+	partition boot {
+		partition-type = 0xC
+		bootable = "true"
+		image = "boot.vfat"
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+	}
+}
diff --git a/board/pine64/pinecube/post-build.sh b/board/pine64/pinecube/post-build.sh
new file mode 100755
index 0000000000..ba29375c05
--- /dev/null
+++ b/board/pine64/pinecube/post-build.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+BOARD_DIR="$(dirname $0)"
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf $BINARIES_DIR/extlinux/extlinux.conf
diff --git a/board/pine64/pinecube/readme.txt b/board/pine64/pinecube/readme.txt
new file mode 100644
index 0000000000..4cf6df2110
--- /dev/null
+++ b/board/pine64/pinecube/readme.txt
@@ -0,0 +1,31 @@
+Intro
+=====
+
+This directory contains a Buildroot configuration for building a
+Pine64 PineCube.
+
+Board homepage: https://www.pine64.org/cube/
+Board wiki:     https://wiki.pine64.org/wiki/PineCube
+
+How to build it
+===============
+
+  $ make pine64_pinecube_defconfig
+  $ make
+
+Note: you will need access to the internet to download the required
+sources.
+
+How to write the SD card
+========================
+
+Once the build process is finished you will have an image called "sdcard.img"
+in the output/images/ directory.
+
+Copy the bootable "sdcard.img" onto an SD card with "dd":
+
+  $ sudo dd if=output/images/sdcard.img of=/dev/sdX
+  $ sudo sync
+
+Insert the micro SDcard in your PineCube and power it up. The console
+is on the serial port 2, 115200 8N1 (check Wiki for board pinout).
diff --git a/configs/pine64_pinecube_defconfig b/configs/pine64_pinecube_defconfig
new file mode 100644
index 0000000000..8f60115f8f
--- /dev/null
+++ b/configs/pine64_pinecube_defconfig
@@ -0,0 +1,45 @@
+# Target options
+BR2_arm=y
+BR2_cortex_a7=y
+BR2_ARM_FPU_VFPV4=y
+
+# Toolchain options
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
+
+# System configuration
+BR2_TARGET_GENERIC_HOSTNAME="pinecube"
+BR2_TARGET_GENERIC_ISSUE="Welcome to Pine64 Pinecube"
+BR2_SYSTEM_DHCP="eth0"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/pine64/pinecube/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/pine64/pinecube/genimage.cfg"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.61"
+BR2_LINUX_KERNEL_DEFCONFIG="sunxi"
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-s3-pinecube"
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+
+# Filesystem
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+
+# Bootloader
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pinecube"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
+
+# Required host utilities for building an SDCard image
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
-- 
2.37.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] board/pine64/pinecube: new board
  2022-08-21 11:04 [Buildroot] [PATCH v2] board/pine64/pinecube: new board Jan Havran
@ 2022-08-21 17:53 ` Giulio Benetti
  2022-08-21 18:01   ` Giulio Benetti
  2023-08-26 21:05 ` Thomas Petazzoni via buildroot
  1 sibling, 1 reply; 9+ messages in thread
From: Giulio Benetti @ 2022-08-21 17:53 UTC (permalink / raw)
  To: Jan Havran, buildroot; +Cc: Jagan Teki

Hi Jan,

On 21/08/22 13:04, Jan Havran wrote:
> Add support for PineCube with:
> - U-Boot 2022.04
> - Linux 5.15.61
> 
> PineCube is a low-powered, open source IP camera
> with the following specs:
>   - Allwinner S3 Cortex-A7
>   - 128 MiB DDR3
>   - 16 MiB SPI flash
>   - 5 MPx OV5640 camera
>   - MicroSD slot
>   - 10/100M Ethernet with passive PoE
>   - 802.11 b/g/n WiFi
>   - Bluetooth 4.1
>   - USB 2.0
>   - 26 pins GPIO header
>   - Microphone
>   - IR LEDs for night vision
> 
> Board homepage: https://www.pine64.org/cube/
> Board wiki:     https://wiki.pine64.org/wiki/PineCube
> 
> Signed-off-by: Jan Havran <havran.jan@email.cz>
> ---
> Changes v1 -> v2 (review by Giulio Benetti):
>    - Updated commit message
>    - Replaced boot.cmd by extlinux.conf
>    - Renamed pinecube_defconfig to pine64_pinecube_defconfig
>    - Changed welcome message (generic issue)
>    - Updated U-Boot 2022.01 to 2022.04
>    - Updated Linux kernel from 5.15 to 5.15.61
>    - Removed NEON from FPU (but kept VFPV4)
> ---
>   DEVELOPERS                          |  4 +++
>   board/pine64/pinecube/extlinux.conf |  4 +++
>   board/pine64/pinecube/genimage.cfg  | 34 ++++++++++++++++++++++
>   board/pine64/pinecube/post-build.sh |  5 ++++
>   board/pine64/pinecube/readme.txt    | 31 ++++++++++++++++++++
>   configs/pine64_pinecube_defconfig   | 45 +++++++++++++++++++++++++++++
>   6 files changed, 123 insertions(+)
>   create mode 100644 board/pine64/pinecube/extlinux.conf
>   create mode 100644 board/pine64/pinecube/genimage.cfg
>   create mode 100755 board/pine64/pinecube/post-build.sh
>   create mode 100644 board/pine64/pinecube/readme.txt
>   create mode 100644 configs/pine64_pinecube_defconfig
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 4287fd9cf7..74f57af6fa 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1410,6 +1410,10 @@ F:	package/pangomm/
>   F:	package/rpm/
>   F:	package/yad/
>   
> +N:	Jan Havran <havran.jan@email.cz>
> +F:	board/pine64/pinecube/
> +F:	configs/pine64_pinecube_defconfig
> +
>   N:	Jan Heylen <jan.heylen@nokia.com>
>   F:	package/opentracing-cpp/
>   
> diff --git a/board/pine64/pinecube/extlinux.conf b/board/pine64/pinecube/extlinux.conf
> new file mode 100644
> index 0000000000..6a18d9a2cb
> --- /dev/null
> +++ b/board/pine64/pinecube/extlinux.conf
> @@ -0,0 +1,4 @@
> +label buildroot
> +  kernel /zImage
> +  devicetree /sun8i-s3-pinecube.dtb
> +  append console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rootwait rw
> diff --git a/board/pine64/pinecube/genimage.cfg b/board/pine64/pinecube/genimage.cfg
> new file mode 100644
> index 0000000000..398d45e2f7
> --- /dev/null
> +++ b/board/pine64/pinecube/genimage.cfg
> @@ -0,0 +1,34 @@
> +image boot.vfat {
> +	vfat {
> +		files = {
> +			"zImage",
> +			"sun8i-s3-pinecube.dtb",
> +			"extlinux"
> +		}
> +	}
> +
> +	size = 8M
> +}
> +
> +image sdcard.img {
> +	hdimage {
> +	}
> +
> +	partition u-boot {
> +		in-partition-table = "no"
> +		image = "u-boot-sunxi-with-spl.bin"
> +		offset = 8K
> +		size = 504K # 512KB - 8KB
> +	}
> +
> +	partition boot {
> +		partition-type = 0xC
> +		bootable = "true"
> +		image = "boot.vfat"
> +	}
> +
> +	partition rootfs {
> +		partition-type = 0x83
> +		image = "rootfs.ext4"
> +	}
> +}
> diff --git a/board/pine64/pinecube/post-build.sh b/board/pine64/pinecube/post-build.sh
> new file mode 100755
> index 0000000000..ba29375c05
> --- /dev/null
> +++ b/board/pine64/pinecube/post-build.sh
> @@ -0,0 +1,5 @@
> +#!/bin/sh
> +
> +BOARD_DIR="$(dirname $0)"
> +
> +install -m 0644 -D $BOARD_DIR/extlinux.conf $BINARIES_DIR/extlinux/extlinux.conf
> diff --git a/board/pine64/pinecube/readme.txt b/board/pine64/pinecube/readme.txt
> new file mode 100644
> index 0000000000..4cf6df2110
> --- /dev/null
> +++ b/board/pine64/pinecube/readme.txt
> @@ -0,0 +1,31 @@
> +Intro
> +=====
> +
> +This directory contains a Buildroot configuration for building a
> +Pine64 PineCube.
> +
> +Board homepage: https://www.pine64.org/cube/
> +Board wiki:     https://wiki.pine64.org/wiki/PineCube
> +
> +How to build it
> +===============
> +
> +  $ make pine64_pinecube_defconfig
> +  $ make
> +
> +Note: you will need access to the internet to download the required
> +sources.
> +
> +How to write the SD card
> +========================
> +
> +Once the build process is finished you will have an image called "sdcard.img"
> +in the output/images/ directory.
> +
> +Copy the bootable "sdcard.img" onto an SD card with "dd":
> +
> +  $ sudo dd if=output/images/sdcard.img of=/dev/sdX
> +  $ sudo sync
> +
> +Insert the micro SDcard in your PineCube and power it up. The console
> +is on the serial port 2, 115200 8N1 (check Wiki for board pinout).
> diff --git a/configs/pine64_pinecube_defconfig b/configs/pine64_pinecube_defconfig
> new file mode 100644
> index 0000000000..8f60115f8f
> --- /dev/null
> +++ b/configs/pine64_pinecube_defconfig
> @@ -0,0 +1,45 @@
> +# Target options
> +BR2_arm=y
> +BR2_cortex_a7=y
> +BR2_ARM_FPU_VFPV4=y

About this ^^^ there is an ongoing discussion if use mixed VFVP4+NEON or
not:
https://lists.buildroot.org/pipermail/buildroot/2022-August/649770.html

For the moment it's ok to me keeping this way and when we've all
clarified FPU strategy on 32-bit ARM cortex then we can modify and
you could test it or even provide the patch for this.

Have you re-tested the board with such modification?

> +
> +# Toolchain options
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> +
> +# System configuration
> +BR2_TARGET_GENERIC_HOSTNAME="pinecube"
> +BR2_TARGET_GENERIC_ISSUE="Welcome to Pine64 Pinecube"
> +BR2_SYSTEM_DHCP="eth0"
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/pine64/pinecube/post-build.sh"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/pine64/pinecube/genimage.cfg"
> +
> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.61"
> +BR2_LINUX_KERNEL_DEFCONFIG="sunxi"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-s3-pinecube"
> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> +
> +# Filesystem
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +
> +# Bootloader
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pinecube"
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> +BR2_TARGET_UBOOT_SPL=y
> +BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
> +
> +# Required host utilities for building an SDCard image
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y

Overall looks good to me, it builds correctly with buildroot/docker-run
so:
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Expect this patch to be part of 2022.11 since 2022.08-rc1 has been
released on 12th August and from -rc1 to 2022.08 only bug fixes and
security patches are allowed.

Thanks for the contribution!

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] board/pine64/pinecube: new board
  2022-08-21 17:53 ` Giulio Benetti
@ 2022-08-21 18:01   ` Giulio Benetti
  2022-08-21 18:55     ` Jan Havran
  0 siblings, 1 reply; 9+ messages in thread
From: Giulio Benetti @ 2022-08-21 18:01 UTC (permalink / raw)
  To: Jan Havran, buildroot; +Cc: Jagan Teki

One last thing, please set the v1 patch to superseded in Patchwork:
https://patchwork.ozlabs.org/project/buildroot/list/?submitter=74841

Thank you!

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

On 21/08/22 19:53, Giulio Benetti wrote:
> Hi Jan,
> 
> On 21/08/22 13:04, Jan Havran wrote:
>> Add support for PineCube with:
>> - U-Boot 2022.04
>> - Linux 5.15.61
>>
>> PineCube is a low-powered, open source IP camera
>> with the following specs:
>>   - Allwinner S3 Cortex-A7
>>   - 128 MiB DDR3
>>   - 16 MiB SPI flash
>>   - 5 MPx OV5640 camera
>>   - MicroSD slot
>>   - 10/100M Ethernet with passive PoE
>>   - 802.11 b/g/n WiFi
>>   - Bluetooth 4.1
>>   - USB 2.0
>>   - 26 pins GPIO header
>>   - Microphone
>>   - IR LEDs for night vision
>>
>> Board homepage: https://www.pine64.org/cube/
>> Board wiki:     https://wiki.pine64.org/wiki/PineCube
>>
>> Signed-off-by: Jan Havran <havran.jan@email.cz>
>> ---
>> Changes v1 -> v2 (review by Giulio Benetti):
>>    - Updated commit message
>>    - Replaced boot.cmd by extlinux.conf
>>    - Renamed pinecube_defconfig to pine64_pinecube_defconfig
>>    - Changed welcome message (generic issue)
>>    - Updated U-Boot 2022.01 to 2022.04
>>    - Updated Linux kernel from 5.15 to 5.15.61
>>    - Removed NEON from FPU (but kept VFPV4)
>> ---
>>   DEVELOPERS                          |  4 +++
>>   board/pine64/pinecube/extlinux.conf |  4 +++
>>   board/pine64/pinecube/genimage.cfg  | 34 ++++++++++++++++++++++
>>   board/pine64/pinecube/post-build.sh |  5 ++++
>>   board/pine64/pinecube/readme.txt    | 31 ++++++++++++++++++++
>>   configs/pine64_pinecube_defconfig   | 45 +++++++++++++++++++++++++++++
>>   6 files changed, 123 insertions(+)
>>   create mode 100644 board/pine64/pinecube/extlinux.conf
>>   create mode 100644 board/pine64/pinecube/genimage.cfg
>>   create mode 100755 board/pine64/pinecube/post-build.sh
>>   create mode 100644 board/pine64/pinecube/readme.txt
>>   create mode 100644 configs/pine64_pinecube_defconfig
>>
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index 4287fd9cf7..74f57af6fa 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -1410,6 +1410,10 @@ F:    package/pangomm/
>>   F:    package/rpm/
>>   F:    package/yad/
>> +N:    Jan Havran <havran.jan@email.cz>
>> +F:    board/pine64/pinecube/
>> +F:    configs/pine64_pinecube_defconfig
>> +
>>   N:    Jan Heylen <jan.heylen@nokia.com>
>>   F:    package/opentracing-cpp/
>> diff --git a/board/pine64/pinecube/extlinux.conf 
>> b/board/pine64/pinecube/extlinux.conf
>> new file mode 100644
>> index 0000000000..6a18d9a2cb
>> --- /dev/null
>> +++ b/board/pine64/pinecube/extlinux.conf
>> @@ -0,0 +1,4 @@
>> +label buildroot
>> +  kernel /zImage
>> +  devicetree /sun8i-s3-pinecube.dtb
>> +  append console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 
>> rootwait rw
>> diff --git a/board/pine64/pinecube/genimage.cfg 
>> b/board/pine64/pinecube/genimage.cfg
>> new file mode 100644
>> index 0000000000..398d45e2f7
>> --- /dev/null
>> +++ b/board/pine64/pinecube/genimage.cfg
>> @@ -0,0 +1,34 @@
>> +image boot.vfat {
>> +    vfat {
>> +        files = {
>> +            "zImage",
>> +            "sun8i-s3-pinecube.dtb",
>> +            "extlinux"
>> +        }
>> +    }
>> +
>> +    size = 8M
>> +}
>> +
>> +image sdcard.img {
>> +    hdimage {
>> +    }
>> +
>> +    partition u-boot {
>> +        in-partition-table = "no"
>> +        image = "u-boot-sunxi-with-spl.bin"
>> +        offset = 8K
>> +        size = 504K # 512KB - 8KB
>> +    }
>> +
>> +    partition boot {
>> +        partition-type = 0xC
>> +        bootable = "true"
>> +        image = "boot.vfat"
>> +    }
>> +
>> +    partition rootfs {
>> +        partition-type = 0x83
>> +        image = "rootfs.ext4"
>> +    }
>> +}
>> diff --git a/board/pine64/pinecube/post-build.sh 
>> b/board/pine64/pinecube/post-build.sh
>> new file mode 100755
>> index 0000000000..ba29375c05
>> --- /dev/null
>> +++ b/board/pine64/pinecube/post-build.sh
>> @@ -0,0 +1,5 @@
>> +#!/bin/sh
>> +
>> +BOARD_DIR="$(dirname $0)"
>> +
>> +install -m 0644 -D $BOARD_DIR/extlinux.conf 
>> $BINARIES_DIR/extlinux/extlinux.conf
>> diff --git a/board/pine64/pinecube/readme.txt 
>> b/board/pine64/pinecube/readme.txt
>> new file mode 100644
>> index 0000000000..4cf6df2110
>> --- /dev/null
>> +++ b/board/pine64/pinecube/readme.txt
>> @@ -0,0 +1,31 @@
>> +Intro
>> +=====
>> +
>> +This directory contains a Buildroot configuration for building a
>> +Pine64 PineCube.
>> +
>> +Board homepage: https://www.pine64.org/cube/
>> +Board wiki:     https://wiki.pine64.org/wiki/PineCube
>> +
>> +How to build it
>> +===============
>> +
>> +  $ make pine64_pinecube_defconfig
>> +  $ make
>> +
>> +Note: you will need access to the internet to download the required
>> +sources.
>> +
>> +How to write the SD card
>> +========================
>> +
>> +Once the build process is finished you will have an image called 
>> "sdcard.img"
>> +in the output/images/ directory.
>> +
>> +Copy the bootable "sdcard.img" onto an SD card with "dd":
>> +
>> +  $ sudo dd if=output/images/sdcard.img of=/dev/sdX
>> +  $ sudo sync
>> +
>> +Insert the micro SDcard in your PineCube and power it up. The console
>> +is on the serial port 2, 115200 8N1 (check Wiki for board pinout).
>> diff --git a/configs/pine64_pinecube_defconfig 
>> b/configs/pine64_pinecube_defconfig
>> new file mode 100644
>> index 0000000000..8f60115f8f
>> --- /dev/null
>> +++ b/configs/pine64_pinecube_defconfig
>> @@ -0,0 +1,45 @@
>> +# Target options
>> +BR2_arm=y
>> +BR2_cortex_a7=y
>> +BR2_ARM_FPU_VFPV4=y
> 
> About this ^^^ there is an ongoing discussion if use mixed VFVP4+NEON or
> not:
> https://lists.buildroot.org/pipermail/buildroot/2022-August/649770.html
> 
> For the moment it's ok to me keeping this way and when we've all
> clarified FPU strategy on 32-bit ARM cortex then we can modify and
> you could test it or even provide the patch for this.
> 
> Have you re-tested the board with such modification?
> 
>> +
>> +# Toolchain options
>> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
>> +
>> +# System configuration
>> +BR2_TARGET_GENERIC_HOSTNAME="pinecube"
>> +BR2_TARGET_GENERIC_ISSUE="Welcome to Pine64 Pinecube"
>> +BR2_SYSTEM_DHCP="eth0"
>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/pine64/pinecube/post-build.sh"
>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
>> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/pine64/pinecube/genimage.cfg"
>> +
>> +# Kernel
>> +BR2_LINUX_KERNEL=y
>> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
>> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.61"
>> +BR2_LINUX_KERNEL_DEFCONFIG="sunxi"
>> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
>> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-s3-pinecube"
>> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>> +
>> +# Filesystem
>> +BR2_TARGET_ROOTFS_EXT2=y
>> +BR2_TARGET_ROOTFS_EXT2_4=y
>> +
>> +# Bootloader
>> +BR2_TARGET_UBOOT=y
>> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
>> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
>> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pinecube"
>> +BR2_TARGET_UBOOT_NEEDS_DTC=y
>> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
>> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
>> +BR2_TARGET_UBOOT_SPL=y
>> +BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
>> +
>> +# Required host utilities for building an SDCard image
>> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
>> +BR2_PACKAGE_HOST_GENIMAGE=y
>> +BR2_PACKAGE_HOST_MTOOLS=y
> 
> Overall looks good to me, it builds correctly with buildroot/docker-run
> so:
> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> 
> Expect this patch to be part of 2022.11 since 2022.08-rc1 has been
> released on 12th August and from -rc1 to 2022.08 only bug fixes and
> security patches are allowed.
> 
> Thanks for the contribution!
> 
> Best regards

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] board/pine64/pinecube: new board
  2022-08-21 18:01   ` Giulio Benetti
@ 2022-08-21 18:55     ` Jan Havran
  2022-08-21 19:01       ` Giulio Benetti
  0 siblings, 1 reply; 9+ messages in thread
From: Jan Havran @ 2022-08-21 18:55 UTC (permalink / raw)
  To: Giulio Benetti, buildroot; +Cc: Jagan Teki

Hi Giulio,

V Sun, Aug 21, 2022 at 08:01:47PM +0200, Giulio Benetti napsal(a):
> One last thing, please set the v1 patch to superseded in Patchwork:
> https://patchwork.ozlabs.org/project/buildroot/list/?submitter=74841
> 

Patch set (did not know that I have to do it manually).

> Thank you!
> 
> Best regards
> -- 
> Giulio Benetti
> Benetti Engineering sas
> 
> On 21/08/22 19:53, Giulio Benetti wrote:
> > Hi Jan,
> > 
> > On 21/08/22 13:04, Jan Havran wrote:
> > > Add support for PineCube with:
> > > - U-Boot 2022.04
> > > - Linux 5.15.61
> > > 
> > > PineCube is a low-powered, open source IP camera
> > > with the following specs:
> > >   - Allwinner S3 Cortex-A7
> > >   - 128 MiB DDR3
> > >   - 16 MiB SPI flash
> > >   - 5 MPx OV5640 camera
> > >   - MicroSD slot
> > >   - 10/100M Ethernet with passive PoE
> > >   - 802.11 b/g/n WiFi
> > >   - Bluetooth 4.1
> > >   - USB 2.0
> > >   - 26 pins GPIO header
> > >   - Microphone
> > >   - IR LEDs for night vision
> > > 
> > > Board homepage: https://www.pine64.org/cube/
> > > Board wiki:     https://wiki.pine64.org/wiki/PineCube
> > > 
> > > Signed-off-by: Jan Havran <havran.jan@email.cz>
> > > ---
> > > Changes v1 -> v2 (review by Giulio Benetti):
> > >    - Updated commit message
> > >    - Replaced boot.cmd by extlinux.conf
> > >    - Renamed pinecube_defconfig to pine64_pinecube_defconfig
> > >    - Changed welcome message (generic issue)
> > >    - Updated U-Boot 2022.01 to 2022.04
> > >    - Updated Linux kernel from 5.15 to 5.15.61
> > >    - Removed NEON from FPU (but kept VFPV4)
> > > ---
> > >   DEVELOPERS                          |  4 +++
> > >   board/pine64/pinecube/extlinux.conf |  4 +++
> > >   board/pine64/pinecube/genimage.cfg  | 34 ++++++++++++++++++++++
> > >   board/pine64/pinecube/post-build.sh |  5 ++++
> > >   board/pine64/pinecube/readme.txt    | 31 ++++++++++++++++++++
> > >   configs/pine64_pinecube_defconfig   | 45 +++++++++++++++++++++++++++++
> > >   6 files changed, 123 insertions(+)
> > >   create mode 100644 board/pine64/pinecube/extlinux.conf
> > >   create mode 100644 board/pine64/pinecube/genimage.cfg
> > >   create mode 100755 board/pine64/pinecube/post-build.sh
> > >   create mode 100644 board/pine64/pinecube/readme.txt
> > >   create mode 100644 configs/pine64_pinecube_defconfig
> > > 
> > > diff --git a/DEVELOPERS b/DEVELOPERS
> > > index 4287fd9cf7..74f57af6fa 100644
> > > --- a/DEVELOPERS
> > > +++ b/DEVELOPERS
> > > @@ -1410,6 +1410,10 @@ F:    package/pangomm/
> > >   F:    package/rpm/
> > >   F:    package/yad/
> > > +N:    Jan Havran <havran.jan@email.cz>
> > > +F:    board/pine64/pinecube/
> > > +F:    configs/pine64_pinecube_defconfig
> > > +
> > >   N:    Jan Heylen <jan.heylen@nokia.com>
> > >   F:    package/opentracing-cpp/
> > > diff --git a/board/pine64/pinecube/extlinux.conf
> > > b/board/pine64/pinecube/extlinux.conf
> > > new file mode 100644
> > > index 0000000000..6a18d9a2cb
> > > --- /dev/null
> > > +++ b/board/pine64/pinecube/extlinux.conf
> > > @@ -0,0 +1,4 @@
> > > +label buildroot
> > > +  kernel /zImage
> > > +  devicetree /sun8i-s3-pinecube.dtb
> > > +  append console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2
> > > rootwait rw
> > > diff --git a/board/pine64/pinecube/genimage.cfg
> > > b/board/pine64/pinecube/genimage.cfg
> > > new file mode 100644
> > > index 0000000000..398d45e2f7
> > > --- /dev/null
> > > +++ b/board/pine64/pinecube/genimage.cfg
> > > @@ -0,0 +1,34 @@
> > > +image boot.vfat {
> > > +    vfat {
> > > +        files = {
> > > +            "zImage",
> > > +            "sun8i-s3-pinecube.dtb",
> > > +            "extlinux"
> > > +        }
> > > +    }
> > > +
> > > +    size = 8M
> > > +}
> > > +
> > > +image sdcard.img {
> > > +    hdimage {
> > > +    }
> > > +
> > > +    partition u-boot {
> > > +        in-partition-table = "no"
> > > +        image = "u-boot-sunxi-with-spl.bin"
> > > +        offset = 8K
> > > +        size = 504K # 512KB - 8KB
> > > +    }
> > > +
> > > +    partition boot {
> > > +        partition-type = 0xC
> > > +        bootable = "true"
> > > +        image = "boot.vfat"
> > > +    }
> > > +
> > > +    partition rootfs {
> > > +        partition-type = 0x83
> > > +        image = "rootfs.ext4"
> > > +    }
> > > +}
> > > diff --git a/board/pine64/pinecube/post-build.sh
> > > b/board/pine64/pinecube/post-build.sh
> > > new file mode 100755
> > > index 0000000000..ba29375c05
> > > --- /dev/null
> > > +++ b/board/pine64/pinecube/post-build.sh
> > > @@ -0,0 +1,5 @@
> > > +#!/bin/sh
> > > +
> > > +BOARD_DIR="$(dirname $0)"
> > > +
> > > +install -m 0644 -D $BOARD_DIR/extlinux.conf
> > > $BINARIES_DIR/extlinux/extlinux.conf
> > > diff --git a/board/pine64/pinecube/readme.txt
> > > b/board/pine64/pinecube/readme.txt
> > > new file mode 100644
> > > index 0000000000..4cf6df2110
> > > --- /dev/null
> > > +++ b/board/pine64/pinecube/readme.txt
> > > @@ -0,0 +1,31 @@
> > > +Intro
> > > +=====
> > > +
> > > +This directory contains a Buildroot configuration for building a
> > > +Pine64 PineCube.
> > > +
> > > +Board homepage: https://www.pine64.org/cube/
> > > +Board wiki:     https://wiki.pine64.org/wiki/PineCube
> > > +
> > > +How to build it
> > > +===============
> > > +
> > > +  $ make pine64_pinecube_defconfig
> > > +  $ make
> > > +
> > > +Note: you will need access to the internet to download the required
> > > +sources.
> > > +
> > > +How to write the SD card
> > > +========================
> > > +
> > > +Once the build process is finished you will have an image called
> > > "sdcard.img"
> > > +in the output/images/ directory.
> > > +
> > > +Copy the bootable "sdcard.img" onto an SD card with "dd":
> > > +
> > > +  $ sudo dd if=output/images/sdcard.img of=/dev/sdX
> > > +  $ sudo sync
> > > +
> > > +Insert the micro SDcard in your PineCube and power it up. The console
> > > +is on the serial port 2, 115200 8N1 (check Wiki for board pinout).
> > > diff --git a/configs/pine64_pinecube_defconfig
> > > b/configs/pine64_pinecube_defconfig
> > > new file mode 100644
> > > index 0000000000..8f60115f8f
> > > --- /dev/null
> > > +++ b/configs/pine64_pinecube_defconfig
> > > @@ -0,0 +1,45 @@
> > > +# Target options
> > > +BR2_arm=y
> > > +BR2_cortex_a7=y
> > > +BR2_ARM_FPU_VFPV4=y
> > 
> > About this ^^^ there is an ongoing discussion if use mixed VFVP4+NEON or
> > not:
> > https://lists.buildroot.org/pipermail/buildroot/2022-August/649770.html
> > 
> > For the moment it's ok to me keeping this way and when we've all
> > clarified FPU strategy on 32-bit ARM cortex then we can modify and
> > you could test it or even provide the patch for this.
> > 
> > Have you re-tested the board with such modification?
> > 

Yes, I re-tested the board for general use. But if you ask about the FPU, I am not
sure what kind of tests should I run and how to check if it gives me valid result.
Should I do some heavy FPU testing? This one setting is more based on chip description
and previous discussion rather than some my tests/experiments.

> > > +
> > > +# Toolchain options
> > > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> > > +
> > > +# System configuration
> > > +BR2_TARGET_GENERIC_HOSTNAME="pinecube"
> > > +BR2_TARGET_GENERIC_ISSUE="Welcome to Pine64 Pinecube"
> > > +BR2_SYSTEM_DHCP="eth0"
> > > +BR2_ROOTFS_POST_BUILD_SCRIPT="board/pine64/pinecube/post-build.sh"
> > > +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> > > +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/pine64/pinecube/genimage.cfg"
> > > +
> > > +# Kernel
> > > +BR2_LINUX_KERNEL=y
> > > +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> > > +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.61"
> > > +BR2_LINUX_KERNEL_DEFCONFIG="sunxi"
> > > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-s3-pinecube"
> > > +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> > > +
> > > +# Filesystem
> > > +BR2_TARGET_ROOTFS_EXT2=y
> > > +BR2_TARGET_ROOTFS_EXT2_4=y
> > > +
> > > +# Bootloader
> > > +BR2_TARGET_UBOOT=y
> > > +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> > > +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> > > +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
> > > +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pinecube"
> > > +BR2_TARGET_UBOOT_NEEDS_DTC=y
> > > +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> > > +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> > > +BR2_TARGET_UBOOT_SPL=y
> > > +BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
> > > +
> > > +# Required host utilities for building an SDCard image
> > > +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> > > +BR2_PACKAGE_HOST_GENIMAGE=y
> > > +BR2_PACKAGE_HOST_MTOOLS=y
> > 
> > Overall looks good to me, it builds correctly with buildroot/docker-run
> > so:
> > Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > 
> > Expect this patch to be part of 2022.11 since 2022.08-rc1 has been
> > released on 12th August and from -rc1 to 2022.08 only bug fixes and
> > security patches are allowed.
> > 
> > Thanks for the contribution!

Thank you very much for your review and your time.

Regards,
Jan

> > 
> > Best regards
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] board/pine64/pinecube: new board
  2022-08-21 18:55     ` Jan Havran
@ 2022-08-21 19:01       ` Giulio Benetti
  2023-06-02 19:27         ` Jan Havran
  0 siblings, 1 reply; 9+ messages in thread
From: Giulio Benetti @ 2022-08-21 19:01 UTC (permalink / raw)
  To: Jan Havran; +Cc: Jagan Teki, buildroot

Hi Jan,

> Il giorno 21 ago 2022, alle ore 20:55, Jan Havran <havran.jan@email.cz> ha scritto:
> 
> Hi Giulio,
> 
> V Sun, Aug 21, 2022 at 08:01:47PM +0200, Giulio Benetti napsal(a):
>> One last thing, please set the v1 patch to superseded in Patchwork:
>> https://patchwork.ozlabs.org/project/buildroot/list/?submitter=74841
>> 
> 
> Patch set (did not know that I have to do it manually).

perfect

> 
>> Thank you!
>> 
>> Best regards
>> -- 
>> Giulio Benetti
>> Benetti Engineering sas
>> 
>>> On 21/08/22 19:53, Giulio Benetti wrote:
>>> Hi Jan,
>>> 
>>> On 21/08/22 13:04, Jan Havran wrote:
>>>> Add support for PineCube with:
>>>> - U-Boot 2022.04
>>>> - Linux 5.15.61
>>>> 
>>>> PineCube is a low-powered, open source IP camera
>>>> with the following specs:
>>>>   - Allwinner S3 Cortex-A7
>>>>   - 128 MiB DDR3
>>>>   - 16 MiB SPI flash
>>>>   - 5 MPx OV5640 camera
>>>>   - MicroSD slot
>>>>   - 10/100M Ethernet with passive PoE
>>>>   - 802.11 b/g/n WiFi
>>>>   - Bluetooth 4.1
>>>>   - USB 2.0
>>>>   - 26 pins GPIO header
>>>>   - Microphone
>>>>   - IR LEDs for night vision
>>>> 
>>>> Board homepage: https://www.pine64.org/cube/
>>>> Board wiki:     https://wiki.pine64.org/wiki/PineCube
>>>> 
>>>> Signed-off-by: Jan Havran <havran.jan@email.cz>
>>>> ---
>>>> Changes v1 -> v2 (review by Giulio Benetti):
>>>>    - Updated commit message
>>>>    - Replaced boot.cmd by extlinux.conf
>>>>    - Renamed pinecube_defconfig to pine64_pinecube_defconfig
>>>>    - Changed welcome message (generic issue)
>>>>    - Updated U-Boot 2022.01 to 2022.04
>>>>    - Updated Linux kernel from 5.15 to 5.15.61
>>>>    - Removed NEON from FPU (but kept VFPV4)
>>>> ---
>>>>   DEVELOPERS                          |  4 +++
>>>>   board/pine64/pinecube/extlinux.conf |  4 +++
>>>>   board/pine64/pinecube/genimage.cfg  | 34 ++++++++++++++++++++++
>>>>   board/pine64/pinecube/post-build.sh |  5 ++++
>>>>   board/pine64/pinecube/readme.txt    | 31 ++++++++++++++++++++
>>>>   configs/pine64_pinecube_defconfig   | 45 +++++++++++++++++++++++++++++
>>>>   6 files changed, 123 insertions(+)
>>>>   create mode 100644 board/pine64/pinecube/extlinux.conf
>>>>   create mode 100644 board/pine64/pinecube/genimage.cfg
>>>>   create mode 100755 board/pine64/pinecube/post-build.sh
>>>>   create mode 100644 board/pine64/pinecube/readme.txt
>>>>   create mode 100644 configs/pine64_pinecube_defconfig
>>>> 
>>>> diff --git a/DEVELOPERS b/DEVELOPERS
>>>> index 4287fd9cf7..74f57af6fa 100644
>>>> --- a/DEVELOPERS
>>>> +++ b/DEVELOPERS
>>>> @@ -1410,6 +1410,10 @@ F:    package/pangomm/
>>>>   F:    package/rpm/
>>>>   F:    package/yad/
>>>> +N:    Jan Havran <havran.jan@email.cz>
>>>> +F:    board/pine64/pinecube/
>>>> +F:    configs/pine64_pinecube_defconfig
>>>> +
>>>>   N:    Jan Heylen <jan.heylen@nokia.com>
>>>>   F:    package/opentracing-cpp/
>>>> diff --git a/board/pine64/pinecube/extlinux.conf
>>>> b/board/pine64/pinecube/extlinux.conf
>>>> new file mode 100644
>>>> index 0000000000..6a18d9a2cb
>>>> --- /dev/null
>>>> +++ b/board/pine64/pinecube/extlinux.conf
>>>> @@ -0,0 +1,4 @@
>>>> +label buildroot
>>>> +  kernel /zImage
>>>> +  devicetree /sun8i-s3-pinecube.dtb
>>>> +  append console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2
>>>> rootwait rw
>>>> diff --git a/board/pine64/pinecube/genimage.cfg
>>>> b/board/pine64/pinecube/genimage.cfg
>>>> new file mode 100644
>>>> index 0000000000..398d45e2f7
>>>> --- /dev/null
>>>> +++ b/board/pine64/pinecube/genimage.cfg
>>>> @@ -0,0 +1,34 @@
>>>> +image boot.vfat {
>>>> +    vfat {
>>>> +        files = {
>>>> +            "zImage",
>>>> +            "sun8i-s3-pinecube.dtb",
>>>> +            "extlinux"
>>>> +        }
>>>> +    }
>>>> +
>>>> +    size = 8M
>>>> +}
>>>> +
>>>> +image sdcard.img {
>>>> +    hdimage {
>>>> +    }
>>>> +
>>>> +    partition u-boot {
>>>> +        in-partition-table = "no"
>>>> +        image = "u-boot-sunxi-with-spl.bin"
>>>> +        offset = 8K
>>>> +        size = 504K # 512KB - 8KB
>>>> +    }
>>>> +
>>>> +    partition boot {
>>>> +        partition-type = 0xC
>>>> +        bootable = "true"
>>>> +        image = "boot.vfat"
>>>> +    }
>>>> +
>>>> +    partition rootfs {
>>>> +        partition-type = 0x83
>>>> +        image = "rootfs.ext4"
>>>> +    }
>>>> +}
>>>> diff --git a/board/pine64/pinecube/post-build.sh
>>>> b/board/pine64/pinecube/post-build.sh
>>>> new file mode 100755
>>>> index 0000000000..ba29375c05
>>>> --- /dev/null
>>>> +++ b/board/pine64/pinecube/post-build.sh
>>>> @@ -0,0 +1,5 @@
>>>> +#!/bin/sh
>>>> +
>>>> +BOARD_DIR="$(dirname $0)"
>>>> +
>>>> +install -m 0644 -D $BOARD_DIR/extlinux.conf
>>>> $BINARIES_DIR/extlinux/extlinux.conf
>>>> diff --git a/board/pine64/pinecube/readme.txt
>>>> b/board/pine64/pinecube/readme.txt
>>>> new file mode 100644
>>>> index 0000000000..4cf6df2110
>>>> --- /dev/null
>>>> +++ b/board/pine64/pinecube/readme.txt
>>>> @@ -0,0 +1,31 @@
>>>> +Intro
>>>> +=====
>>>> +
>>>> +This directory contains a Buildroot configuration for building a
>>>> +Pine64 PineCube.
>>>> +
>>>> +Board homepage: https://www.pine64.org/cube/
>>>> +Board wiki:     https://wiki.pine64.org/wiki/PineCube
>>>> +
>>>> +How to build it
>>>> +===============
>>>> +
>>>> +  $ make pine64_pinecube_defconfig
>>>> +  $ make
>>>> +
>>>> +Note: you will need access to the internet to download the required
>>>> +sources.
>>>> +
>>>> +How to write the SD card
>>>> +========================
>>>> +
>>>> +Once the build process is finished you will have an image called
>>>> "sdcard.img"
>>>> +in the output/images/ directory.
>>>> +
>>>> +Copy the bootable "sdcard.img" onto an SD card with "dd":
>>>> +
>>>> +  $ sudo dd if=output/images/sdcard.img of=/dev/sdX
>>>> +  $ sudo sync
>>>> +
>>>> +Insert the micro SDcard in your PineCube and power it up. The console
>>>> +is on the serial port 2, 115200 8N1 (check Wiki for board pinout).
>>>> diff --git a/configs/pine64_pinecube_defconfig
>>>> b/configs/pine64_pinecube_defconfig
>>>> new file mode 100644
>>>> index 0000000000..8f60115f8f
>>>> --- /dev/null
>>>> +++ b/configs/pine64_pinecube_defconfig
>>>> @@ -0,0 +1,45 @@
>>>> +# Target options
>>>> +BR2_arm=y
>>>> +BR2_cortex_a7=y
>>>> +BR2_ARM_FPU_VFPV4=y
>>> 
>>> About this ^^^ there is an ongoing discussion if use mixed VFVP4+NEON or
>>> not:
>>> https://lists.buildroot.org/pipermail/buildroot/2022-August/649770.html
>>> 
>>> For the moment it's ok to me keeping this way and when we've all
>>> clarified FPU strategy on 32-bit ARM cortex then we can modify and
>>> you could test it or even provide the patch for this.
>>> 
>>> Have you re-tested the board with such modification?
>>> 
> 
> Yes, I re-tested the board for general use. But if you ask about the FPU, I am not
> sure what kind of tests should I run and how to check if it gives me valid result.
> Should I do some heavy FPU testing? This one setting is more based on chip description
> and previous discussion rather than some my tests/experiments.

No need. It’s ok, if there was a problem you’ve have found a segmentation fault while booting.

> 
>>>> +
>>>> +# Toolchain options
>>>> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
>>>> +
>>>> +# System configuration
>>>> +BR2_TARGET_GENERIC_HOSTNAME="pinecube"
>>>> +BR2_TARGET_GENERIC_ISSUE="Welcome to Pine64 Pinecube"
>>>> +BR2_SYSTEM_DHCP="eth0"
>>>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/pine64/pinecube/post-build.sh"
>>>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
>>>> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/pine64/pinecube/genimage.cfg"
>>>> +
>>>> +# Kernel
>>>> +BR2_LINUX_KERNEL=y
>>>> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
>>>> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.61"
>>>> +BR2_LINUX_KERNEL_DEFCONFIG="sunxi"
>>>> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
>>>> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-s3-pinecube"
>>>> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>>>> +
>>>> +# Filesystem
>>>> +BR2_TARGET_ROOTFS_EXT2=y
>>>> +BR2_TARGET_ROOTFS_EXT2_4=y
>>>> +
>>>> +# Bootloader
>>>> +BR2_TARGET_UBOOT=y
>>>> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>>>> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
>>>> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
>>>> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pinecube"
>>>> +BR2_TARGET_UBOOT_NEEDS_DTC=y
>>>> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
>>>> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
>>>> +BR2_TARGET_UBOOT_SPL=y
>>>> +BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
>>>> +
>>>> +# Required host utilities for building an SDCard image
>>>> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
>>>> +BR2_PACKAGE_HOST_GENIMAGE=y
>>>> +BR2_PACKAGE_HOST_MTOOLS=y
>>> 
>>> Overall looks good to me, it builds correctly with buildroot/docker-run
>>> so:
>>> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>> 
>>> Expect this patch to be part of 2022.11 since 2022.08-rc1 has been
>>> released on 12th August and from -rc1 to 2022.08 only bug fixes and
>>> security patches are allowed.
>>> 
>>> Thanks for the contribution!
> 
> Thank you very much for your review and your time.

You’re welcome

Best regards
Giulio

> 
> Regards,
> Jan
> 
>>> 
>>> Best regards
>> 
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] board/pine64/pinecube: new board
  2022-08-21 19:01       ` Giulio Benetti
@ 2023-06-02 19:27         ` Jan Havran
  2023-06-02 20:09           ` Giulio Benetti
  0 siblings, 1 reply; 9+ messages in thread
From: Jan Havran @ 2023-06-02 19:27 UTC (permalink / raw)
  To: Giulio Benetti, buildroot; +Cc: Jagan Teki

Hello everyone,

it's been a while since I sent this v2 (and even longer since v1) and got review by Giulio...
is there anything I can do to help this merged?

I guess I will need to send v3 anyway since this patch is quite old now.

Thank you,
Jan

V Sun, Aug 21, 2022 at 09:01:25PM +0200, Giulio Benetti napsal(a):
> Hi Jan,
> 
> > Il giorno 21 ago 2022, alle ore 20:55, Jan Havran <havran.jan@email.cz> ha scritto:
> > 
> > Hi Giulio,
> > 
> > V Sun, Aug 21, 2022 at 08:01:47PM +0200, Giulio Benetti napsal(a):
> >> One last thing, please set the v1 patch to superseded in Patchwork:
> >> https://patchwork.ozlabs.org/project/buildroot/list/?submitter=74841
> >> 
> > 
> > Patch set (did not know that I have to do it manually).
> 
> perfect
> 
> > 
> >> Thank you!
> >> 
> >> Best regards
> >> -- 
> >> Giulio Benetti
> >> Benetti Engineering sas
> >> 
> >>> On 21/08/22 19:53, Giulio Benetti wrote:
> >>> Hi Jan,
> >>> 
> >>> On 21/08/22 13:04, Jan Havran wrote:
> >>>> Add support for PineCube with:
> >>>> - U-Boot 2022.04
> >>>> - Linux 5.15.61
> >>>> 
> >>>> PineCube is a low-powered, open source IP camera
> >>>> with the following specs:
> >>>>   - Allwinner S3 Cortex-A7
> >>>>   - 128 MiB DDR3
> >>>>   - 16 MiB SPI flash
> >>>>   - 5 MPx OV5640 camera
> >>>>   - MicroSD slot
> >>>>   - 10/100M Ethernet with passive PoE
> >>>>   - 802.11 b/g/n WiFi
> >>>>   - Bluetooth 4.1
> >>>>   - USB 2.0
> >>>>   - 26 pins GPIO header
> >>>>   - Microphone
> >>>>   - IR LEDs for night vision
> >>>> 
> >>>> Board homepage: https://www.pine64.org/cube/
> >>>> Board wiki:     https://wiki.pine64.org/wiki/PineCube
> >>>> 
> >>>> Signed-off-by: Jan Havran <havran.jan@email.cz>
> >>>> ---
> >>>> Changes v1 -> v2 (review by Giulio Benetti):
> >>>>    - Updated commit message
> >>>>    - Replaced boot.cmd by extlinux.conf
> >>>>    - Renamed pinecube_defconfig to pine64_pinecube_defconfig
> >>>>    - Changed welcome message (generic issue)
> >>>>    - Updated U-Boot 2022.01 to 2022.04
> >>>>    - Updated Linux kernel from 5.15 to 5.15.61
> >>>>    - Removed NEON from FPU (but kept VFPV4)
> >>>> ---
> >>>>   DEVELOPERS                          |  4 +++
> >>>>   board/pine64/pinecube/extlinux.conf |  4 +++
> >>>>   board/pine64/pinecube/genimage.cfg  | 34 ++++++++++++++++++++++
> >>>>   board/pine64/pinecube/post-build.sh |  5 ++++
> >>>>   board/pine64/pinecube/readme.txt    | 31 ++++++++++++++++++++
> >>>>   configs/pine64_pinecube_defconfig   | 45 +++++++++++++++++++++++++++++
> >>>>   6 files changed, 123 insertions(+)
> >>>>   create mode 100644 board/pine64/pinecube/extlinux.conf
> >>>>   create mode 100644 board/pine64/pinecube/genimage.cfg
> >>>>   create mode 100755 board/pine64/pinecube/post-build.sh
> >>>>   create mode 100644 board/pine64/pinecube/readme.txt
> >>>>   create mode 100644 configs/pine64_pinecube_defconfig
> >>>> 
> >>>> diff --git a/DEVELOPERS b/DEVELOPERS
> >>>> index 4287fd9cf7..74f57af6fa 100644
> >>>> --- a/DEVELOPERS
> >>>> +++ b/DEVELOPERS
> >>>> @@ -1410,6 +1410,10 @@ F:    package/pangomm/
> >>>>   F:    package/rpm/
> >>>>   F:    package/yad/
> >>>> +N:    Jan Havran <havran.jan@email.cz>
> >>>> +F:    board/pine64/pinecube/
> >>>> +F:    configs/pine64_pinecube_defconfig
> >>>> +
> >>>>   N:    Jan Heylen <jan.heylen@nokia.com>
> >>>>   F:    package/opentracing-cpp/
> >>>> diff --git a/board/pine64/pinecube/extlinux.conf
> >>>> b/board/pine64/pinecube/extlinux.conf
> >>>> new file mode 100644
> >>>> index 0000000000..6a18d9a2cb
> >>>> --- /dev/null
> >>>> +++ b/board/pine64/pinecube/extlinux.conf
> >>>> @@ -0,0 +1,4 @@
> >>>> +label buildroot
> >>>> +  kernel /zImage
> >>>> +  devicetree /sun8i-s3-pinecube.dtb
> >>>> +  append console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2
> >>>> rootwait rw
> >>>> diff --git a/board/pine64/pinecube/genimage.cfg
> >>>> b/board/pine64/pinecube/genimage.cfg
> >>>> new file mode 100644
> >>>> index 0000000000..398d45e2f7
> >>>> --- /dev/null
> >>>> +++ b/board/pine64/pinecube/genimage.cfg
> >>>> @@ -0,0 +1,34 @@
> >>>> +image boot.vfat {
> >>>> +    vfat {
> >>>> +        files = {
> >>>> +            "zImage",
> >>>> +            "sun8i-s3-pinecube.dtb",
> >>>> +            "extlinux"
> >>>> +        }
> >>>> +    }
> >>>> +
> >>>> +    size = 8M
> >>>> +}
> >>>> +
> >>>> +image sdcard.img {
> >>>> +    hdimage {
> >>>> +    }
> >>>> +
> >>>> +    partition u-boot {
> >>>> +        in-partition-table = "no"
> >>>> +        image = "u-boot-sunxi-with-spl.bin"
> >>>> +        offset = 8K
> >>>> +        size = 504K # 512KB - 8KB
> >>>> +    }
> >>>> +
> >>>> +    partition boot {
> >>>> +        partition-type = 0xC
> >>>> +        bootable = "true"
> >>>> +        image = "boot.vfat"
> >>>> +    }
> >>>> +
> >>>> +    partition rootfs {
> >>>> +        partition-type = 0x83
> >>>> +        image = "rootfs.ext4"
> >>>> +    }
> >>>> +}
> >>>> diff --git a/board/pine64/pinecube/post-build.sh
> >>>> b/board/pine64/pinecube/post-build.sh
> >>>> new file mode 100755
> >>>> index 0000000000..ba29375c05
> >>>> --- /dev/null
> >>>> +++ b/board/pine64/pinecube/post-build.sh
> >>>> @@ -0,0 +1,5 @@
> >>>> +#!/bin/sh
> >>>> +
> >>>> +BOARD_DIR="$(dirname $0)"
> >>>> +
> >>>> +install -m 0644 -D $BOARD_DIR/extlinux.conf
> >>>> $BINARIES_DIR/extlinux/extlinux.conf
> >>>> diff --git a/board/pine64/pinecube/readme.txt
> >>>> b/board/pine64/pinecube/readme.txt
> >>>> new file mode 100644
> >>>> index 0000000000..4cf6df2110
> >>>> --- /dev/null
> >>>> +++ b/board/pine64/pinecube/readme.txt
> >>>> @@ -0,0 +1,31 @@
> >>>> +Intro
> >>>> +=====
> >>>> +
> >>>> +This directory contains a Buildroot configuration for building a
> >>>> +Pine64 PineCube.
> >>>> +
> >>>> +Board homepage: https://www.pine64.org/cube/
> >>>> +Board wiki:     https://wiki.pine64.org/wiki/PineCube
> >>>> +
> >>>> +How to build it
> >>>> +===============
> >>>> +
> >>>> +  $ make pine64_pinecube_defconfig
> >>>> +  $ make
> >>>> +
> >>>> +Note: you will need access to the internet to download the required
> >>>> +sources.
> >>>> +
> >>>> +How to write the SD card
> >>>> +========================
> >>>> +
> >>>> +Once the build process is finished you will have an image called
> >>>> "sdcard.img"
> >>>> +in the output/images/ directory.
> >>>> +
> >>>> +Copy the bootable "sdcard.img" onto an SD card with "dd":
> >>>> +
> >>>> +  $ sudo dd if=output/images/sdcard.img of=/dev/sdX
> >>>> +  $ sudo sync
> >>>> +
> >>>> +Insert the micro SDcard in your PineCube and power it up. The console
> >>>> +is on the serial port 2, 115200 8N1 (check Wiki for board pinout).
> >>>> diff --git a/configs/pine64_pinecube_defconfig
> >>>> b/configs/pine64_pinecube_defconfig
> >>>> new file mode 100644
> >>>> index 0000000000..8f60115f8f
> >>>> --- /dev/null
> >>>> +++ b/configs/pine64_pinecube_defconfig
> >>>> @@ -0,0 +1,45 @@
> >>>> +# Target options
> >>>> +BR2_arm=y
> >>>> +BR2_cortex_a7=y
> >>>> +BR2_ARM_FPU_VFPV4=y
> >>> 
> >>> About this ^^^ there is an ongoing discussion if use mixed VFVP4+NEON or
> >>> not:
> >>> https://lists.buildroot.org/pipermail/buildroot/2022-August/649770.html
> >>> 
> >>> For the moment it's ok to me keeping this way and when we've all
> >>> clarified FPU strategy on 32-bit ARM cortex then we can modify and
> >>> you could test it or even provide the patch for this.
> >>> 
> >>> Have you re-tested the board with such modification?
> >>> 
> > 
> > Yes, I re-tested the board for general use. But if you ask about the FPU, I am not
> > sure what kind of tests should I run and how to check if it gives me valid result.
> > Should I do some heavy FPU testing? This one setting is more based on chip description
> > and previous discussion rather than some my tests/experiments.
> 
> No need. It’s ok, if there was a problem you’ve have found a segmentation fault while booting.
> 
> > 
> >>>> +
> >>>> +# Toolchain options
> >>>> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
> >>>> +
> >>>> +# System configuration
> >>>> +BR2_TARGET_GENERIC_HOSTNAME="pinecube"
> >>>> +BR2_TARGET_GENERIC_ISSUE="Welcome to Pine64 Pinecube"
> >>>> +BR2_SYSTEM_DHCP="eth0"
> >>>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/pine64/pinecube/post-build.sh"
> >>>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> >>>> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/pine64/pinecube/genimage.cfg"
> >>>> +
> >>>> +# Kernel
> >>>> +BR2_LINUX_KERNEL=y
> >>>> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> >>>> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.61"
> >>>> +BR2_LINUX_KERNEL_DEFCONFIG="sunxi"
> >>>> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> >>>> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-s3-pinecube"
> >>>> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> >>>> +
> >>>> +# Filesystem
> >>>> +BR2_TARGET_ROOTFS_EXT2=y
> >>>> +BR2_TARGET_ROOTFS_EXT2_4=y
> >>>> +
> >>>> +# Bootloader
> >>>> +BR2_TARGET_UBOOT=y
> >>>> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> >>>> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> >>>> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
> >>>> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pinecube"
> >>>> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> >>>> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> >>>> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> >>>> +BR2_TARGET_UBOOT_SPL=y
> >>>> +BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
> >>>> +
> >>>> +# Required host utilities for building an SDCard image
> >>>> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> >>>> +BR2_PACKAGE_HOST_GENIMAGE=y
> >>>> +BR2_PACKAGE_HOST_MTOOLS=y
> >>> 
> >>> Overall looks good to me, it builds correctly with buildroot/docker-run
> >>> so:
> >>> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> >>> 
> >>> Expect this patch to be part of 2022.11 since 2022.08-rc1 has been
> >>> released on 12th August and from -rc1 to 2022.08 only bug fixes and
> >>> security patches are allowed.
> >>> 
> >>> Thanks for the contribution!
> > 
> > Thank you very much for your review and your time.
> 
> You’re welcome
> 
> Best regards
> Giulio
> 
> > 
> > Regards,
> > Jan
> > 
> >>> 
> >>> Best regards
> >> 
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot@buildroot.org
> >> https://lists.buildroot.org/mailman/listinfo/buildroot
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] board/pine64/pinecube: new board
  2023-06-02 19:27         ` Jan Havran
@ 2023-06-02 20:09           ` Giulio Benetti
  0 siblings, 0 replies; 9+ messages in thread
From: Giulio Benetti @ 2023-06-02 20:09 UTC (permalink / raw)
  To: Jan Havran; +Cc: Jagan Teki, buildroot

Hi Jan,

> Il giorno 2 giu 2023, alle ore 21:41, Jan Havran <havran.jan@email.cz> ha scritto:
> 
> Hello everyone,
> 
> it's been a while since I sent this v2 (and even longer since v1) and got review by Giulio...
> is there anything I can do to help this merged?
> 
> I guess I will need to send v3 anyway since this patch is quite old now.

you should send v3 only if it creates conflicts with current master branch.

Best regards
Giulio

> 
> Thank you,
> Jan
> 
> V Sun, Aug 21, 2022 at 09:01:25PM +0200, Giulio Benetti napsal(a):
>> Hi Jan,
>> 
>>>> Il giorno 21 ago 2022, alle ore 20:55, Jan Havran <havran.jan@email.cz> ha scritto:
>>> 
>>> Hi Giulio,
>>> 
>>> V Sun, Aug 21, 2022 at 08:01:47PM +0200, Giulio Benetti napsal(a):
>>>> One last thing, please set the v1 patch to superseded in Patchwork:
>>>> https://patchwork.ozlabs.org/project/buildroot/list/?submitter=74841
>>>> 
>>> 
>>> Patch set (did not know that I have to do it manually).
>> 
>> perfect
>> 
>>> 
>>>> Thank you!
>>>> 
>>>> Best regards
>>>> -- 
>>>> Giulio Benetti
>>>> Benetti Engineering sas
>>>> 
>>>>> On 21/08/22 19:53, Giulio Benetti wrote:
>>>>> Hi Jan,
>>>>> 
>>>>> On 21/08/22 13:04, Jan Havran wrote:
>>>>>> Add support for PineCube with:
>>>>>> - U-Boot 2022.04
>>>>>> - Linux 5.15.61
>>>>>> 
>>>>>> PineCube is a low-powered, open source IP camera
>>>>>> with the following specs:
>>>>>>  - Allwinner S3 Cortex-A7
>>>>>>  - 128 MiB DDR3
>>>>>>  - 16 MiB SPI flash
>>>>>>  - 5 MPx OV5640 camera
>>>>>>  - MicroSD slot
>>>>>>  - 10/100M Ethernet with passive PoE
>>>>>>  - 802.11 b/g/n WiFi
>>>>>>  - Bluetooth 4.1
>>>>>>  - USB 2.0
>>>>>>  - 26 pins GPIO header
>>>>>>  - Microphone
>>>>>>  - IR LEDs for night vision
>>>>>> 
>>>>>> Board homepage: https://www.pine64.org/cube/
>>>>>> Board wiki:     https://wiki.pine64.org/wiki/PineCube
>>>>>> 
>>>>>> Signed-off-by: Jan Havran <havran.jan@email.cz>
>>>>>> ---
>>>>>> Changes v1 -> v2 (review by Giulio Benetti):
>>>>>>   - Updated commit message
>>>>>>   - Replaced boot.cmd by extlinux.conf
>>>>>>   - Renamed pinecube_defconfig to pine64_pinecube_defconfig
>>>>>>   - Changed welcome message (generic issue)
>>>>>>   - Updated U-Boot 2022.01 to 2022.04
>>>>>>   - Updated Linux kernel from 5.15 to 5.15.61
>>>>>>   - Removed NEON from FPU (but kept VFPV4)
>>>>>> ---
>>>>>>  DEVELOPERS                          |  4 +++
>>>>>>  board/pine64/pinecube/extlinux.conf |  4 +++
>>>>>>  board/pine64/pinecube/genimage.cfg  | 34 ++++++++++++++++++++++
>>>>>>  board/pine64/pinecube/post-build.sh |  5 ++++
>>>>>>  board/pine64/pinecube/readme.txt    | 31 ++++++++++++++++++++
>>>>>>  configs/pine64_pinecube_defconfig   | 45 +++++++++++++++++++++++++++++
>>>>>>  6 files changed, 123 insertions(+)
>>>>>>  create mode 100644 board/pine64/pinecube/extlinux.conf
>>>>>>  create mode 100644 board/pine64/pinecube/genimage.cfg
>>>>>>  create mode 100755 board/pine64/pinecube/post-build.sh
>>>>>>  create mode 100644 board/pine64/pinecube/readme.txt
>>>>>>  create mode 100644 configs/pine64_pinecube_defconfig
>>>>>> 
>>>>>> diff --git a/DEVELOPERS b/DEVELOPERS
>>>>>> index 4287fd9cf7..74f57af6fa 100644
>>>>>> --- a/DEVELOPERS
>>>>>> +++ b/DEVELOPERS
>>>>>> @@ -1410,6 +1410,10 @@ F:    package/pangomm/
>>>>>>  F:    package/rpm/
>>>>>>  F:    package/yad/
>>>>>> +N:    Jan Havran <havran.jan@email.cz>
>>>>>> +F:    board/pine64/pinecube/
>>>>>> +F:    configs/pine64_pinecube_defconfig
>>>>>> +
>>>>>>  N:    Jan Heylen <jan.heylen@nokia.com>
>>>>>>  F:    package/opentracing-cpp/
>>>>>> diff --git a/board/pine64/pinecube/extlinux.conf
>>>>>> b/board/pine64/pinecube/extlinux.conf
>>>>>> new file mode 100644
>>>>>> index 0000000000..6a18d9a2cb
>>>>>> --- /dev/null
>>>>>> +++ b/board/pine64/pinecube/extlinux.conf
>>>>>> @@ -0,0 +1,4 @@
>>>>>> +label buildroot
>>>>>> +  kernel /zImage
>>>>>> +  devicetree /sun8i-s3-pinecube.dtb
>>>>>> +  append console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2
>>>>>> rootwait rw
>>>>>> diff --git a/board/pine64/pinecube/genimage.cfg
>>>>>> b/board/pine64/pinecube/genimage.cfg
>>>>>> new file mode 100644
>>>>>> index 0000000000..398d45e2f7
>>>>>> --- /dev/null
>>>>>> +++ b/board/pine64/pinecube/genimage.cfg
>>>>>> @@ -0,0 +1,34 @@
>>>>>> +image boot.vfat {
>>>>>> +    vfat {
>>>>>> +        files = {
>>>>>> +            "zImage",
>>>>>> +            "sun8i-s3-pinecube.dtb",
>>>>>> +            "extlinux"
>>>>>> +        }
>>>>>> +    }
>>>>>> +
>>>>>> +    size = 8M
>>>>>> +}
>>>>>> +
>>>>>> +image sdcard.img {
>>>>>> +    hdimage {
>>>>>> +    }
>>>>>> +
>>>>>> +    partition u-boot {
>>>>>> +        in-partition-table = "no"
>>>>>> +        image = "u-boot-sunxi-with-spl.bin"
>>>>>> +        offset = 8K
>>>>>> +        size = 504K # 512KB - 8KB
>>>>>> +    }
>>>>>> +
>>>>>> +    partition boot {
>>>>>> +        partition-type = 0xC
>>>>>> +        bootable = "true"
>>>>>> +        image = "boot.vfat"
>>>>>> +    }
>>>>>> +
>>>>>> +    partition rootfs {
>>>>>> +        partition-type = 0x83
>>>>>> +        image = "rootfs.ext4"
>>>>>> +    }
>>>>>> +}
>>>>>> diff --git a/board/pine64/pinecube/post-build.sh
>>>>>> b/board/pine64/pinecube/post-build.sh
>>>>>> new file mode 100755
>>>>>> index 0000000000..ba29375c05
>>>>>> --- /dev/null
>>>>>> +++ b/board/pine64/pinecube/post-build.sh
>>>>>> @@ -0,0 +1,5 @@
>>>>>> +#!/bin/sh
>>>>>> +
>>>>>> +BOARD_DIR="$(dirname $0)"
>>>>>> +
>>>>>> +install -m 0644 -D $BOARD_DIR/extlinux.conf
>>>>>> $BINARIES_DIR/extlinux/extlinux.conf
>>>>>> diff --git a/board/pine64/pinecube/readme.txt
>>>>>> b/board/pine64/pinecube/readme.txt
>>>>>> new file mode 100644
>>>>>> index 0000000000..4cf6df2110
>>>>>> --- /dev/null
>>>>>> +++ b/board/pine64/pinecube/readme.txt
>>>>>> @@ -0,0 +1,31 @@
>>>>>> +Intro
>>>>>> +=====
>>>>>> +
>>>>>> +This directory contains a Buildroot configuration for building a
>>>>>> +Pine64 PineCube.
>>>>>> +
>>>>>> +Board homepage: https://www.pine64.org/cube/
>>>>>> +Board wiki:     https://wiki.pine64.org/wiki/PineCube
>>>>>> +
>>>>>> +How to build it
>>>>>> +===============
>>>>>> +
>>>>>> +  $ make pine64_pinecube_defconfig
>>>>>> +  $ make
>>>>>> +
>>>>>> +Note: you will need access to the internet to download the required
>>>>>> +sources.
>>>>>> +
>>>>>> +How to write the SD card
>>>>>> +========================
>>>>>> +
>>>>>> +Once the build process is finished you will have an image called
>>>>>> "sdcard.img"
>>>>>> +in the output/images/ directory.
>>>>>> +
>>>>>> +Copy the bootable "sdcard.img" onto an SD card with "dd":
>>>>>> +
>>>>>> +  $ sudo dd if=output/images/sdcard.img of=/dev/sdX
>>>>>> +  $ sudo sync
>>>>>> +
>>>>>> +Insert the micro SDcard in your PineCube and power it up. The console
>>>>>> +is on the serial port 2, 115200 8N1 (check Wiki for board pinout).
>>>>>> diff --git a/configs/pine64_pinecube_defconfig
>>>>>> b/configs/pine64_pinecube_defconfig
>>>>>> new file mode 100644
>>>>>> index 0000000000..8f60115f8f
>>>>>> --- /dev/null
>>>>>> +++ b/configs/pine64_pinecube_defconfig
>>>>>> @@ -0,0 +1,45 @@
>>>>>> +# Target options
>>>>>> +BR2_arm=y
>>>>>> +BR2_cortex_a7=y
>>>>>> +BR2_ARM_FPU_VFPV4=y
>>>>> 
>>>>> About this ^^^ there is an ongoing discussion if use mixed VFVP4+NEON or
>>>>> not:
>>>>> https://lists.buildroot.org/pipermail/buildroot/2022-August/649770.html
>>>>> 
>>>>> For the moment it's ok to me keeping this way and when we've all
>>>>> clarified FPU strategy on 32-bit ARM cortex then we can modify and
>>>>> you could test it or even provide the patch for this.
>>>>> 
>>>>> Have you re-tested the board with such modification?
>>>>> 
>>> 
>>> Yes, I re-tested the board for general use. But if you ask about the FPU, I am not
>>> sure what kind of tests should I run and how to check if it gives me valid result.
>>> Should I do some heavy FPU testing? This one setting is more based on chip description
>>> and previous discussion rather than some my tests/experiments.
>> 
>> No need. It’s ok, if there was a problem you’ve have found a segmentation fault while booting.
>> 
>>> 
>>>>>> +
>>>>>> +# Toolchain options
>>>>>> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
>>>>>> +
>>>>>> +# System configuration
>>>>>> +BR2_TARGET_GENERIC_HOSTNAME="pinecube"
>>>>>> +BR2_TARGET_GENERIC_ISSUE="Welcome to Pine64 Pinecube"
>>>>>> +BR2_SYSTEM_DHCP="eth0"
>>>>>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/pine64/pinecube/post-build.sh"
>>>>>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
>>>>>> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/pine64/pinecube/genimage.cfg"
>>>>>> +
>>>>>> +# Kernel
>>>>>> +BR2_LINUX_KERNEL=y
>>>>>> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
>>>>>> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.61"
>>>>>> +BR2_LINUX_KERNEL_DEFCONFIG="sunxi"
>>>>>> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
>>>>>> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="sun8i-s3-pinecube"
>>>>>> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>>>>>> +
>>>>>> +# Filesystem
>>>>>> +BR2_TARGET_ROOTFS_EXT2=y
>>>>>> +BR2_TARGET_ROOTFS_EXT2_4=y
>>>>>> +
>>>>>> +# Bootloader
>>>>>> +BR2_TARGET_UBOOT=y
>>>>>> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>>>>>> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
>>>>>> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
>>>>>> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pinecube"
>>>>>> +BR2_TARGET_UBOOT_NEEDS_DTC=y
>>>>>> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
>>>>>> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
>>>>>> +BR2_TARGET_UBOOT_SPL=y
>>>>>> +BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
>>>>>> +
>>>>>> +# Required host utilities for building an SDCard image
>>>>>> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
>>>>>> +BR2_PACKAGE_HOST_GENIMAGE=y
>>>>>> +BR2_PACKAGE_HOST_MTOOLS=y
>>>>> 
>>>>> Overall looks good to me, it builds correctly with buildroot/docker-run
>>>>> so:
>>>>> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>>>> 
>>>>> Expect this patch to be part of 2022.11 since 2022.08-rc1 has been
>>>>> released on 12th August and from -rc1 to 2022.08 only bug fixes and
>>>>> security patches are allowed.
>>>>> 
>>>>> Thanks for the contribution!
>>> 
>>> Thank you very much for your review and your time.
>> 
>> You’re welcome
>> 
>> Best regards
>> Giulio
>> 
>>> 
>>> Regards,
>>> Jan
>>> 
>>>>> 
>>>>> Best regards
>>>> 
>>>> _______________________________________________
>>>> buildroot mailing list
>>>> buildroot@buildroot.org
>>>> https://lists.buildroot.org/mailman/listinfo/buildroot
>> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] board/pine64/pinecube: new board
  2022-08-21 11:04 [Buildroot] [PATCH v2] board/pine64/pinecube: new board Jan Havran
  2022-08-21 17:53 ` Giulio Benetti
@ 2023-08-26 21:05 ` Thomas Petazzoni via buildroot
  2023-09-03 13:39   ` Jan Havran
  1 sibling, 1 reply; 9+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-26 21:05 UTC (permalink / raw)
  To: Jan Havran; +Cc: Giulio Benetti, Jagan Teki, buildroot

On Sun, 21 Aug 2022 13:04:18 +0200
Jan Havran <havran.jan@email.cz> wrote:

> Add support for PineCube with:
> - U-Boot 2022.04
> - Linux 5.15.61
> 
> PineCube is a low-powered, open source IP camera
> with the following specs:
>  - Allwinner S3 Cortex-A7
>  - 128 MiB DDR3
>  - 16 MiB SPI flash
>  - 5 MPx OV5640 camera
>  - MicroSD slot
>  - 10/100M Ethernet with passive PoE
>  - 802.11 b/g/n WiFi
>  - Bluetooth 4.1
>  - USB 2.0
>  - 26 pins GPIO header
>  - Microphone
>  - IR LEDs for night vision
> 
> Board homepage: https://www.pine64.org/cube/
> Board wiki:     https://wiki.pine64.org/wiki/PineCube
> 
> Signed-off-by: Jan Havran <havran.jan@email.cz>

Sorry for the super long delay, I have now applied your patch to our
next branch. It will be part of 2023.11. Don't hesitate to send a
follow-up patch updating to a newer kernel and/or U-Boot version.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] board/pine64/pinecube: new board
  2023-08-26 21:05 ` Thomas Petazzoni via buildroot
@ 2023-09-03 13:39   ` Jan Havran
  0 siblings, 0 replies; 9+ messages in thread
From: Jan Havran @ 2023-09-03 13:39 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: Giulio Benetti, Jagan Teki, buildroot

V Sat, Aug 26, 2023 at 11:05:50PM +0200, Thomas Petazzoni napsal(a):
> On Sun, 21 Aug 2022 13:04:18 +0200
> Jan Havran <havran.jan@email.cz> wrote:
> 
> > Add support for PineCube with:
> > - U-Boot 2022.04
> > - Linux 5.15.61
> > 
> > PineCube is a low-powered, open source IP camera
> > with the following specs:
> >  - Allwinner S3 Cortex-A7
> >  - 128 MiB DDR3
> >  - 16 MiB SPI flash
> >  - 5 MPx OV5640 camera
> >  - MicroSD slot
> >  - 10/100M Ethernet with passive PoE
> >  - 802.11 b/g/n WiFi
> >  - Bluetooth 4.1
> >  - USB 2.0
> >  - 26 pins GPIO header
> >  - Microphone
> >  - IR LEDs for night vision
> > 
> > Board homepage: https://www.pine64.org/cube/
> > Board wiki:     https://wiki.pine64.org/wiki/PineCube
> > 
> > Signed-off-by: Jan Havran <havran.jan@email.cz>
> 
> Sorry for the super long delay, I have now applied your patch to our
> next branch. It will be part of 2023.11. Don't hesitate to send a
> follow-up patch updating to a newer kernel and/or U-Boot version.
> 
> Thanks a lot!
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Thank you, will do!

Jan
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-09-03 13:52 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-21 11:04 [Buildroot] [PATCH v2] board/pine64/pinecube: new board Jan Havran
2022-08-21 17:53 ` Giulio Benetti
2022-08-21 18:01   ` Giulio Benetti
2022-08-21 18:55     ` Jan Havran
2022-08-21 19:01       ` Giulio Benetti
2023-06-02 19:27         ` Jan Havran
2023-06-02 20:09           ` Giulio Benetti
2023-08-26 21:05 ` Thomas Petazzoni via buildroot
2023-09-03 13:39   ` Jan Havran

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.