All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/vlv: no MCHBAR on VLV
@ 2014-03-03 22:27 Jesse Barnes
  2014-03-18 18:13 ` Jesse Barnes
  0 siblings, 1 reply; 6+ messages in thread
From: Jesse Barnes @ 2014-03-03 22:27 UTC (permalink / raw)
  To: intel-gfx; +Cc: Junxiao Chang

So don't try to allocate and program it, we're only fooling ourselves.

Reported-by: "Chang, Junxiao" <junxiao.chang@intel.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/i915_dma.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 7688abc..22f839b 100644
--- a/drivers/gpu/drm/i915/i915_dma.c
+++ b/drivers/gpu/drm/i915/i915_dma.c
@@ -1187,6 +1187,9 @@ intel_setup_mchbar(struct drm_device *dev)
 	u32 temp;
 	bool enabled;
 
+	if (IS_VALLEYVIEW(dev))
+		return;
+
 	dev_priv->mchbar_need_disable = false;
 
 	if (IS_I915G(dev) || IS_I915GM(dev)) {
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/vlv: no MCHBAR on VLV
  2014-03-03 22:27 [PATCH] drm/i915/vlv: no MCHBAR on VLV Jesse Barnes
@ 2014-03-18 18:13 ` Jesse Barnes
  2014-03-19  2:13   ` Chang, Junxiao
  0 siblings, 1 reply; 6+ messages in thread
From: Jesse Barnes @ 2014-03-18 18:13 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: Junxiao Chang, intel-gfx

Junxiao, can you add you reviewed-by to this patch?

Thanks,
Jesse

On Mon,  3 Mar 2014 14:27:57 -0800
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> So don't try to allocate and program it, we're only fooling ourselves.
> 
> Reported-by: "Chang, Junxiao" <junxiao.chang@intel.com>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/i915_dma.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index 7688abc..22f839b 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -1187,6 +1187,9 @@ intel_setup_mchbar(struct drm_device *dev)
>  	u32 temp;
>  	bool enabled;
>  
> +	if (IS_VALLEYVIEW(dev))
> +		return;
> +
>  	dev_priv->mchbar_need_disable = false;
>  
>  	if (IS_I915G(dev) || IS_I915GM(dev)) {


-- 
Jesse Barnes, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/vlv: no MCHBAR on VLV
  2014-03-18 18:13 ` Jesse Barnes
@ 2014-03-19  2:13   ` Chang, Junxiao
  2014-03-19  2:31     ` Dave Airlie
  0 siblings, 1 reply; 6+ messages in thread
From: Chang, Junxiao @ 2014-03-19  2:13 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: intel-gfx

Hi Jesse,

I just registered patchwork account in freedesktop.org, but I don't know how to add "reviewed by" to the patch http://patchwork.freedesktop.org/patch/21324/.

Could you tell me how to add "reviewed by" to the patch?

Thanks,
Junxiao

-----Original Message-----
From: Jesse Barnes [mailto:jbarnes@virtuousgeek.org] 
Sent: Wednesday, March 19, 2014 2:13 AM
To: Jesse Barnes
Cc: intel-gfx@lists.freedesktop.org; Chang, Junxiao
Subject: Re: [Intel-gfx] [PATCH] drm/i915/vlv: no MCHBAR on VLV

Junxiao, can you add you reviewed-by to this patch?

Thanks,
Jesse

On Mon,  3 Mar 2014 14:27:57 -0800
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> So don't try to allocate and program it, we're only fooling ourselves.
> 
> Reported-by: "Chang, Junxiao" <junxiao.chang@intel.com>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/i915_dma.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_dma.c 
> b/drivers/gpu/drm/i915/i915_dma.c index 7688abc..22f839b 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -1187,6 +1187,9 @@ intel_setup_mchbar(struct drm_device *dev)
>  	u32 temp;
>  	bool enabled;
>  
> +	if (IS_VALLEYVIEW(dev))
> +		return;
> +
>  	dev_priv->mchbar_need_disable = false;
>  
>  	if (IS_I915G(dev) || IS_I915GM(dev)) {


--
Jesse Barnes, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/vlv: no MCHBAR on VLV
  2014-03-19  2:13   ` Chang, Junxiao
@ 2014-03-19  2:31     ` Dave Airlie
  2014-03-19  3:31       ` Chang, Junxiao
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Airlie @ 2014-03-19  2:31 UTC (permalink / raw)
  To: Chang, Junxiao; +Cc: intel-gfx

On Wed, Mar 19, 2014 at 12:13 PM, Chang, Junxiao
<junxiao.chang@intel.com> wrote:
> Hi Jesse,
>
> I just registered patchwork account in freedesktop.org, but I don't know how to add "reviewed by" to the patch http://patchwork.freedesktop.org/patch/21324/.
>
> Could you tell me how to add "reviewed by" to the patch?

Just reply here, with Reviewed-by: tag, and patckwork picks it up.

Dave.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/vlv: no MCHBAR on VLV
  2014-03-19  2:31     ` Dave Airlie
@ 2014-03-19  3:31       ` Chang, Junxiao
  2014-03-19  9:14         ` Daniel Vetter
  0 siblings, 1 reply; 6+ messages in thread
From: Chang, Junxiao @ 2014-03-19  3:31 UTC (permalink / raw)
  To: Dave Airlie; +Cc: intel-gfx

Reviewed-by: Junxiao Chang <junxiao.chang@intel.com>

Thanks,
Junxiao

-----Original Message-----
From: Dave Airlie [mailto:airlied@gmail.com] 
Sent: Wednesday, March 19, 2014 10:32 AM
To: Chang, Junxiao
Cc: Jesse Barnes; intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/vlv: no MCHBAR on VLV

On Wed, Mar 19, 2014 at 12:13 PM, Chang, Junxiao <junxiao.chang@intel.com> wrote:
> Hi Jesse,
>
> I just registered patchwork account in freedesktop.org, but I don't know how to add "reviewed by" to the patch http://patchwork.freedesktop.org/patch/21324/.
>
> Could you tell me how to add "reviewed by" to the patch?

Just reply here, with Reviewed-by: tag, and patckwork picks it up.

Dave.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/vlv: no MCHBAR on VLV
  2014-03-19  3:31       ` Chang, Junxiao
@ 2014-03-19  9:14         ` Daniel Vetter
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2014-03-19  9:14 UTC (permalink / raw)
  To: Chang, Junxiao; +Cc: intel-gfx

On Wed, Mar 19, 2014 at 03:31:41AM +0000, Chang, Junxiao wrote:
> Reviewed-by: Junxiao Chang <junxiao.chang@intel.com>

Queued for -next, thanks for the patch&review.
-Daniel
> 
> Thanks,
> Junxiao
> 
> -----Original Message-----
> From: Dave Airlie [mailto:airlied@gmail.com] 
> Sent: Wednesday, March 19, 2014 10:32 AM
> To: Chang, Junxiao
> Cc: Jesse Barnes; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/vlv: no MCHBAR on VLV
> 
> On Wed, Mar 19, 2014 at 12:13 PM, Chang, Junxiao <junxiao.chang@intel.com> wrote:
> > Hi Jesse,
> >
> > I just registered patchwork account in freedesktop.org, but I don't know how to add "reviewed by" to the patch http://patchwork.freedesktop.org/patch/21324/.
> >
> > Could you tell me how to add "reviewed by" to the patch?
> 
> Just reply here, with Reviewed-by: tag, and patckwork picks it up.
> 
> Dave.
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-19  9:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-03 22:27 [PATCH] drm/i915/vlv: no MCHBAR on VLV Jesse Barnes
2014-03-18 18:13 ` Jesse Barnes
2014-03-19  2:13   ` Chang, Junxiao
2014-03-19  2:31     ` Dave Airlie
2014-03-19  3:31       ` Chang, Junxiao
2014-03-19  9:14         ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.