* [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node [not found] <CGME20170110082433eucas1p2f7cb7b0974987e2c8294509960468fd3@eucas1p2.samsung.com> @ 2017-01-10 8:24 ` Andrzej Hajda [not found] ` <CGME20170110082433eucas1p10121a0c5defc7a3004235c78a50b1ff4@eucas1p1.samsung.com> [not found] ` <CGME20170110082434eucas1p2aa6d49ad0e77f9ed2a4d4d8c58f94307@eucas1p2.samsung.com> 0 siblings, 2 replies; 13+ messages in thread From: Andrzej Hajda @ 2017-01-10 8:24 UTC (permalink / raw) To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree-u79uwXL29TY76Z2rM5mHXA, Andi Shyti, Chanwoo Choi DECON_TV is 2nd display controller on Exynos5433, used in HDMI path or 2nd DSI path. Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Tested-by: Hoegeun Kwon <hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> --- Hi Krzysztof, These patches are based on latest patches separating tm2 and tm2e and touchscreen patches. I hope this is good base. Thanks all for quick response/review. Regards Andrzej v2: - replaced magic numbers with macros, - removed power domains, - removed 0x prefixes from node names v3: - order nodes by address --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 68f764e..8865fae 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -751,6 +751,29 @@ }; }; + decon_tv: decon@13880000 { + compatible = "samsung,exynos5433-decon-tv"; + reg = <0x13880000 0x20b8>; + clocks = <&cmu_disp CLK_PCLK_DECON_TV>, + <&cmu_disp CLK_ACLK_DECON_TV>, + <&cmu_disp CLK_ACLK_SMMU_TV0X>, + <&cmu_disp CLK_ACLK_XIU_TV0X>, + <&cmu_disp CLK_PCLK_SMMU_TV0X>, + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>, + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>; + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x", + "aclk_xiu_decon0x", "pclk_smmu_decon0x", + "sclk_decon_vclk", "sclk_decon_eclk"; + samsung,disp-sysreg = <&syscon_disp>; + interrupt-names = "fifo", "vsync", "lcd_sys"; + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>; + iommu-names = "m0", "m1"; + }; + dsi: dsi@13900000 { compatible = "samsung,exynos5433-mipi-dsi"; reg = <0x13900000 0xC0>; @@ -912,6 +935,26 @@ #iommu-cells = <0>; }; + sysmmu_tv0x: sysmmu@13a20000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x13a20000 0x1000>; + interrupts = <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>; + clock-names = "pclk", "aclk"; + clocks = <&cmu_disp CLK_PCLK_SMMU_TV0X>, + <&cmu_disp CLK_ACLK_SMMU_TV0X>; + #iommu-cells = <0>; + }; + + sysmmu_tv1x: sysmmu@13a30000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x13a30000 0x1000>; + interrupts = <GIC_SPI 216 IRQ_TYPE_LEVEL_HIGH>; + clock-names = "pclk", "aclk"; + clocks = <&cmu_disp CLK_PCLK_SMMU_TV1X>, + <&cmu_disp CLK_ACLK_SMMU_TV1X>; + #iommu-cells = <0>; + }; + sysmmu_gscl0: sysmmu@0x13C80000 { compatible = "samsung,exynos-sysmmu"; reg = <0x13C80000 0x1000>; -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <CGME20170110082433eucas1p10121a0c5defc7a3004235c78a50b1ff4@eucas1p1.samsung.com>]
* [PATCH v3 2/3] arm64: dts: exynos5433: add HDMI node [not found] ` <CGME20170110082433eucas1p10121a0c5defc7a3004235c78a50b1ff4@eucas1p1.samsung.com> @ 2017-01-10 8:24 ` Andrzej Hajda 0 siblings, 0 replies; 13+ messages in thread From: Andrzej Hajda @ 2017-01-10 8:24 UTC (permalink / raw) To: linux-samsung-soc, Krzysztof Kozlowski Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree, Andi Shyti, Chanwoo Choi HDMI converts RGB/I80 signal from DECON_TV to HDMI/TMDS video stream. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> --- v2: - replaced magic numbers with macros, - removed power domains --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 8865fae..441270f 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -837,6 +837,35 @@ }; }; + hdmi: hdmi@13970000 { + compatible = "samsung,exynos5433-hdmi"; + reg = <0x13970000 0x70000>; + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu_disp CLK_PCLK_HDMI>, + <&cmu_disp CLK_PCLK_HDMIPHY>, + <&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO>, + <&cmu_disp CLK_PHYCLK_HDMI_PIXEL>, + <&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO_PHY>, + <&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_TMDS_CLKO_USER>, + <&cmu_disp CLK_PHYCLK_HDMIPHY_PIXEL_CLKO_PHY>, + <&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_PIXEL_CLKO_USER>, + <&xxti>, <&cmu_disp CLK_SCLK_HDMI_SPDIF>; + clock-names = "hdmi_pclk", "hdmi_i_pclk", + "i_tmds_clk", "i_pixel_clk", + "tmds_clko", "tmds_clko_user", + "pixel_clko", "pixel_clko_user", + "oscclk", "i_spdif_clk"; + phy = <&hdmiphy>; + ddc = <&hsi2c_11>; + samsung,syscon-phandle = <&pmu_system_controller>; + samsung,sysreg-phandle = <&syscon_disp>; + status = "disabled"; + }; + + hdmiphy: hdmiphy@13af0000 { + reg = <0x13af0000 0x80>; + }; + syscon_disp: syscon@13b80000 { compatible = "syscon"; reg = <0x13b80000 0x1010>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <CGME20170110082434eucas1p2aa6d49ad0e77f9ed2a4d4d8c58f94307@eucas1p2.samsung.com>]
[parent not found: <1484036664-15951-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* [PATCH v3 3/3] arm64: dts: exynos5433-tm2: enable HDMI/TV path [not found] ` <1484036664-15951-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2017-01-10 8:24 ` Andrzej Hajda 2017-01-10 17:11 ` [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node Krzysztof Kozlowski 2017-01-10 19:09 ` Krzysztof Kozlowski 2 siblings, 0 replies; 13+ messages in thread From: Andrzej Hajda @ 2017-01-10 8:24 UTC (permalink / raw) To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree-u79uwXL29TY76Z2rM5mHXA, Andi Shyti, Chanwoo Choi TV path consist of following interconnected components: - DECON_TV - display controller, - HDMI - video signal converter RGB / HDMI, - MHL - video signal converter HDMI / MHL, - DDC - i2c slave device for EDID reading (on hsi2c_11 bus). Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Tested-by: Hoegeun Kwon <hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> --- v2: - replaced magic numbers with macros, - removed assigned-clock properties from sii8620 - PMU clock is already confgured in PMU node --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 69 ++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index 669bb1f..ca90e6a 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -281,6 +281,22 @@ }; }; +&decon_tv { + status = "okay"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + tv_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_tv>; + }; + }; + }; +}; + &dsi { status = "okay"; vddcore-supply = <&ldo6_reg>; @@ -304,6 +320,33 @@ }; }; +&hdmi { + hpd-gpios = <&gpa3 0 GPIO_ACTIVE_HIGH>; + status = "okay"; + vdd-supply = <&ldo6_reg>; + vdd_osc-supply = <&ldo7_reg>; + vdd_pll-supply = <&ldo6_reg>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + hdmi_to_tv: endpoint { + remote-endpoint = <&tv_to_hdmi>; + }; + }; + + port@1 { + reg = <1>; + hdmi_to_mhl: endpoint { + remote-endpoint = <&mhl_to_hdmi>; + }; + }; + }; +}; + &hsi2c_0 { status = "okay"; clock-frequency = <2500000>; @@ -692,6 +735,28 @@ }; }; +&hsi2c_7 { + status = "okay"; + + sii8620@39 { + reg = <0x39>; + compatible = "sil,sii8620"; + cvcc10-supply = <&ldo36_reg>; + iovcc18-supply = <&ldo34_reg>; + interrupt-parent = <&gpf0>; + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; + reset-gpios = <&gpv7 0 GPIO_ACTIVE_LOW>; + clocks = <&pmu_system_controller 0>; + clock-names = "xtal"; + + port { + mhl_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_mhl>; + }; + }; + }; +}; + &hsi2c_8 { status = "okay"; @@ -735,6 +800,10 @@ }; }; +&hsi2c_11 { + status = "okay"; +}; + &i2s0 { status = "okay"; }; -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node [not found] ` <1484036664-15951-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2017-01-10 8:24 ` [PATCH v3 3/3] arm64: dts: exynos5433-tm2: enable HDMI/TV path Andrzej Hajda @ 2017-01-10 17:11 ` Krzysztof Kozlowski 2017-01-11 8:07 ` Andrzej Hajda 2017-01-10 19:09 ` Krzysztof Kozlowski 2 siblings, 1 reply; 13+ messages in thread From: Krzysztof Kozlowski @ 2017-01-10 17:11 UTC (permalink / raw) To: Andrzej Hajda Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree-u79uwXL29TY76Z2rM5mHXA, Andi Shyti, Chanwoo Choi On Tue, Jan 10, 2017 at 09:24:22AM +0100, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> > Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Tested-by: Hoegeun Kwon <hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > --- > > Hi Krzysztof, > > These patches are based on latest patches separating tm2 and tm2e and > touchscreen patches. I hope this is good base. > Thanks all for quick response/review. > Thanks for fixing the issues. Also thank you for trying to fix the subject. However this is not a full fix. Please run: $ git log --oneline arch/arm64/boot/dts/exynos/ Why I am asking about this? I am trying to have it consistent so going through history would be easier. Of course we might discuss what prefix should be used. Some other platforms use "arm64: dts: architecture:", some use "arm64: dts: specific_chip_family:". For exynos we are trying to keep it just "exynos". Anyway regardless of the chosen prefix itself, after choosing some pattern, the consistency helps. When people keep sending patches with wrong title, then after every git-am I have to amend the commit and fix it. It is not difficult but annoying. Actually before I did not complain about it... but recently (this cycle) a lot of Samsung folks are sending wrong subjects. Weird. So just use the command and look at history. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node 2017-01-10 17:11 ` [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node Krzysztof Kozlowski @ 2017-01-11 8:07 ` Andrzej Hajda 0 siblings, 0 replies; 13+ messages in thread From: Andrzej Hajda @ 2017-01-11 8:07 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree-u79uwXL29TY76Z2rM5mHXA, Andi Shyti, Chanwoo Choi On 10.01.2017 18:11, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 09:24:22AM +0100, Andrzej Hajda wrote: >> DECON_TV is 2nd display controller on Exynos5433, used in HDMI path >> or 2nd DSI path. >> >> Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> >> Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> Tested-by: Hoegeun Kwon <hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> --- >> >> Hi Krzysztof, >> >> These patches are based on latest patches separating tm2 and tm2e and >> touchscreen patches. I hope this is good base. >> Thanks all for quick response/review. >> > Thanks for fixing the issues. Also thank you for trying to fix the > subject. However this is not a full fix. Please run: > $ git log --oneline arch/arm64/boot/dts/exynos/ > > Why I am asking about this? I am trying to have it consistent so > going through history would be easier. Of course we might discuss what > prefix should be used. Some other platforms use "arm64: dts: > architecture:", some use "arm64: dts: specific_chip_family:". For exynos > we are trying to keep it just "exynos". Anyway regardless of the chosen > prefix itself, after choosing some pattern, the consistency helps. > > When people keep sending patches with wrong title, then after every > git-am I have to amend the commit and fix it. It is not difficult but > annoying. > > Actually before I did not complain about it... but recently (this cycle) > a lot of Samsung folks are sending wrong subjects. Weird. I agree that consistency is good, so next time maybe it would be better to just simply write which prefix to use, instead of advising to dig into samsung-soc for help :) > > So just use the command and look at history. Good point. Regards Andrzej -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node [not found] ` <1484036664-15951-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2017-01-10 8:24 ` [PATCH v3 3/3] arm64: dts: exynos5433-tm2: enable HDMI/TV path Andrzej Hajda 2017-01-10 17:11 ` [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node Krzysztof Kozlowski @ 2017-01-10 19:09 ` Krzysztof Kozlowski 2017-01-11 8:14 ` Andrzej Hajda [not found] ` <CGME20170111083153eucas1p2b11e7b64f976a21f59c141bf7b06fd84@eucas1p2.samsung.com> 2 siblings, 2 replies; 13+ messages in thread From: Krzysztof Kozlowski @ 2017-01-10 19:09 UTC (permalink / raw) To: Andrzej Hajda Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree-u79uwXL29TY76Z2rM5mHXA, Andi Shyti, Chanwoo Choi On Tue, Jan 10, 2017 at 09:24:22AM +0100, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> > Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Tested-by: Hoegeun Kwon <hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > --- > > Hi Krzysztof, > > These patches are based on latest patches separating tm2 and tm2e and > touchscreen patches. I hope this is good base. > Thanks all for quick response/review. > > Regards > Andrzej > > v2: > - replaced magic numbers with macros, > - removed power domains, > - removed 0x prefixes from node names > > v3: > - order nodes by address > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > First, I applied your fix for unit addresses. Then I wanted to apply these... no, it does not apply. Okay, so maybe unit address confuses git-am (it is not that smart as cherry-pick etc) - let's try the other way. I applied these three patches, fixed that damned subject in each commit and I wanted to apply the fix for unit address. Nope. It won't apply. I do not know how you rebased your work. As of now, the fix is applied. Please fix the subject and rebase. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node 2017-01-10 19:09 ` Krzysztof Kozlowski @ 2017-01-11 8:14 ` Andrzej Hajda [not found] ` <CGME20170111083153eucas1p2b11e7b64f976a21f59c141bf7b06fd84@eucas1p2.samsung.com> 1 sibling, 0 replies; 13+ messages in thread From: Andrzej Hajda @ 2017-01-11 8:14 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree-u79uwXL29TY76Z2rM5mHXA, Andi Shyti, Chanwoo Choi On 10.01.2017 20:09, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 09:24:22AM +0100, Andrzej Hajda wrote: >> DECON_TV is 2nd display controller on Exynos5433, used in HDMI path >> or 2nd DSI path. >> >> Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> Reviewed-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> >> Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> Tested-by: Hoegeun Kwon <hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> --- >> >> Hi Krzysztof, >> >> These patches are based on latest patches separating tm2 and tm2e and >> touchscreen patches. I hope this is good base. >> Thanks all for quick response/review. >> >> Regards >> Andrzej >> >> v2: >> - replaced magic numbers with macros, >> - removed power domains, >> - removed 0x prefixes from node names >> >> v3: >> - order nodes by address >> --- >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> > First, I applied your fix for unit addresses. Then I wanted to apply > these... no, it does not apply. > > Okay, so maybe unit address confuses git-am (it is not that smart as > cherry-pick etc) - let's try the other way. I applied these three > patches, fixed that damned subject in each commit and I wanted to apply > the fix for unit address. Nope. It won't apply. > > I do not know how you rebased your work. I have get your latest for-next branch 68cb4b38b94473afe4dff3adaf97bbc6a81b5b91. I have reverted "arm64: dts: exynos: Fix addresses in node names on Exynos5433". I have applied all my patches cleanly. Anyway I will send again my patches rebased on 68cb4b38b94473afe4dff3adaf97bbc6a81b5b91 with your prefix. Regards Andrzej -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <CGME20170111083153eucas1p2b11e7b64f976a21f59c141bf7b06fd84@eucas1p2.samsung.com>]
* [PATCH v4 1/3] arm64: dts: exynos: add DECON_TV node [not found] ` <CGME20170111083153eucas1p2b11e7b64f976a21f59c141bf7b06fd84@eucas1p2.samsung.com> @ 2017-01-11 8:31 ` Andrzej Hajda [not found] ` <CGME20170111083155eucas1p21c30b8fb055ebe9415683df5f7e119e1@eucas1p2.samsung.com> ` (2 more replies) 0 siblings, 3 replies; 13+ messages in thread From: Andrzej Hajda @ 2017-01-11 8:31 UTC (permalink / raw) To: linux-samsung-soc, Krzysztof Kozlowski Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree, Andi Shyti, Chanwoo Choi DECON_TV is 2nd display controller on Exynos5433, used in HDMI path or 2nd DSI path. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> --- v4: - changed prefix - rebased on '68cb4b3 Merge branch 'next/dt64' into for-next' --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index abaf6b4..80dc0e8 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -751,6 +751,29 @@ }; }; + decon_tv: decon@13880000 { + compatible = "samsung,exynos5433-decon-tv"; + reg = <0x13880000 0x20b8>; + clocks = <&cmu_disp CLK_PCLK_DECON_TV>, + <&cmu_disp CLK_ACLK_DECON_TV>, + <&cmu_disp CLK_ACLK_SMMU_TV0X>, + <&cmu_disp CLK_ACLK_XIU_TV0X>, + <&cmu_disp CLK_PCLK_SMMU_TV0X>, + <&cmu_disp CLK_SCLK_DECON_TV_VCLK>, + <&cmu_disp CLK_SCLK_DECON_TV_ECLK>; + clock-names = "pclk", "aclk_decon", "aclk_smmu_decon0x", + "aclk_xiu_decon0x", "pclk_smmu_decon0x", + "sclk_decon_vclk", "sclk_decon_eclk"; + samsung,disp-sysreg = <&syscon_disp>; + interrupt-names = "fifo", "vsync", "lcd_sys"; + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + iommus = <&sysmmu_tv0x>, <&sysmmu_tv1x>; + iommu-names = "m0", "m1"; + }; + dsi: dsi@13900000 { compatible = "samsung,exynos5433-mipi-dsi"; reg = <0x13900000 0xC0>; @@ -912,6 +935,26 @@ #iommu-cells = <0>; }; + sysmmu_tv0x: sysmmu@13a20000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x13a20000 0x1000>; + interrupts = <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>; + clock-names = "pclk", "aclk"; + clocks = <&cmu_disp CLK_PCLK_SMMU_TV0X>, + <&cmu_disp CLK_ACLK_SMMU_TV0X>; + #iommu-cells = <0>; + }; + + sysmmu_tv1x: sysmmu@13a30000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x13a30000 0x1000>; + interrupts = <GIC_SPI 216 IRQ_TYPE_LEVEL_HIGH>; + clock-names = "pclk", "aclk"; + clocks = <&cmu_disp CLK_PCLK_SMMU_TV1X>, + <&cmu_disp CLK_ACLK_SMMU_TV1X>; + #iommu-cells = <0>; + }; + sysmmu_gscl0: sysmmu@13c80000 { compatible = "samsung,exynos-sysmmu"; reg = <0x13C80000 0x1000>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <CGME20170111083155eucas1p21c30b8fb055ebe9415683df5f7e119e1@eucas1p2.samsung.com>]
* [PATCH v4 2/3] arm64: dts: exynos: add HDMI node [not found] ` <CGME20170111083155eucas1p21c30b8fb055ebe9415683df5f7e119e1@eucas1p2.samsung.com> @ 2017-01-11 8:31 ` Andrzej Hajda 2017-01-11 16:21 ` Krzysztof Kozlowski 0 siblings, 1 reply; 13+ messages in thread From: Andrzej Hajda @ 2017-01-11 8:31 UTC (permalink / raw) To: linux-samsung-soc, Krzysztof Kozlowski Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree, Andi Shyti, Chanwoo Choi HDMI converts RGB/I80 signal from DECON_TV to HDMI/TMDS video stream. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 80dc0e8..f120d99 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -837,6 +837,35 @@ }; }; + hdmi: hdmi@13970000 { + compatible = "samsung,exynos5433-hdmi"; + reg = <0x13970000 0x70000>; + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu_disp CLK_PCLK_HDMI>, + <&cmu_disp CLK_PCLK_HDMIPHY>, + <&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO>, + <&cmu_disp CLK_PHYCLK_HDMI_PIXEL>, + <&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO_PHY>, + <&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_TMDS_CLKO_USER>, + <&cmu_disp CLK_PHYCLK_HDMIPHY_PIXEL_CLKO_PHY>, + <&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_PIXEL_CLKO_USER>, + <&xxti>, <&cmu_disp CLK_SCLK_HDMI_SPDIF>; + clock-names = "hdmi_pclk", "hdmi_i_pclk", + "i_tmds_clk", "i_pixel_clk", + "tmds_clko", "tmds_clko_user", + "pixel_clko", "pixel_clko_user", + "oscclk", "i_spdif_clk"; + phy = <&hdmiphy>; + ddc = <&hsi2c_11>; + samsung,syscon-phandle = <&pmu_system_controller>; + samsung,sysreg-phandle = <&syscon_disp>; + status = "disabled"; + }; + + hdmiphy: hdmiphy@13af0000 { + reg = <0x13af0000 0x80>; + }; + syscon_disp: syscon@13b80000 { compatible = "syscon"; reg = <0x13b80000 0x1010>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v4 2/3] arm64: dts: exynos: add HDMI node 2017-01-11 8:31 ` [PATCH v4 2/3] arm64: dts: exynos: add HDMI node Andrzej Hajda @ 2017-01-11 16:21 ` Krzysztof Kozlowski 0 siblings, 0 replies; 13+ messages in thread From: Krzysztof Kozlowski @ 2017-01-11 16:21 UTC (permalink / raw) To: Andrzej Hajda Cc: linux-samsung-soc, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree, Andi Shyti, Chanwoo Choi On Wed, Jan 11, 2017 at 09:31:39AM +0100, Andrzej Hajda wrote: > HDMI converts RGB/I80 signal from DECON_TV to HDMI/TMDS video stream. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > Thanks, applied. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <CGME20170111083155eucas1p28c9c49a619a31d33c2666f58bf22e7c0@eucas1p2.samsung.com>]
* [PATCH v4 3/3] arm64: dts: exynos: enable HDMI/TV path [not found] ` <CGME20170111083155eucas1p28c9c49a619a31d33c2666f58bf22e7c0@eucas1p2.samsung.com> @ 2017-01-11 8:31 ` Andrzej Hajda 2017-01-11 16:21 ` Krzysztof Kozlowski 0 siblings, 1 reply; 13+ messages in thread From: Andrzej Hajda @ 2017-01-11 8:31 UTC (permalink / raw) To: linux-samsung-soc, Krzysztof Kozlowski Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree, Andi Shyti, Chanwoo Choi TV path consist of following interconnected components: - DECON_TV - display controller, - HDMI - video signal converter RGB / HDMI, - MHL - video signal converter HDMI / MHL, - DDC - i2c slave device for EDID reading (on hsi2c_11 bus). Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 69 ++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index cc6701b..a5c8669 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -278,6 +278,22 @@ }; }; +&decon_tv { + status = "okay"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + tv_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_tv>; + }; + }; + }; +}; + &dsi { status = "okay"; vddcore-supply = <&ldo6_reg>; @@ -301,6 +317,33 @@ }; }; +&hdmi { + hpd-gpios = <&gpa3 0 GPIO_ACTIVE_HIGH>; + status = "okay"; + vdd-supply = <&ldo6_reg>; + vdd_osc-supply = <&ldo7_reg>; + vdd_pll-supply = <&ldo6_reg>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + hdmi_to_tv: endpoint { + remote-endpoint = <&tv_to_hdmi>; + }; + }; + + port@1 { + reg = <1>; + hdmi_to_mhl: endpoint { + remote-endpoint = <&mhl_to_hdmi>; + }; + }; + }; +}; + &hsi2c_0 { status = "okay"; clock-frequency = <2500000>; @@ -702,6 +745,28 @@ }; }; +&hsi2c_7 { + status = "okay"; + + sii8620@39 { + reg = <0x39>; + compatible = "sil,sii8620"; + cvcc10-supply = <&ldo36_reg>; + iovcc18-supply = <&ldo34_reg>; + interrupt-parent = <&gpf0>; + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; + reset-gpios = <&gpv7 0 GPIO_ACTIVE_LOW>; + clocks = <&pmu_system_controller 0>; + clock-names = "xtal"; + + port { + mhl_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_mhl>; + }; + }; + }; +}; + &hsi2c_8 { status = "okay"; @@ -745,6 +810,10 @@ }; }; +&hsi2c_11 { + status = "okay"; +}; + &i2s0 { status = "okay"; }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v4 3/3] arm64: dts: exynos: enable HDMI/TV path 2017-01-11 8:31 ` [PATCH v4 3/3] arm64: dts: exynos: enable HDMI/TV path Andrzej Hajda @ 2017-01-11 16:21 ` Krzysztof Kozlowski 0 siblings, 0 replies; 13+ messages in thread From: Krzysztof Kozlowski @ 2017-01-11 16:21 UTC (permalink / raw) To: Andrzej Hajda Cc: linux-samsung-soc, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree, Andi Shyti, Chanwoo Choi On Wed, Jan 11, 2017 at 09:31:40AM +0100, Andrzej Hajda wrote: > TV path consist of following interconnected components: > - DECON_TV - display controller, > - HDMI - video signal converter RGB / HDMI, > - MHL - video signal converter HDMI / MHL, > - DDC - i2c slave device for EDID reading (on hsi2c_11 bus). > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > --- > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 69 ++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > Thanks, applied. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v4 1/3] arm64: dts: exynos: add DECON_TV node 2017-01-11 8:31 ` [PATCH v4 1/3] arm64: dts: exynos: " Andrzej Hajda [not found] ` <CGME20170111083155eucas1p21c30b8fb055ebe9415683df5f7e119e1@eucas1p2.samsung.com> [not found] ` <CGME20170111083155eucas1p28c9c49a619a31d33c2666f58bf22e7c0@eucas1p2.samsung.com> @ 2017-01-11 16:21 ` Krzysztof Kozlowski 2 siblings, 0 replies; 13+ messages in thread From: Krzysztof Kozlowski @ 2017-01-11 16:21 UTC (permalink / raw) To: Andrzej Hajda Cc: linux-samsung-soc, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Marek Szyprowski, Inki Dae, Rob Herring, Mark Rutland, Javier Martinez Canillas, devicetree, Andi Shyti, Chanwoo Choi On Wed, Jan 11, 2017 at 09:31:38AM +0100, Andrzej Hajda wrote: > DECON_TV is 2nd display controller on Exynos5433, used in HDMI path > or 2nd DSI path. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > --- > v4: > - changed prefix > - rebased on '68cb4b3 Merge branch 'next/dt64' into for-next' > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 43 ++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) Thanks, applied. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-01-11 16:21 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CGME20170110082433eucas1p2f7cb7b0974987e2c8294509960468fd3@eucas1p2.samsung.com> 2017-01-10 8:24 ` [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node Andrzej Hajda [not found] ` <CGME20170110082433eucas1p10121a0c5defc7a3004235c78a50b1ff4@eucas1p1.samsung.com> 2017-01-10 8:24 ` [PATCH v3 2/3] arm64: dts: exynos5433: add HDMI node Andrzej Hajda [not found] ` <CGME20170110082434eucas1p2aa6d49ad0e77f9ed2a4d4d8c58f94307@eucas1p2.samsung.com> [not found] ` <1484036664-15951-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2017-01-10 8:24 ` [PATCH v3 3/3] arm64: dts: exynos5433-tm2: enable HDMI/TV path Andrzej Hajda 2017-01-10 17:11 ` [PATCH v3 1/3] arm64: dts: exynos5433: add DECON_TV node Krzysztof Kozlowski 2017-01-11 8:07 ` Andrzej Hajda 2017-01-10 19:09 ` Krzysztof Kozlowski 2017-01-11 8:14 ` Andrzej Hajda [not found] ` <CGME20170111083153eucas1p2b11e7b64f976a21f59c141bf7b06fd84@eucas1p2.samsung.com> 2017-01-11 8:31 ` [PATCH v4 1/3] arm64: dts: exynos: " Andrzej Hajda [not found] ` <CGME20170111083155eucas1p21c30b8fb055ebe9415683df5f7e119e1@eucas1p2.samsung.com> 2017-01-11 8:31 ` [PATCH v4 2/3] arm64: dts: exynos: add HDMI node Andrzej Hajda 2017-01-11 16:21 ` Krzysztof Kozlowski [not found] ` <CGME20170111083155eucas1p28c9c49a619a31d33c2666f58bf22e7c0@eucas1p2.samsung.com> 2017-01-11 8:31 ` [PATCH v4 3/3] arm64: dts: exynos: enable HDMI/TV path Andrzej Hajda 2017-01-11 16:21 ` Krzysztof Kozlowski 2017-01-11 16:21 ` [PATCH v4 1/3] arm64: dts: exynos: add DECON_TV node Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.