* [0/2] support mt8186 encoder
@ 2022-02-23 11:51 ` kyrie.wu
0 siblings, 0 replies; 14+ messages in thread
From: kyrie.wu @ 2022-02-23 11:51 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring, kyrie wu,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
Firstly, add "mediatek,mt8186-vcodec-enc" in yaml file.
Then add mt8186 compatible and private data for hardware encoder.
Patche 1 add mt8186 compatible attribute in yaml file.
Patche 2 add mt8186 compatible and private data.
kyrie wu (2):
dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186
mtk-vcodec: Support encoder for MT8186
.../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 1 +
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 1 +
2 files changed, 2 insertions(+)
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 14+ messages in thread
* [0/2] support mt8186 encoder
@ 2022-02-23 11:51 ` kyrie.wu
0 siblings, 0 replies; 14+ messages in thread
From: kyrie.wu @ 2022-02-23 11:51 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring, kyrie wu,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
Firstly, add "mediatek,mt8186-vcodec-enc" in yaml file.
Then add mt8186 compatible and private data for hardware encoder.
Patche 1 add mt8186 compatible attribute in yaml file.
Patche 2 add mt8186 compatible and private data.
kyrie wu (2):
dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186
mtk-vcodec: Support encoder for MT8186
.../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 1 +
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 1 +
2 files changed, 2 insertions(+)
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [1/2] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186
2022-02-23 11:51 ` kyrie.wu
@ 2022-02-23 11:51 ` kyrie.wu
-1 siblings, 0 replies; 14+ messages in thread
From: kyrie.wu @ 2022-02-23 11:51 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring, kyrie wu,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
Adds encoder dt-bindings for mt8186.
Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
---
.../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
index b72c1a50e89e..1fb9908b7454 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
@@ -22,6 +22,7 @@ properties:
- mediatek,mt8183-vcodec-enc
- mediatek,mt8192-vcodec-enc
- mediatek,mt8195-vcodec-enc
+ - mediatek,mt8186-vcodec-enc
reg:
maxItems: 1
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [1/2] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186
@ 2022-02-23 11:51 ` kyrie.wu
0 siblings, 0 replies; 14+ messages in thread
From: kyrie.wu @ 2022-02-23 11:51 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring, kyrie wu,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
Adds encoder dt-bindings for mt8186.
Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
---
.../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
index b72c1a50e89e..1fb9908b7454 100644
--- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
@@ -22,6 +22,7 @@ properties:
- mediatek,mt8183-vcodec-enc
- mediatek,mt8192-vcodec-enc
- mediatek,mt8195-vcodec-enc
+ - mediatek,mt8186-vcodec-enc
reg:
maxItems: 1
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [2/2] mtk-vcodec: Support encoder for MT8186
2022-02-23 11:51 ` kyrie.wu
@ 2022-02-23 11:51 ` kyrie.wu
-1 siblings, 0 replies; 14+ messages in thread
From: kyrie.wu @ 2022-02-23 11:51 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring, kyrie wu,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
Adds MT8186's compatible "mediatek,mt8186-vcodec-enc".
Adds MT8186's device private data.
Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
index 65207f5b6c1c..e1b91ae9a164 100644
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
@@ -437,6 +437,7 @@ static const struct of_device_id mtk_vcodec_enc_match[] = {
{.compatible = "mediatek,mt8183-vcodec-enc", .data = &mt8183_pdata},
{.compatible = "mediatek,mt8192-vcodec-enc", .data = &mt8192_pdata},
{.compatible = "mediatek,mt8195-vcodec-enc", .data = &mt8195_pdata},
+ {.compatible = "mediatek,mt8186-vcodec-enc", .data = &mt8183_pdata},
{},
};
MODULE_DEVICE_TABLE(of, mtk_vcodec_enc_match);
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [2/2] mtk-vcodec: Support encoder for MT8186
@ 2022-02-23 11:51 ` kyrie.wu
0 siblings, 0 replies; 14+ messages in thread
From: kyrie.wu @ 2022-02-23 11:51 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring, kyrie wu,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
Adds MT8186's compatible "mediatek,mt8186-vcodec-enc".
Adds MT8186's device private data.
Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
index 65207f5b6c1c..e1b91ae9a164 100644
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
@@ -437,6 +437,7 @@ static const struct of_device_id mtk_vcodec_enc_match[] = {
{.compatible = "mediatek,mt8183-vcodec-enc", .data = &mt8183_pdata},
{.compatible = "mediatek,mt8192-vcodec-enc", .data = &mt8192_pdata},
{.compatible = "mediatek,mt8195-vcodec-enc", .data = &mt8195_pdata},
+ {.compatible = "mediatek,mt8186-vcodec-enc", .data = &mt8183_pdata},
{},
};
MODULE_DEVICE_TABLE(of, mtk_vcodec_enc_match);
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [1/2] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186
2022-02-23 11:51 ` kyrie.wu
@ 2022-02-23 12:37 ` Rex-BC Chen
-1 siblings, 0 replies; 14+ messages in thread
From: Rex-BC Chen @ 2022-02-23 12:37 UTC (permalink / raw)
To: kyrie.wu, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
Hello Kyrie,
Could you move the 8186 below 8183?
I think it's better to match alphabetical order.
BRs,
Rex
On Wed, 2022-02-23 at 19:51 +0800, kyrie.wu wrote:
> From: kyrie wu <kyrie.wu@mediatek.com>
>
> Adds encoder dt-bindings for mt8186.
>
> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> ---
> .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> encoder.yaml
> b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> encoder.yaml
> index b72c1a50e89e..1fb9908b7454 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> encoder.yaml
> @@ -22,6 +22,7 @@ properties:
> - mediatek,mt8183-vcodec-enc
> - mediatek,mt8192-vcodec-enc
> - mediatek,mt8195-vcodec-enc
> + - mediatek,mt8186-vcodec-enc
>
> reg:
> maxItems: 1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [1/2] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186
@ 2022-02-23 12:37 ` Rex-BC Chen
0 siblings, 0 replies; 14+ messages in thread
From: Rex-BC Chen @ 2022-02-23 12:37 UTC (permalink / raw)
To: kyrie.wu, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
Hello Kyrie,
Could you move the 8186 below 8183?
I think it's better to match alphabetical order.
BRs,
Rex
On Wed, 2022-02-23 at 19:51 +0800, kyrie.wu wrote:
> From: kyrie wu <kyrie.wu@mediatek.com>
>
> Adds encoder dt-bindings for mt8186.
>
> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> ---
> .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> encoder.yaml
> b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> encoder.yaml
> index b72c1a50e89e..1fb9908b7454 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> encoder.yaml
> @@ -22,6 +22,7 @@ properties:
> - mediatek,mt8183-vcodec-enc
> - mediatek,mt8192-vcodec-enc
> - mediatek,mt8195-vcodec-enc
> + - mediatek,mt8186-vcodec-enc
>
> reg:
> maxItems: 1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2/2] mtk-vcodec: Support encoder for MT8186
2022-02-23 11:51 ` kyrie.wu
@ 2022-02-23 12:37 ` Rex-BC Chen
-1 siblings, 0 replies; 14+ messages in thread
From: Rex-BC Chen @ 2022-02-23 12:37 UTC (permalink / raw)
To: kyrie.wu, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
Hello Kyrie,
Why not just use compatible of mt8183?
The data of 8186 is the same with 8183.
In this case, I think we just need to add dt-binding of 8186 and no
need for this patch.
BRs,
Rex
On Wed, 2022-02-23 at 19:51 +0800, kyrie.wu wrote:
> From: kyrie wu <kyrie.wu@mediatek.com>
>
> Adds MT8186's compatible "mediatek,mt8186-vcodec-enc".
> Adds MT8186's device private data.
>
> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> index 65207f5b6c1c..e1b91ae9a164 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> @@ -437,6 +437,7 @@ static const struct of_device_id
> mtk_vcodec_enc_match[] = {
> {.compatible = "mediatek,mt8183-vcodec-enc", .data =
> &mt8183_pdata},
> {.compatible = "mediatek,mt8192-vcodec-enc", .data =
> &mt8192_pdata},
> {.compatible = "mediatek,mt8195-vcodec-enc", .data =
> &mt8195_pdata},
> + {.compatible = "mediatek,mt8186-vcodec-enc", .data =
> &mt8183_pdata},
> {},
> };
> MODULE_DEVICE_TABLE(of, mtk_vcodec_enc_match);
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2/2] mtk-vcodec: Support encoder for MT8186
@ 2022-02-23 12:37 ` Rex-BC Chen
0 siblings, 0 replies; 14+ messages in thread
From: Rex-BC Chen @ 2022-02-23 12:37 UTC (permalink / raw)
To: kyrie.wu, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
Hello Kyrie,
Why not just use compatible of mt8183?
The data of 8186 is the same with 8183.
In this case, I think we just need to add dt-binding of 8186 and no
need for this patch.
BRs,
Rex
On Wed, 2022-02-23 at 19:51 +0800, kyrie.wu wrote:
> From: kyrie wu <kyrie.wu@mediatek.com>
>
> Adds MT8186's compatible "mediatek,mt8186-vcodec-enc".
> Adds MT8186's device private data.
>
> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> index 65207f5b6c1c..e1b91ae9a164 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> @@ -437,6 +437,7 @@ static const struct of_device_id
> mtk_vcodec_enc_match[] = {
> {.compatible = "mediatek,mt8183-vcodec-enc", .data =
> &mt8183_pdata},
> {.compatible = "mediatek,mt8192-vcodec-enc", .data =
> &mt8192_pdata},
> {.compatible = "mediatek,mt8195-vcodec-enc", .data =
> &mt8195_pdata},
> + {.compatible = "mediatek,mt8186-vcodec-enc", .data =
> &mt8183_pdata},
> {},
> };
> MODULE_DEVICE_TABLE(of, mtk_vcodec_enc_match);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [1/2] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186
2022-02-23 12:37 ` Rex-BC Chen
@ 2022-02-24 1:08 ` kyrie.wu
-1 siblings, 0 replies; 14+ messages in thread
From: kyrie.wu @ 2022-02-24 1:08 UTC (permalink / raw)
To: Rex-BC Chen, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
On Wed, 2022-02-23 at 20:37 +0800, Rex-BC Chen wrote:
> Hello Kyrie,
>
> Could you move the 8186 below 8183?
> I think it's better to match alphabetical order.
>
> BRs,
> Rex
Dear Rex-BC,
Thanks for your suggestion. I will fix this issue.
>
> On Wed, 2022-02-23 at 19:51 +0800, kyrie.wu wrote:
> > From: kyrie wu <kyrie.wu@mediatek.com>
> >
> > Adds encoder dt-bindings for mt8186.
> >
> > Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> > ---
> > .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > index b72c1a50e89e..1fb9908b7454 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt8183-vcodec-enc
> > - mediatek,mt8192-vcodec-enc
> > - mediatek,mt8195-vcodec-enc
> > + - mediatek,mt8186-vcodec-enc
> >
> > reg:
> > maxItems: 1
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [1/2] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186
@ 2022-02-24 1:08 ` kyrie.wu
0 siblings, 0 replies; 14+ messages in thread
From: kyrie.wu @ 2022-02-24 1:08 UTC (permalink / raw)
To: Rex-BC Chen, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
On Wed, 2022-02-23 at 20:37 +0800, Rex-BC Chen wrote:
> Hello Kyrie,
>
> Could you move the 8186 below 8183?
> I think it's better to match alphabetical order.
>
> BRs,
> Rex
Dear Rex-BC,
Thanks for your suggestion. I will fix this issue.
>
> On Wed, 2022-02-23 at 19:51 +0800, kyrie.wu wrote:
> > From: kyrie wu <kyrie.wu@mediatek.com>
> >
> > Adds encoder dt-bindings for mt8186.
> >
> > Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> > ---
> > .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > index b72c1a50e89e..1fb9908b7454 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt8183-vcodec-enc
> > - mediatek,mt8192-vcodec-enc
> > - mediatek,mt8195-vcodec-enc
> > + - mediatek,mt8186-vcodec-enc
> >
> > reg:
> > maxItems: 1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2/2] mtk-vcodec: Support encoder for MT8186
2022-02-23 12:37 ` Rex-BC Chen
@ 2022-02-24 1:12 ` kyrie.wu
-1 siblings, 0 replies; 14+ messages in thread
From: kyrie.wu @ 2022-02-24 1:12 UTC (permalink / raw)
To: Rex-BC Chen, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
On Wed, 2022-02-23 at 20:37 +0800, Rex-BC Chen wrote:
> Hello Kyrie,
>
> Why not just use compatible of mt8183?
> The data of 8186 is the same with 8183.
>
> In this case, I think we just need to add dt-binding of 8186 and no
> need for this patch.
>
> BRs,
> Rex
Hi Rex-BC,
MT8186 has same private data as MT8183, but has different compatible,
which is used to match device tree. So the new line is added for 8186.
>
> On Wed, 2022-02-23 at 19:51 +0800, kyrie.wu wrote:
> > From: kyrie wu <kyrie.wu@mediatek.com>
> >
> > Adds MT8186's compatible "mediatek,mt8186-vcodec-enc".
> > Adds MT8186's device private data.
> >
> > Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> > ---
> > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> > b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> > index 65207f5b6c1c..e1b91ae9a164 100644
> > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> > @@ -437,6 +437,7 @@ static const struct of_device_id
> > mtk_vcodec_enc_match[] = {
> > {.compatible = "mediatek,mt8183-vcodec-enc", .data =
> > &mt8183_pdata},
> > {.compatible = "mediatek,mt8192-vcodec-enc", .data =
> > &mt8192_pdata},
> > {.compatible = "mediatek,mt8195-vcodec-enc", .data =
> > &mt8195_pdata},
> > + {.compatible = "mediatek,mt8186-vcodec-enc", .data =
> > &mt8183_pdata},
> > {},
> > };
> > MODULE_DEVICE_TABLE(of, mtk_vcodec_enc_match);
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [2/2] mtk-vcodec: Support encoder for MT8186
@ 2022-02-24 1:12 ` kyrie.wu
0 siblings, 0 replies; 14+ messages in thread
From: kyrie.wu @ 2022-02-24 1:12 UTC (permalink / raw)
To: Rex-BC Chen, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
On Wed, 2022-02-23 at 20:37 +0800, Rex-BC Chen wrote:
> Hello Kyrie,
>
> Why not just use compatible of mt8183?
> The data of 8186 is the same with 8183.
>
> In this case, I think we just need to add dt-binding of 8186 and no
> need for this patch.
>
> BRs,
> Rex
Hi Rex-BC,
MT8186 has same private data as MT8183, but has different compatible,
which is used to match device tree. So the new line is added for 8186.
>
> On Wed, 2022-02-23 at 19:51 +0800, kyrie.wu wrote:
> > From: kyrie wu <kyrie.wu@mediatek.com>
> >
> > Adds MT8186's compatible "mediatek,mt8186-vcodec-enc".
> > Adds MT8186's device private data.
> >
> > Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> > ---
> > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> > b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> > index 65207f5b6c1c..e1b91ae9a164 100644
> > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> > @@ -437,6 +437,7 @@ static const struct of_device_id
> > mtk_vcodec_enc_match[] = {
> > {.compatible = "mediatek,mt8183-vcodec-enc", .data =
> > &mt8183_pdata},
> > {.compatible = "mediatek,mt8192-vcodec-enc", .data =
> > &mt8192_pdata},
> > {.compatible = "mediatek,mt8195-vcodec-enc", .data =
> > &mt8195_pdata},
> > + {.compatible = "mediatek,mt8186-vcodec-enc", .data =
> > &mt8183_pdata},
> > {},
> > };
> > MODULE_DEVICE_TABLE(of, mtk_vcodec_enc_match);
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-02-24 1:13 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 11:51 [0/2] support mt8186 encoder kyrie.wu
2022-02-23 11:51 ` kyrie.wu
2022-02-23 11:51 ` [1/2] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186 kyrie.wu
2022-02-23 11:51 ` kyrie.wu
2022-02-23 12:37 ` Rex-BC Chen
2022-02-23 12:37 ` Rex-BC Chen
2022-02-24 1:08 ` kyrie.wu
2022-02-24 1:08 ` kyrie.wu
2022-02-23 11:51 ` [2/2] mtk-vcodec: Support encoder for MT8186 kyrie.wu
2022-02-23 11:51 ` kyrie.wu
2022-02-23 12:37 ` Rex-BC Chen
2022-02-23 12:37 ` Rex-BC Chen
2022-02-24 1:12 ` kyrie.wu
2022-02-24 1:12 ` kyrie.wu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.