From: David Lechner <david@lechnology.com>
To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts
Date: Mon, 24 Oct 2016 16:20:59 -0500 [thread overview]
Message-ID: <84648cb0-f1fa-d88b-bac2-79208af01ca6@lechnology.com> (raw)
In-Reply-To: <b6cd3c47-0df8-266a-2b8d-13c82062b647@lechnology.com>
On 10/24/2016 02:50 PM, David Lechner wrote:
> On 10/24/2016 10:50 AM, David Lechner wrote:
>> On 10/24/2016 06:58 AM, Sekhar Nori wrote:
>>> On Saturday 22 October 2016 12:06 AM, David Lechner wrote:
>>>
>>>> +&ehrpwm1 {
>>>> + status = "disabled";
>>>
>>> Hmm, disabled? Can you add this node when you actually use it?
>>
>> Not sure why I have this disabled. Like the gpios, the pwms can be used
>> via sysfs, so I would like to leave them.
>>
>
> Now I remember why these are disabled. The clock matching is broken.
> Only the first ehrpwm and the first ecap get clocks. The others fail.
>
> I can change these to "okay". It will just result in a kernel error
> message until the clocks are fixed.
>
correction: it is not the clocks that are broken. it is the device names.
In arch/arm/mach-davinci/da8xx-dt.c, we have...
OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f00000, "ehrpwm", NULL),
OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f02000, "ehrpwm", NULL),
OF_DEV_AUXDATA("ti,da850-ecap", 0x01f06000, "ecap", NULL),
OF_DEV_AUXDATA("ti,da850-ecap", 0x01f07000, "ecap", NULL),
OF_DEV_AUXDATA("ti,da850-ecap", 0x01f08000, "ecap", NULL),
Which causes each device to have the same device node name. This causes
sysfs errors because it is trying to register a second device at the
same sysfs path.
If you change the names here, then the device do not work because the
clock lookup fails.
WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
To: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
Kevin Hilman <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts
Date: Mon, 24 Oct 2016 16:20:59 -0500 [thread overview]
Message-ID: <84648cb0-f1fa-d88b-bac2-79208af01ca6@lechnology.com> (raw)
In-Reply-To: <b6cd3c47-0df8-266a-2b8d-13c82062b647-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
On 10/24/2016 02:50 PM, David Lechner wrote:
> On 10/24/2016 10:50 AM, David Lechner wrote:
>> On 10/24/2016 06:58 AM, Sekhar Nori wrote:
>>> On Saturday 22 October 2016 12:06 AM, David Lechner wrote:
>>>
>>>> +&ehrpwm1 {
>>>> + status = "disabled";
>>>
>>> Hmm, disabled? Can you add this node when you actually use it?
>>
>> Not sure why I have this disabled. Like the gpios, the pwms can be used
>> via sysfs, so I would like to leave them.
>>
>
> Now I remember why these are disabled. The clock matching is broken.
> Only the first ehrpwm and the first ecap get clocks. The others fail.
>
> I can change these to "okay". It will just result in a kernel error
> message until the clocks are fixed.
>
correction: it is not the clocks that are broken. it is the device names.
In arch/arm/mach-davinci/da8xx-dt.c, we have...
OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f00000, "ehrpwm", NULL),
OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f02000, "ehrpwm", NULL),
OF_DEV_AUXDATA("ti,da850-ecap", 0x01f06000, "ecap", NULL),
OF_DEV_AUXDATA("ti,da850-ecap", 0x01f07000, "ecap", NULL),
OF_DEV_AUXDATA("ti,da850-ecap", 0x01f08000, "ecap", NULL),
Which causes each device to have the same device node name. This causes
sysfs errors because it is trying to register a second device at the
same sysfs path.
If you change the names here, then the device do not work because the
clock lookup fails.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: david@lechnology.com (David Lechner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts
Date: Mon, 24 Oct 2016 16:20:59 -0500 [thread overview]
Message-ID: <84648cb0-f1fa-d88b-bac2-79208af01ca6@lechnology.com> (raw)
In-Reply-To: <b6cd3c47-0df8-266a-2b8d-13c82062b647@lechnology.com>
On 10/24/2016 02:50 PM, David Lechner wrote:
> On 10/24/2016 10:50 AM, David Lechner wrote:
>> On 10/24/2016 06:58 AM, Sekhar Nori wrote:
>>> On Saturday 22 October 2016 12:06 AM, David Lechner wrote:
>>>
>>>> +&ehrpwm1 {
>>>> + status = "disabled";
>>>
>>> Hmm, disabled? Can you add this node when you actually use it?
>>
>> Not sure why I have this disabled. Like the gpios, the pwms can be used
>> via sysfs, so I would like to leave them.
>>
>
> Now I remember why these are disabled. The clock matching is broken.
> Only the first ehrpwm and the first ecap get clocks. The others fail.
>
> I can change these to "okay". It will just result in a kernel error
> message until the clocks are fixed.
>
correction: it is not the clocks that are broken. it is the device names.
In arch/arm/mach-davinci/da8xx-dt.c, we have...
OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f00000, "ehrpwm", NULL),
OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f02000, "ehrpwm", NULL),
OF_DEV_AUXDATA("ti,da850-ecap", 0x01f06000, "ecap", NULL),
OF_DEV_AUXDATA("ti,da850-ecap", 0x01f07000, "ecap", NULL),
OF_DEV_AUXDATA("ti,da850-ecap", 0x01f08000, "ecap", NULL),
Which causes each device to have the same device node name. This causes
sysfs errors because it is trying to register a second device at the
same sysfs path.
If you change the names here, then the device do not work because the
clock lookup fails.
next prev parent reply other threads:[~2016-10-24 21:21 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 18:36 [PATCH 0/5] Support for LEGO MINDSTORTMS EV3 David Lechner
2016-10-21 18:36 ` David Lechner
2016-10-21 18:36 ` David Lechner
2016-10-21 18:36 ` [PATCH 1/5] ARM: davinci: Compile MMC in kernel David Lechner
2016-10-21 18:36 ` David Lechner
2016-10-26 11:33 ` Sekhar Nori
2016-10-26 11:33 ` Sekhar Nori
2016-10-26 11:33 ` Sekhar Nori
2016-10-21 18:36 ` [PATCH 2/5] ARM: davinci: Don't append git rev to local version David Lechner
2016-10-21 18:36 ` David Lechner
2016-10-21 18:36 ` David Lechner
2016-10-24 11:35 ` Sekhar Nori
2016-10-24 11:35 ` Sekhar Nori
2016-10-24 11:35 ` Sekhar Nori
2016-10-24 15:15 ` David Lechner
2016-10-24 15:15 ` David Lechner
2016-10-24 15:15 ` David Lechner
2016-10-26 10:54 ` Sekhar Nori
2016-10-26 10:54 ` Sekhar Nori
2016-10-26 10:54 ` Sekhar Nori
2016-10-26 15:44 ` David Lechner
2016-10-26 15:44 ` David Lechner
2016-10-26 15:44 ` David Lechner
2016-10-21 18:36 ` [PATCH 3/5] ARM: davinci: enable gpio poweroff in default config David Lechner
2016-10-21 18:36 ` David Lechner
2016-10-21 18:36 ` David Lechner
2016-10-26 11:09 ` Sekhar Nori
2016-10-26 11:09 ` Sekhar Nori
2016-10-26 11:09 ` Sekhar Nori
2016-10-21 18:36 ` [PATCH 4/5] ARM: davinci: enable LEDs default-on trigger " David Lechner
2016-10-21 18:36 ` David Lechner
2016-10-27 11:29 ` Sekhar Nori
2016-10-27 11:29 ` Sekhar Nori
2016-10-27 11:29 ` Sekhar Nori
2016-10-27 15:49 ` David Lechner
2016-10-27 15:49 ` David Lechner
2016-10-27 15:49 ` David Lechner
2016-10-28 9:03 ` Sekhar Nori
2016-10-28 9:03 ` Sekhar Nori
2016-10-28 9:03 ` Sekhar Nori
2016-10-21 18:36 ` [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts David Lechner
2016-10-21 18:36 ` David Lechner
2016-10-21 18:36 ` David Lechner
2016-10-21 19:13 ` Kevin Hilman
2016-10-21 19:13 ` Kevin Hilman
2016-10-24 11:58 ` Sekhar Nori
2016-10-24 11:58 ` Sekhar Nori
2016-10-24 11:58 ` Sekhar Nori
2016-10-24 15:50 ` David Lechner
2016-10-24 15:50 ` David Lechner
2016-10-24 15:50 ` David Lechner
2016-10-24 19:50 ` David Lechner
2016-10-24 19:50 ` David Lechner
2016-10-24 21:20 ` David Lechner [this message]
2016-10-24 21:20 ` David Lechner
2016-10-24 21:20 ` David Lechner
2016-10-25 10:58 ` Sekhar Nori
2016-10-25 10:58 ` Sekhar Nori
2016-10-25 10:58 ` Sekhar Nori
2016-10-25 15:44 ` David Lechner
2016-10-25 15:44 ` David Lechner
2016-10-25 15:44 ` David Lechner
2016-10-25 2:56 ` David Lechner
2016-10-25 2:56 ` David Lechner
2016-10-25 2:56 ` David Lechner
2016-10-27 10:05 ` Sekhar Nori
2016-10-27 10:05 ` Sekhar Nori
2016-10-27 1:30 ` David Lechner
2016-10-27 1:30 ` David Lechner
2016-10-27 1:30 ` David Lechner
2016-10-27 11:18 ` Sekhar Nori
2016-10-27 11:18 ` Sekhar Nori
2016-10-21 18:45 ` [PATCH 0/5] Support for LEGO MINDSTORTMS EV3 Lennart Sorensen
2016-10-21 18:45 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84648cb0-f1fa-d88b-bac2-79208af01ca6@lechnology.com \
--to=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.