All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] drm/amd/display: fix coding style
@ 2021-06-01 10:13 Nirmoy Das
  2021-06-01 10:15 ` Christian König
  0 siblings, 1 reply; 2+ messages in thread
From: Nirmoy Das @ 2021-06-01 10:13 UTC (permalink / raw)
  To: alexander.deucher; +Cc: Nirmoy Das, Christian.Koenig, amd-gfx

Fixes: 60d198ca66ecf778 ("drm/amd/display: WARN_ON cleanups")

Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
Hi Alex,

Can you please squash this with the "Fixes" patch?

Thanks,
Nirmoy

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 09bbec4dab7c..56abc27b78f7 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -315,9 +315,8 @@ get_crtc_by_otg_inst(struct amdgpu_device *adev,
 	struct drm_crtc *crtc;
 	struct amdgpu_crtc *amdgpu_crtc;

-	if (WARN_ON(otg_inst == -1)) {
+	if (WARN_ON(otg_inst == -1))
 		return adev->mode_info.crtcs[0];
-	}

 	list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
 		amdgpu_crtc = to_amdgpu_crtc(crtc);
--
2.31.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] drm/amd/display: fix coding style
  2021-06-01 10:13 [PATCH 1/1] drm/amd/display: fix coding style Nirmoy Das
@ 2021-06-01 10:15 ` Christian König
  0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2021-06-01 10:15 UTC (permalink / raw)
  To: Nirmoy Das, alexander.deucher; +Cc: amd-gfx

Am 01.06.21 um 12:13 schrieb Nirmoy Das:
> Fixes: 60d198ca66ecf778 ("drm/amd/display: WARN_ON cleanups")
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
> Hi Alex,
>
> Can you please squash this with the "Fixes" patch?

We could keep that separated as well, no big deal.

Christian.

>
> Thanks,
> Nirmoy
>
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 09bbec4dab7c..56abc27b78f7 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -315,9 +315,8 @@ get_crtc_by_otg_inst(struct amdgpu_device *adev,
>   	struct drm_crtc *crtc;
>   	struct amdgpu_crtc *amdgpu_crtc;
>
> -	if (WARN_ON(otg_inst == -1)) {
> +	if (WARN_ON(otg_inst == -1))
>   		return adev->mode_info.crtcs[0];
> -	}
>
>   	list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
>   		amdgpu_crtc = to_amdgpu_crtc(crtc);
> --
> 2.31.1
>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-01 10:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 10:13 [PATCH 1/1] drm/amd/display: fix coding style Nirmoy Das
2021-06-01 10:15 ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.