All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 08/16] Add missing LEDs to Firestone DT
@ 2016-09-15 20:36 Timothy Pearson
  2016-09-16  1:41 ` Joel Stanley
  0 siblings, 1 reply; 2+ messages in thread
From: Timothy Pearson @ 2016-09-15 20:36 UTC (permalink / raw)
  To: openbmc


---
 arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
index ae1a633..4f04e76 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
@@ -2,6 +2,8 @@
 
 #include "aspeed-g4.dtsi"
 
+#include <dt-bindings/gpio/aspeed-gpio.h>
+
 / {
 	model = "Firestone BMC";
 	compatible = "ibm,firestone-bmc", "aspeed,ast2400";
@@ -19,6 +21,22 @@
 		reg = < 0x40000000 0x10000000 >;
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		heartbeat {
+			gpios = <&gpio ASPEED_GPIO(R, 4) GPIO_ACTIVE_LOW>;
+		};
+
+		power {
+			gpios = <&gpio ASPEED_GPIO(R, 5) GPIO_ACTIVE_LOW>;
+		};
+
+		identify {
+			gpios = <&gpio ASPEED_GPIO(A, 2) GPIO_ACTIVE_LOW>;
+		};
+	};
+
 	ahb {
 		fmc@1e620000 {
 			reg = < 0x1e620000 0x94
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 08/16] Add missing LEDs to Firestone DT
  2016-09-15 20:36 [PATCH 08/16] Add missing LEDs to Firestone DT Timothy Pearson
@ 2016-09-16  1:41 ` Joel Stanley
  0 siblings, 0 replies; 2+ messages in thread
From: Joel Stanley @ 2016-09-16  1:41 UTC (permalink / raw)
  To: Timothy Pearson; +Cc: OpenBMC Maillist

On Fri, Sep 16, 2016 at 6:06 AM, Timothy Pearson
<tpearson@raptorengineering.com> wrote:
>
Missing commit message, s-o-b.

> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index ae1a633..4f04e76 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -2,6 +2,8 @@
>
>  #include "aspeed-g4.dtsi"
>
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +
>  / {
>         model = "Firestone BMC";
>         compatible = "ibm,firestone-bmc", "aspeed,ast2400";
> @@ -19,6 +21,22 @@
>                 reg = < 0x40000000 0x10000000 >;
>         };
>
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               heartbeat {
> +                       gpios = <&gpio ASPEED_GPIO(R, 4) GPIO_ACTIVE_LOW>;
> +               };
> +
> +               power {
> +                       gpios = <&gpio ASPEED_GPIO(R, 5) GPIO_ACTIVE_LOW>;
> +               };

On barreleye in the dev-4.4 tree we have another property to ensure
these are kept in the same state on reboot. Do you want the same?

> +
> +               identify {
> +                       gpios = <&gpio ASPEED_GPIO(A, 2) GPIO_ACTIVE_LOW>;
> +               };
> +       };
> +
>         ahb {
>                 fmc@1e620000 {
>                         reg = < 0x1e620000 0x94
> --
> 1.7.9.5
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-16  1:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15 20:36 [PATCH 08/16] Add missing LEDs to Firestone DT Timothy Pearson
2016-09-16  1:41 ` Joel Stanley

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.