From: Arnd Bergmann <arnd@arndb.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Jens Axboe <axboe@fb.com>, Mike Christie <mchristi@redhat.com>,
Andy Grover <agrover@redhat.com>, Hannes Reinecke <hare@suse.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] target/iblock: use ilog2 to compute block size
Date: Wed, 22 Jun 2016 17:53:01 +0200 [thread overview]
Message-ID: <8480462.cSbQVM4ZJM@wuerfel> (raw)
In-Reply-To: <20160622133809.GA29657@infradead.org>
On Wednesday, June 22, 2016 6:38:09 AM CEST Christoph Hellwig wrote:
> This doesn't compute the block size, it computes the number of block
> in a block device.
Right, that's at least what I planned to put in the $subject ;-)
> I think it would be useful to add a generic helper
> (e.g. in blkdev.h) as this calculation seems to be open coded in various
> places.
Good idea, I'll try to come up with a patch for that.
Arnd
prev parent reply other threads:[~2016-06-22 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 12:55 [PATCH] target/iblock: use ilog2 to compute block size Arnd Bergmann
2016-06-22 13:38 ` Christoph Hellwig
2016-06-22 15:53 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8480462.cSbQVM4ZJM@wuerfel \
--to=arnd@arndb.de \
--cc=agrover@redhat.com \
--cc=axboe@fb.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.