[U-Boot] [PATCH v3] net: Fix cache misalignment message after network load operations

[U-Boot] [PATCH v3] net: Fix cache misalignment message after network load operations

[Peter.Chubb at data61.csiro.au]

After any operation that downloads a file (e.g., pxe get, or dhcp), the
buffer containing the downloaded data is flushed.  This is unnecessary
and annoying.  Unnecessary, because
the network driver should already have fliushed the cache for the DMAed area,
and annoying because it generates a cache misalignment message.

Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>
---
 cmd/net.c |    3 ---
 1 file changed, 3 deletions(-)

Index: u-boot/cmd/net.c
===================================================================
--- u-boot.orig/cmd/net.c	2016-09-07 13:50:46.616156851 +1000
+++ u-boot/cmd/net.c	2016-09-07 19:18:18.962450874 +1000
@@ -243,9 +243,6 @@ static int netboot_common(enum proto_t p
 		return CMD_RET_SUCCESS;
 	}
 
-	/* flush cache */
-	flush_cache(load_addr, size);
-
 	bootstage_mark(BOOTSTAGE_ID_NET_LOADED);
 
 	rcode = bootm_maybe_autostart(cmdtp, argv[0]);

[U-Boot] [PATCH v3] net: Fix cache misalignment message after network load operations

[Heiko Schocher]

Hello Peter,

Am 14.09.2016 um 05:49 schrieb Peter.Chubb at data61.csiro.au:
> After any operation that downloads a file (e.g., pxe get, or dhcp), the
> buffer containing the downloaded data is flushed.  This is unnecessary
> and annoying.  Unnecessary, because
> the network driver should already have fliushed the cache for the DMAed area,
> and annoying because it generates a cache misalignment message.
>
> Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>
> ---
>   cmd/net.c |    3 ---
>   1 file changed, 3 deletions(-)

I posted a fix for this here:
http://patchwork.ozlabs.org/patch/663489/

but I did not remove the flush operation ... can we really remove it?

If so, you can add my
Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> Index: u-boot/cmd/net.c
> ===================================================================
> --- u-boot.orig/cmd/net.c	2016-09-07 13:50:46.616156851 +1000
> +++ u-boot/cmd/net.c	2016-09-07 19:18:18.962450874 +1000
> @@ -243,9 +243,6 @@ static int netboot_common(enum proto_t p
>   		return CMD_RET_SUCCESS;
>   	}
>
> -	/* flush cache */
> -	flush_cache(load_addr, size);
> -
>   	bootstage_mark(BOOTSTAGE_ID_NET_LOADED);
>
>   	rcode = bootm_maybe_autostart(cmdtp, argv[0]);
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] [PATCH v3] net: Fix cache misalignment message after network load operations

[Peter.Chubb at data61.csiro.au]

>>>>> "Heiko" == Heiko Schocher <hs@denx.de> writes:

Heiko> Hello Peter, Am 14.09.2016 um 05:49 schrieb
Heiko> Peter.Chubb at data61.csiro.au:
>> After any operation that downloads a file (e.g., pxe get, or dhcp),
>> the buffer containing the downloaded data is flushed.  This is
>> unnecessary and annoying.  Unnecessary, because the network driver
>> should already have fliushed the cache for the DMAed area, and
>> annoying because it generates a cache misalignment message.
>> 
>> Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>
>> ---
>> cmd/net.c | 3 --- 1 file changed, 3 deletions(-)

Heiko> I posted a fix for this here:
Heiko> http://patchwork.ozlabs.org/patch/663489/

Heiko> but I did not remove the flush operation ... can we really
Heiko> remove it?
 I believe so -- removing it was suggested by Joe Hershberger.

Heiko> If so, you can add my Acked-by: Heiko Schocher <hs@denx.de>

OK. thanks.
-- 
Dr Peter Chubb         Tel: +61 2 9490 5852      http://ts.data61.csiro.au/
Trustworthy Systems Group                           Data61 (formerly NICTA)

[U-Boot] [PATCH v3] net: Fix cache misalignment message after network load operations

[Joe Hershberger]

On Tue, Sep 13, 2016 at 10:49 PM,  <Peter.Chubb@data61.csiro.au> wrote:
> After any operation that downloads a file (e.g., pxe get, or dhcp), the
> buffer containing the downloaded data is flushed.  This is unnecessary
> and annoying.  Unnecessary, because
> the network driver should already have fliushed the cache for the DMAed area,
> and annoying because it generates a cache misalignment message.
>
> Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

[U-Boot] [U-Boot, v3] net: Fix cache misalignment message after network load operations

[Tom Rini]

On Wed, Sep 14, 2016 at 03:49:22AM +0000, Peter Chubb wrote:

> After any operation that downloads a file (e.g., pxe get, or dhcp), the
> buffer containing the downloaded data is flushed.  This is unnecessary
> and annoying.  Unnecessary, because
> the network driver should already have fliushed the cache for the DMAed area,
> and annoying because it generates a cache misalignment message.
> 
> Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>
> Acked-by: Heiko Schocher <hs@denx.de>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

Joe, do you want to pick this up or should I?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161005/7af841f9/attachment.sig>

[U-Boot] [U-Boot, v3] net: Fix cache misalignment message after network load operations

[Joe Hershberger]

On Thu, Oct 6, 2016 at 2:14 AM, Tom Rini <trini@konsulko.com> wrote:
> On Wed, Sep 14, 2016 at 03:49:22AM +0000, Peter Chubb wrote:
>
>> After any operation that downloads a file (e.g., pxe get, or dhcp), the
>> buffer containing the downloaded data is flushed.  This is unnecessary
>> and annoying.  Unnecessary, because
>> the network driver should already have fliushed the cache for the DMAed area,
>> and annoying because it generates a cache misalignment message.
>>
>> Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au>
>> Acked-by: Heiko Schocher <hs@denx.de>
>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> Joe, do you want to pick this up or should I?  Thanks!

I'll get it.

Thanks,
-Joe

[U-Boot] net: Fix cache misalignment message after network load operations

[Joe Hershberger]

Hi Peter,

https://patchwork.ozlabs.org/patch/669691/ was applied to u-boot-net.git.

Thanks!
-Joe