All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Saenz Julienne <nsaenzju@redhat.com>
To: Mark Brown <broonie@kernel.org>,
	Joe Burmeister <joe.burmeister@devtank.co.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit.
Date: Fri, 23 Apr 2021 19:34:14 +0200	[thread overview]
Message-ID: <84cafe48637fd1deed7da2cd15eb2f7679545416.camel@redhat.com> (raw)
In-Reply-To: <20210423162055.GE5507@sirena.org.uk>

On Fri, 2021-04-23 at 17:20 +0100, Mark Brown wrote:
> On Fri, Apr 23, 2021 at 03:12:11PM +0100, Joe Burmeister wrote:
> > Of course we could just raise BCM2835_SPI_NUM_CS to 8 or more if that is
> > preferred. Does seams like the dynamic solution is less favoured.
> 
> The best thing would be to have it not have a single array of chip
> select specific data and instead store everything in the controller_data
> that's there per-device.

+1

All in all, it would make for a cleaner driver.

-- 
Nicolás Sáenz


WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzju@redhat.com>
To: Mark Brown <broonie@kernel.org>,
	Joe Burmeister <joe.burmeister@devtank.co.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	 Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org,
	 linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit.
Date: Fri, 23 Apr 2021 19:34:14 +0200	[thread overview]
Message-ID: <84cafe48637fd1deed7da2cd15eb2f7679545416.camel@redhat.com> (raw)
In-Reply-To: <20210423162055.GE5507@sirena.org.uk>

On Fri, 2021-04-23 at 17:20 +0100, Mark Brown wrote:
> On Fri, Apr 23, 2021 at 03:12:11PM +0100, Joe Burmeister wrote:
> > Of course we could just raise BCM2835_SPI_NUM_CS to 8 or more if that is
> > preferred. Does seams like the dynamic solution is less favoured.
> 
> The best thing would be to have it not have a single array of chip
> select specific data and instead store everything in the controller_data
> that's there per-device.

+1

All in all, it would make for a cleaner driver.

-- 
Nicolás Sáenz


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-23 17:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  8:34 [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go beyond limit Joe Burmeister
2021-04-20  8:34 ` Joe Burmeister
2021-04-22 16:42 ` Mark Brown
2021-04-22 16:42   ` Mark Brown
2021-04-22 16:50 ` Florian Fainelli
2021-04-22 16:50   ` Florian Fainelli
2021-04-22 20:10   ` Joe Burmeister
2021-04-22 20:10     ` Joe Burmeister
2021-04-22 23:49     ` Florian Fainelli
2021-04-22 23:49       ` Florian Fainelli
2021-04-23 10:03       ` Joe Burmeister
2021-04-23 10:03         ` Joe Burmeister
2021-04-23 11:57         ` Mark Brown
2021-04-23 11:57           ` Mark Brown
2021-04-23 14:12           ` Joe Burmeister
2021-04-23 14:12             ` Joe Burmeister
2021-04-23 16:20             ` Mark Brown
2021-04-23 16:20               ` Mark Brown
2021-04-23 17:34               ` Nicolas Saenz Julienne [this message]
2021-04-23 17:34                 ` Nicolas Saenz Julienne
2021-05-01 19:51               ` Lukas Wunner
2021-05-04 11:51                 ` Mark Brown
2021-05-04 11:51                   ` Mark Brown
2021-05-04 13:53                   ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84cafe48637fd1deed7da2cd15eb2f7679545416.camel@redhat.com \
    --to=nsaenzju@redhat.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=broonie@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=joe.burmeister@devtank.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.