All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] phy: samsung: fix missing of_node_put()
@ 2022-04-07  8:59 ` cgel.zte
  0 siblings, 0 replies; 9+ messages in thread
From: cgel.zte @ 2022-04-07  8:59 UTC (permalink / raw)
  To: kishon, vkoul
  Cc: krzysztof.kozlowski, alim.akhtar, lv.ruyi, linux-phy,
	linux-arm-kernel, linux-samsung-soc, linux-kernel, Zeal Robot

From: Lv Ruyi <lv.ruyi@zte.com.cn>

of_parse_phandle returns node pointer with refcount incremented,
use of_node_put() on it when done.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
 drivers/phy/samsung/phy-exynos5250-sata.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/samsung/phy-exynos5250-sata.c b/drivers/phy/samsung/phy-exynos5250-sata.c
index 9ec234243f7c..6c305a3fe187 100644
--- a/drivers/phy/samsung/phy-exynos5250-sata.c
+++ b/drivers/phy/samsung/phy-exynos5250-sata.c
@@ -187,6 +187,7 @@ static int exynos_sata_phy_probe(struct platform_device *pdev)
 		return -EINVAL;
 
 	sata_phy->client = of_find_i2c_device_by_node(node);
+	of_node_put(node);
 	if (!sata_phy->client)
 		return -EPROBE_DEFER;
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] phy: samsung: fix missing of_node_put()
@ 2022-04-07  8:59 ` cgel.zte
  0 siblings, 0 replies; 9+ messages in thread
From: cgel.zte @ 2022-04-07  8:59 UTC (permalink / raw)
  To: kishon, vkoul
  Cc: krzysztof.kozlowski, alim.akhtar, lv.ruyi, linux-phy,
	linux-arm-kernel, linux-samsung-soc, linux-kernel, Zeal Robot

From: Lv Ruyi <lv.ruyi@zte.com.cn>

of_parse_phandle returns node pointer with refcount incremented,
use of_node_put() on it when done.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
 drivers/phy/samsung/phy-exynos5250-sata.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/samsung/phy-exynos5250-sata.c b/drivers/phy/samsung/phy-exynos5250-sata.c
index 9ec234243f7c..6c305a3fe187 100644
--- a/drivers/phy/samsung/phy-exynos5250-sata.c
+++ b/drivers/phy/samsung/phy-exynos5250-sata.c
@@ -187,6 +187,7 @@ static int exynos_sata_phy_probe(struct platform_device *pdev)
 		return -EINVAL;
 
 	sata_phy->client = of_find_i2c_device_by_node(node);
+	of_node_put(node);
 	if (!sata_phy->client)
 		return -EPROBE_DEFER;
 
-- 
2.25.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] phy: samsung: fix missing of_node_put()
@ 2022-04-07  8:59 ` cgel.zte
  0 siblings, 0 replies; 9+ messages in thread
From: cgel.zte @ 2022-04-07  8:59 UTC (permalink / raw)
  To: kishon, vkoul
  Cc: krzysztof.kozlowski, alim.akhtar, lv.ruyi, linux-phy,
	linux-arm-kernel, linux-samsung-soc, linux-kernel, Zeal Robot

From: Lv Ruyi <lv.ruyi@zte.com.cn>

of_parse_phandle returns node pointer with refcount incremented,
use of_node_put() on it when done.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
 drivers/phy/samsung/phy-exynos5250-sata.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/samsung/phy-exynos5250-sata.c b/drivers/phy/samsung/phy-exynos5250-sata.c
index 9ec234243f7c..6c305a3fe187 100644
--- a/drivers/phy/samsung/phy-exynos5250-sata.c
+++ b/drivers/phy/samsung/phy-exynos5250-sata.c
@@ -187,6 +187,7 @@ static int exynos_sata_phy_probe(struct platform_device *pdev)
 		return -EINVAL;
 
 	sata_phy->client = of_find_i2c_device_by_node(node);
+	of_node_put(node);
 	if (!sata_phy->client)
 		return -EPROBE_DEFER;
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] phy: samsung: fix missing of_node_put()
  2022-04-07  8:59 ` cgel.zte
  (?)
@ 2022-04-07  9:14   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07  9:14 UTC (permalink / raw)
  To: cgel.zte, kishon, vkoul
  Cc: alim.akhtar, lv.ruyi, linux-phy, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Zeal Robot

On 07/04/2022 10:59, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
> 
> of_parse_phandle returns node pointer with refcount incremented,
> use of_node_put() on it when done.
> 

Please add fixes tag and rebase on this:
https://lore.kernel.org/all/20220309170028.51913-1-krzysztof.kozlowski@canonical.com/

I'll resend it because it might be forgotten.

> Reported-by: Zeal Robot <zealci@zte.com.cn>

I cannot find this report. This is an open source work and public
collaboration. The “Reported-by” usually means that the issue was
reported. Usually in public. Can we see the report?

> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
>  drivers/phy/samsung/phy-exynos5250-sata.c | 1 +
>  1 file changed, 1 insertion(+)
> 



Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] phy: samsung: fix missing of_node_put()
@ 2022-04-07  9:14   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07  9:14 UTC (permalink / raw)
  To: cgel.zte, kishon, vkoul
  Cc: alim.akhtar, lv.ruyi, linux-phy, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Zeal Robot

On 07/04/2022 10:59, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
> 
> of_parse_phandle returns node pointer with refcount incremented,
> use of_node_put() on it when done.
> 

Please add fixes tag and rebase on this:
https://lore.kernel.org/all/20220309170028.51913-1-krzysztof.kozlowski@canonical.com/

I'll resend it because it might be forgotten.

> Reported-by: Zeal Robot <zealci@zte.com.cn>

I cannot find this report. This is an open source work and public
collaboration. The “Reported-by” usually means that the issue was
reported. Usually in public. Can we see the report?

> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
>  drivers/phy/samsung/phy-exynos5250-sata.c | 1 +
>  1 file changed, 1 insertion(+)
> 



Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] phy: samsung: fix missing of_node_put()
@ 2022-04-07  9:14   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07  9:14 UTC (permalink / raw)
  To: cgel.zte, kishon, vkoul
  Cc: alim.akhtar, lv.ruyi, linux-phy, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Zeal Robot

On 07/04/2022 10:59, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
> 
> of_parse_phandle returns node pointer with refcount incremented,
> use of_node_put() on it when done.
> 

Please add fixes tag and rebase on this:
https://lore.kernel.org/all/20220309170028.51913-1-krzysztof.kozlowski@canonical.com/

I'll resend it because it might be forgotten.

> Reported-by: Zeal Robot <zealci@zte.com.cn>

I cannot find this report. This is an open source work and public
collaboration. The “Reported-by” usually means that the issue was
reported. Usually in public. Can we see the report?

> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
>  drivers/phy/samsung/phy-exynos5250-sata.c | 1 +
>  1 file changed, 1 insertion(+)
> 



Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] phy: samsung: fix missing of_node_put()
  2022-04-07  8:59 ` cgel.zte
  (?)
@ 2022-04-07  9:15   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07  9:15 UTC (permalink / raw)
  To: cgel.zte, kishon, vkoul
  Cc: alim.akhtar, lv.ruyi, linux-phy, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Zeal Robot

On 07/04/2022 10:59, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
> 
> of_parse_phandle returns node pointer with refcount incremented,
> use of_node_put() on it when done.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>

Ah, now I found, that this was already fixed:
https://lore.kernel.org/all/3eed8d0c-e009-2daa-ba66-899fe8f48a90@canonical.com/


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] phy: samsung: fix missing of_node_put()
@ 2022-04-07  9:15   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07  9:15 UTC (permalink / raw)
  To: cgel.zte, kishon, vkoul
  Cc: alim.akhtar, lv.ruyi, linux-phy, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Zeal Robot

On 07/04/2022 10:59, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
> 
> of_parse_phandle returns node pointer with refcount incremented,
> use of_node_put() on it when done.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>

Ah, now I found, that this was already fixed:
https://lore.kernel.org/all/3eed8d0c-e009-2daa-ba66-899fe8f48a90@canonical.com/


Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] phy: samsung: fix missing of_node_put()
@ 2022-04-07  9:15   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07  9:15 UTC (permalink / raw)
  To: cgel.zte, kishon, vkoul
  Cc: alim.akhtar, lv.ruyi, linux-phy, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Zeal Robot

On 07/04/2022 10:59, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
> 
> of_parse_phandle returns node pointer with refcount incremented,
> use of_node_put() on it when done.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>

Ah, now I found, that this was already fixed:
https://lore.kernel.org/all/3eed8d0c-e009-2daa-ba66-899fe8f48a90@canonical.com/


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-04-07  9:36 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07  8:59 [PATCH] phy: samsung: fix missing of_node_put() cgel.zte
2022-04-07  8:59 ` cgel.zte
2022-04-07  8:59 ` cgel.zte
2022-04-07  9:14 ` Krzysztof Kozlowski
2022-04-07  9:14   ` Krzysztof Kozlowski
2022-04-07  9:14   ` Krzysztof Kozlowski
2022-04-07  9:15 ` Krzysztof Kozlowski
2022-04-07  9:15   ` Krzysztof Kozlowski
2022-04-07  9:15   ` Krzysztof Kozlowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.