Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

[Eric Blake <eblake@redhat.com>]

On 11/29/18 11:45 AM, Paolo Bonzini wrote:
> gtester is deprecated by upstream glib and it does not support tests
> that call g_test_skip in some glib stable releases.
> 
> glib suggests instead using Automake's TAP support.  We do not support
> Automake, but we can copy the code that beautifies the TAP output and
> use it.  I chose to use the Perl copy rather than the shell/awk one,
> in order to reuse Perl's TAP parsing package, but I'm open to suggestions
> about which language to use.

Maybe a reference to a URL documenting the glib deprecation would be in 
order? I found https://blog.gtk.org/2018/07/11/news-from-glib-2-58/

> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

> +++ b/scripts/tap-driver.pl
> @@ -0,0 +1,386 @@
> +#! /usr/bin/env perl
> +# Copyright (C) 2011-2013 Free Software Foundation, Inc.

This is not the latest version of automake.git/contrib/tap-driver.pl - 
which Automake version is it from?  Automake moved its perl driver out 
to pasture in 2013, stating that the awk+shell version is preferred in 
new automake projects.  I don't have a strong preference for which one 
you pick, but do worry that if automake adds future enhancements to the 
awk+shell, then the perl version won't keep up and we'll be stuck 
redoing things again in a few years.  On the other hand, TAP doesn't 
seem to be gaining new features at a very fast rate.

> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.

Among other things, the most recent version of tap-driver.pl switched 
all references to https://.

> +
> +# As a special exception to the GNU General Public License, if you
> +# distribute this file as part of a program that contains a
> +# configuration script generated by Autoconf, you may include it under
> +# the same distribution terms that you use for the rest of that program.

We do not use Autoconf, so this exception does not apply to our use of 
this file.  But since our project is GPL, I don't see including this 
file as a problem, nor do I find any problem with leaving the exception 
in place.

> +
> +my $VERSION = '2012-02-01.19'; # UTC

Okay, so this matches the version in automake.git commit 6b819187, which 
was shipped in automake 1.11b.  Six years old, but still does what we 
need, at least for today.

Otherwise, looks good to me, although I'm weak enough with TAP in 
general that this is a fairly weak:
Reviewed-by: Eric Blake <eblake@redhat.com>

(The real test is if all the CI systems are happy with it...)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org