* [linux-nvme:nvme-5.14 2/32] drivers/acpi/x86/utils.c:153:25: sparse: sparse: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?
@ 2021-06-16 3:22 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-06-16 3:22 UTC (permalink / raw)
To: Mario Limonciello; +Cc: kbuild-all, linux-nvme, Christoph Hellwig
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
tree: git://git.infradead.org/nvme.git nvme-5.14
head: 9653e01d9c3c46930da3f007a39a2aaf230bd8ff
commit: 7c20093d34bcaf6bc1e2fbe44cb665eaa07f8964 [2/32] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint
config: i386-randconfig-s001-20210615 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
git remote add linux-nvme git://git.infradead.org/nvme.git
git fetch --no-tags linux-nvme nvme-5.14
git checkout 7c20093d34bcaf6bc1e2fbe44cb665eaa07f8964
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/acpi/x86/utils.c:153:25: sparse: sparse: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42304 bytes --]
[-- Attachment #3: Type: text/plain, Size: 158 bytes --]
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread* [linux-nvme:nvme-5.14 2/32] drivers/acpi/x86/utils.c:153:25: sparse: sparse: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?
@ 2021-06-16 3:22 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-06-16 3:22 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]
tree: git://git.infradead.org/nvme.git nvme-5.14
head: 9653e01d9c3c46930da3f007a39a2aaf230bd8ff
commit: 7c20093d34bcaf6bc1e2fbe44cb665eaa07f8964 [2/32] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint
config: i386-randconfig-s001-20210615 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
git remote add linux-nvme git://git.infradead.org/nvme.git
git fetch --no-tags linux-nvme nvme-5.14
git checkout 7c20093d34bcaf6bc1e2fbe44cb665eaa07f8964
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/acpi/x86/utils.c:153:25: sparse: sparse: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42304 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [RFC PATCH linux-nvme] ACPI: storage_d3_cpu_ids[] can be static
2021-06-16 3:22 ` kernel test robot
@ 2021-06-16 3:22 ` kernel test robot
-1 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-06-16 3:22 UTC (permalink / raw)
To: Mario Limonciello; +Cc: kbuild-all, linux-nvme, Christoph Hellwig
drivers/acpi/x86/utils.c:153:25: warning: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?
Fixes: 7c20093d34bc ("ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
index 5298bb4d81fea..f22f23933063b 100644
--- a/drivers/acpi/x86/utils.c
+++ b/drivers/acpi/x86/utils.c
@@ -150,7 +150,7 @@ bool acpi_device_always_present(struct acpi_device *adev)
*
* This allows quirking on Linux in a similar fashion.
*/
-const struct x86_cpu_id storage_d3_cpu_ids[] = {
+static const struct x86_cpu_id storage_d3_cpu_ids[] = {
X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /* Renoir */
X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL), /* Lucienne */
{}
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RFC PATCH linux-nvme] ACPI: storage_d3_cpu_ids[] can be static
@ 2021-06-16 3:22 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-06-16 3:22 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
drivers/acpi/x86/utils.c:153:25: warning: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?
Fixes: 7c20093d34bc ("ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
index 5298bb4d81fea..f22f23933063b 100644
--- a/drivers/acpi/x86/utils.c
+++ b/drivers/acpi/x86/utils.c
@@ -150,7 +150,7 @@ bool acpi_device_always_present(struct acpi_device *adev)
*
* This allows quirking on Linux in a similar fashion.
*/
-const struct x86_cpu_id storage_d3_cpu_ids[] = {
+static const struct x86_cpu_id storage_d3_cpu_ids[] = {
X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /* Renoir */
X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL), /* Lucienne */
{}
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RFC PATCH linux-nvme] ACPI: storage_d3_cpu_ids[] can be static
2021-06-16 3:22 ` kernel test robot
@ 2021-06-16 15:59 ` Limonciello, Mario
-1 siblings, 0 replies; 6+ messages in thread
From: Limonciello, Mario @ 2021-06-16 15:59 UTC (permalink / raw)
To: kernel test robot; +Cc: kbuild-all, linux-nvme, Christoph Hellwig
On 6/15/2021 22:22, kernel test robot wrote:
> drivers/acpi/x86/utils.c:153:25: warning: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?
>
> Fixes: 7c20093d34bc ("ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> index 5298bb4d81fea..f22f23933063b 100644
> --- a/drivers/acpi/x86/utils.c
> +++ b/drivers/acpi/x86/utils.c
> @@ -150,7 +150,7 @@ bool acpi_device_always_present(struct acpi_device *adev)
> *
> * This allows quirking on Linux in a similar fashion.
> */
> -const struct x86_cpu_id storage_d3_cpu_ids[] = {
> +static const struct x86_cpu_id storage_d3_cpu_ids[] = {
> X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /* Renoir */
> X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL), /* Lucienne */
> {}
>
Acked-By: Mario Limonciello <mario.limonciello@amd.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC PATCH linux-nvme] ACPI: storage_d3_cpu_ids[] can be static
@ 2021-06-16 15:59 ` Limonciello, Mario
0 siblings, 0 replies; 6+ messages in thread
From: Limonciello, Mario @ 2021-06-16 15:59 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
On 6/15/2021 22:22, kernel test robot wrote:
> drivers/acpi/x86/utils.c:153:25: warning: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?
>
> Fixes: 7c20093d34bc ("ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> index 5298bb4d81fea..f22f23933063b 100644
> --- a/drivers/acpi/x86/utils.c
> +++ b/drivers/acpi/x86/utils.c
> @@ -150,7 +150,7 @@ bool acpi_device_always_present(struct acpi_device *adev)
> *
> * This allows quirking on Linux in a similar fashion.
> */
> -const struct x86_cpu_id storage_d3_cpu_ids[] = {
> +static const struct x86_cpu_id storage_d3_cpu_ids[] = {
> X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL), /* Renoir */
> X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL), /* Lucienne */
> {}
>
Acked-By: Mario Limonciello <mario.limonciello@amd.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-16 16:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 3:22 [linux-nvme:nvme-5.14 2/32] drivers/acpi/x86/utils.c:153:25: sparse: sparse: symbol 'storage_d3_cpu_ids' was not declared. Should it be static? kernel test robot
2021-06-16 3:22 ` kernel test robot
2021-06-16 3:22 ` [RFC PATCH linux-nvme] ACPI: storage_d3_cpu_ids[] can be static kernel test robot
2021-06-16 3:22 ` kernel test robot
2021-06-16 15:59 ` Limonciello, Mario
2021-06-16 15:59 ` Limonciello, Mario
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.