[REGRESSION] sc7180-trogdor-lazor image corruption regression for USB-C DP Alt Mode ([PATCH 0/2] Add param for the highest bank bit)

[REGRESSION] sc7180-trogdor-lazor image corruption regression for USB-C DP Alt Mode ([PATCH 0/2] Add param for the highest bank bit)

[Leonard Lausen]

Hi Connor,

unfortunately, your series https://patchwork.freedesktop.org/series/127529/ has introduced a regression for external displays connected through USB-C DP Alt Mode, at least on sc7180-trogdor-lazor devices. Do you think it's possible to  fix this before the 6.8 release or would it be better to revert the series? I'm happy to help testing any fixes. The issue is also tracked at https://gitlab.freedesktop.org/drm/msm/-/issues/49.

Thank you
Leonard

#regzbot introduced: 8814455a0e54ca353b4b0ad5105569d3fdb945cc

On 12/7/23 16:30, Connor Abbott wrote:
> The highest bank bit is a parameter that influences the Adreno tiling
> scheme. It is programmed by the kernel, and is supposed to be based on
> the DRAM configuration. In order for Mesa to tile/until images itself,
> it needs to know this parameter, and because it's programmed by the
> kernel, the kernel should be the source of truth.
> 
> Mesa series: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26578
> 
> Connor Abbott (2):
>   drm/msm: Refactor UBWC config setting
>   drm/msm: Add param for the highest bank bit
> 
>  drivers/gpu/drm/msm/adreno/a5xx_gpu.c   |  21 ++---
>  drivers/gpu/drm/msm/adreno/a6xx_gpu.c   | 101 +++++++++++++-----------
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c |   3 +
>  drivers/gpu/drm/msm/adreno/adreno_gpu.h |   9 +++
>  include/uapi/drm/msm_drm.h              |   1 +
>  5 files changed, 82 insertions(+), 53 deletions(-)
> 

Re: [REGRESSION] sc7180-trogdor-lazor image corruption regression for USB-C DP Alt Mode ([PATCH 0/2] Add param for the highest bank bit)

[Dmitry Baryshkov]

Hi Leonard,

On Sun, 18 Feb 2024 at 03:17, Leonard Lausen <leonard@lausen.nl> wrote:
>
> Hi Connor,
>
> unfortunately, your series https://patchwork.freedesktop.org/series/127529/ has introduced a regression for external displays connected through USB-C DP Alt Mode, at least on sc7180-trogdor-lazor devices. Do you think it's possible to  fix this before the 6.8 release or would it be better to revert the series? I'm happy to help testing any fixes. The issue is also tracked at https://gitlab.freedesktop.org/drm/msm/-/issues/49.

Please check whether this quick fix works for you

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c 
b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index c9c55e2ea584..f097577a99ad 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -1325,6 +1325,11 @@ static void a6xx_calc_ubwc_config(struct 
adreno_gpu *gpu)
  static void a6xx_set_ubwc_config(struct msm_gpu *gpu)
  {
  	struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
+
+	/* a618 is using the hw default values */
+	if (adreno_is_a618(adreno_gpu))
+		return;
+
  	/*
  	 * We subtract 13 from the highest bank bit (13 is the minimum value
  	 * allowed by hw) and write the lowest two bits of the remaining value


-- 
With best wishes
Dmitry

Re: [REGRESSION] sc7180-trogdor-lazor image corruption regression for USB-C DP Alt Mode ([PATCH 0/2] Add param for the highest bank bit)

[Leonard Lausen]

Hi Dmitry,

thank you for sharing a patch. I tested and can confirm it fixes the issue.

Best regards
Leonard

On 2/17/24 23:04, Dmitry Baryshkov wrote:
> Hi Leonard,
> 
> On Sun, 18 Feb 2024 at 03:17, Leonard Lausen <leonard@lausen.nl> wrote:
>>
>> Hi Connor,
>>
>> unfortunately, your series https://patchwork.freedesktop.org/series/127529/ has introduced a regression for external displays connected through USB-C DP Alt Mode, at least on sc7180-trogdor-lazor devices. Do you think it's possible to  fix this before the 6.8 release or would it be better to revert the series? I'm happy to help testing any fixes. The issue is also tracked at https://gitlab.freedesktop.org/drm/msm/-/issues/49.
> 
> Please check whether this quick fix works for you
> 
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> index c9c55e2ea584..f097577a99ad 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> @@ -1325,6 +1325,11 @@ static void a6xx_calc_ubwc_config(struct adreno_gpu *gpu)
>  static void a6xx_set_ubwc_config(struct msm_gpu *gpu)
>  {
>      struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
> +
> +    /* a618 is using the hw default values */
> +    if (adreno_is_a618(adreno_gpu))
> +        return;
> +
>      /*
>       * We subtract 13 from the highest bank bit (13 is the minimum value
>       * allowed by hw) and write the lowest two bits of the remaining value
> 
> 

Re: [REGRESSION] sc7180-trogdor-lazor image corruption regression for USB-C DP Alt Mode ([PATCH 0/2] Add param for the highest bank bit)

[Dmitry Baryshkov]

On Sun, 18 Feb 2024 at 03:17, Leonard Lausen <leonard@lausen.nl> wrote:
>
> Hi Connor,
>
> unfortunately, your series https://patchwork.freedesktop.org/series/127529/ has introduced a regression for external displays connected through USB-C DP Alt Mode, at least on sc7180-trogdor-lazor devices. Do you think it's possible to  fix this before the 6.8 release or would it be better to revert the series? I'm happy to help testing any fixes. The issue is also tracked at https://gitlab.freedesktop.org/drm/msm/-/issues/49.
>
> Thank you
> Leonard
>
> #regzbot introduced: 8814455a0e54ca353b4b0ad5105569d3fdb945cc

#regzbot monitor https://gitlab.freedesktop.org/drm/msm/-/issues/49


-- 
With best wishes
Dmitry

Re: [REGRESSION] sc7180-trogdor-lazor image corruption regression for USB-C DP Alt Mode ([PATCH 0/2] Add param for the highest bank bit)

[Linux regression tracking #update (Thorsten Leemhuis)]

On 18.02.24 14:31, Dmitry Baryshkov wrote:
> On Sun, 18 Feb 2024 at 03:17, Leonard Lausen <leonard@lausen.nl> wrote:
>>
>> Hi Connor,
>>
>> unfortunately, your series https://patchwork.freedesktop.org/series/127529/ has introduced a regression for external displays connected through USB-C DP Alt Mode, at least on sc7180-trogdor-lazor devices. Do you think it's possible to  fix this before the 6.8 release or would it be better to revert the series? I'm happy to help testing any fixes. The issue is also tracked at https://gitlab.freedesktop.org/drm/msm/-/issues/49.
>>
>> Thank you
>> Leonard
>>
>> #regzbot introduced: 8814455a0e54ca353b4b0ad5105569d3fdb945cc
> 
> #regzbot monitor https://gitlab.freedesktop.org/drm/msm/-/issues/49

This is a duplicate, thus handle it as such:

#regzbot duplicate https://gitlab.freedesktop.org/drm/msm/-/issues/49
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.